From 07811f47965cf850bfaba3cafdab47408d31853a Mon Sep 17 00:00:00 2001 From: Matthew Lugg Date: Sat, 5 Sep 2026 15:35:43 +0100 Subject: [PATCH] Elf2: fix crash when creating copy relocation Accidental regression in https://codeberg.org/ziglang/zig/pulls/36413. Not sure how I didn't run into this sooner! --- src/link/Elf2.zig | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/link/Elf2.zig b/src/link/Elf2.zig index 20514f0a4a44d59e5c6e13f947d024a428b55980..5c3a65fea0ddd3c5af50b5fd942109606caaa879 100644 --- a/src/link/Elf2.zig +++ b/src/link/Elf2.zig @@ -8580,10 +8580,13 @@ fn maybeAddCopyRelocation(elf: *Elf, global_name: String(.strtab)) Error!bool { try Section.Index.data.ensureAligned(elf, dso_global.alignment); try elf.nodes.ensureUnusedCapacity(gpa, 1); - const node = try Section.Index.data.get(elf).ni.addFloatingChild(gpa, &elf.mf, .{ - .size = dso_global.alignment.forward(dso_global.size), - .alignment = dso_global.alignment, - }); + const node = elf.addNodeAssumeCapacity( + try Section.Index.data.get(elf).ni.addFloatingChild(gpa, &elf.mf, .{ + .size = dso_global.alignment.forward(dso_global.size), + .alignment = dso_global.alignment, + }), + .{ .copied_global = global_name }, + ); errdefer comptime unreachable; const vaddr = elf.computeNodeVAddr(node); -- 2.54.0