From 19961c50e4db10fc4ada428928a7f5d1a2966da6 Mon Sep 17 00:00:00 2001
From: Andrew Kelley <superjoe30@gmail.com>
Date: Wed, 27 Jun 2018 13:15:55 -0400
Subject: [PATCH] fix comptime @tagName crashing sometimes

closes #1118
---
 src/analyze.cpp         | 1 +
 src/ir.cpp              | 3 +++
 test/cases/eval.zig     | 5 +++++
 test/cases/widening.zig | 9 +++++----
 4 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/src/analyze.cpp b/src/analyze.cpp
index 25cc1c79d0b81087a1f12ea2046edfa05ccaaf20..d5e69de1ebfd8e60ef73be457a26c4e398c2ea48 100644
--- a/src/analyze.cpp
+++ b/src/analyze.cpp
@@ -3728,6 +3728,7 @@ TypeUnionField *find_union_field_by_tag(TypeTableEntry *type_entry, const BigInt
 }
 
 TypeEnumField *find_enum_field_by_tag(TypeTableEntry *enum_type, const BigInt *tag) {
+    assert(enum_type->data.enumeration.zero_bits_known);
     for (uint32_t i = 0; i < enum_type->data.enumeration.src_field_count; i += 1) {
         TypeEnumField *field = &enum_type->data.enumeration.fields[i];
         if (bigint_cmp(&field->value, tag) == CmpEQ) {
diff --git a/src/ir.cpp b/src/ir.cpp
index 6e424980f845dad3ba67d5edc3bb93c73098d3c6..9ba01d141181b1b67e1c93028bba2064105560b4 100644
--- a/src/ir.cpp
+++ b/src/ir.cpp
@@ -16053,6 +16053,9 @@ static TypeTableEntry *ir_analyze_instruction_enum_tag_name(IrAnalyze *ira, IrIn
     assert(target->value.type->id == TypeTableEntryIdEnum);
 
     if (instr_is_comptime(target)) {
+        type_ensure_zero_bits_known(ira->codegen, target->value.type);
+        if (type_is_invalid(target->value.type))
+            return ira->codegen->builtin_types.entry_invalid;
         TypeEnumField *field = find_enum_field_by_tag(target->value.type, &target->value.data.x_bigint);
         ConstExprValue *array_val = create_const_str_lit(ira->codegen, field->name);
         ConstExprValue *out_val = ir_build_const_from(ira, &instruction->base);
diff --git a/test/cases/eval.zig b/test/cases/eval.zig
index 756ffe339adec38db8d4d98cab0aa5c90aaaf716..83d2e801766fe8749d2b2f1e6b19d03adb52af7d 100644
--- a/test/cases/eval.zig
+++ b/test/cases/eval.zig
@@ -637,3 +637,8 @@ test "call method with comptime pass-by-non-copying-value self parameter" {
     var b = s.b();
     assert(b == 2);
 }
+
+test "@tagName of @typeId" {
+    const str = @tagName(@typeId(u8));
+    assert(std.mem.eql(u8, str, "Int"));
+}
diff --git a/test/cases/widening.zig b/test/cases/widening.zig
index 18c12806d34c5168f4f1f9f41e5cd60b4437e495..cf6ab4ca0fb4eeacf06e8d334554b106ff231686 100644
--- a/test/cases/widening.zig
+++ b/test/cases/widening.zig
@@ -19,8 +19,9 @@ test "implicit unsigned integer to signed integer" {
 }
 
 test "float widening" {
-    var a: f32 = 12.34;
-    var b: f64 = a;
-    var c: f128 = b;
-    assert(c == a);
+    var a: f16 = 12.34;
+    var b: f32 = a;
+    var c: f64 = b;
+    var d: f128 = c;
+    assert(d == a);
 }
-- 
2.54.0