authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2023-03-13 23:16:28-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2023-03-15 10:48:15-07:00
log22d94eaf32bc303ff757f442991f570b264b24c3
treef57026e3b13131315475c2144b0c9d863faac7c6
parent2b0929929d67e222ca6a9523a3a594ed456c4a51

disable std lib unit tests that hard code port numbers

See tracking issue #14907

1 files changed, 33 insertions(+), 0 deletions(-)

lib/std/os/linux/io_uring.zig+33
...@@ -1976,6 +1976,11 @@ test "close" {...@@ -1976,6 +1976,11 @@ test "close" {
1976test "accept/connect/send/recv" {1976test "accept/connect/send/recv" {
1977 if (builtin.os.tag != .linux) return error.SkipZigTest;1977 if (builtin.os.tag != .linux) return error.SkipZigTest;
19781978
1979 if (true) {
1980 // https://github.com/ziglang/zig/issues/14907
1981 return error.SkipZigTest;
1982 }
1983
1979 var ring = IO_Uring.init(16, 0) catch |err| switch (err) {1984 var ring = IO_Uring.init(16, 0) catch |err| switch (err) {
1980 error.SystemOutdated => return error.SkipZigTest,1985 error.SystemOutdated => return error.SkipZigTest,
1981 error.PermissionDenied => return error.SkipZigTest,1986 error.PermissionDenied => return error.SkipZigTest,
...@@ -2017,6 +2022,11 @@ test "accept/connect/send/recv" {...@@ -2017,6 +2022,11 @@ test "accept/connect/send/recv" {
2017test "sendmsg/recvmsg" {2022test "sendmsg/recvmsg" {
2018 if (builtin.os.tag != .linux) return error.SkipZigTest;2023 if (builtin.os.tag != .linux) return error.SkipZigTest;
20192024
2025 if (true) {
2026 // https://github.com/ziglang/zig/issues/14907
2027 return error.SkipZigTest;
2028 }
2029
2020 var ring = IO_Uring.init(2, 0) catch |err| switch (err) {2030 var ring = IO_Uring.init(2, 0) catch |err| switch (err) {
2021 error.SystemOutdated => return error.SkipZigTest,2031 error.SystemOutdated => return error.SkipZigTest,
2022 error.PermissionDenied => return error.SkipZigTest,2032 error.PermissionDenied => return error.SkipZigTest,
...@@ -2024,6 +2034,7 @@ test "sendmsg/recvmsg" {...@@ -2024,6 +2034,7 @@ test "sendmsg/recvmsg" {
2024 };2034 };
2025 defer ring.deinit();2035 defer ring.deinit();
20262036
2037 if (true) @compileError("don't hard code port numbers in unit tests"); // https://github.com/ziglang/zig/issues/14907
2027 const address_server = try net.Address.parseIp4("127.0.0.1", 3131);2038 const address_server = try net.Address.parseIp4("127.0.0.1", 3131);
20282039
2029 const server = try os.socket(address_server.any.family, os.SOCK.DGRAM, 0);2040 const server = try os.socket(address_server.any.family, os.SOCK.DGRAM, 0);
...@@ -2223,6 +2234,11 @@ test "timeout_remove" {...@@ -2223,6 +2234,11 @@ test "timeout_remove" {
2223test "accept/connect/recv/link_timeout" {2234test "accept/connect/recv/link_timeout" {
2224 if (builtin.os.tag != .linux) return error.SkipZigTest;2235 if (builtin.os.tag != .linux) return error.SkipZigTest;
22252236
2237 if (true) {
2238 // https://github.com/ziglang/zig/issues/14907
2239 return error.SkipZigTest;
2240 }
2241
2226 var ring = IO_Uring.init(16, 0) catch |err| switch (err) {2242 var ring = IO_Uring.init(16, 0) catch |err| switch (err) {
2227 error.SystemOutdated => return error.SkipZigTest,2243 error.SystemOutdated => return error.SkipZigTest,
2228 error.PermissionDenied => return error.SkipZigTest,2244 error.PermissionDenied => return error.SkipZigTest,
...@@ -2372,6 +2388,11 @@ test "statx" {...@@ -2372,6 +2388,11 @@ test "statx" {
2372test "accept/connect/recv/cancel" {2388test "accept/connect/recv/cancel" {
2373 if (builtin.os.tag != .linux) return error.SkipZigTest;2389 if (builtin.os.tag != .linux) return error.SkipZigTest;
23742390
2391 if (true) {
2392 // https://github.com/ziglang/zig/issues/14907
2393 return error.SkipZigTest;
2394 }
2395
2375 var ring = IO_Uring.init(16, 0) catch |err| switch (err) {2396 var ring = IO_Uring.init(16, 0) catch |err| switch (err) {
2376 error.SystemOutdated => return error.SkipZigTest,2397 error.SystemOutdated => return error.SkipZigTest,
2377 error.PermissionDenied => return error.SkipZigTest,2398 error.PermissionDenied => return error.SkipZigTest,
...@@ -2509,6 +2530,11 @@ test "register_files_update" {...@@ -2509,6 +2530,11 @@ test "register_files_update" {
2509test "shutdown" {2530test "shutdown" {
2510 if (builtin.os.tag != .linux) return error.SkipZigTest;2531 if (builtin.os.tag != .linux) return error.SkipZigTest;
25112532
2533 if (true) {
2534 // https://github.com/ziglang/zig/issues/14907
2535 return error.SkipZigTest;
2536 }
2537
2512 var ring = IO_Uring.init(16, 0) catch |err| switch (err) {2538 var ring = IO_Uring.init(16, 0) catch |err| switch (err) {
2513 error.SystemOutdated => return error.SkipZigTest,2539 error.SystemOutdated => return error.SkipZigTest,
2514 error.PermissionDenied => return error.SkipZigTest,2540 error.PermissionDenied => return error.SkipZigTest,
...@@ -2516,6 +2542,7 @@ test "shutdown" {...@@ -2516,6 +2542,7 @@ test "shutdown" {
2516 };2542 };
2517 defer ring.deinit();2543 defer ring.deinit();
25182544
2545 if (true) @compileError("don't hard code port numbers in unit tests"); // https://github.com/ziglang/zig/issues/14907
2519 const address = try net.Address.parseIp4("127.0.0.1", 3131);2546 const address = try net.Address.parseIp4("127.0.0.1", 3131);
25202547
2521 // Socket bound, expect shutdown to work2548 // Socket bound, expect shutdown to work
...@@ -3060,6 +3087,11 @@ test "remove_buffers" {...@@ -3060,6 +3087,11 @@ test "remove_buffers" {
3060test "provide_buffers: accept/connect/send/recv" {3087test "provide_buffers: accept/connect/send/recv" {
3061 if (builtin.os.tag != .linux) return error.SkipZigTest;3088 if (builtin.os.tag != .linux) return error.SkipZigTest;
30623089
3090 if (true) {
3091 // https://github.com/ziglang/zig/issues/14907
3092 return error.SkipZigTest;
3093 }
3094
3063 var ring = IO_Uring.init(16, 0) catch |err| switch (err) {3095 var ring = IO_Uring.init(16, 0) catch |err| switch (err) {
3064 error.SystemOutdated => return error.SkipZigTest,3096 error.SystemOutdated => return error.SkipZigTest,
3065 error.PermissionDenied => return error.SkipZigTest,3097 error.PermissionDenied => return error.SkipZigTest,
...@@ -3236,6 +3268,7 @@ const SocketTestHarness = struct {...@@ -3236,6 +3268,7 @@ const SocketTestHarness = struct {
3236fn createSocketTestHarness(ring: *IO_Uring) !SocketTestHarness {3268fn createSocketTestHarness(ring: *IO_Uring) !SocketTestHarness {
3237 // Create a TCP server socket3269 // Create a TCP server socket
32383270
3271 if (true) @compileError("don't hard code port numbers in unit tests"); // https://github.com/ziglang/zig/issues/14907
3239 const address = try net.Address.parseIp4("127.0.0.1", 3131);3272 const address = try net.Address.parseIp4("127.0.0.1", 3131);
3240 const kernel_backlog = 1;3273 const kernel_backlog = 1;
3241 const listener_socket = try os.socket(address.any.family, os.SOCK.STREAM | os.SOCK.CLOEXEC, 0);3274 const listener_socket = try os.socket(address.any.family, os.SOCK.STREAM | os.SOCK.CLOEXEC, 0);