diff --git a/src/glibc.zig b/src/glibc.zig index 744e4d1766727d713956976df8851a52ff053c74..ef0acff6adb35eb8c456e6a079b1dae3432a05b5 100644 --- a/src/glibc.zig +++ b/src/glibc.zig @@ -178,7 +178,9 @@ pub const CrtFile = enum { libc_nonshared_a, }; -pub fn buildCrtFile(comp: *Compilation, crt_file: CrtFile, prog_node: std.Progress.Node) !void { +/// TODO replace anyerror with explicit error set, recording user-friendly errors with +/// setMiscFailure and returning error.SubCompilationFailed. see libcxx.zig for example. +pub fn buildCrtFile(comp: *Compilation, crt_file: CrtFile, prog_node: std.Progress.Node) anyerror!void { if (!build_options.have_llvm) { return error.ZigCompilerNotBuiltWithLLVMExtensions; } @@ -735,7 +737,9 @@ fn wordDirective(target: std.Target) []const u8 { return if (target.ptrBitWidth() == 64) ".quad" else ".long"; } -pub fn buildSharedObjects(comp: *Compilation, prog_node: std.Progress.Node) !void { +/// TODO replace anyerror with explicit error set, recording user-friendly errors with +/// setMiscFailure and returning error.SubCompilationFailed. see libcxx.zig for example. +pub fn buildSharedObjects(comp: *Compilation, prog_node: std.Progress.Node) anyerror!void { const tracy = trace(@src()); defer tracy.end(); diff --git a/src/mingw.zig b/src/mingw.zig index 1e20d327701326820c650f88faa2a74b28414d25..eeed1e6f061393b671a5a14f7b15a007ce2662e9 100644 --- a/src/mingw.zig +++ b/src/mingw.zig @@ -17,7 +17,9 @@ pub const CrtFile = enum { mingw32_lib, }; -pub fn buildCrtFile(comp: *Compilation, crt_file: CrtFile, prog_node: std.Progress.Node) !void { +/// TODO replace anyerror with explicit error set, recording user-friendly errors with +/// setMiscFailure and returning error.SubCompilationFailed. see libcxx.zig for example. +pub fn buildCrtFile(comp: *Compilation, crt_file: CrtFile, prog_node: std.Progress.Node) anyerror!void { if (!build_options.have_llvm) { return error.ZigCompilerNotBuiltWithLLVMExtensions; } diff --git a/src/musl.zig b/src/musl.zig index 989fe461f5271c17a8925e34300748165d07a980..e16b5601ab18fd121c8ccfd225abf67c0617b84a 100644 --- a/src/musl.zig +++ b/src/musl.zig @@ -18,7 +18,9 @@ pub const CrtFile = enum { libc_so, }; -pub fn buildCrtFile(comp: *Compilation, in_crt_file: CrtFile, prog_node: std.Progress.Node) !void { +/// TODO replace anyerror with explicit error set, recording user-friendly errors with +/// setMiscFailure and returning error.SubCompilationFailed. see libcxx.zig for example. +pub fn buildCrtFile(comp: *Compilation, in_crt_file: CrtFile, prog_node: std.Progress.Node) anyerror!void { if (!build_options.have_llvm) { return error.ZigCompilerNotBuiltWithLLVMExtensions; } diff --git a/src/wasi_libc.zig b/src/wasi_libc.zig index 34d194a302f9db9954ece0a477a92710317f7c9b..a44a187e8f6f6afc4e9692545eb7596b0f63d52a 100644 --- a/src/wasi_libc.zig +++ b/src/wasi_libc.zig @@ -57,7 +57,9 @@ pub fn execModelCrtFileFullName(wasi_exec_model: std.builtin.WasiExecModel) []co }; } -pub fn buildCrtFile(comp: *Compilation, crt_file: CrtFile, prog_node: std.Progress.Node) !void { +/// TODO replace anyerror with explicit error set, recording user-friendly errors with +/// setMiscFailure and returning error.SubCompilationFailed. see libcxx.zig for example. +pub fn buildCrtFile(comp: *Compilation, crt_file: CrtFile, prog_node: std.Progress.Node) anyerror!void { if (!build_options.have_llvm) { return error.ZigCompilerNotBuiltWithLLVMExtensions; }