Commit 3194a4d22b755393296a4db4c85d7b54ea83e96d | zig

author	Jacob Young <jacobly@ziglang.org> 2025-07-26 07:30:56-04:00
committer	Jacob Young <jacobly@ziglang.org> 2025-07-26 07:44:12-04:00
log	3194a4d22b755393296a4db4c85d7b54ea83e96d
tree	35981c33d9017f610722766e6b573bd8189b1145
parent	68cfa736dfd38cc151af1f9e1b0edb3041bc237c

x86_64: fix dst create alloc reg clobbering src

Closes #24390

1 files changed, 22 insertions(+), 12 deletions(-)

src
- arch
  - x86_64
    CodeGen.zig

src/arch/x86_64/CodeGen.zig+22-12

 @@ -191920,18 +191920,15 @@ const Select = struct {
                 error.InvalidInstruction => {
                     const fixes = @tagName(mir_tag[0]);
                     const fixes_blank = std.mem.indexOfScalar(u8, fixes, '_').?;
-                    return s.cg.fail(
+                    return s.cg.fail("invalid instruction: '{s}{s}{s} {s} {s} {s} {s}'", .{
-                        "invalid instruction: '{s}{s}{s} {s} {s} {s} {s}'",
+                        fixes[0..fixes_blank],
-                        .{
+                        @tagName(mir_tag[1]),
-                            fixes[0..fixes_blank],
+                        fixes[fixes_blank + 1 ..],
-                            @tagName(mir_tag[1]),
+                        @tagName(mir_ops[0]),
-                            fixes[fixes_blank + 1 ..],
+                        @tagName(mir_ops[1]),
-                            @tagName(mir_ops[0]),
+                        @tagName(mir_ops[2]),
-                            @tagName(mir_ops[1]),
+                        @tagName(mir_ops[3]),
-                            @tagName(mir_ops[2]),
+                    });
-                            @tagName(mir_ops[3]),
-                        },
-                    );
                 },
                 else => |e| return e,
             };
 @@ -194423,6 +194420,18 @@ fn select(
             while (true) for (pattern.src[0..src_temps.len], src_temps) |src_pattern, *src_temp| {
                 if (try src_pattern.convert(src_temp, cg)) break;
             } else break;
+            var src_locks: [s_src_temps.len][2]?RegisterLock = @splat(@splat(null));
+            for (src_locks[0..src_temps.len], src_temps) |*locks, src_temp| {
+                const regs: [2]Register = switch (src_temp.tracking(cg).short) {
+                    else => continue,
+                    .register => |reg| .{ reg, .none },
+                    .register_pair => |regs| regs,
+                };
+                for (regs, locks) |reg, *lock| {
+                    if (reg == .none) continue;
+                    lock.* = cg.register_manager.lockRegIndex(RegisterManager.indexOfRegIntoTracked(reg) orelse continue);
+                }
+            }
             @memcpy(s_src_temps[0..src_temps.len], src_temps);
             std.mem.swap(Temp, &s_src_temps[pattern.commute[0]], &s_src_temps[pattern.commute[1]]);
 @@ -194441,6 +194450,7 @@ fn select(
             }
             assert(s.top == 0);
+            for (src_locks) |locks| for (locks) |lock| if (lock) |reg| cg.register_manager.unlockReg(reg);
             for (tmp_locks) |locks| for (locks) |lock| if (lock) |reg| cg.register_manager.unlockReg(reg);
             for (dst_locks) |locks| for (locks) |lock| if (lock) |reg| cg.register_manager.unlockReg(reg);
             caller_preserved: {