Commit 38698f4f6aabb20639642afa58b17f31a43e162b | zig

author	Andrew Kelley <andrew@ziglang.org> 2023-04-10 16:38:24-07:00
committer	Andrew Kelley <andrew@ziglang.org> 2023-04-10 18:35:14-07:00
log	38698f4f6aabb20639642afa58b17f31a43e162b
tree	76d5a9f1c01b7e77cc530a961406d6edb903849f
parent	d2ad3f5074877475c8f0ec0fbbb323a05fe8cf78

std.Build.CompileStep: delete install_step field

This was used to ensure that an artifact would only be installed once,
but this is not only unnecessary, but actively harmful, in the face of
dependencies.

see #15079

2 files changed, 0 insertions(+), 5 deletions(-)

lib
- std
  - Build
    CompileStep.zig
    InstallArtifactStep.zig

lib/std/Build/CompileStep.zig-2

...	...	@@ -111,7 +111,6 @@ vcpkg_bin_path: ?[]const u8 = null,
111	111	/// This may be set in order to override the default install directory
112	112	override_dest_dir: ?InstallDir,
113	113	installed_path: ?[]const u8,
114		install_step: ?*InstallArtifactStep,
115	114
116	115	/// Base address for an executable image.
117	116	image_base: ?u64 = null,
...	...	@@ -390,7 +389,6 @@ pub fn create(owner: std.Build, options: Options) CompileStep {
390	389	.output_dir = null,
391	390	.override_dest_dir = null,
392	391	.installed_path = null,
393		.install_step = null,
394	392	.force_undefined_symbols = StringHashMap(void).init(owner.allocator),
395	393
396	394	.output_path_source = GeneratedFile{ .step = &self.step },

lib/std/Build/InstallArtifactStep.zig-3

...	...	@@ -17,8 +17,6 @@ h_dir: ?InstallDir,
17	17	dest_sub_path: ?[]const u8,
18	18
19	19	pub fn create(owner: std.Build, artifact: CompileStep) *InstallArtifactStep {
20		if (artifact.install_step) \|s\| return s;
21
22	20	const self = owner.allocator.create(InstallArtifactStep) catch @panic("OOM");
23	21	self.* = InstallArtifactStep{
24	22	.step = Step.init(.{
...	...	@@ -44,7 +42,6 @@ pub fn create(owner: std.Build, artifact: CompileStep) *InstallArtifactStep {
44	42	.dest_sub_path = null,
45	43	};
46	44	self.step.dependOn(&artifact.step);
47		artifact.install_step = self;
48	45
49	46	owner.pushInstalledFile(self.dest_dir, artifact.out_filename);
50	47	if (self.artifact.isDynamicLibrary()) {