authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2023-01-25 10:10:50+01:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2023-01-25 10:10:50+01:00
log4983da40d02632217e606098fd8a94bd7732bf0c
treec70fcfe533b5ec55ca60592815afdfb27fd57d4d
parente675af06984d0709d308e3faf60b33cadadf2bbf

self-hosted: remove unused `externally_managed` prong for Decls code

12 files changed, 49 insertions(+), 139 deletions(-)

src/arch/aarch64/CodeGen.zig+9-9
......@@ -24,7 +24,7 @@ const log = std.log.scoped(.codegen);
2424const build_options = @import("build_options");
2525
2626const GenerateSymbolError = codegen.GenerateSymbolError;
27const FnResult = codegen.FnResult;
27const Result = codegen.Result;
2828const DebugInfoOutput = codegen.DebugInfoOutput;
2929
3030const bits = @import("bits.zig");
......@@ -349,7 +349,7 @@ pub fn generate(
349349 liveness: Liveness,
350350 code: *std.ArrayList(u8),
351351 debug_output: DebugInfoOutput,
352) GenerateSymbolError!FnResult {
352) GenerateSymbolError!Result {
353353 if (build_options.skip_non_native and builtin.cpu.arch != bin_file.options.target.cpu.arch) {
354354 @panic("Attempted to compile for architecture that was disabled by build configuration");
355355 }
......@@ -392,8 +392,8 @@ pub fn generate(
392392 defer function.dbg_info_relocs.deinit(bin_file.allocator);
393393
394394 var call_info = function.resolveCallingConventionValues(fn_type) catch |err| switch (err) {
395 error.CodegenFail => return FnResult{ .fail = function.err_msg.? },
396 error.OutOfRegisters => return FnResult{
395 error.CodegenFail => return Result{ .fail = function.err_msg.? },
396 error.OutOfRegisters => return Result{
397397 .fail = try ErrorMsg.create(bin_file.allocator, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
398398 },
399399 else => |e| return e,
......@@ -406,8 +406,8 @@ pub fn generate(
406406 function.max_end_stack = call_info.stack_byte_count;
407407
408408 function.gen() catch |err| switch (err) {
409 error.CodegenFail => return FnResult{ .fail = function.err_msg.? },
410 error.OutOfRegisters => return FnResult{
409 error.CodegenFail => return Result{ .fail = function.err_msg.? },
410 error.OutOfRegisters => return Result{
411411 .fail = try ErrorMsg.create(bin_file.allocator, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
412412 },
413413 else => |e| return e,
......@@ -439,14 +439,14 @@ pub fn generate(
439439 defer emit.deinit();
440440
441441 emit.emitMir() catch |err| switch (err) {
442 error.EmitFail => return FnResult{ .fail = emit.err_msg.? },
442 error.EmitFail => return Result{ .fail = emit.err_msg.? },
443443 else => |e| return e,
444444 };
445445
446446 if (function.err_msg) |em| {
447 return FnResult{ .fail = em };
447 return Result{ .fail = em };
448448 } else {
449 return FnResult{ .appended = {} };
449 return Result{ .appended = {} };
450450 }
451451}
452452
src/arch/arm/CodeGen.zig+9-9
......@@ -23,7 +23,7 @@ const leb128 = std.leb;
2323const log = std.log.scoped(.codegen);
2424const build_options = @import("build_options");
2525
26const FnResult = codegen.FnResult;
26const Result = codegen.Result;
2727const GenerateSymbolError = codegen.GenerateSymbolError;
2828const DebugInfoOutput = codegen.DebugInfoOutput;
2929
......@@ -356,7 +356,7 @@ pub fn generate(
356356 liveness: Liveness,
357357 code: *std.ArrayList(u8),
358358 debug_output: DebugInfoOutput,
359) GenerateSymbolError!FnResult {
359) GenerateSymbolError!Result {
360360 if (build_options.skip_non_native and builtin.cpu.arch != bin_file.options.target.cpu.arch) {
361361 @panic("Attempted to compile for architecture that was disabled by build configuration");
362362 }
......@@ -399,8 +399,8 @@ pub fn generate(
399399 defer function.dbg_info_relocs.deinit(bin_file.allocator);
400400
401401 var call_info = function.resolveCallingConventionValues(fn_type) catch |err| switch (err) {
402 error.CodegenFail => return FnResult{ .fail = function.err_msg.? },
403 error.OutOfRegisters => return FnResult{
402 error.CodegenFail => return Result{ .fail = function.err_msg.? },
403 error.OutOfRegisters => return Result{
404404 .fail = try ErrorMsg.create(bin_file.allocator, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
405405 },
406406 else => |e| return e,
......@@ -413,8 +413,8 @@ pub fn generate(
413413 function.max_end_stack = call_info.stack_byte_count;
414414
415415 function.gen() catch |err| switch (err) {
416 error.CodegenFail => return FnResult{ .fail = function.err_msg.? },
417 error.OutOfRegisters => return FnResult{
416 error.CodegenFail => return Result{ .fail = function.err_msg.? },
417 error.OutOfRegisters => return Result{
418418 .fail = try ErrorMsg.create(bin_file.allocator, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
419419 },
420420 else => |e| return e,
......@@ -446,14 +446,14 @@ pub fn generate(
446446 defer emit.deinit();
447447
448448 emit.emitMir() catch |err| switch (err) {
449 error.EmitFail => return FnResult{ .fail = emit.err_msg.? },
449 error.EmitFail => return Result{ .fail = emit.err_msg.? },
450450 else => |e| return e,
451451 };
452452
453453 if (function.err_msg) |em| {
454 return FnResult{ .fail = em };
454 return Result{ .fail = em };
455455 } else {
456 return FnResult{ .appended = {} };
456 return Result{ .appended = {} };
457457 }
458458}
459459
src/arch/riscv64/CodeGen.zig+9-9
......@@ -22,7 +22,7 @@ const leb128 = std.leb;
2222const log = std.log.scoped(.codegen);
2323const build_options = @import("build_options");
2424
25const FnResult = @import("../../codegen.zig").FnResult;
25const Result = @import("../../codegen.zig").Result;
2626const GenerateSymbolError = @import("../../codegen.zig").GenerateSymbolError;
2727const DebugInfoOutput = @import("../../codegen.zig").DebugInfoOutput;
2828
......@@ -225,7 +225,7 @@ pub fn generate(
225225 liveness: Liveness,
226226 code: *std.ArrayList(u8),
227227 debug_output: DebugInfoOutput,
228) GenerateSymbolError!FnResult {
228) GenerateSymbolError!Result {
229229 if (build_options.skip_non_native and builtin.cpu.arch != bin_file.options.target.cpu.arch) {
230230 @panic("Attempted to compile for architecture that was disabled by build configuration");
231231 }
......@@ -268,8 +268,8 @@ pub fn generate(
268268 defer function.exitlude_jump_relocs.deinit(bin_file.allocator);
269269
270270 var call_info = function.resolveCallingConventionValues(fn_type) catch |err| switch (err) {
271 error.CodegenFail => return FnResult{ .fail = function.err_msg.? },
272 error.OutOfRegisters => return FnResult{
271 error.CodegenFail => return Result{ .fail = function.err_msg.? },
272 error.OutOfRegisters => return Result{
273273 .fail = try ErrorMsg.create(bin_file.allocator, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
274274 },
275275 else => |e| return e,
......@@ -282,8 +282,8 @@ pub fn generate(
282282 function.max_end_stack = call_info.stack_byte_count;
283283
284284 function.gen() catch |err| switch (err) {
285 error.CodegenFail => return FnResult{ .fail = function.err_msg.? },
286 error.OutOfRegisters => return FnResult{
285 error.CodegenFail => return Result{ .fail = function.err_msg.? },
286 error.OutOfRegisters => return Result{
287287 .fail = try ErrorMsg.create(bin_file.allocator, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
288288 },
289289 else => |e| return e,
......@@ -309,14 +309,14 @@ pub fn generate(
309309 defer emit.deinit();
310310
311311 emit.emitMir() catch |err| switch (err) {
312 error.EmitFail => return FnResult{ .fail = emit.err_msg.? },
312 error.EmitFail => return Result{ .fail = emit.err_msg.? },
313313 else => |e| return e,
314314 };
315315
316316 if (function.err_msg) |em| {
317 return FnResult{ .fail = em };
317 return Result{ .fail = em };
318318 } else {
319 return FnResult{ .appended = {} };
319 return Result{ .appended = {} };
320320 }
321321}
322322
src/arch/sparc64/CodeGen.zig+9-9
......@@ -20,7 +20,7 @@ const Emit = @import("Emit.zig");
2020const Liveness = @import("../../Liveness.zig");
2121const Type = @import("../../type.zig").Type;
2222const GenerateSymbolError = @import("../../codegen.zig").GenerateSymbolError;
23const FnResult = @import("../../codegen.zig").FnResult;
23const Result = @import("../../codegen.zig").Result;
2424const DebugInfoOutput = @import("../../codegen.zig").DebugInfoOutput;
2525
2626const build_options = @import("build_options");
......@@ -265,7 +265,7 @@ pub fn generate(
265265 liveness: Liveness,
266266 code: *std.ArrayList(u8),
267267 debug_output: DebugInfoOutput,
268) GenerateSymbolError!FnResult {
268) GenerateSymbolError!Result {
269269 if (build_options.skip_non_native and builtin.cpu.arch != bin_file.options.target.cpu.arch) {
270270 @panic("Attempted to compile for architecture that was disabled by build configuration");
271271 }
......@@ -310,8 +310,8 @@ pub fn generate(
310310 defer function.exitlude_jump_relocs.deinit(bin_file.allocator);
311311
312312 var call_info = function.resolveCallingConventionValues(fn_type, .callee) catch |err| switch (err) {
313 error.CodegenFail => return FnResult{ .fail = function.err_msg.? },
314 error.OutOfRegisters => return FnResult{
313 error.CodegenFail => return Result{ .fail = function.err_msg.? },
314 error.OutOfRegisters => return Result{
315315 .fail = try ErrorMsg.create(bin_file.allocator, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
316316 },
317317 else => |e| return e,
......@@ -324,8 +324,8 @@ pub fn generate(
324324 function.max_end_stack = call_info.stack_byte_count;
325325
326326 function.gen() catch |err| switch (err) {
327 error.CodegenFail => return FnResult{ .fail = function.err_msg.? },
328 error.OutOfRegisters => return FnResult{
327 error.CodegenFail => return Result{ .fail = function.err_msg.? },
328 error.OutOfRegisters => return Result{
329329 .fail = try ErrorMsg.create(bin_file.allocator, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
330330 },
331331 else => |e| return e,
......@@ -351,14 +351,14 @@ pub fn generate(
351351 defer emit.deinit();
352352
353353 emit.emitMir() catch |err| switch (err) {
354 error.EmitFail => return FnResult{ .fail = emit.err_msg.? },
354 error.EmitFail => return Result{ .fail = emit.err_msg.? },
355355 else => |e| return e,
356356 };
357357
358358 if (function.err_msg) |em| {
359 return FnResult{ .fail = em };
359 return Result{ .fail = em };
360360 } else {
361 return FnResult{ .appended = {} };
361 return Result{ .appended = {} };
362362 }
363363}
364364
src/arch/wasm/CodeGen.zig+3-10
......@@ -627,13 +627,6 @@ test "Wasm - buildOpcode" {
627627 try testing.expectEqual(@as(wasm.Opcode, .f64_reinterpret_i64), f64_reinterpret_i64);
628628}
629629
630pub const Result = union(enum) {
631 /// The codegen bytes have been appended to `Context.code`
632 appended: void,
633 /// The data is managed externally and are part of the `Result`
634 externally_managed: []const u8,
635};
636
637630/// Hashmap to store generated `WValue` for each `Air.Inst.Ref`
638631pub const ValueTable = std.AutoArrayHashMapUnmanaged(Air.Inst.Ref, WValue);
639632
......@@ -1171,7 +1164,7 @@ pub fn generate(
11711164 liveness: Liveness,
11721165 code: *std.ArrayList(u8),
11731166 debug_output: codegen.DebugInfoOutput,
1174) codegen.GenerateSymbolError!codegen.FnResult {
1167) codegen.GenerateSymbolError!codegen.Result {
11751168 _ = src_loc;
11761169 var code_gen: CodeGen = .{
11771170 .gpa = bin_file.allocator,
......@@ -1190,11 +1183,11 @@ pub fn generate(
11901183 defer code_gen.deinit();
11911184
11921185 genFunc(&code_gen) catch |err| switch (err) {
1193 error.CodegenFail => return codegen.FnResult{ .fail = code_gen.err_msg },
1186 error.CodegenFail => return codegen.Result{ .fail = code_gen.err_msg },
11941187 else => |e| return e,
11951188 };
11961189
1197 return codegen.FnResult{ .appended = {} };
1190 return codegen.Result{ .appended = {} };
11981191}
11991192
12001193fn genFunc(func: *CodeGen) InnerError!void {
src/arch/x86_64/CodeGen.zig+9-9
......@@ -16,7 +16,7 @@ const Compilation = @import("../../Compilation.zig");
1616const DebugInfoOutput = codegen.DebugInfoOutput;
1717const DW = std.dwarf;
1818const ErrorMsg = Module.ErrorMsg;
19const FnResult = codegen.FnResult;
19const Result = codegen.Result;
2020const GenerateSymbolError = codegen.GenerateSymbolError;
2121const Emit = @import("Emit.zig");
2222const Liveness = @import("../../Liveness.zig");
......@@ -257,7 +257,7 @@ pub fn generate(
257257 liveness: Liveness,
258258 code: *std.ArrayList(u8),
259259 debug_output: DebugInfoOutput,
260) GenerateSymbolError!FnResult {
260) GenerateSymbolError!Result {
261261 if (build_options.skip_non_native and builtin.cpu.arch != bin_file.options.target.cpu.arch) {
262262 @panic("Attempted to compile for architecture that was disabled by build configuration");
263263 }
......@@ -305,8 +305,8 @@ pub fn generate(
305305 defer if (builtin.mode == .Debug) function.mir_to_air_map.deinit();
306306
307307 var call_info = function.resolveCallingConventionValues(fn_type) catch |err| switch (err) {
308 error.CodegenFail => return FnResult{ .fail = function.err_msg.? },
309 error.OutOfRegisters => return FnResult{
308 error.CodegenFail => return Result{ .fail = function.err_msg.? },
309 error.OutOfRegisters => return Result{
310310 .fail = try ErrorMsg.create(bin_file.allocator, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
311311 },
312312 else => |e| return e,
......@@ -319,8 +319,8 @@ pub fn generate(
319319 function.max_end_stack = call_info.stack_byte_count;
320320
321321 function.gen() catch |err| switch (err) {
322 error.CodegenFail => return FnResult{ .fail = function.err_msg.? },
323 error.OutOfRegisters => return FnResult{
322 error.CodegenFail => return Result{ .fail = function.err_msg.? },
323 error.OutOfRegisters => return Result{
324324 .fail = try ErrorMsg.create(bin_file.allocator, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
325325 },
326326 else => |e| return e,
......@@ -345,14 +345,14 @@ pub fn generate(
345345 };
346346 defer emit.deinit();
347347 emit.lowerMir() catch |err| switch (err) {
348 error.EmitFail => return FnResult{ .fail = emit.err_msg.? },
348 error.EmitFail => return Result{ .fail = emit.err_msg.? },
349349 else => |e| return e,
350350 };
351351
352352 if (function.err_msg) |em| {
353 return FnResult{ .fail = em };
353 return Result{ .fail = em };
354354 } else {
355 return FnResult{ .appended = {} };
355 return Result{ .appended = {} };
356356 }
357357}
358358
src/codegen.zig+1-74
......@@ -21,16 +21,9 @@ const TypedValue = @import("TypedValue.zig");
2121const Value = @import("value.zig").Value;
2222const Zir = @import("Zir.zig");
2323
24pub const FnResult = union(enum) {
25 /// The `code` parameter passed to `generateSymbol` has the value appended.
26 appended: void,
27 fail: *ErrorMsg,
28};
2924pub const Result = union(enum) {
3025 /// The `code` parameter passed to `generateSymbol` has the value appended.
3126 appended: void,
32 /// The value is available externally, `code` is unused.
33 externally_managed: []const u8,
3427 fail: *ErrorMsg,
3528};
3629
......@@ -89,7 +82,7 @@ pub fn generateFunction(
8982 liveness: Liveness,
9083 code: *std.ArrayList(u8),
9184 debug_output: DebugInfoOutput,
92) GenerateSymbolError!FnResult {
85) GenerateSymbolError!Result {
9386 switch (bin_file.options.target.cpu.arch) {
9487 .arm,
9588 .armeb,
......@@ -209,9 +202,6 @@ pub fn generateSymbol(
209202 .val = elem_val,
210203 }, code, debug_output, reloc_info)) {
211204 .appended => {},
212 .externally_managed => |slice| {
213 code.appendSliceAssumeCapacity(slice);
214 },
215205 .fail => |em| return Result{ .fail = em },
216206 }
217207 }
......@@ -230,9 +220,6 @@ pub fn generateSymbol(
230220 .val = array,
231221 }, code, debug_output, reloc_info)) {
232222 .appended => {},
233 .externally_managed => |slice| {
234 code.appendSliceAssumeCapacity(slice);
235 },
236223 .fail => |em| return Result{ .fail = em },
237224 }
238225 }
......@@ -243,9 +230,6 @@ pub fn generateSymbol(
243230 .val = sentinel_val,
244231 }, code, debug_output, reloc_info)) {
245232 .appended => {},
246 .externally_managed => |slice| {
247 code.appendSliceAssumeCapacity(slice);
248 },
249233 .fail => |em| return Result{ .fail = em },
250234 }
251235 }
......@@ -260,9 +244,6 @@ pub fn generateSymbol(
260244 .val = sentinel_val,
261245 }, code, debug_output, reloc_info)) {
262246 .appended => {},
263 .externally_managed => |slice| {
264 code.appendSliceAssumeCapacity(slice);
265 },
266247 .fail => |em| return Result{ .fail = em },
267248 }
268249 return Result{ .appended = {} };
......@@ -310,9 +291,6 @@ pub fn generateSymbol(
310291 .val = slice.ptr,
311292 }, code, debug_output, reloc_info)) {
312293 .appended => {},
313 .externally_managed => |external_slice| {
314 code.appendSliceAssumeCapacity(external_slice);
315 },
316294 .fail => |em| return Result{ .fail = em },
317295 }
318296
......@@ -322,9 +300,6 @@ pub fn generateSymbol(
322300 .val = slice.len,
323301 }, code, debug_output, reloc_info)) {
324302 .appended => {},
325 .externally_managed => |external_slice| {
326 code.appendSliceAssumeCapacity(external_slice);
327 },
328303 .fail => |em| return Result{ .fail = em },
329304 }
330305
......@@ -376,9 +351,6 @@ pub fn generateSymbol(
376351 .val = container_ptr,
377352 }, code, debug_output, reloc_info)) {
378353 .appended => {},
379 .externally_managed => |external_slice| {
380 code.appendSliceAssumeCapacity(external_slice);
381 },
382354 .fail => |em| return Result{ .fail = em },
383355 }
384356 return Result{ .appended = {} };
......@@ -552,9 +524,6 @@ pub fn generateSymbol(
552524 .appended => {
553525 mem.copy(u8, code.items[current_pos..], tmp_list.items);
554526 },
555 .externally_managed => |external_slice| {
556 mem.copy(u8, code.items[current_pos..], external_slice);
557 },
558527 .fail => |em| return Result{ .fail = em },
559528 }
560529 } else {
......@@ -577,9 +546,6 @@ pub fn generateSymbol(
577546 .val = field_val,
578547 }, code, debug_output, reloc_info)) {
579548 .appended => {},
580 .externally_managed => |external_slice| {
581 code.appendSliceAssumeCapacity(external_slice);
582 },
583549 .fail => |em| return Result{ .fail = em },
584550 }
585551 const unpadded_field_end = code.items.len - struct_begin;
......@@ -613,9 +579,6 @@ pub fn generateSymbol(
613579 .val = union_obj.tag,
614580 }, code, debug_output, reloc_info)) {
615581 .appended => {},
616 .externally_managed => |external_slice| {
617 code.appendSliceAssumeCapacity(external_slice);
618 },
619582 .fail => |em| return Result{ .fail = em },
620583 }
621584 }
......@@ -633,9 +596,6 @@ pub fn generateSymbol(
633596 .val = union_obj.val,
634597 }, code, debug_output, reloc_info)) {
635598 .appended => {},
636 .externally_managed => |external_slice| {
637 code.appendSliceAssumeCapacity(external_slice);
638 },
639599 .fail => |em| return Result{ .fail = em },
640600 }
641601
......@@ -651,9 +611,6 @@ pub fn generateSymbol(
651611 .val = union_obj.tag,
652612 }, code, debug_output, reloc_info)) {
653613 .appended => {},
654 .externally_managed => |external_slice| {
655 code.appendSliceAssumeCapacity(external_slice);
656 },
657614 .fail => |em| return Result{ .fail = em },
658615 }
659616 }
......@@ -679,9 +636,6 @@ pub fn generateSymbol(
679636 .val = payload.data,
680637 }, code, debug_output, reloc_info)) {
681638 .appended => {},
682 .externally_managed => |external_slice| {
683 code.appendSliceAssumeCapacity(external_slice);
684 },
685639 .fail => |em| return Result{ .fail = em },
686640 }
687641 } else if (!typed_value.val.isNull()) {
......@@ -690,9 +644,6 @@ pub fn generateSymbol(
690644 .val = typed_value.val,
691645 }, code, debug_output, reloc_info)) {
692646 .appended => {},
693 .externally_managed => |external_slice| {
694 code.appendSliceAssumeCapacity(external_slice);
695 },
696647 .fail => |em| return Result{ .fail = em },
697648 }
698649 } else {
......@@ -709,9 +660,6 @@ pub fn generateSymbol(
709660 .val = value,
710661 }, code, debug_output, reloc_info)) {
711662 .appended => {},
712 .externally_managed => |external_slice| {
713 code.appendSliceAssumeCapacity(external_slice);
714 },
715663 .fail => |em| return Result{ .fail = em },
716664 }
717665
......@@ -741,9 +689,6 @@ pub fn generateSymbol(
741689 .val = if (is_payload) Value.initTag(.zero) else typed_value.val,
742690 }, code, debug_output, reloc_info)) {
743691 .appended => {},
744 .externally_managed => |external_slice| {
745 code.appendSliceAssumeCapacity(external_slice);
746 },
747692 .fail => |em| return Result{ .fail = em },
748693 }
749694 }
......@@ -757,9 +702,6 @@ pub fn generateSymbol(
757702 .val = payload_val,
758703 }, code, debug_output, reloc_info)) {
759704 .appended => {},
760 .externally_managed => |external_slice| {
761 code.appendSliceAssumeCapacity(external_slice);
762 },
763705 .fail => |em| return Result{ .fail = em },
764706 }
765707 const unpadded_end = code.items.len - begin;
......@@ -779,9 +721,6 @@ pub fn generateSymbol(
779721 .val = if (is_payload) Value.initTag(.zero) else typed_value.val,
780722 }, code, debug_output, reloc_info)) {
781723 .appended => {},
782 .externally_managed => |external_slice| {
783 code.appendSliceAssumeCapacity(external_slice);
784 },
785724 .fail => |em| return Result{ .fail = em },
786725 }
787726 const unpadded_end = code.items.len - begin;
......@@ -826,9 +765,6 @@ pub fn generateSymbol(
826765 .val = elem_val,
827766 }, code, debug_output, reloc_info)) {
828767 .appended => {},
829 .externally_managed => |slice| {
830 code.appendSliceAssumeCapacity(slice);
831 },
832768 .fail => |em| return Result{ .fail = em },
833769 }
834770 }
......@@ -846,9 +782,6 @@ pub fn generateSymbol(
846782 .val = array,
847783 }, code, debug_output, reloc_info)) {
848784 .appended => {},
849 .externally_managed => |slice| {
850 code.appendSliceAssumeCapacity(slice);
851 },
852785 .fail => |em| return Result{ .fail = em },
853786 }
854787 }
......@@ -902,9 +835,6 @@ fn lowerDeclRef(
902835 .val = typed_value.val,
903836 }, code, debug_output, reloc_info)) {
904837 .appended => {},
905 .externally_managed => |external_slice| {
906 code.appendSliceAssumeCapacity(external_slice);
907 },
908838 .fail => |em| return Result{ .fail = em },
909839 }
910840
......@@ -918,9 +848,6 @@ fn lowerDeclRef(
918848 .val = Value.initPayload(&slice_len.base),
919849 }, code, debug_output, reloc_info)) {
920850 .appended => {},
921 .externally_managed => |external_slice| {
922 code.appendSliceAssumeCapacity(external_slice);
923 },
924851 .fail => |em| return Result{ .fail = em },
925852 }
926853
src/link/Coff.zig-2
......@@ -981,7 +981,6 @@ pub fn lowerUnnamedConst(self: *Coff, tv: TypedValue, decl_index: Module.Decl.In
981981 .parent_atom_index = atom.sym_index,
982982 });
983983 const code = switch (res) {
984 .externally_managed => |x| x,
985984 .appended => code_buffer.items,
986985 .fail => |em| {
987986 decl.analysis = .codegen_failure;
......@@ -1042,7 +1041,6 @@ pub fn updateDecl(self: *Coff, module: *Module, decl_index: Module.Decl.Index) !
10421041 .parent_atom_index = decl.link.coff.sym_index,
10431042 });
10441043 const code = switch (res) {
1045 .externally_managed => |x| x,
10461044 .appended => code_buffer.items,
10471045 .fail => |em| {
10481046 decl.analysis = .codegen_failure;
src/link/Elf.zig-2
......@@ -2553,7 +2553,6 @@ pub fn updateDecl(self: *Elf, module: *Module, decl_index: Module.Decl.Index) !v
25532553 });
25542554
25552555 const code = switch (res) {
2556 .externally_managed => |x| x,
25572556 .appended => code_buffer.items,
25582557 .fail => |em| {
25592558 decl.analysis = .codegen_failure;
......@@ -2618,7 +2617,6 @@ pub fn lowerUnnamedConst(self: *Elf, typed_value: TypedValue, decl_index: Module
26182617 .parent_atom_index = atom.local_sym_index,
26192618 });
26202619 const code = switch (res) {
2621 .externally_managed => |x| x,
26222620 .appended => code_buffer.items,
26232621 .fail => |em| {
26242622 decl.analysis = .codegen_failure;
src/link/MachO.zig-2
......@@ -2082,7 +2082,6 @@ pub fn lowerUnnamedConst(self: *MachO, typed_value: TypedValue, decl_index: Modu
20822082 .parent_atom_index = atom.sym_index,
20832083 });
20842084 const code = switch (res) {
2085 .externally_managed => |x| x,
20862085 .appended => code_buffer.items,
20872086 .fail => |em| {
20882087 decl.analysis = .codegen_failure;
......@@ -2167,7 +2166,6 @@ pub fn updateDecl(self: *MachO, module: *Module, decl_index: Module.Decl.Index)
21672166 });
21682167
21692168 const code = switch (res) {
2170 .externally_managed => |x| x,
21712169 .appended => code_buffer.items,
21722170 .fail => |em| {
21732171 decl.analysis = .codegen_failure;
src/link/Plan9.zig-2
......@@ -358,7 +358,6 @@ pub fn lowerUnnamedConst(self: *Plan9, tv: TypedValue, decl_index: Module.Decl.I
358358 .parent_atom_index = @enumToInt(decl_index),
359359 });
360360 const code = switch (res) {
361 .externally_managed => |x| x,
362361 .appended => code_buffer.items,
363362 .fail => |em| {
364363 decl.analysis = .codegen_failure;
......@@ -403,7 +402,6 @@ pub fn updateDecl(self: *Plan9, module: *Module, decl_index: Module.Decl.Index)
403402 .parent_atom_index = @enumToInt(decl_index),
404403 });
405404 const code = switch (res) {
406 .externally_managed => |x| x,
407405 .appended => code_buffer.items,
408406 .fail => |em| {
409407 decl.analysis = .codegen_failure;
src/link/Wasm.zig-2
......@@ -1113,7 +1113,6 @@ pub fn updateDecl(wasm: *Wasm, mod: *Module, decl_index: Module.Decl.Index) !voi
11131113 );
11141114
11151115 const code = switch (res) {
1116 .externally_managed => |x| x,
11171116 .appended => code_writer.items,
11181117 .fail => |em| {
11191118 decl.analysis = .codegen_failure;
......@@ -1250,7 +1249,6 @@ pub fn lowerUnnamedConst(wasm: *Wasm, tv: TypedValue, decl_index: Module.Decl.In
12501249 },
12511250 );
12521251 const code = switch (result) {
1253 .externally_managed => |x| x,
12541252 .appended => value_bytes.items,
12551253 .fail => |em| {
12561254 decl.analysis = .codegen_failure;