Commit 51a8f52e6cdd53321572830efe3ac75cb09b5a09 | zig

author	Cody Tapscott <topolarity@tapscott.me> 2022-07-08 17:29:32-07:00
committer	Cody Tapscott <topolarity@tapscott.me> 2022-07-08 19:51:35-07:00
log	51a8f52e6cdd53321572830efe3ac75cb09b5a09
tree	0b263b2bc46765c0c17aa4d06e30e1c7007c6176
parent	2fff25fd220632cc6943680d3d6bbb1f21fa141f

stage2: Support `@offsetOf` for tuples and anon structs

3 files changed, 23 insertions(+), 39 deletions(-)

src
- Sema.zig
test
- behavior
  - tuple.zig
- cases
  - compile_errors
    offsetOf-bad_field_name.zig

src/Sema.zig+22-32

 @@ -15872,50 +15872,40 @@ fn bitOffsetOf(sema: *Sema, block: *Block, inst: Zir.Inst.Index) CompileError!u6
     const target = sema.mod.getTarget();
     try sema.resolveTypeLayout(block, lhs_src, ty);
-    if (ty.tag() != .@"struct") {
+    switch (ty.tag()) {
-        const msg = msg: {
+        .@"struct", .tuple, .anon_struct => {},
-            const msg = try sema.errMsg(block, lhs_src, "expected struct type, found '{}'", .{ty.fmt(sema.mod)});
+        else => {
-            errdefer msg.destroy(sema.gpa);
+            const msg = msg: {
-            try sema.addDeclaredHereNote(msg, ty);
+                const msg = try sema.errMsg(block, lhs_src, "expected struct type, found '{}'", .{ty.fmt(sema.mod)});
-            break :msg msg;
+                errdefer msg.destroy(sema.gpa);
-        };
+                try sema.addDeclaredHereNote(msg, ty);
-        return sema.failWithOwnedErrorMsg(block, msg);
+                break :msg msg;
+            };
+            return sema.failWithOwnedErrorMsg(block, msg);
+        },
     }
-    const fields = ty.structFields();
+    const field_index = if (ty.isTuple()) b: {
-    const index = fields.getIndex(field_name) orelse {
+        if (std.fmt.parseUnsigned(u32, field_name, 10)) |idx| {
-        const msg = msg: {
+            if (idx < ty.structFieldCount()) break :b idx;
-            const msg = try sema.errMsg(
+        } else |_| {}
-                block,
+        return sema.fail(block, rhs_src, "tuple '{}' has no such field '{s}'", .{
-                rhs_src,
+            ty.fmt(sema.mod), field_name,
-                "struct '{}' has no field '{s}'",
+        });
-                .{ ty.fmt(sema.mod), field_name },
+    } else try sema.structFieldIndex(block, ty, field_name, rhs_src);
-            );
-            errdefer msg.destroy(sema.gpa);
-            try sema.addDeclaredHereNote(msg, ty);
-            break :msg msg;
-        };
-        return sema.failWithOwnedErrorMsg(block, msg);
-    };
     switch (ty.containerLayout()) {
         .Packed => {
             var bit_sum: u64 = 0;
+            const fields = ty.structFields();
             for (fields.values()) |field, i| {
-                if (i == index) {
+                if (i == field_index) {
                     return bit_sum;
                 }
                 bit_sum += field.ty.bitSize(target);
             } else unreachable;
         },
-        else => {
+        else => return ty.structFieldOffset(field_index, target) * 8,
-            var it = ty.iterateStructOffsets(target);
-            while (it.next()) |field_offset| {
-                if (field_offset.field == index) {
-                    return field_offset.offset * 8;
-                }
-            } else unreachable;
-        },
     }
 }

test/behavior/tuple.zig-6

 @@ -221,20 +221,14 @@ test "fieldParentPtr of anon struct" {
 }
 test "offsetOf tuple" {
-    if (builtin.zig_backend != .stage1) return error.SkipZigTest;
     var x: u32 = 0;
     const T = @TypeOf(.{ x, x });
     _ = @offsetOf(T, "1");
 }
 test "offsetOf anon struct" {
-    if (builtin.zig_backend != .stage1) return error.SkipZigTest;
     var x: u32 = 0;
     const T = @TypeOf(.{ .foo = x, .bar = x });
     _ = @offsetOf(T, "bar");
 }

test/cases/compile_errors/offsetOf-bad_field_name.zig+1-1

...	@@ -9,5 +9,5 @@ export fn foo() usize {	...	@@ -9,5 +9,5 @@ export fn foo() usize {
9	// backend=stage2	9	// backend=stage2
10	// target=native	10	// target=native
11	//	11	//
12	// :5:27: error: struct 'tmp.Foo' has no field 'a'	12	// :5:27: error: no field named 'a' in struct 'tmp.Foo'
13	// :1:13: note: struct declared here	13	// :1:13: note: struct declared here