authorgravatar for michael.dusan@gmail.comMichael Dusan <michael.dusan@gmail.com> 2019-04-24 10:56:16-04:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2019-04-24 14:37:14-04:00
log5de934810fda80dcf141fce57331ef9291a45abc
tree40912e4b476607f430a5a1f79d5ace32ca38c929
parented419555229a6d93eb7b08950620f86641f44d92

add -fvisibility-inlines-hidden

On macOS building with Xcode/clang the linker complains loudly when symbol visibility is inconsistent. This option syncs visibilty setting of both LLVM and Zig.

1 files changed, 2 insertions(+), 2 deletions(-)

CMakeLists.txt+2-2
...@@ -192,7 +192,7 @@ else()...@@ -192,7 +192,7 @@ else()
192 if(MSVC)192 if(MSVC)
193 set(ZIG_LLD_COMPILE_FLAGS "-std=c++11 -D_CRT_SECURE_NO_WARNINGS /w")193 set(ZIG_LLD_COMPILE_FLAGS "-std=c++11 -D_CRT_SECURE_NO_WARNINGS /w")
194 else()194 else()
195 set(ZIG_LLD_COMPILE_FLAGS "-std=c++11 -fno-exceptions -fno-rtti -Wno-comment")195 set(ZIG_LLD_COMPILE_FLAGS "-std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wno-comment")
196 if(MINGW)196 if(MINGW)
197 set(ZIG_LLD_COMPILE_FLAGS "${ZIG_LLD_COMPILE_FLAGS} -D__STDC_FORMAT_MACROS -D__USE_MINGW_ANSI_STDIO -Wno-pedantic-ms-format")197 set(ZIG_LLD_COMPILE_FLAGS "${ZIG_LLD_COMPILE_FLAGS} -D__STDC_FORMAT_MACROS -D__USE_MINGW_ANSI_STDIO -Wno-pedantic-ms-format")
198 endif()198 endif()
...@@ -6609,7 +6609,7 @@ endif()...@@ -6609,7 +6609,7 @@ endif()
6609if(MSVC)6609if(MSVC)
6610 set(EXE_CFLAGS "${EXE_CFLAGS}")6610 set(EXE_CFLAGS "${EXE_CFLAGS}")
6611else()6611else()
6612 set(EXE_CFLAGS "${EXE_CFLAGS} -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D_GNU_SOURCE -fno-exceptions -fno-rtti -Werror=strict-prototypes -Werror=old-style-definition -Werror=type-limits -Wno-missing-braces")6612 set(EXE_CFLAGS "${EXE_CFLAGS} -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D_GNU_SOURCE -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Werror=strict-prototypes -Werror=old-style-definition -Werror=type-limits -Wno-missing-braces")
6613 if(MINGW)6613 if(MINGW)
6614 set(EXE_CFLAGS "${EXE_CFLAGS} -D__USE_MINGW_ANSI_STDIO -Wno-pedantic-ms-format")6614 set(EXE_CFLAGS "${EXE_CFLAGS} -D__USE_MINGW_ANSI_STDIO -Wno-pedantic-ms-format")
6615 endif()6615 endif()