authorgravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2023-11-04 04:58:42-04:00
committergravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2023-11-04 08:13:13-04:00
log6553359f398ccc3be10a4975d99cb325a5b7c1fd
treefac80e7f0a7684fb5cf1e1cf2b72417595b5c001
parent7b1a644d6ee50740196328bd8f7b1a46ac46b4d2

x86_64: fix ub that the llvm backend was hiding


1 files changed, 3 insertions(+), 9 deletions(-)

src/arch/x86_64/Encoding.zig+3-9
......@@ -62,8 +62,7 @@ pub fn findByMnemonic(
6262 .rex, .rex_short => if (!rex_required) continue,
6363 else => {},
6464 }
65 for (input_ops, data.ops) |input_op, data_op|
66 if (!input_op.isSubset(data_op)) continue :next;
65 for (input_ops, data.ops) |input_op, data_op| if (!input_op.isSubset(data_op)) continue :next;
6766
6867 const enc = Encoding{ .mnemonic = mnemonic, .data = data };
6968 if (shortest_enc) |previous_shortest_enc| {
......@@ -828,18 +827,13 @@ const mnemonic_to_encodings_map = init: {
828827 for (&data_storage, entries, 0..) |*data, entry, data_index| {
829828 data.* = .{
830829 .op_en = entry[1],
831 .ops = undefined,
830 .ops = (entry[2] ++ .{.none} ** (data.ops.len - entry[2].len)).*,
832831 .opc_len = entry[3].len,
833 .opc = undefined,
832 .opc = (entry[3] ++ .{undefined} ** (data.opc.len - entry[3].len)).*,
834833 .modrm_ext = entry[4],
835834 .mode = entry[5],
836835 .feature = entry[6],
837836 };
838 // TODO: use `@memcpy` for these. When I did that, I got a false positive
839 // compile error for this copy happening at compile time.
840 std.mem.copyForwards(Op, &data.ops, entry[2]);
841 std.mem.copyForwards(u8, &data.opc, entry[3]);
842
843837 while (mnemonic_int < @intFromEnum(entry[0])) : (mnemonic_int += 1) {
844838 mnemonic_map[mnemonic_int] = data_storage[mnemonic_start..data_index];
845839 mnemonic_start = data_index;