Commit 65924d31e4ed3234303d6c6ca72cf30cda0cbaa3 | zig

author	Ryan Liptak <squeek502@hotmail.com> 2026-07-30 18:45:58-07:00
committer	Alex Rønne Petersen <alex@alexrp.com> 2026-10-22 12:21:43+02:00
log	65924d31e4ed3234303d6c6ca72cf30cda0cbaa3
tree	f23aa313ea7f64d02cae0d7988a6dc3e510a4841
parent	a25a20160258b9936ff402e5da404420004fecff

Fix precedence upgrade when two lower prec operators surround a higher one

For example, `a | b << c | d` gives two errors: one for `a | b << c` which would have been evaluated as `a | (b << c)` in 0.16.x and one for `b << c | d` which would have been evaluated as `(b << c) | d` in 0.16.x. This would have caused the `<<` to be the operator token for a hint_operator_precedence_right and a hint_operator_precedence_left note, which the fmt implementation could not handle.

1 files changed, 10 insertions(+), 3 deletions(-)

src
- fmt.zig

src/fmt.zig+10-3

 @@ -400,14 +400,21 @@ fn fmtPathFile(
         defer operators_to_fix.deinit(gpa);
         // Gather ambiguous operator precedence error tokens for quick lookup later
+        var remaining_errors: usize = tree.errors.len;
         for (tree.errors) |err| {
             switch (err.tag) {
                 .hint_operator_precedence_left => {
-                    try operators_to_fix.putNoClobber(gpa, err.token - @as(u32, @intCast(err.extra.offset)), {});
+                    try operators_to_fix.put(gpa, err.token - @as(u32, @intCast(err.extra.offset)), {});
+                    remaining_errors -= 1;
                 },
                 .hint_operator_precedence_right => {
-                    try operators_to_fix.putNoClobber(gpa, err.token, {});
+                    try operators_to_fix.put(gpa, err.token, {});
+                    remaining_errors -= 1;
                 },
+                .ambiguous_operator_precedence,
+                .illegal_chained_operators,
+                .previous_ambiguous_operator,
+                => remaining_errors -= 1,
                 else => continue,
             }
         }
 @@ -415,7 +422,7 @@ fn fmtPathFile(
         if (operators_to_fix.count() == 0) break :fix;
         // Build a new error list without the ambiguous operator precedence errors/notes
-        var fixed_errors: std.ArrayList(std.zig.Ast.Error) = try .initCapacity(gpa, tree.errors.len - (operators_to_fix.count() * 3));
+        var fixed_errors: std.ArrayList(std.zig.Ast.Error) = try .initCapacity(gpa, remaining_errors);
         for (tree.errors) |err| {
             switch (err.tag) {
                 .ambiguous_operator_precedence,