From 66cd872dff0ac0cb4b960d703af1db3f43354091 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?= Date: Tue, 4 Aug 2026 10:17:43 +0200 Subject: [PATCH] Revert "llvm: work around upstream aarch64-windows bug for private thread_local symbols" This reverts commit b3747dd707eeaf06e0bacbde259bf71ef525a961. closes https://codeberg.org/ziglang/zig/issues/31865 --- src/codegen/llvm.zig | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/codegen/llvm.zig b/src/codegen/llvm.zig index 3306734ec53e9742d3ed051c2c685c9d5f51c154..2b2edd07e9551815ced40e2287be6b91c3806f13 100644 --- a/src/codegen/llvm.zig +++ b/src/codegen/llvm.zig @@ -1000,11 +1000,6 @@ pub const Object = struct { try o.flushTypePool(pt); } - fn workaroundPrivateSymbolBugs(target: *const std.Target, resolved: *const InternPool.Nav.Resolved) bool { - // https://codeberg.org/ziglang/zig/issues/31865 - return target.cpu.arch.isAARCH64() and target.ofmt == .coff and resolved.@"threadlocal"; - } - pub fn updateNav(o: *Object, pt: Zcu.PerThread, nav_id: InternPool.Nav.Index) !void { const zcu = o.zcu; const ip = &zcu.intern_pool; @@ -1082,7 +1077,7 @@ pub const Object = struct { }; llvm_global.ptr(&o.builder).visibility = .fromSymbolVisibility(@"extern".visibility); } else { - llvm_global.ptr(&o.builder).linkage = if (o.builder.strip and !workaroundPrivateSymbolBugs(zcu.getTarget(), &resolved)) .private else .internal; + llvm_global.ptr(&o.builder).linkage = if (o.builder.strip) .private else .internal; llvm_global.ptr(&o.builder).visibility = .default; llvm_global.ptr(&o.builder).dll_storage_class = .default; llvm_global.ptr(&o.builder).unnamed_addr = .unnamed_addr; -- 2.54.0