Commit 8199428beb1be2c59fc1da535372f5f7170f72b7 | zig

author	Andrew Kelley <andrew@ziglang.org> 2023-07-23 14:02:58-07:00
committer	Andrew Kelley <andrew@ziglang.org> 2023-07-23 19:16:33-07:00
log	8199428beb1be2c59fc1da535372f5f7170f72b7
tree	0dd67795b4b18cc6d856657e8d294cdf31589715
parent	c57749f5cefd26d79d97a5a00ec07ab1a7b70505

Compilation: fix autodocs CLI

6e4fff6ba62ae3e61a948c98fa8fea7e35732cc0 regressed the direct CLI
interface of -femit-docs.

This commit fixes it and also hooks up to the progress bar.

1 files changed, 27 insertions(+), 10 deletions(-)

src
- Compilation.zig

src/Compilation.zig+27-10

 @@ -2153,16 +2153,9 @@ pub fn update(comp: *Compilation, main_progress_node: *std.Progress.Node) !void
             try comp.flush(main_progress_node);
             if (comp.totalErrorCount() != 0) return;
-            // TODO: do this in a separate job during performAllTheWork(). The
+            // Note the placement of this logic is relying on the call to
-            // file copies at the end of generate() can also be extracted to
+            // `wholeCacheModeSetBinFilePath` above.
-            // separate jobs
+            try maybeGenerateAutodocs(comp, main_progress_node);
-            if (!build_options.only_c and !build_options.only_core_functionality) {
-                if (comp.bin_file.options.docs_emit) |emit| {
-                    var dir = try emit.directory.handle.makeOpenPath(emit.sub_path, .{});
-                    defer dir.close();
-                    try Autodoc.generate(module, dir);
-                }
-            }
         } else {
             try comp.flush(main_progress_node);
             if (comp.totalErrorCount() != 0) return;
 @@ -2177,6 +2170,10 @@ pub fn update(comp: *Compilation, main_progress_node: *std.Progress.Node) !void
         comp.bin_file.lock = man.toOwnedLock();
     } else {
         try comp.flush(main_progress_node);
+        if (comp.totalErrorCount() == 0) {
+            try maybeGenerateAutodocs(comp, main_progress_node);
+        }
     }
     // Unload all source files to save memory.
 @@ -2193,6 +2190,26 @@ pub fn update(comp: *Compilation, main_progress_node: *std.Progress.Node) !void
     }
 }
+fn maybeGenerateAutodocs(comp: *Compilation, prog_node: *std.Progress.Node) !void {
+    const mod = comp.bin_file.options.module orelse return;
+    // TODO: do this in a separate job during performAllTheWork(). The
+    // file copies at the end of generate() can also be extracted to
+    // separate jobs
+    if (!build_options.only_c and !build_options.only_core_functionality) {
+        if (comp.bin_file.options.docs_emit) |emit| {
+            var dir = try emit.directory.handle.makeOpenPath(emit.sub_path, .{});
+            defer dir.close();
+            var sub_prog_node = prog_node.start("Generating documentation", 0);
+            sub_prog_node.activate();
+            sub_prog_node.context.refresh();
+            defer sub_prog_node.end();
+            try Autodoc.generate(mod, dir);
+        }
+    }
+}
 fn flush(comp: *Compilation, prog_node: *std.Progress.Node) !void {
     // This is needed before reading the error flags.
     comp.bin_file.flush(comp, prog_node) catch |err| switch (err) {