authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2023-04-18 06:24:16+02:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2023-04-18 06:24:16+02:00
log8ba937c787efd690a8a984f9ab42cac00fb9b2bf
tree4a84c3da1cac4640565ae1985f8f07fb1431876e
parent40e1fca34b2c0d2cde130fd17331a2935c473644
parent13503b7cba2c826633017e34e8bda2bf5072e7f6
signaturebadge-question-mark Signed by PGP key 4AEE18F83AFDEB23

Merge pull request #15339 from ziglang/link-and-x86_64-cleanups

Misc cleanups

3 files changed, 65 insertions(+), 19 deletions(-)

src/arch/x86_64/CodeGen.zig+1-3
......@@ -439,9 +439,7 @@ fn dumpWipMir(self: *Self, inst: Mir.Inst) !void {
439439 },
440440 else => |e| return e,
441441 }) |lower_inst| {
442 try stderr.writeAll(" | ");
443 try lower_inst.fmtPrint(stderr);
444 try stderr.writeByte('\n');
442 try stderr.print(" | {}\n", .{lower_inst});
445443 }
446444}
447445
src/arch/x86_64/encoder.zig+44-3
......@@ -54,7 +54,34 @@ pub const Instruction = struct {
5454 };
5555 }
5656
57 pub fn fmtPrint(op: Operand, enc_op: Encoding.Op, writer: anytype) @TypeOf(writer).Error!void {
57 fn format(
58 op: Operand,
59 comptime unused_format_string: []const u8,
60 options: std.fmt.FormatOptions,
61 writer: anytype,
62 ) !void {
63 _ = op;
64 _ = unused_format_string;
65 _ = options;
66 _ = writer;
67 @compileError("do not format Operand directly; use fmtPrint() instead");
68 }
69
70 const FormatContext = struct {
71 op: Operand,
72 enc_op: Encoding.Op,
73 };
74
75 fn fmt(
76 ctx: FormatContext,
77 comptime unused_format_string: []const u8,
78 options: std.fmt.FormatOptions,
79 writer: anytype,
80 ) @TypeOf(writer).Error!void {
81 _ = unused_format_string;
82 _ = options;
83 const op = ctx.op;
84 const enc_op = ctx.enc_op;
5885 switch (op) {
5986 .none => {},
6087 .reg => |reg| try writer.writeAll(@tagName(reg)),
......@@ -105,6 +132,13 @@ pub const Instruction = struct {
105132 .imm => |imm| try writer.print("0x{x}", .{imm.asUnsigned(enc_op.bitSize())}),
106133 }
107134 }
135
136 pub fn fmtPrint(op: Operand, enc_op: Encoding.Op) std.fmt.Formatter(fmt) {
137 return .{ .data = .{
138 .op = op,
139 .enc_op = enc_op,
140 } };
141 }
108142 };
109143
110144 pub fn new(prefix: Prefix, mnemonic: Mnemonic, ops: []const Operand) !Instruction {
......@@ -130,14 +164,21 @@ pub const Instruction = struct {
130164 return inst;
131165 }
132166
133 pub fn fmtPrint(inst: Instruction, writer: anytype) @TypeOf(writer).Error!void {
167 pub fn format(
168 inst: Instruction,
169 comptime unused_format_string: []const u8,
170 options: std.fmt.FormatOptions,
171 writer: anytype,
172 ) @TypeOf(writer).Error!void {
173 _ = unused_format_string;
174 _ = options;
134175 if (inst.prefix != .none) try writer.print("{s} ", .{@tagName(inst.prefix)});
135176 try writer.print("{s}", .{@tagName(inst.encoding.mnemonic)});
136177 for (inst.ops, inst.encoding.data.ops, 0..) |op, enc, i| {
137178 if (op == .none) break;
138179 if (i > 0) try writer.writeByte(',');
139180 try writer.writeByte(' ');
140 try op.fmtPrint(enc, writer);
181 try writer.print("{}", .{op.fmtPrint(enc)});
141182 }
142183 }
143184
src/link/tapi/parse.zig+20-13
......@@ -40,10 +40,26 @@ pub const Node = struct {
4040
4141 pub fn deinit(self: *Node, allocator: Allocator) void {
4242 switch (self.tag) {
43 .doc => @fieldParentPtr(Node.Doc, "base", self).deinit(allocator),
44 .map => @fieldParentPtr(Node.Map, "base", self).deinit(allocator),
45 .list => @fieldParentPtr(Node.List, "base", self).deinit(allocator),
46 .value => @fieldParentPtr(Node.Value, "base", self).deinit(allocator),
43 .doc => {
44 const parent = @fieldParentPtr(Node.Doc, "base", self);
45 parent.deinit(allocator);
46 allocator.destroy(parent);
47 },
48 .map => {
49 const parent = @fieldParentPtr(Node.Map, "base", self);
50 parent.deinit(allocator);
51 allocator.destroy(parent);
52 },
53 .list => {
54 const parent = @fieldParentPtr(Node.List, "base", self);
55 parent.deinit(allocator);
56 allocator.destroy(parent);
57 },
58 .value => {
59 const parent = @fieldParentPtr(Node.Value, "base", self);
60 parent.deinit(allocator);
61 allocator.destroy(parent);
62 },
4763 }
4864 }
4965
......@@ -76,7 +92,6 @@ pub const Node = struct {
7692 pub fn deinit(self: *Doc, allocator: Allocator) void {
7793 if (self.value) |node| {
7894 node.deinit(allocator);
79 allocator.destroy(node);
8095 }
8196 }
8297
......@@ -122,7 +137,6 @@ pub const Node = struct {
122137 for (self.values.items) |entry| {
123138 if (entry.value) |value| {
124139 value.deinit(allocator);
125 allocator.destroy(value);
126140 }
127141 }
128142 self.values.deinit(allocator);
......@@ -163,7 +177,6 @@ pub const Node = struct {
163177 pub fn deinit(self: *List, allocator: Allocator) void {
164178 for (self.values.items) |node| {
165179 node.deinit(allocator);
166 allocator.destroy(node);
167180 }
168181 self.values.deinit(allocator);
169182 }
......@@ -239,7 +252,6 @@ pub const Tree = struct {
239252 self.line_cols.deinit();
240253 for (self.docs.items) |doc| {
241254 doc.deinit(self.allocator);
242 self.allocator.destroy(doc);
243255 }
244256 self.docs.deinit(self.allocator);
245257 }
......@@ -386,7 +398,6 @@ const Parser = struct {
386398 }
387399 errdefer if (node.value) |val| {
388400 val.deinit(self.allocator);
389 self.allocator.destroy(val);
390401 };
391402
392403 // Parse footer
......@@ -426,7 +437,6 @@ const Parser = struct {
426437 for (node.values.items) |entry| {
427438 if (entry.value) |val| {
428439 val.deinit(self.allocator);
429 self.allocator.destroy(val);
430440 }
431441 }
432442 node.values.deinit(self.allocator);
......@@ -467,7 +477,6 @@ const Parser = struct {
467477 const val = try self.value();
468478 errdefer if (val) |v| {
469479 v.deinit(self.allocator);
470 self.allocator.destroy(v);
471480 };
472481
473482 if (val) |v| {
......@@ -503,7 +512,6 @@ const Parser = struct {
503512 errdefer {
504513 for (node.values.items) |val| {
505514 val.deinit(self.allocator);
506 self.allocator.destroy(val);
507515 }
508516 node.values.deinit(self.allocator);
509517 }
......@@ -535,7 +543,6 @@ const Parser = struct {
535543 errdefer {
536544 for (node.values.items) |val| {
537545 val.deinit(self.allocator);
538 self.allocator.destroy(val);
539546 }
540547 node.values.deinit(self.allocator);
541548 }