authorgravatar for 124872+jedisct1@users.noreply.github.comFrank Denis <124872+jedisct1@users.noreply.github.com> 2021-08-24 02:06:02+02:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2021-08-23 20:06:02-04:00
log9e3ec98937de07d0e06f483ba8f7e6592b4dd152
tree6a8cc8684ca6c26f419f5e4847212d1d71dde7a7
parentbb38931c7146678548f63ae9ef71e534c7598fe3
signaturebadge-question-mark Signed by PGP key 4AEE18F83AFDEB23

Don't define valgrind_support on macOS (#9612)

Unfortunately, Valgrind for macOS has been broken for years, and the Homebrew formula is only for Linux.

2 files changed, 2 insertions(+), 2 deletions(-)

src/stage1/target.cpp+1-1
......@@ -919,7 +919,7 @@ bool target_has_valgrind_support(const ZigTarget *target) {
919919 case ZigLLVM_UnknownArch:
920920 zig_unreachable();
921921 case ZigLLVM_x86_64:
922 return (target->os == OsLinux || target_os_is_darwin(target->os) || target->os == OsSolaris ||
922 return (target->os == OsLinux || target->os == OsSolaris ||
923923 (target->os == OsWindows && target->abi != ZigLLVM_MSVC));
924924 default:
925925 return false;
src/target.zig+1-1
......@@ -163,7 +163,7 @@ pub fn isSingleThreaded(target: std.Target) bool {
163163pub fn hasValgrindSupport(target: std.Target) bool {
164164 switch (target.cpu.arch) {
165165 .x86_64 => {
166 return target.os.tag == .linux or target.isDarwin() or target.os.tag == .solaris or
166 return target.os.tag == .linux or target.os.tag == .solaris or
167167 (target.os.tag == .windows and target.abi != .msvc);
168168 },
169169 else => return false,