authorgravatar for matthew.h.borkowski@gmail.comMatthew Borkowski <matthew.h.borkowski@gmail.com> 2021-11-01 04:53:11-04:00
committergravatar for matthew.h.borkowski@gmail.comMatthew Borkowski <matthew.h.borkowski@gmail.com> 2021-11-01 05:27:52-04:00
loga0bf620fbfcdc9435c4a06842ab6270fb720c3e1
tree8fe26614bbf5fc2eaae692ff5a5a532f66c471a6
parent2561be2e34ecdbdb11b9de7790089d844739eaea

astgen.zig: avoid unnecessary allocation in identifier for @"" syntax


1 files changed, 8 insertions(+), 6 deletions(-)

src/AstGen.zig+8-6
......@@ -6558,25 +6558,25 @@ fn identifier(
65586558 if (mem.eql(u8, ident_name_raw, "_")) {
65596559 return astgen.failNode(ident, "'_' used as an identifier without @\"_\" syntax", .{});
65606560 }
6561 const ident_name = try astgen.identifierTokenString(ident_token);
65626561
6562 // if not @"" syntax, just use raw token slice
65636563 if (ident_name_raw[0] != '@') {
6564 if (primitives.get(ident_name)) |zir_const_ref| {
6564 if (primitives.get(ident_name_raw)) |zir_const_ref| {
65656565 return rvalue(gz, rl, zir_const_ref, ident);
65666566 }
65676567
6568 if (ident_name.len >= 2) integer: {
6569 const first_c = ident_name[0];
6568 if (ident_name_raw.len >= 2) integer: {
6569 const first_c = ident_name_raw[0];
65706570 if (first_c == 'i' or first_c == 'u') {
65716571 const signedness: std.builtin.Signedness = switch (first_c == 'i') {
65726572 true => .signed,
65736573 false => .unsigned,
65746574 };
6575 const bit_count = std.fmt.parseInt(u16, ident_name[1..], 10) catch |err| switch (err) {
6575 const bit_count = std.fmt.parseInt(u16, ident_name_raw[1..], 10) catch |err| switch (err) {
65766576 error.Overflow => return astgen.failNode(
65776577 ident,
65786578 "primitive integer type '{s}' exceeds maximum bit width of 65535",
6579 .{ident_name},
6579 .{ident_name_raw},
65806580 ),
65816581 error.InvalidCharacter => break :integer,
65826582 };
......@@ -6629,6 +6629,7 @@ fn identifier(
66296629
66306630 // Can't close over a runtime variable
66316631 if (num_namespaces_out != 0 and !local_ptr.maybe_comptime) {
6632 const ident_name = try astgen.identifierTokenString(ident_token);
66326633 return astgen.failNodeNotes(ident, "mutable '{s}' not accessible from here", .{ident_name}, &.{
66336634 try astgen.errNoteTok(local_ptr.token_src, "declared mutable here", .{}),
66346635 try astgen.errNoteNode(capturing_namespace.?.node, "crosses namespace boundary here", .{}),
......@@ -6676,6 +6677,7 @@ fn identifier(
66766677 .top => break,
66776678 };
66786679 if (found_already == null) {
6680 const ident_name = try astgen.identifierTokenString(ident_token);
66796681 return astgen.failNode(ident, "use of undeclared identifier '{s}'", .{ident_name});
66806682 }
66816683