authorgravatar for topolarity@tapscott.meCody Tapscott <topolarity@tapscott.me> 2022-11-10 12:03:17-07:00
committergravatar for topolarity@tapscott.meCody Tapscott <topolarity@tapscott.me> 2022-11-10 12:22:40-07:00
loga2f4de1663f815ae8c202ba6a8c68b0658b7d23f
treee900f62b506072b35e8d4d106c7948ee6977879c
parent8f3880074fb76871d9a4f35d1f72d0304ac5b404

stage2 llvm: Elide more loads

Adds optimizations for by-ref types to: - .struct_field_val - .slice_elem_val - .ptr_elem_val I would have expected LLVM to be able to optimize away these temporaries since we don't leak pointers to them and they are fed straight from def to use, but empirically it does not. Resolves https://github.com/ziglang/zig/issues/12713 Resolves https://github.com/ziglang/zig/issues/12638

1 files changed, 24 insertions(+), 1 deletions(-)

src/codegen/llvm.zig+24-1
...@@ -5644,6 +5644,14 @@ pub const FuncGen = struct {...@@ -5644,6 +5644,14 @@ pub const FuncGen = struct {
5644 const base_ptr = self.builder.buildExtractValue(slice, 0, "");5644 const base_ptr = self.builder.buildExtractValue(slice, 0, "");
5645 const indices: [1]*llvm.Value = .{index};5645 const indices: [1]*llvm.Value = .{index};
5646 const ptr = self.builder.buildInBoundsGEP(llvm_elem_ty, base_ptr, &indices, indices.len, "");5646 const ptr = self.builder.buildInBoundsGEP(llvm_elem_ty, base_ptr, &indices, indices.len, "");
5647 if (isByRef(elem_ty)) {
5648 if (self.canElideLoad(body_tail))
5649 return ptr;
5650
5651 const target = self.dg.module.getTarget();
5652 return self.loadByRef(ptr, elem_ty, elem_ty.abiAlignment(target), false);
5653 }
5654
5647 return self.load(ptr, slice_ty);5655 return self.load(ptr, slice_ty);
5648 }5656 }
56495657
...@@ -5709,6 +5717,14 @@ pub const FuncGen = struct {...@@ -5709,6 +5717,14 @@ pub const FuncGen = struct {
5709 const indices: [1]*llvm.Value = .{rhs};5717 const indices: [1]*llvm.Value = .{rhs};
5710 break :ptr self.builder.buildInBoundsGEP(llvm_elem_ty, base_ptr, &indices, indices.len, "");5718 break :ptr self.builder.buildInBoundsGEP(llvm_elem_ty, base_ptr, &indices, indices.len, "");
5711 };5719 };
5720 if (isByRef(elem_ty)) {
5721 if (self.canElideLoad(body_tail))
5722 return ptr;
5723
5724 const target = self.dg.module.getTarget();
5725 return self.loadByRef(ptr, elem_ty, elem_ty.abiAlignment(target), false);
5726 }
5727
5712 return self.load(ptr, ptr_ty);5728 return self.load(ptr, ptr_ty);
5713 }5729 }
57145730
...@@ -5832,7 +5848,14 @@ pub const FuncGen = struct {...@@ -5832,7 +5848,14 @@ pub const FuncGen = struct {
5832 const struct_llvm_ty = try self.dg.lowerType(struct_ty);5848 const struct_llvm_ty = try self.dg.lowerType(struct_ty);
5833 const field_ptr = self.builder.buildStructGEP(struct_llvm_ty, struct_llvm_val, llvm_field_index, "");5849 const field_ptr = self.builder.buildStructGEP(struct_llvm_ty, struct_llvm_val, llvm_field_index, "");
5834 const field_ptr_ty = Type.initPayload(&ptr_ty_buf.base);5850 const field_ptr_ty = Type.initPayload(&ptr_ty_buf.base);
5835 return self.load(field_ptr, field_ptr_ty);5851 if (isByRef(field_ty)) {
5852 if (canElideLoad(self, body_tail))
5853 return field_ptr;
5854
5855 return self.loadByRef(field_ptr, field_ty, ptr_ty_buf.data.alignment(target), false);
5856 } else {
5857 return self.load(field_ptr, field_ptr_ty);
5858 }
5836 },5859 },
5837 .Union => {5860 .Union => {
5838 const union_llvm_ty = try self.dg.lowerType(struct_ty);5861 const union_llvm_ty = try self.dg.lowerType(struct_ty);