authorgravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2024-03-23 03:38:51+01:00
committergravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2024-03-23 11:32:37+01:00
loga7282d09101b4339fc71d5ea78927c598aee0f52
tree5bf8431bd154460e683ac961614ce28c9d19d50e
parentff7ca4b70fc411a9e1e3ba94a06333601a229e6e

WasmAllocator: fix safety panic during OOM


1 files changed, 8 insertions(+), 10 deletions(-)

lib/std/heap/WasmAllocator.zig+8-10
......@@ -55,7 +55,7 @@ fn alloc(ctx: *anyopaque, len: usize, log2_align: u8, return_address: usize) ?[*
5555 const addr = a: {
5656 const top_free_ptr = frees[class];
5757 if (top_free_ptr != 0) {
58 const node = @as(*usize, @ptrFromInt(top_free_ptr + (slot_size - @sizeOf(usize))));
58 const node: *usize = @ptrFromInt(top_free_ptr + (slot_size - @sizeOf(usize)));
5959 frees[class] = node.*;
6060 break :a top_free_ptr;
6161 }
......@@ -74,11 +74,10 @@ fn alloc(ctx: *anyopaque, len: usize, log2_align: u8, return_address: usize) ?[*
7474 break :a next_addr;
7575 }
7676 };
77 return @as([*]u8, @ptrFromInt(addr));
77 return @ptrFromInt(addr);
7878 }
7979 const bigpages_needed = bigPagesNeeded(actual_len);
80 const addr = allocBigPages(bigpages_needed);
81 return @as([*]u8, @ptrFromInt(addr));
80 return @ptrFromInt(allocBigPages(bigpages_needed));
8281}
8382
8483fn resize(
......@@ -123,14 +122,14 @@ fn free(
123122 const class = math.log2(slot_size) - min_class;
124123 const addr = @intFromPtr(buf.ptr);
125124 if (class < size_class_count) {
126 const node = @as(*usize, @ptrFromInt(addr + (slot_size - @sizeOf(usize))));
125 const node: *usize = @ptrFromInt(addr + (slot_size - @sizeOf(usize)));
127126 node.* = frees[class];
128127 frees[class] = addr;
129128 } else {
130129 const bigpages_needed = bigPagesNeeded(actual_len);
131130 const pow2_pages = math.ceilPowerOfTwoAssert(usize, bigpages_needed);
132131 const big_slot_size_bytes = pow2_pages * bigpage_size;
133 const node = @as(*usize, @ptrFromInt(addr + (big_slot_size_bytes - @sizeOf(usize))));
132 const node: *usize = @ptrFromInt(addr + (big_slot_size_bytes - @sizeOf(usize)));
134133 const big_class = math.log2(pow2_pages);
135134 node.* = big_frees[big_class];
136135 big_frees[big_class] = addr;
......@@ -148,15 +147,14 @@ fn allocBigPages(n: usize) usize {
148147
149148 const top_free_ptr = big_frees[class];
150149 if (top_free_ptr != 0) {
151 const node = @as(*usize, @ptrFromInt(top_free_ptr + (slot_size_bytes - @sizeOf(usize))));
150 const node: *usize = @ptrFromInt(top_free_ptr + (slot_size_bytes - @sizeOf(usize)));
152151 big_frees[class] = node.*;
153152 return top_free_ptr;
154153 }
155154
156155 const page_index = @wasmMemoryGrow(0, pow2_pages * pages_per_bigpage);
157 if (page_index <= 0) return 0;
158 const addr = @as(u32, @intCast(page_index)) * wasm.page_size;
159 return addr;
156 if (page_index == -1) return 0;
157 return @as(usize, @intCast(page_index)) * wasm.page_size;
160158}
161159
162160const test_ally = Allocator{