authorgravatar for timonkruiper@gmail.comTimon Kruiper <timonkruiper@gmail.com> 2020-04-01 20:40:13+02:00
committergravatar for timonkruiper@gmail.comTimon Kruiper <timonkruiper@gmail.com> 2020-04-01 20:50:09+02:00
logae6965a4e73cd5aad04e1c6831f48e7f0ecafc04
treed18ea56cc85ff06642fa5d4b63cc263200488981
parentd9cf779b47573f750f9e6ffb6373bfcb75b1632e

Fix undefined behavior when shift amount is 64

1 files changed, 1 insertions(+), 1 deletions(-)

src/bigint.cpp+1-1
...@@ -1430,7 +1430,7 @@ void bigint_shr(BigInt *dest, const BigInt *op1, const BigInt *op2) {...@@ -1430,7 +1430,7 @@ void bigint_shr(BigInt *dest, const BigInt *op1, const BigInt *op2) {
1430 uint64_t digit = op1_digits[op_digit_index];1430 uint64_t digit = op1_digits[op_digit_index];
1431 size_t dest_digit_index = op_digit_index - digit_shift_count;1431 size_t dest_digit_index = op_digit_index - digit_shift_count;
1432 digits[dest_digit_index] = carry | (digit >> leftover_shift_count);1432 digits[dest_digit_index] = carry | (digit >> leftover_shift_count);
1433 carry = digit << (64 - leftover_shift_count);1433 carry = (leftover_shift_count != 0) ? (digit << (64 - leftover_shift_count)) : 0;
14341434
1435 if (dest_digit_index == 0) { break; }1435 if (dest_digit_index == 0) { break; }
1436 op_digit_index -= 1;1436 op_digit_index -= 1;