authorgravatar for stephen@hexops.comStephen Gutekanst <stephen@hexops.com> 2022-02-22 09:02:37-07:00
committergravatar for stephen@hexops.comStephen Gutekanst <stephen@hexops.com> 2022-02-22 15:49:03-07:00
logc577926a7d3cea68f781cd68ad65a0606c4f7a54
treed8ee91b8de438818a142957e1c5e886e7ceb8e70
parentb341967da0fc0fe5dfc8fa914006fd6a7624297f

zig build: style: remove unnecessary constant bindings

Signed-off-by: Stephen Gutekanst <stephen@hexops.com>

1 files changed, 34 insertions(+), 59 deletions(-)

src/main.zig+34-59
......@@ -822,10 +822,9 @@ fn buildOutputType(
822822 cur_pkg = cur_pkg.parent orelse
823823 fatal("encountered --pkg-end with no matching --pkg-begin", .{});
824824 } else if (mem.eql(u8, arg, "--main-pkg-path")) {
825 const next_arg = args_iter.next() orelse {
825 main_pkg_path = args_iter.next() orelse {
826826 fatal("expected parameter after {s}", .{arg});
827827 };
828 main_pkg_path = next_arg;
829828 } else if (mem.eql(u8, arg, "-cflags")) {
830829 extra_cflags.shrinkRetainingCapacity(0);
831830 while (true) {
......@@ -877,15 +876,13 @@ fn buildOutputType(
877876 });
878877 }
879878 } else if (mem.eql(u8, arg, "-O")) {
880 const next_arg = args_iter.next() orelse {
879 optimize_mode_string = args_iter.next() orelse {
881880 fatal("expected parameter after {s}", .{arg});
882881 };
883 optimize_mode_string = next_arg;
884882 } else if (mem.eql(u8, arg, "--entry")) {
885 const next_arg = args_iter.next() orelse {
883 entry = args_iter.next() orelse {
886884 fatal("expected parameter after {s}", .{arg});
887885 };
888 entry = next_arg;
889886 } else if (mem.eql(u8, arg, "--stack")) {
890887 const next_arg = args_iter.next() orelse {
891888 fatal("expected parameter after {s}", .{arg});
......@@ -901,45 +898,37 @@ fn buildOutputType(
901898 fatal("unable to parse '{s}': {s}", .{ arg, @errorName(err) });
902899 };
903900 } else if (mem.eql(u8, arg, "--name")) {
904 const next_arg = args_iter.next() orelse {
901 provided_name = args_iter.next() orelse {
905902 fatal("expected parameter after {s}", .{arg});
906903 };
907 provided_name = next_arg;
908904 } else if (mem.eql(u8, arg, "-rpath")) {
909 const next_arg = args_iter.next() orelse {
905 try rpath_list.append(args_iter.next() orelse {
910906 fatal("expected parameter after {s}", .{arg});
911 };
912 try rpath_list.append(next_arg);
907 });
913908 } else if (mem.eql(u8, arg, "--library-directory") or mem.eql(u8, arg, "-L")) {
914 const next_arg = args_iter.next() orelse {
909 try lib_dirs.append(args_iter.next() orelse {
915910 fatal("expected parameter after {s}", .{arg});
916 };
917 try lib_dirs.append(next_arg);
911 });
918912 } else if (mem.eql(u8, arg, "-F")) {
919 const next_arg = args_iter.next() orelse {
913 try framework_dirs.append(args_iter.next() orelse {
920914 fatal("expected parameter after {s}", .{arg});
921 };
922 try framework_dirs.append(next_arg);
915 });
923916 } else if (mem.eql(u8, arg, "-framework")) {
924 const next_arg = args_iter.next() orelse {
917 try frameworks.append(args_iter.next() orelse {
925918 fatal("expected parameter after {s}", .{arg});
926 };
927 try frameworks.append(next_arg);
919 });
928920 } else if (mem.eql(u8, arg, "-install_name")) {
929 const next_arg = args_iter.next() orelse {
921 install_name = args_iter.next() orelse {
930922 fatal("expected parameter after {s}", .{arg});
931923 };
932 install_name = next_arg;
933924 } else if (mem.eql(u8, arg, "-T") or mem.eql(u8, arg, "--script")) {
934 const next_arg = args_iter.next() orelse {
925 linker_script = args_iter.next() orelse {
935926 fatal("expected parameter after {s}", .{arg});
936927 };
937 linker_script = next_arg;
938928 } else if (mem.eql(u8, arg, "--version-script")) {
939 const next_arg = args_iter.next() orelse {
929 version_script = args_iter.next() orelse {
940930 fatal("expected parameter after {s}", .{arg});
941931 };
942 version_script = next_arg;
943932 } else if (mem.eql(u8, arg, "--library") or mem.eql(u8, arg, "-l")) {
944933 const next_arg = args_iter.next() orelse {
945934 fatal("expected parameter after {s}", .{arg});
......@@ -960,11 +949,10 @@ fn buildOutputType(
960949 mem.eql(u8, arg, "-iframework") or
961950 mem.eql(u8, arg, "-iframeworkwithsysroot"))
962951 {
963 const next_arg = args_iter.next() orelse {
964 fatal("expected parameter after {s}", .{arg});
965 };
966952 try clang_argv.append(arg);
967 try clang_argv.append(next_arg);
953 try clang_argv.append(args_iter.next() orelse {
954 fatal("expected parameter after {s}", .{arg});
955 });
968956 } else if (mem.eql(u8, arg, "--version")) {
969957 const next_arg = args_iter.next() orelse {
970958 fatal("expected parameter after {s}", .{arg});
......@@ -974,20 +962,17 @@ fn buildOutputType(
974962 };
975963 have_version = true;
976964 } else if (mem.eql(u8, arg, "-target")) {
977 const next_arg = args_iter.next() orelse {
965 target_arch_os_abi = args_iter.next() orelse {
978966 fatal("expected parameter after {s}", .{arg});
979967 };
980 target_arch_os_abi = next_arg;
981968 } else if (mem.eql(u8, arg, "-mcpu")) {
982 const next_arg = args_iter.next() orelse {
969 target_mcpu = args_iter.next() orelse {
983970 fatal("expected parameter after {s}", .{arg});
984971 };
985 target_mcpu = next_arg;
986972 } else if (mem.eql(u8, arg, "-mcmodel")) {
987 const next_arg = args_iter.next() orelse {
973 machine_code_model = parseCodeModel(args_iter.next() orelse {
988974 fatal("expected parameter after {s}", .{arg});
989 };
990 machine_code_model = parseCodeModel(next_arg);
975 });
991976 } else if (mem.startsWith(u8, arg, "-ofmt=")) {
992977 target_ofmt = arg["-ofmt=".len..];
993978 } else if (mem.startsWith(u8, arg, "-mcpu=")) {
......@@ -997,52 +982,43 @@ fn buildOutputType(
997982 } else if (mem.startsWith(u8, arg, "-O")) {
998983 optimize_mode_string = arg["-O".len..];
999984 } else if (mem.eql(u8, arg, "--dynamic-linker")) {
1000 const next_arg = args_iter.next() orelse {
985 target_dynamic_linker = args_iter.next() orelse {
1001986 fatal("expected parameter after {s}", .{arg});
1002987 };
1003 target_dynamic_linker = next_arg;
1004988 } else if (mem.eql(u8, arg, "--sysroot")) {
1005 const next_arg = args_iter.next() orelse {
989 sysroot = args_iter.next() orelse {
1006990 fatal("expected parameter after {s}", .{arg});
1007991 };
1008 sysroot = next_arg;
1009992 try clang_argv.append("-isysroot");
1010 try clang_argv.append(next_arg);
993 try clang_argv.append(sysroot.?);
1011994 } else if (mem.eql(u8, arg, "--libc")) {
1012 const next_arg = args_iter.next() orelse {
995 libc_paths_file = args_iter.next() orelse {
1013996 fatal("expected parameter after {s}", .{arg});
1014997 };
1015 libc_paths_file = next_arg;
1016998 } else if (mem.eql(u8, arg, "--test-filter")) {
1017 const next_arg = args_iter.next() orelse {
999 test_filter = args_iter.next() orelse {
10181000 fatal("expected parameter after {s}", .{arg});
10191001 };
1020 test_filter = next_arg;
10211002 } else if (mem.eql(u8, arg, "--test-name-prefix")) {
1022 const next_arg = args_iter.next() orelse {
1003 test_name_prefix = args_iter.next() orelse {
10231004 fatal("expected parameter after {s}", .{arg});
10241005 };
1025 test_name_prefix = next_arg;
10261006 } else if (mem.eql(u8, arg, "--test-cmd")) {
1027 const next_arg = args_iter.next() orelse {
1007 try test_exec_args.append(args_iter.next() orelse {
10281008 fatal("expected parameter after {s}", .{arg});
1029 };
1030 try test_exec_args.append(next_arg);
1009 });
10311010 } else if (mem.eql(u8, arg, "--cache-dir")) {
1032 const next_arg = args_iter.next() orelse {
1011 override_local_cache_dir = args_iter.next() orelse {
10331012 fatal("expected parameter after {s}", .{arg});
10341013 };
1035 override_local_cache_dir = next_arg;
10361014 } else if (mem.eql(u8, arg, "--global-cache-dir")) {
1037 const next_arg = args_iter.next() orelse {
1015 override_global_cache_dir = args_iter.next() orelse {
10381016 fatal("expected parameter after {s}", .{arg});
10391017 };
1040 override_global_cache_dir = next_arg;
10411018 } else if (mem.eql(u8, arg, "--zig-lib-dir")) {
1042 const next_arg = args_iter.next() orelse {
1019 override_lib_dir = args_iter.next() orelse {
10431020 fatal("expected parameter after {s}", .{arg});
10441021 };
1045 override_lib_dir = next_arg;
10461022 } else if (mem.eql(u8, arg, "--debug-log")) {
10471023 const next_arg = args_iter.next() orelse {
10481024 fatal("expected parameter after {s}", .{arg});
......@@ -1223,10 +1199,9 @@ fn buildOutputType(
12231199 } else if (mem.eql(u8, arg, "-fno-allow-shlib-undefined")) {
12241200 linker_allow_shlib_undefined = false;
12251201 } else if (mem.eql(u8, arg, "-z")) {
1226 const next_arg = args_iter.next() orelse {
1202 const z_arg = args_iter.next() orelse {
12271203 fatal("expected parameter after {s}", .{arg});
12281204 };
1229 const z_arg = next_arg;
12301205 if (mem.eql(u8, z_arg, "nodelete")) {
12311206 linker_z_nodelete = true;
12321207 } else if (mem.eql(u8, z_arg, "notext")) {