authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2024-07-04 07:21:01+02:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2024-07-04 07:33:00+02:00
logc9d19ebb7a3d6996ec8b299d1698adf6737d73e5
tree0b73733a27b173d2b62c09ab00bb150a738bc813
parent1cfc3647853123efc0fda991180e337d8a72eac5

macho: link dynamic TSAN lib


2 files changed, 16 insertions(+), 7 deletions(-)

src/link/MachO.zig+15-6
......@@ -150,6 +150,7 @@ no_implicit_dylibs: bool = false,
150150/// Whether the linker should parse and always force load objects containing ObjC in archives.
151151// TODO: in Zig we currently take -ObjC as always on
152152force_load_objc: bool = true,
153rpaths: std.ArrayListUnmanaged([]const u8) = .{},
153154
154155/// Hot-code swapping state.
155156hot_state: if (is_hot_update_compatible) HotUpdateState else struct {} = .{},
......@@ -192,7 +193,7 @@ pub fn createEmpty(
192193 null
193194 else
194195 try std.fmt.allocPrint(arena, "{s}.o", .{emit.sub_path});
195 const allow_shlib_undefined = options.allow_shlib_undefined orelse comp.config.any_sanitize_thread;
196 const allow_shlib_undefined = options.allow_shlib_undefined orelse false;
196197
197198 const self = try arena.create(MachO);
198199 self.* = .{
......@@ -358,6 +359,8 @@ pub fn deinit(self: *MachO) void {
358359 }
359360 self.thunks.deinit(gpa);
360361 self.unwind_records.deinit(gpa);
362
363 self.rpaths.deinit(gpa);
361364}
362365
363366pub fn flush(self: *MachO, arena: Allocator, prog_node: std.Progress.Node) link.File.FlushError!void {
......@@ -395,6 +398,9 @@ pub fn flushModule(self: *MachO, arena: Allocator, prog_node: std.Progress.Node)
395398 if (self.base.isStaticLib()) return relocatable.flushStaticLib(self, comp, module_obj_path);
396399 if (self.base.isObject()) return relocatable.flushObject(self, comp, module_obj_path);
397400
401 try self.rpaths.ensureUnusedCapacity(gpa, self.base.rpath_list.len);
402 self.rpaths.appendSliceAssumeCapacity(self.base.rpath_list);
403
398404 var positionals = std.ArrayList(Compilation.LinkObject).init(gpa);
399405 defer positionals.deinit();
400406
......@@ -413,7 +419,10 @@ pub fn flushModule(self: *MachO, arena: Allocator, prog_node: std.Progress.Node)
413419
414420 // TSAN
415421 if (comp.config.any_sanitize_thread) {
416 try positionals.append(.{ .path = comp.tsan_static_lib.?.full_object_path });
422 const path = comp.tsan_dynamic_lib.?.full_object_path;
423 try positionals.append(.{ .path = path });
424 const basename = std.fs.path.dirname(path) orelse ".";
425 try self.rpaths.append(gpa, basename);
417426 }
418427
419428 for (positionals.items) |obj| {
......@@ -771,7 +780,7 @@ fn dumpArgv(self: *MachO, comp: *Compilation) !void {
771780 try argv.append(syslibroot);
772781 }
773782
774 for (self.base.rpath_list) |rpath| {
783 for (self.rpaths.items) |rpath| {
775784 try argv.append("-rpath");
776785 try argv.append(rpath);
777786 }
......@@ -831,7 +840,7 @@ fn dumpArgv(self: *MachO, comp: *Compilation) !void {
831840 }
832841
833842 if (comp.config.any_sanitize_thread) {
834 try argv.append(comp.tsan_static_lib.?.full_object_path);
843 try argv.append(comp.tsan_dynamic_lib.?.full_object_path);
835844 }
836845
837846 for (self.lib_dirs) |lib_dir| {
......@@ -3015,8 +3024,8 @@ fn writeLoadCommands(self: *MachO) !struct { usize, usize, u64 } {
30153024 ncmds += 1;
30163025 }
30173026
3018 try load_commands.writeRpathLCs(self.base.rpath_list, writer);
3019 ncmds += self.base.rpath_list.len;
3027 try load_commands.writeRpathLCs(self.rpaths.items, writer);
3028 ncmds += self.rpaths.items.len;
30203029
30213030 try writer.writeStruct(macho.source_version_command{ .version = 0 });
30223031 ncmds += 1;
src/link/MachO/load_commands.zig+1-1
......@@ -61,7 +61,7 @@ pub fn calcLoadCommandsSize(macho_file: *MachO, assume_max_path_len: bool) !u32
6161 }
6262 // LC_RPATH
6363 {
64 for (macho_file.base.rpath_list) |rpath| {
64 for (macho_file.rpaths.items) |rpath| {
6565 sizeofcmds += calcInstallNameLen(
6666 @sizeOf(macho.rpath_command),
6767 rpath,