Commit cac814cf58ca65ffd8081dca6f2f5b26d822ef5d | zig

author	Matthew Lugg <mlugg@mlugg.co.uk> 2025-02-05 20:13:56+00:00
committer	Matthew Lugg <mlugg@mlugg.co.uk> 2025-02-05 20:13:56+00:00
log	cac814cf58ca65ffd8081dca6f2f5b26d822ef5d
tree	a47d2a1e449630d66526acbb73e4714cffee52fc
parent	9ba9f457be13c0c32981e94cf75ba7ea6619d92f
signature	Commit is signed but in an unrecognized format.

Sema: fix comparison between error set and comptime-known error union

Resolves: #20613

2 files changed, 19 insertions(+), 1 deletions(-)

src
- Sema.zig
test
- behavior
  - error.zig

src/Sema.zig+8-1

 @@ -9145,6 +9145,7 @@ fn zirErrUnionCode(sema: *Sema, block: *Block, inst: Zir.Inst.Index) CompileErro
     return sema.analyzeErrUnionCode(block, src, operand);
 }
+/// If `operand` is comptime-known, asserts that it is an error value rather than a payload value.
 fn analyzeErrUnionCode(sema: *Sema, block: *Block, src: LazySrcLoc, operand: Air.Inst.Ref) CompileError!Air.Inst.Ref {
     const pt = sema.pt;
     const zcu = pt.zcu;
 @@ -17599,10 +17600,16 @@ fn analyzeCmp(
         return sema.cmpNumeric(block, src, lhs, rhs, op, lhs_src, rhs_src);
     }
     if (is_equality_cmp and lhs_ty.zigTypeTag(zcu) == .error_union and rhs_ty.zigTypeTag(zcu) == .error_set) {
+        if (try sema.resolveDefinedValue(block, lhs_src, lhs)) |lhs_val| {
+            if (lhs_val.errorUnionIsPayload(zcu)) return .bool_false;
+        }
         const casted_lhs = try sema.analyzeErrUnionCode(block, lhs_src, lhs);
         return sema.cmpSelf(block, src, casted_lhs, rhs, op, lhs_src, rhs_src);
     }
     if (is_equality_cmp and lhs_ty.zigTypeTag(zcu) == .error_set and rhs_ty.zigTypeTag(zcu) == .error_union) {
+        if (try sema.resolveDefinedValue(block, rhs_src, rhs)) |rhs_val| {
+            if (rhs_val.errorUnionIsPayload(zcu)) return .bool_false;
+        }
         const casted_rhs = try sema.analyzeErrUnionCode(block, rhs_src, rhs);
         return sema.cmpSelf(block, src, lhs, casted_rhs, op, lhs_src, rhs_src);
     }
 @@ -23254,7 +23261,7 @@ fn zirErrorCast(sema: *Sema, block: *Block, extended: Zir.Inst.Extended.InstData
         zcu.backendSupportsFeature(.error_set_has_value))
     {
         if (dest_tag == .error_union) {
-            const err_code = try sema.analyzeErrUnionCode(block, operand_src, operand);
+            const err_code = try block.addTyOp(.unwrap_errunion_err, operand_ty, operand);
             const err_int = try block.addBitCast(err_int_ty, err_code);
             const zero_err = try pt.intRef(try pt.errorIntType(), 0);

test/behavior/error.zig+11

...	@@ -1100,3 +1100,14 @@ test "return error union with i65" {	...	@@ -1100,3 +1100,14 @@ test "return error union with i65" {
1100	fn add(x: i65, y: i65) anyerror!i65 {	1100	fn add(x: i65, y: i65) anyerror!i65 {
1101	return x + y;	1101	return x + y;
1102	}	1102	}
		1103
		1104	test "compare error union to error set" {
		1105	const S = struct {
		1106	fn doTheTest(val: error{Foo}!i32) !void {
		1107	if (error.Foo == val) return error.Unexpected;
		1108	if (val == error.Foo) return error.Unexpected;
		1109	}
		1110	};
		1111	try S.doTheTest(0);
		1112	try comptime S.doTheTest(0);
		1113	}