Commit cfeb412a4263809698f941081197cd0ff7f260aa | zig

author	gracefu <81774659+gracefuu@users.noreply.github.com> 2021-04-12 01:29:40+08:00
committer	gracefu <81774659+gracefuu@users.noreply.github.com> 2021-04-16 15:21:17+08:00
log	cfeb412a4263809698f941081197cd0ff7f260aa
tree	09f34468d720286fc3791c0c2083bbcde277a520
parent	dc136627251c920713536807e0da922c140ca588
signature	Commit is signed but in an unrecognized format.

Co-authored-by: joachimschmidt557 <joachim.schmidt557@outlook.com>

1 files changed, 7 insertions(+), 1 deletions(-)

src/codegen.zig+7-1

 @@ -1505,8 +1505,14 @@ fn Function(comptime arch: std.Target.Cpu.Arch) type {
         /// ADD, SUB, XOR, OR, AND
         fn genX8664BinMath(self: *Self, inst: *ir.Inst, op_lhs: *ir.Inst, op_rhs: *ir.Inst) !MCValue {
             // We'll handle these ops in two steps.
-            // 1) Prepare an output register, and put one of the arguments in it
+            // 1) Prepare an output location (register or memory)
+            //    This location will be the location of the operand that dies (if one exists)
+            //    or just a temporary register (if one doesn't exist)
             // 2) Perform the op with the other argument
+            // 3) Sometimes, the output location is memory but the op doesn't support it.
+            //    In this case, copy that location to a register, then perform the op to that register instead.
+            //
+            // TODO: make this algorithm less bad
             try self.code.ensureCapacity(self.code.items.len + 8);