authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2021-07-17 15:13:16+02:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2021-07-17 15:13:16+02:00
logd81783375c2555b2e2cb6a028ea648179031bc93
tree5a7af146d49b4b27fc8912859f3d2965d5e207f5
parent71384a383e0ec6d4c3f6e16571c36a9c44d1645c

zld: allocate TextBlocks and symbols


1 files changed, 34 insertions(+), 34 deletions(-)

src/link/MachO/Zld.zig+34-34
......@@ -233,7 +233,15 @@ pub fn link(self: *Zld, files: []const []const u8, output: Output, args: LinkArg
233233 try self.parseLibs(args.libs, args.syslibroot);
234234 try self.resolveSymbols();
235235 try self.parseTextBlocks();
236 // try self.sortSections();
236 try self.sortSections();
237 try self.addRpaths(args.rpaths);
238 try self.addDataInCodeLC();
239 try self.addCodeSignatureLC();
240 try self.allocateTextSegment();
241 try self.allocateDataConstSegment();
242 try self.allocateDataSegment();
243 self.allocateLinkeditSegment();
244 try self.allocateTextBlocks();
237245
238246 log.warn("locals", .{});
239247 for (self.locals.items) |sym, id| {
......@@ -289,14 +297,6 @@ pub fn link(self: *Zld, files: []const []const u8, output: Output, args: LinkArg
289297 }
290298
291299 return error.TODO;
292 // try self.addRpaths(args.rpaths);
293 // try self.addDataInCodeLC();
294 // try self.addCodeSignatureLC();
295 // try self.allocateTextSegment();
296 // try self.allocateDataConstSegment();
297 // try self.allocateDataSegment();
298 // self.allocateLinkeditSegment();
299 // try self.allocateTextBlocks();
300300
301301 // try self.flush();
302302}
......@@ -883,23 +883,11 @@ fn sortSections(self: *Zld) !void {
883883 self.blocks.deinit(self.allocator);
884884 self.blocks = transient;
885885 }
886
887 for (self.locals.items) |sym, i| {
888 if (i == 0) continue; // skip the null symbol
889 assert(sym.payload == .regular);
890 const reg = &sym.payload.regular;
891 reg.section_id = if (reg.segment_id == self.text_segment_cmd_index.?)
892 text_index_mapping.get(reg.section_id).?
893 else if (reg.segment_id == self.data_const_segment_cmd_index.?)
894 data_const_index_mapping.get(reg.section_id).?
895 else
896 data_index_mapping.get(reg.section_id).?;
897 }
898886}
899887
900888fn allocateTextSegment(self: *Zld) !void {
901889 const seg = &self.load_commands.items[self.text_segment_cmd_index.?].Segment;
902 const nstubs = @intCast(u32, self.stubs.items.len);
890 const nstubs = @intCast(u32, self.stubs.count());
903891
904892 const base_vmaddr = self.load_commands.items[self.pagezero_segment_cmd_index.?].Segment.inner.vmsize;
905893 seg.inner.fileoff = 0;
......@@ -950,7 +938,7 @@ fn allocateTextSegment(self: *Zld) !void {
950938
951939fn allocateDataConstSegment(self: *Zld) !void {
952940 const seg = &self.load_commands.items[self.data_const_segment_cmd_index.?].Segment;
953 const nentries = @intCast(u32, self.got_entries.items.len);
941 const nentries = @intCast(u32, self.got_entries.count());
954942
955943 const text_seg = self.load_commands.items[self.text_segment_cmd_index.?].Segment;
956944 seg.inner.fileoff = text_seg.inner.fileoff + text_seg.inner.filesize;
......@@ -965,7 +953,7 @@ fn allocateDataConstSegment(self: *Zld) !void {
965953
966954fn allocateDataSegment(self: *Zld) !void {
967955 const seg = &self.load_commands.items[self.data_segment_cmd_index.?].Segment;
968 const nstubs = @intCast(u32, self.stubs.items.len);
956 const nstubs = @intCast(u32, self.stubs.count());
969957
970958 const data_const_seg = self.load_commands.items[self.data_const_segment_cmd_index.?].Segment;
971959 seg.inner.fileoff = data_const_seg.inner.fileoff + data_const_seg.inner.filesize;
......@@ -1021,6 +1009,7 @@ fn allocateTextBlocks(self: *Zld) !void {
10211009 const sect = seg.sections.items[match.sect];
10221010
10231011 var base_addr: u64 = sect.addr;
1012 const n_sect = self.sectionId(match);
10241013
10251014 log.debug(" within section {s},{s}", .{ segmentName(sect), sectionName(sect) });
10261015 log.debug(" {}", .{sect});
......@@ -1029,12 +1018,12 @@ fn allocateTextBlocks(self: *Zld) !void {
10291018 const block_alignment = try math.powi(u32, 2, block.alignment);
10301019 base_addr = mem.alignForwardGeneric(u64, base_addr, block_alignment);
10311020
1032 const sym = self.locals.items[block.local_sym_index];
1033 assert(sym.payload == .regular);
1034 sym.payload.regular.address = base_addr;
1021 const sym = &self.locals.items[block.local_sym_index];
1022 sym.n_value = base_addr;
1023 sym.n_sect = n_sect;
10351024
10361025 log.debug(" {s}: start=0x{x}, end=0x{x}, size={}, align={}", .{
1037 self.getString(sym.strx),
1026 self.getString(sym.n_strx),
10381027 base_addr,
10391028 base_addr + block.size,
10401029 block.size,
......@@ -1043,17 +1032,17 @@ fn allocateTextBlocks(self: *Zld) !void {
10431032
10441033 // Update each alias (if any)
10451034 for (block.aliases.items) |index| {
1046 const alias_sym = self.locals.items[index];
1047 assert(alias_sym.payload == .regular);
1048 alias_sym.payload.regular.address = base_addr;
1035 const alias_sym = &self.locals.items[index];
1036 alias_sym.n_value = base_addr;
1037 alias_sym.n_sect = n_sect;
10491038 }
10501039
10511040 // Update each symbol contained within the TextBlock
10521041 if (block.contained) |contained| {
10531042 for (contained) |sym_at_off| {
1054 const contained_sym = self.locals.items[sym_at_off.local_sym_index];
1055 assert(contained_sym.payload == .regular);
1056 contained_sym.payload.regular.address = base_addr + sym_at_off.offset;
1043 const contained_sym = &self.locals.items[sym_at_off.local_sym_index];
1044 contained_sym.n_value = base_addr + sym_at_off.offset;
1045 contained_sym.n_sect = n_sect;
10571046 }
10581047 }
10591048
......@@ -1064,6 +1053,17 @@ fn allocateTextBlocks(self: *Zld) !void {
10641053 } else break;
10651054 }
10661055 }
1056
1057 // Update globals
1058 for (self.symbol_resolver.values()) |resolv| {
1059 if (resolv.where != .global) continue;
1060
1061 assert(resolv.local_sym_index != 0);
1062 const local_sym = self.locals.items[resolv.local_sym_index];
1063 const sym = &self.globals.items[resolv.where_index];
1064 sym.n_value = local_sym.n_value;
1065 sym.n_sect = local_sym.n_sect;
1066 }
10671067}
10681068
10691069fn writeTextBlocks(self: *Zld) !void {