diff --git a/src/Sema.zig b/src/Sema.zig index abd66f22fe19699d89e34a508d3f8ebcf83abc00..7060128e6db24562e5ae03e4122184edc425d9df 100644 --- a/src/Sema.zig +++ b/src/Sema.zig @@ -2274,15 +2274,20 @@ pub fn resolveFinalDeclValue( src: LazySrcLoc, air_ref: Air.Inst.Ref, ) CompileError!Value { + const zcu = sema.pt.zcu; + const val = try sema.resolveValueAllowVariables(air_ref) orelse { return sema.failWithNeededComptime(block, src, .{ .needed_comptime_reason = "global variable initializer must be comptime-known", }); }; if (val.isGenericPoison()) return error.GenericPoison; - if (val.canMutateComptimeVarState(sema.pt.zcu)) { + + const init_val: Value = if (val.getVariable(zcu)) |v| .fromInterned(v.init) else val; + if (init_val.canMutateComptimeVarState(zcu)) { return sema.fail(block, src, "global variable contains reference to comptime var", .{}); } + return val; } @@ -26193,6 +26198,8 @@ fn zirMemcpy(sema: *Sema, block: *Block, inst: Zir.Inst.Index) CompileError!void } try sema.requireRuntimeBlock(block, src, runtime_src); + try sema.validateRuntimeValue(block, dest_src, dest_ptr); + try sema.validateRuntimeValue(block, src_src, src_ptr); // Aliasing safety check. if (block.wantSafety()) { @@ -26321,6 +26328,9 @@ fn zirMemset(sema: *Sema, block: *Block, inst: Zir.Inst.Index) CompileError!void }; try sema.requireRuntimeBlock(block, src, runtime_src); + try sema.validateRuntimeValue(block, dest_src, dest_ptr); + try sema.validateRuntimeValue(block, value_src, elem); + _ = try block.addInst(.{ .tag = if (block.wantSafety()) .memset_safe else .memset, .data = .{ .bin_op = .{ diff --git a/test/cases/compile_errors/comptime_var_referenced_at_runtime.zig b/test/cases/compile_errors/comptime_var_referenced_at_runtime.zig index 30c3b2b850d01296eee659a104c40ba47271d811..2a5868f6b1ee17ed1f1060f35e64c61b1ab002f7 100644 --- a/test/cases/compile_errors/comptime_var_referenced_at_runtime.zig +++ b/test/cases/compile_errors/comptime_var_referenced_at_runtime.zig @@ -47,6 +47,22 @@ export fn qar() void { _ = y; } +export fn bux() void { + comptime var x: [2]u32 = undefined; + x = .{ 1, 2 }; + + var rt: [2]u32 = undefined; + @memcpy(&rt, &x); +} + +export fn far() void { + comptime var x: u32 = 123; + + var rt: [2]*u32 = undefined; + const elem: *u32 = &x; + @memset(&rt, elem); +} + // error // // :5:19: error: runtime value contains reference to comptime var @@ -63,3 +79,7 @@ export fn qar() void { // :41:12: note: comptime var pointers are not available at runtime // :46:39: error: runtime value contains reference to comptime var // :46:39: note: comptime var pointers are not available at runtime +// :55:18: error: runtime value contains reference to comptime var +// :55:18: note: comptime var pointers are not available at runtime +// :63:18: error: runtime value contains reference to comptime var +// :63:18: note: comptime var pointers are not available at runtime diff --git a/test/cases/compile_errors/comptime_var_referenced_by_decl.zig b/test/cases/compile_errors/comptime_var_referenced_by_decl.zig index a5dce623edbd1d01b757aaad6e3d37deffdad4f0..e11af45df3156394540fd3398c08564deb9c846b 100644 --- a/test/cases/compile_errors/comptime_var_referenced_by_decl.zig +++ b/test/cases/compile_errors/comptime_var_referenced_by_decl.zig @@ -38,6 +38,12 @@ export const g: *const *const u32 = g: { break :g &aggregate[0]; }; +// Mutable globals should have the same restrictions as const globals. +export var h: *[1]u32 = h: { + var x: [1]u32 = .{123}; + break :h &x; +}; + // error // // :1:27: error: global variable contains reference to comptime var @@ -47,3 +53,4 @@ export const g: *const *const u32 = g: { // :22:24: error: global variable contains reference to comptime var // :28:33: error: global variable contains reference to comptime var // :34:40: error: global variable contains reference to comptime var +// :42:28: error: global variable contains reference to comptime var