Commit f293fbbeaf6c48e6ce1410743181f89f359eb697 | zig

author	Andrew Kelley <andrew@ziglang.org> 2022-02-10 15:42:57-07:00
committer	Jakub Konka <kubkon@jakubkonka.com> 2022-02-12 11:18:23+01:00
log	f293fbbeaf6c48e6ce1410743181f89f359eb697
tree	a9df71d5e092872e8ba68a03337a03c3481f486b
parent	beb275b371cd50ee1d57528d2792f2f267e6013d

stage2: LLVM backend: adjust replaceAllUsesWith usage

replaceAllUsesWith requires the type to be unchanged. So we bitcast
the new global to the old type and use that as the thing to replace
old uses.

Fixes an LLVM assertion found while troubleshooting #10837.

1 files changed, 5 insertions(+), 1 deletions(-)

src
- codegen
  - llvm.zig

src/codegen/llvm.zig+5-1

 @@ -661,7 +661,11 @@ pub const DeclGen = struct {
                     new_global.setUnnamedAddr(global.getUnnamedAddress());
                     new_global.setAlignment(global.getAlignment());
                     new_global.setInitializer(llvm_init);
-                    global.replaceAllUsesWith(new_global);
+                    // replaceAllUsesWith requires the type to be unchanged. So we bitcast
+                    // the new global to the old type and use that as the thing to replace
+                    // old uses.
+                    const new_global_ptr = new_global.constBitCast(global.typeOf());
+                    global.replaceAllUsesWith(new_global_ptr);
                     dg.object.decl_map.putAssumeCapacity(decl, new_global);
                     new_global.takeName(global);
                     global.deleteGlobal();