authorgravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2026-01-15 21:54:07-05:00
committergravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2026-02-09 10:47:21-05:00
logf2cbc1912b9c58c2a20b9f32fb60b7793f5e4820
tree941d4b75b39f503b1984244e077bd3e1ac0dd317
parenta28d57292f86dfdacf88453509d0b7a1a49443eb

tracy: replace `namedFrame` with `traceNamed`

It is not valid to use frames here because multiple compilations may run concurrently, and a frame with a given name must stop before starting again.

1 files changed, 13 insertions(+), 12 deletions(-)

src/Compilation.zig+13-12
......@@ -21,6 +21,7 @@ const introspect = @import("introspect.zig");
2121const link = @import("link.zig");
2222const tracy = @import("tracy.zig");
2323const trace = tracy.trace;
24const traceNamed = tracy.traceNamed;
2425const build_options = @import("build_options");
2526const LibCInstallation = std.zig.LibCInstallation;
2627const glibc = @import("libs/glibc.zig");
......@@ -4707,8 +4708,8 @@ fn performAllTheWork(
47074708 }
47084709
47094710 if (comp.zcu) |zcu| {
4710 const astgen_frame = tracy.namedFrame("astgen");
4711 defer astgen_frame.end();
4711 const tracy_trace = traceNamed(@src(), "astgen");
4712 defer tracy_trace.end();
47124713
47134714 const zir_prog_node = main_progress_node.start("AST Lowering", 0);
47144715 defer zir_prog_node.end();
......@@ -5221,8 +5222,8 @@ fn processOneJob(tid: Zcu.PerThread.Id, comp: *Compilation, job: Job) JobError!v
52215222 try comp.link_queue.enqueueZcu(comp, tid, .{ .update_line_number = tracked_inst });
52225223 },
52235224 .analyze_func => |func| {
5224 const named_frame = tracy.namedFrame("analyze_func");
5225 defer named_frame.end();
5225 const tracy_trace = traceNamed(@src(), "analyze_func");
5226 defer tracy_trace.end();
52265227
52275228 const pt: Zcu.PerThread = .activate(comp.zcu.?, tid);
52285229 defer pt.deactivate();
......@@ -5234,8 +5235,8 @@ fn processOneJob(tid: Zcu.PerThread.Id, comp: *Compilation, job: Job) JobError!v
52345235 };
52355236 },
52365237 .analyze_comptime_unit => |unit| {
5237 const named_frame = tracy.namedFrame("analyze_comptime_unit");
5238 defer named_frame.end();
5238 const tracy_trace = traceNamed(@src(), "analyze_comptime_unit");
5239 defer tracy_trace.end();
52395240
52405241 const pt: Zcu.PerThread = .activate(comp.zcu.?, tid);
52415242 defer pt.deactivate();
......@@ -5274,8 +5275,8 @@ fn processOneJob(tid: Zcu.PerThread.Id, comp: *Compilation, job: Job) JobError!v
52745275 }
52755276 },
52765277 .resolve_type_fully => |ty| {
5277 const named_frame = tracy.namedFrame("resolve_type_fully");
5278 defer named_frame.end();
5278 const tracy_trace = traceNamed(@src(), "resolve_type_fully");
5279 defer tracy_trace.end();
52795280
52805281 const pt: Zcu.PerThread = .activate(comp.zcu.?, tid);
52815282 defer pt.deactivate();
......@@ -5285,8 +5286,8 @@ fn processOneJob(tid: Zcu.PerThread.Id, comp: *Compilation, job: Job) JobError!v
52855286 };
52865287 },
52875288 .analyze_mod => |mod| {
5288 const named_frame = tracy.namedFrame("analyze_mod");
5289 defer named_frame.end();
5289 const tracy_trace = traceNamed(@src(), "analyze_mod");
5290 defer tracy_trace.end();
52905291
52915292 const pt: Zcu.PerThread = .activate(comp.zcu.?, tid);
52925293 defer pt.deactivate();
......@@ -5296,8 +5297,8 @@ fn processOneJob(tid: Zcu.PerThread.Id, comp: *Compilation, job: Job) JobError!v
52965297 };
52975298 },
52985299 .windows_import_lib => |index| {
5299 const named_frame = tracy.namedFrame("windows_import_lib");
5300 defer named_frame.end();
5300 const tracy_trace = traceNamed(@src(), "windows_import_lib");
5301 defer tracy_trace.end();
53015302
53025303 const link_lib = comp.windows_libs.keys()[index];
53035304 mingw.buildImportLib(comp, link_lib) catch |err| {