authorgravatar for lachlan@lakebythewoods.xyzLachlan Easton <lachlan@lakebythewoods.xyz> 2020-08-31 23:32:42+10:00
committergravatar for lachlan@lakebythewoods.xyzLachlan Easton <lachlan@lakebythewoods.xyz> 2020-08-31 23:39:50+10:00
log029ec456bce5fc6c57eea496db1cebed55e31ede
treeb04ebc1ba122151f53c3da7261a8c109f3ba0ae7
parent5aca3baea62326dee301ec29c567dc224baa4a08

zig fmt: Set indent_delta to 2 when rendering inline asm

3 files changed, 33 insertions(+), 20 deletions(-)

lib/std/io/auto_indenting_stream.zig+24-12
......@@ -13,7 +13,7 @@ pub fn AutoIndentingStream(comptime WriterType: type) type {
1313
1414 writer_pointer: *WriterType,
1515
16 indent_stack: usize = 0,
16 indent_count: usize = 0,
1717 indent_delta: usize,
1818 current_line_empty: bool = true,
1919 indent_one_shot_count: usize = 0, // automatically popped when applied
......@@ -24,9 +24,6 @@ pub fn AutoIndentingStream(comptime WriterType: type) type {
2424 return Self{ .writer_pointer = writer_pointer, .indent_delta = indent_delta };
2525 }
2626
27 /// Release all allocated memory.
28 pub fn deinit(self: Self) void {}
29
3027 pub fn writer(self: *Self) Writer {
3128 return .{ .context = self };
3229 }
......@@ -39,6 +36,21 @@ pub fn AutoIndentingStream(comptime WriterType: type) type {
3936 return self.writeNoIndent(bytes);
4037 }
4138
39 // Change the indent delta without changing the final indentation level
40 pub fn setIndentDelta(self: *Self, indent_delta: usize) void {
41 if (self.indent_delta == indent_delta) {
42 return;
43 } else if (self.indent_delta > indent_delta) {
44 assert(self.indent_delta % indent_delta == 0);
45 self.indent_count = self.indent_count * (self.indent_delta / indent_delta);
46 } else {
47 // assert that the current indentation (in spaces) in a multiple of the new delta
48 assert((self.indent_count * self.indent_delta) % indent_delta == 0);
49 self.indent_count = self.indent_count / (indent_delta / self.indent_delta);
50 }
51 self.indent_delta = indent_delta;
52 }
53
4254 fn writeNoIndent(self: *Self, bytes: []const u8) Error!usize {
4355 if (bytes.len == 0)
4456 return @as(usize, 0);
......@@ -68,7 +80,7 @@ pub fn AutoIndentingStream(comptime WriterType: type) type {
6880 pub fn pushIndent(self: *Self) void {
6981 // Doesn't actually write any indentation.
7082 // Just primes the stream to be able to write the correct indentation if it needs to.
71 self.indent_stack += 1;
83 self.indent_count += 1;
7284 }
7385
7486 /// Push an indent that is automatically popped after being applied
......@@ -92,9 +104,9 @@ pub fn AutoIndentingStream(comptime WriterType: type) type {
92104 }
93105
94106 pub fn popIndent(self: *Self) void {
95 assert(self.indent_stack != 0);
96 self.indent_stack -= 1;
97 self.indent_next_line = std.math.min(self.indent_stack, self.indent_next_line); // Tentative indent may have been popped before there was a newline
107 assert(self.indent_count != 0);
108 self.indent_count -= 1;
109 self.indent_next_line = std.math.min(self.indent_count, self.indent_next_line); // Tentative indent may have been popped before there was a newline
98110 }
99111
100112 /// Writes ' ' bytes if the current line is empty
......@@ -105,7 +117,7 @@ pub fn AutoIndentingStream(comptime WriterType: type) type {
105117 self.applied_indent = current_indent;
106118 }
107119
108 self.indent_stack -= self.indent_one_shot_count;
120 self.indent_count -= self.indent_one_shot_count;
109121 self.indent_one_shot_count = 0;
110122 self.current_line_empty = false;
111123 }
......@@ -118,9 +130,9 @@ pub fn AutoIndentingStream(comptime WriterType: type) type {
118130
119131 fn currentIndent(self: *Self) usize {
120132 var indent_current: usize = 0;
121 if (self.indent_stack > 0) {
122 const stack_top = self.indent_stack - self.indent_next_line;
123 indent_current = stack_top * self.indent_delta;
133 if (self.indent_count > 0) {
134 const indent_count = self.indent_count - self.indent_next_line;
135 indent_current = indent_count * self.indent_delta;
124136 }
125137 return indent_current;
126138 }
lib/std/zig/parser_test.zig+5-5
......@@ -2827,7 +2827,7 @@ test "zig fmt: inline asm" {
28272827 \\ return asm volatile ("syscall"
28282828 \\ : [ret] "={rax}" (-> usize)
28292829 \\ : [number] "{rax}" (number),
2830 \\ [arg1] "{rdi}" (arg1)
2830 \\ [arg1] "{rdi}" (arg1)
28312831 \\ : "rcx", "r11"
28322832 \\ );
28332833 \\}
......@@ -2930,14 +2930,14 @@ test "zig fmt: inline asm parameter alignment" {
29302930 \\ \\ foo
29312931 \\ \\ bar
29322932 \\ : [_] "" (-> usize),
2933 \\ [_] "" (-> usize)
2933 \\ [_] "" (-> usize)
29342934 \\ );
29352935 \\ asm volatile (
29362936 \\ \\ foo
29372937 \\ \\ bar
29382938 \\ :
29392939 \\ : [_] "" (0),
2940 \\ [_] "" (0)
2940 \\ [_] "" (0)
29412941 \\ );
29422942 \\ asm volatile (
29432943 \\ \\ foo
......@@ -2950,9 +2950,9 @@ test "zig fmt: inline asm parameter alignment" {
29502950 \\ \\ foo
29512951 \\ \\ bar
29522952 \\ : [_] "" (-> usize),
2953 \\ [_] "" (-> usize)
2953 \\ [_] "" (-> usize)
29542954 \\ : [_] "" (0),
2955 \\ [_] "" (0)
2955 \\ [_] "" (0)
29562956 \\ : "", ""
29572957 \\ );
29582958 \\}
lib/std/zig/render.zig+4-3
......@@ -11,6 +11,7 @@ const ast = std.zig.ast;
1111const Token = std.zig.Token;
1212
1313const indent_delta = 4;
14const asm_indent_delta = 2;
1415
1516pub const Error = error{
1617 /// Ran out of memory allocating call stack frames to complete rendering.
......@@ -25,7 +26,6 @@ pub fn render(allocator: *mem.Allocator, stream: anytype, tree: *ast.Tree) (meta
2526 var s = stream.*;
2627 var change_detection_stream = std.io.changeDetectionStream(tree.source, &s);
2728 var auto_indenting_stream = std.io.autoIndentingStream(indent_delta, &change_detection_stream);
28 defer auto_indenting_stream.deinit();
2929
3030 try renderRoot(allocator, &auto_indenting_stream, tree);
3131
......@@ -784,7 +784,6 @@ fn renderExpression(
784784 // Null stream for counting the printed length of each expression
785785 var counting_stream = std.io.countingOutStream(std.io.null_out_stream);
786786 var auto_indenting_stream = std.io.autoIndentingStream(indent_delta, &counting_stream);
787 defer auto_indenting_stream.deinit();
788787
789788 for (exprs) |expr, i| {
790789 counting_stream.bytes_written = 0;
......@@ -903,7 +902,6 @@ fn renderExpression(
903902 for (field_inits) |field_init| {
904903 var find_stream = std.io.findByteOutStream('\n', &std.io.null_out_stream);
905904 var auto_indenting_stream = std.io.autoIndentingStream(indent_delta, &find_stream);
906 defer auto_indenting_stream.deinit();
907905
908906 try renderExpression(allocator, &auto_indenting_stream, tree, field_init, Space.None);
909907 if (find_stream.byte_found) break :blk false;
......@@ -1959,6 +1957,9 @@ fn renderExpression(
19591957
19601958 try renderExpression(allocator, stream, tree, asm_node.template, Space.Newline);
19611959
1960 stream.setIndentDelta(asm_indent_delta);
1961 defer stream.setIndentDelta(indent_delta);
1962
19621963 const colon1 = tree.nextToken(asm_node.template.lastToken());
19631964
19641965 const colon2 = if (asm_node.outputs.len == 0) blk: {