authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2019-07-09 13:31:13-04:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2019-07-09 13:31:13-04:00
log038946288cf25e430d1ebfee014847470e0f65ba
treec46475c5da33c3d0e214683ca80db677e3041aca
parentd23798a296ddab023009dab860b6cb9361a62abd
signaturelock-open Commit is signed but in an unrecognized format.

Revert "fixed path with spaces in llvm-config (#2854)"

This reverts commit d23798a296ddab023009dab860b6cb9361a62abd. This caused build problems for several people.

1 files changed, 47 insertions(+), 53 deletions(-)

cmake/Findllvm.cmake+47-53
...@@ -5,15 +5,15 @@...@@ -5,15 +5,15 @@
5# LLVM_FOUND5# LLVM_FOUND
6# LLVM_INCLUDE_DIRS6# LLVM_INCLUDE_DIRS
7# LLVM_LIBRARIES7# LLVM_LIBRARIES
8# LLVM_LIBDIR8# LLVM_LIBDIRS
99
10find_program(LLVM_CONFIG_EXE10find_program(LLVM_CONFIG_EXE
11 NAMES llvm-config-8 llvm-config-8.0 llvm-config80 llvm-config11 NAMES llvm-config-8 llvm-config-8.0 llvm-config80 llvm-config
12 PATHS12 PATHS
13 "/mingw64/bin"13 "/mingw64/bin"
14 "/c/msys64/mingw64/bin"14 "/c/msys64/mingw64/bin"
15 "c:/msys64/mingw64/bin"15 "c:/msys64/mingw64/bin"
16 "C:/Libraries/llvm-8.0.0/bin")16 "C:/Libraries/llvm-8.0.0/bin")
1717
18if ("${LLVM_CONFIG_EXE}" STREQUAL "LLVM_CONFIG_EXE-NOTFOUND")18if ("${LLVM_CONFIG_EXE}" STREQUAL "LLVM_CONFIG_EXE-NOTFOUND")
19 message(FATAL_ERROR "unable to find llvm-config")19 message(FATAL_ERROR "unable to find llvm-config")
...@@ -24,9 +24,9 @@ if ("${LLVM_CONFIG_EXE}" STREQUAL "LLVM_CONFIG_EXE-NOTFOUND")...@@ -24,9 +24,9 @@ if ("${LLVM_CONFIG_EXE}" STREQUAL "LLVM_CONFIG_EXE-NOTFOUND")
24endif()24endif()
2525
26execute_process(26execute_process(
27 COMMAND ${LLVM_CONFIG_EXE} --version27 COMMAND ${LLVM_CONFIG_EXE} --version
28 OUTPUT_VARIABLE LLVM_CONFIG_VERSION28 OUTPUT_VARIABLE LLVM_CONFIG_VERSION
29 OUTPUT_STRIP_TRAILING_WHITESPACE)29 OUTPUT_STRIP_TRAILING_WHITESPACE)
3030
31if("${LLVM_CONFIG_VERSION}" VERSION_LESS 8)31if("${LLVM_CONFIG_VERSION}" VERSION_LESS 8)
32 message(FATAL_ERROR "expected LLVM 8.x but found ${LLVM_CONFIG_VERSION}")32 message(FATAL_ERROR "expected LLVM 8.x but found ${LLVM_CONFIG_VERSION}")
...@@ -39,15 +39,15 @@ if("${LLVM_CONFIG_VERSION}" VERSION_GREATER 9)...@@ -39,15 +39,15 @@ if("${LLVM_CONFIG_VERSION}" VERSION_GREATER 9)
39endif()39endif()
4040
41execute_process(41execute_process(
42 COMMAND ${LLVM_CONFIG_EXE} --targets-built42 COMMAND ${LLVM_CONFIG_EXE} --targets-built
43 OUTPUT_VARIABLE LLVM_TARGETS_BUILT_SPACES43 OUTPUT_VARIABLE LLVM_TARGETS_BUILT_SPACES
44 OUTPUT_STRIP_TRAILING_WHITESPACE)44 OUTPUT_STRIP_TRAILING_WHITESPACE)
45 string(REPLACE " " ";" LLVM_TARGETS_BUILT "${LLVM_TARGETS_BUILT_SPACES}")45string(REPLACE " " ";" LLVM_TARGETS_BUILT "${LLVM_TARGETS_BUILT_SPACES}")
46function(NEED_TARGET TARGET_NAME)46function(NEED_TARGET TARGET_NAME)
47 list (FIND LLVM_TARGETS_BUILT "${TARGET_NAME}" _index)47 list (FIND LLVM_TARGETS_BUILT "${TARGET_NAME}" _index)
48 if (${_index} EQUAL -1)48 if (${_index} EQUAL -1)
49 message(FATAL_ERROR "LLVM is missing target ${TARGET_NAME}. Zig requires LLVM to be built with all default targets enabled.")49 message(FATAL_ERROR "LLVM is missing target ${TARGET_NAME}. Zig requires LLVM to be built with all default targets enabled.")
50 endif()50 endif()
51endfunction(NEED_TARGET)51endfunction(NEED_TARGET)
52NEED_TARGET("AArch64")52NEED_TARGET("AArch64")
53NEED_TARGET("AMDGPU")53NEED_TARGET("AMDGPU")
...@@ -67,53 +67,47 @@ NEED_TARGET("XCore")...@@ -67,53 +67,47 @@ NEED_TARGET("XCore")
6767
68if(NOT(CMAKE_BUILD_TYPE STREQUAL "Debug") OR ZIG_STATIC)68if(NOT(CMAKE_BUILD_TYPE STREQUAL "Debug") OR ZIG_STATIC)
69 execute_process(69 execute_process(
70 COMMAND ${LLVM_CONFIG_EXE} --libdir --link-static70 COMMAND ${LLVM_CONFIG_EXE} --libfiles --link-static
71 OUTPUT_VARIABLE LLVM_LIBDIR_ORIG71 OUTPUT_VARIABLE LLVM_LIBRARIES_SPACES
72 OUTPUT_STRIP_TRAILING_WHITESPACE)72 OUTPUT_STRIP_TRAILING_WHITESPACE)
73 file(TO_CMAKE_PATH "${LLVM_LIBDIR_ORIG}" LLVM_LIBDIR)73 string(REPLACE " " ";" LLVM_LIBRARIES "${LLVM_LIBRARIES_SPACES}")
7474
75 execute_process(75 execute_process(
76 COMMAND ${LLVM_CONFIG_EXE} --libnames --link-static76 COMMAND ${LLVM_CONFIG_EXE} --system-libs --link-static
77 OUTPUT_VARIABLE LLVM_LIBNAMES_SPACES77 OUTPUT_VARIABLE LLVM_SYSTEM_LIBS_SPACES
78 OUTPUT_STRIP_TRAILING_WHITESPACE)78 OUTPUT_STRIP_TRAILING_WHITESPACE)
79 string(REPLACE " " ";" LLVM_LIBNAMES "${LLVM_LIBNAMES_SPACES}")79 string(REPLACE " " ";" LLVM_SYSTEM_LIBS "${LLVM_SYSTEM_LIBS_SPACES}")
80 foreach(LLVM_LIBNAME ${LLVM_LIBNAMES})
81 list(APPEND LLVM_LIBRARIES "${LLVM_LIBDIR}/${LLVM_LIBNAME}")
82 endforeach()
8380
84 execute_process(81 execute_process(
85 COMMAND ${LLVM_CONFIG_EXE} --system-libs --link-static82 COMMAND ${LLVM_CONFIG_EXE} --libdir --link-static
86 OUTPUT_VARIABLE LLVM_SYSTEM_LIBS_SPACES83 OUTPUT_VARIABLE LLVM_LIBDIRS_SPACES
87 OUTPUT_STRIP_TRAILING_WHITESPACE)84 OUTPUT_STRIP_TRAILING_WHITESPACE)
88 string(REPLACE " " ";" LLVM_SYSTEM_LIBS "${LLVM_SYSTEM_LIBS_SPACES}")85 string(REPLACE " " ";" LLVM_LIBDIRS "${LLVM_LIBDIRS_SPACES}")
89endif()86endif()
90if(NOT LLVM_LIBRARIES)87if(NOT LLVM_LIBRARIES)
91 execute_process(88 execute_process(
92 COMMAND ${LLVM_CONFIG_EXE} --libdir89 COMMAND ${LLVM_CONFIG_EXE} --libs
93 OUTPUT_VARIABLE LLVM_LIBDIR_ORIG90 OUTPUT_VARIABLE LLVM_LIBRARIES_SPACES
94 OUTPUT_STRIP_TRAILING_WHITESPACE)91 OUTPUT_STRIP_TRAILING_WHITESPACE)
95 file(TO_CMAKE_PATH "${LLVM_LIBDIR_ORIG}" LLVM_LIBDIR)92 string(REPLACE " " ";" LLVM_LIBRARIES "${LLVM_LIBRARIES_SPACES}")
9693
97 execute_process(94 execute_process(
98 COMMAND ${LLVM_CONFIG_EXE} --libs95 COMMAND ${LLVM_CONFIG_EXE} --system-libs
99 OUTPUT_VARIABLE LLVM_LIBNAMES_SPACES96 OUTPUT_VARIABLE LLVM_SYSTEM_LIBS_SPACES
100 OUTPUT_STRIP_TRAILING_WHITESPACE)97 OUTPUT_STRIP_TRAILING_WHITESPACE)
101 string(REPLACE " " ";" LLVM_LIBNAMES "${LLVM_LIBNAMES_SPACES}")98 string(REPLACE " " ";" LLVM_SYSTEM_LIBS "${LLVM_SYSTEM_LIBS_SPACES}")
102 foreach(LLVM_LIBNAME ${LLVM_LIBNAMES})
103 list(APPEND LLVM_LIBRARIES "${LLVM_LIBDIR}/${LLVM_LIBNAME}")
104 endforeach()
10599
106 execute_process(100 execute_process(
107 COMMAND ${LLVM_CONFIG_EXE} --system-libs101 COMMAND ${LLVM_CONFIG_EXE} --libdir
108 OUTPUT_VARIABLE LLVM_SYSTEM_LIBS_SPACES102 OUTPUT_VARIABLE LLVM_LIBDIRS_SPACES
109 OUTPUT_STRIP_TRAILING_WHITESPACE)103 OUTPUT_STRIP_TRAILING_WHITESPACE)
110 string(REPLACE " " ";" LLVM_SYSTEM_LIBS "${LLVM_SYSTEM_LIBS_SPACES}")104 string(REPLACE " " ";" LLVM_LIBDIRS "${LLVM_LIBDIRS_SPACES}")
111endif()105endif()
112106
113execute_process(107execute_process(
114 COMMAND ${LLVM_CONFIG_EXE} --includedir108 COMMAND ${LLVM_CONFIG_EXE} --includedir
115 OUTPUT_VARIABLE LLVM_INCLUDE_DIRS109 OUTPUT_VARIABLE LLVM_INCLUDE_DIRS
116 OUTPUT_STRIP_TRAILING_WHITESPACE)110 OUTPUT_STRIP_TRAILING_WHITESPACE)
117111
118set(LLVM_LIBRARIES ${LLVM_LIBRARIES} ${LLVM_SYSTEM_LIBS})112set(LLVM_LIBRARIES ${LLVM_LIBRARIES} ${LLVM_SYSTEM_LIBS})
119113
...@@ -122,9 +116,9 @@ if(NOT LLVM_LIBRARIES)...@@ -122,9 +116,9 @@ if(NOT LLVM_LIBRARIES)
122endif()116endif()
123117
124link_directories("${CMAKE_PREFIX_PATH}/lib")118link_directories("${CMAKE_PREFIX_PATH}/lib")
125link_directories("${LLVM_LIBDIR}")119link_directories("${LLVM_LIBDIRS}")
126120
127include(FindPackageHandleStandardArgs)121include(FindPackageHandleStandardArgs)
128find_package_handle_standard_args(LLVM DEFAULT_MSG LLVM_LIBRARIES LLVM_INCLUDE_DIRS)122find_package_handle_standard_args(LLVM DEFAULT_MSG LLVM_LIBRARIES LLVM_INCLUDE_DIRS)
129123
130mark_as_advanced(LLVM_INCLUDE_DIRS LLVM_LIBRARIES LLVM_LIBDIR)124mark_as_advanced(LLVM_INCLUDE_DIRS LLVM_LIBRARIES LLVM_LIBDIRS)