authorgravatar for 124872+jedisct1@users.noreply.github.comFrank Denis <124872+jedisct1@users.noreply.github.com> 2026-10-23 15:38:13+02:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2026-10-24 23:04:43+02:00
log09ee89a89ce3e2a04021695e92893fc4e507c7e6
treef4701b26dde7c674cb3ce236a1c1cbb5a9f6036c
parent3bb0056d60f64b1d2bfdb029d61c8a107afe212a

cbe: Fix @reduce(.Add) and @reduce(.Mul) with narrow integers

For integers up to 64 bits, the generated code used += and *=, but the C type might be bigger than the Zig type. For example, a sum or product of u1, u7 or i3 integers would end up out of range. Fix this by using zig_addw and zig_mulw if the integer bit width doesn't match the C type.

2 files changed, 5 insertions(+), 2 deletions(-)

src/codegen/c.zig+3-2
......@@ -6875,6 +6875,7 @@ fn airReduce(f: *Function, inst: Air.Inst.Index) !CValue {
68756875 },
68766876 .big => .{ false, true },
68776877 } else .{ false, false };
6878 const operator_wraps = use_operator and scalar_ty.intInfo(zcu).bits == 8 * scalar_ty.abiSize(zcu);
68786879 const op: union(enum) {
68796880 const Func = struct { operation: []const u8, info: BuiltinInfo = .none };
68806881 builtin: Func,
......@@ -6895,12 +6896,12 @@ fn airReduce(f: *Function, inst: Air.Inst.Index) !CValue {
68956896 else => unreachable,
68966897 },
68976898 .Add => switch (scalar_ty.zigTypeTag(zcu)) {
6898 .int => if (use_operator) .{ .infix = " += " } else .{ .builtin = .{ .operation = "addw", .info = .bits } },
6899 .int => if (operator_wraps) .{ .infix = " += " } else .{ .builtin = .{ .operation = "addw", .info = .bits } },
68996900 .float => .{ .builtin = .{ .operation = "add" } },
69006901 else => unreachable,
69016902 },
69026903 .Mul => switch (scalar_ty.zigTypeTag(zcu)) {
6903 .int => if (use_operator) .{ .infix = " *= " } else .{ .builtin = .{ .operation = "mulw", .info = .bits } },
6904 .int => if (operator_wraps) .{ .infix = " *= " } else .{ .builtin = .{ .operation = "mulw", .info = .bits } },
69046905 .float => .{ .builtin = .{ .operation = "mul" } },
69056906 else => unreachable,
69066907 },
test/behavior/vector.zig+2
......@@ -969,6 +969,7 @@ test "vector reduce operation" {
969969 try testReduce(.Add, [4]u64{ 9, 99, 999, 9999 }, @as(u64, 11106));
970970 try testReduce(.Add, [4]i128{ -9, -99, -999, -9999 }, @as(i128, -11106));
971971 try testReduce(.Add, [4]u128{ 9, 99, 999, 9999 }, @as(u128, 11106));
972 try testReduce(.Add, [4]u7{ 100, 100, 0, 0 }, @as(u7, 72));
972973 try testReduce(.Add, [4]f16{ -1.9, 5.1, -60.3, 100.0 }, @as(f16, 42.9));
973974 try testReduce(.Add, [4]f32{ -1.9, 5.1, -60.3, 100.0 }, @as(f32, 42.9));
974975 try testReduce(.Add, [4]f64{ -1.9, 5.1, -60.3, 100.0 }, @as(f64, 42.9));
......@@ -1017,6 +1018,7 @@ test "vector reduce operation" {
10171018 try testReduce(.Mul, [4]u64{ 9, 99, 999, 9999 }, @as(u64, 8900199891));
10181019 try testReduce(.Mul, [4]i128{ -9, -99, -999, 9999 }, @as(i128, -8900199891));
10191020 try testReduce(.Mul, [4]u128{ 9, 99, 999, 9999 }, @as(u128, 8900199891));
1021 try testReduce(.Mul, [4]i3{ 3, 2, 1, 1 }, @as(i3, -2));
10201022 try testReduce(.Mul, [4]f16{ -1.9, 5.1, -60.3, 100.0 }, @as(f16, 58430.7));
10211023 try testReduce(.Mul, [4]f32{ -1.9, 5.1, -60.3, 100.0 }, @as(f32, 58430.7));
10221024 try testReduce(.Mul, [4]f64{ -1.9, 5.1, -60.3, 100.0 }, @as(f64, 58430.7));