authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2021-09-20 20:56:30-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2021-09-20 20:56:30-07:00
log0c74ce1156d6a967cd089cd4657575a3e22bb782
treea95896bf83bb427953a6a33d037698e30c05d8f8
parent55e7c099caa7cf8dc253dac21765bb994e06b741

Sema: fix double-free of `@cImport` error message


1 files changed, 17 insertions(+), 13 deletions(-)

src/Sema.zig+17-13
......@@ -83,6 +83,7 @@ const Decl = Module.Decl;
8383const LazySrcLoc = Module.LazySrcLoc;
8484const RangeSet = @import("RangeSet.zig");
8585const target_util = @import("target.zig");
86const Package = @import("Package.zig");
8687
8788pub const InstMap = std.AutoHashMapUnmanaged(Zir.Inst.Index, Air.Inst.Ref);
8889
......@@ -2167,23 +2168,26 @@ fn zirCImport(sema: *Sema, parent_block: *Scope.Block, inst: Zir.Inst.Index) Com
21672168 return sema.mod.fail(&child_block.base, src, "C import failed: {s}", .{@errorName(err)});
21682169
21692170 if (c_import_res.errors.len != 0) {
2170 const msg = try sema.mod.errMsg(&child_block.base, src, "C import failed", .{});
2171 errdefer msg.destroy(sema.gpa);
2171 const msg = msg: {
2172 const msg = try sema.mod.errMsg(&child_block.base, src, "C import failed", .{});
2173 errdefer msg.destroy(sema.gpa);
21722174
2173 if (!sema.mod.comp.bin_file.options.link_libc)
2174 try sema.mod.errNote(&child_block.base, src, msg, "libc headers not available; compilation does not link against libc", .{});
2175 if (!sema.mod.comp.bin_file.options.link_libc)
2176 try sema.mod.errNote(&child_block.base, src, msg, "libc headers not available; compilation does not link against libc", .{});
21752177
2176 for (c_import_res.errors) |_| {
2177 // TODO integrate with LazySrcLoc
2178 // try sema.mod.errNoteNonLazy(.{}, msg, "{s}", .{clang_err.msg_ptr[0..clang_err.msg_len]});
2179 // if (clang_err.filename_ptr) |p| p[0..clang_err.filename_len] else "(no file)",
2180 // clang_err.line + 1,
2181 // clang_err.column + 1,
2182 }
2183 @import("clang.zig").Stage2ErrorMsg.delete(c_import_res.errors.ptr, c_import_res.errors.len);
2178 for (c_import_res.errors) |_| {
2179 // TODO integrate with LazySrcLoc
2180 // try sema.mod.errNoteNonLazy(.{}, msg, "{s}", .{clang_err.msg_ptr[0..clang_err.msg_len]});
2181 // if (clang_err.filename_ptr) |p| p[0..clang_err.filename_len] else "(no file)",
2182 // clang_err.line + 1,
2183 // clang_err.column + 1,
2184 }
2185 @import("clang.zig").Stage2ErrorMsg.delete(c_import_res.errors.ptr, c_import_res.errors.len);
2186 break :msg msg;
2187 };
21842188 return sema.mod.failWithOwnedErrorMsg(&child_block.base, msg);
21852189 }
2186 const c_import_pkg = @import("Package.zig").create(
2190 const c_import_pkg = Package.create(
21872191 sema.gpa,
21882192 null,
21892193 c_import_res.out_zig_path,