authorgravatar for mlugg@mlugg.co.ukMatthew Lugg <mlugg@mlugg.co.uk> 2023-05-29 20:31:09+01:00
committergravatar for mlugg@mlugg.co.ukMatthew Lugg <mlugg@mlugg.co.uk> 2023-05-29 23:06:11+01:00
log0f58d34ef7935dd9877f4969ed6ec7d582cd104c
treebaefd3d15dbdc8962c318ccd62d3a5ad436d6180
parent4976b58ab16069f8d3267b69ed030f29685c1abe
signaturelock-open Commit is signed but in an unrecognized format.

tests: disable incremental cases for now

These were failing on the prior commit. Unfortunately, the fix would have been relatively complicated, and ties into underlying issues with the current incremental compilation logic. After discussing this with Andrew, we agreed that the best course of action is to completely disable incremental compilation tests for now until it's more mature, at which point we can re-enable them.

1 files changed, 7 insertions(+), 0 deletions(-)

test/src/Cases.zig+7
...@@ -468,6 +468,13 @@ pub fn lowerToBuildSteps(...@@ -468,6 +468,13 @@ pub fn lowerToBuildSteps(
468 incremental_exe: *std.Build.Step.Compile,468 incremental_exe: *std.Build.Step.Compile,
469) void {469) void {
470 for (self.incremental_cases.items) |incr_case| {470 for (self.incremental_cases.items) |incr_case| {
471 if (true) {
472 // TODO: incremental tests are disabled for now, as incremental compilation bugs were
473 // getting in the way of practical improvements to the compiler, and incremental
474 // compilation is not currently used. They should be re-enabled once incremental
475 // compilation is in a happier state.
476 continue;
477 }
471 if (opt_test_filter) |test_filter| {478 if (opt_test_filter) |test_filter| {
472 if (std.mem.indexOf(u8, incr_case.base_path, test_filter) == null) continue;479 if (std.mem.indexOf(u8, incr_case.base_path, test_filter) == null) continue;
473 }480 }