| author | |
| committer | |
| log | 0feacc2b81679514c0168a6ba4c0decafeb2e43e |
| tree | ecd0b572273020af3b27f3d2e1ae65e07c39f12d |
| parent | 26825e95066c104585d248787c0e56ce4e8413e0 |
Adds the limit option to `--fuzz=[limit]`. the limit expresses a number
of iterations that *each fuzz test* will perform at maximum before
exiting. The limit argument supports also 'K', 'M', and 'G' suffixeds
(e.g. '10K').
Does not imply `--web-ui` (like unlimited fuzzing does) and prints a
fuzzing report at the end.
Closes #22900 but does not implement the time based limit, as after
internal discussions we concluded to be problematic to both implement
and use correctly.9 files changed, 407 insertions(+), 73 deletions(-)
lib/compiler/build_runner.zig+84-6| ... | @@ -112,7 +112,7 @@ pub fn main() !void { | ... | @@ -112,7 +112,7 @@ pub fn main() !void { |
| 112 | var steps_menu = false; | 112 | var steps_menu = false; |
| 113 | var output_tmp_nonce: ?[16]u8 = null; | 113 | var output_tmp_nonce: ?[16]u8 = null; |
| 114 | var watch = false; | 114 | var watch = false; |
| 115 | var fuzz = false; | 115 | var fuzz: ?std.Build.Fuzz.Mode = null; |
| 116 | var debounce_interval_ms: u16 = 50; | 116 | var debounce_interval_ms: u16 = 50; |
| 117 | var webui_listen: ?std.net.Address = null; | 117 | var webui_listen: ?std.net.Address = null; |
| 118 | 118 | ||
| ... | @@ -274,10 +274,44 @@ pub fn main() !void { | ... | @@ -274,10 +274,44 @@ pub fn main() !void { |
| 274 | webui_listen = std.net.Address.parseIp("::1", 0) catch unreachable; | 274 | webui_listen = std.net.Address.parseIp("::1", 0) catch unreachable; |
| 275 | } | 275 | } |
| 276 | } else if (mem.eql(u8, arg, "--fuzz")) { | 276 | } else if (mem.eql(u8, arg, "--fuzz")) { |
| 277 | fuzz = true; | 277 | fuzz = .{ .forever = undefined }; |
| 278 | if (webui_listen == null) { | 278 | if (webui_listen == null) { |
| 279 | webui_listen = std.net.Address.parseIp("::1", 0) catch unreachable; | 279 | webui_listen = std.net.Address.parseIp("::1", 0) catch unreachable; |
| 280 | } | 280 | } |
| 281 | } else if (mem.startsWith(u8, arg, "--fuzz=")) { | ||
| 282 | const value = arg["--fuzz=".len..]; | ||
| 283 | if (value.len == 0) fatal("missing argument to --fuzz\n", .{}); | ||
| 284 | |||
| 285 | const unit: u8 = value[value.len - 1]; | ||
| 286 | const digits = switch (value[value.len - 1]) { | ||
| 287 | '0'...'9' => value, | ||
| 288 | 'K', 'M', 'G' => value[0 .. value.len - 1], | ||
| 289 | else => fatal( | ||
| 290 | "invalid argument to --fuzz, expected a positive number optionally suffixed by one of: [KMG]\n", | ||
| 291 | .{}, | ||
| 292 | ), | ||
| 293 | }; | ||
| 294 | |||
| 295 | const amount = std.fmt.parseInt(u64, digits, 10) catch { | ||
| 296 | fatal( | ||
| 297 | "invalid argument to --fuzz, expected a positive number optionally suffixed by one of: [KMG]\n", | ||
| 298 | .{}, | ||
| 299 | ); | ||
| 300 | }; | ||
| 301 | |||
| 302 | const normalized_amount = std.math.mul(u64, amount, switch (unit) { | ||
| 303 | else => unreachable, | ||
| 304 | '0'...'9' => 1, | ||
| 305 | 'K' => 1000, | ||
| 306 | 'M' => 1_000_000, | ||
| 307 | 'G' => 1_000_000_000, | ||
| 308 | }) catch fatal("fuzzing limit amount overflows u64\n", .{}); | ||
| 309 | |||
| 310 | fuzz = .{ | ||
| 311 | .limit = .{ | ||
| 312 | .amount = normalized_amount, | ||
| 313 | }, | ||
| 314 | }; | ||
| 281 | } else if (mem.eql(u8, arg, "-fincremental")) { | 315 | } else if (mem.eql(u8, arg, "-fincremental")) { |
| 282 | graph.incremental = true; | 316 | graph.incremental = true; |
| 283 | } else if (mem.eql(u8, arg, "-fno-incremental")) { | 317 | } else if (mem.eql(u8, arg, "-fno-incremental")) { |
| ... | @@ -476,6 +510,7 @@ pub fn main() !void { | ... | @@ -476,6 +510,7 @@ pub fn main() !void { |
| 476 | targets.items, | 510 | targets.items, |
| 477 | main_progress_node, | 511 | main_progress_node, |
| 478 | &run, | 512 | &run, |
| 513 | fuzz, | ||
| 479 | ) catch |err| switch (err) { | 514 | ) catch |err| switch (err) { |
| 480 | error.UncleanExit => { | 515 | error.UncleanExit => { |
| 481 | assert(!run.watch and run.web_server == null); | 516 | assert(!run.watch and run.web_server == null); |
| ... | @@ -485,7 +520,8 @@ pub fn main() !void { | ... | @@ -485,7 +520,8 @@ pub fn main() !void { |
| 485 | }; | 520 | }; |
| 486 | 521 | ||
| 487 | if (run.web_server) |*web_server| { | 522 | if (run.web_server) |*web_server| { |
| 488 | web_server.finishBuild(.{ .fuzz = fuzz }); | 523 | if (fuzz) |mode| assert(mode == .forever); |
| 524 | web_server.finishBuild(.{ .fuzz = fuzz != null }); | ||
| 489 | } | 525 | } |
| 490 | 526 | ||
| 491 | if (!watch and run.web_server == null) { | 527 | if (!watch and run.web_server == null) { |
| ... | @@ -651,6 +687,7 @@ fn runStepNames( | ... | @@ -651,6 +687,7 @@ fn runStepNames( |
| 651 | step_names: []const []const u8, | 687 | step_names: []const []const u8, |
| 652 | parent_prog_node: std.Progress.Node, | 688 | parent_prog_node: std.Progress.Node, |
| 653 | run: *Run, | 689 | run: *Run, |
| 690 | fuzz: ?std.Build.Fuzz.Mode, | ||
| 654 | ) !void { | 691 | ) !void { |
| 655 | const gpa = run.gpa; | 692 | const gpa = run.gpa; |
| 656 | const step_stack = &run.step_stack; | 693 | const step_stack = &run.step_stack; |
| ... | @@ -676,6 +713,7 @@ fn runStepNames( | ... | @@ -676,6 +713,7 @@ fn runStepNames( |
| 676 | }); | 713 | }); |
| 677 | } | 714 | } |
| 678 | } | 715 | } |
| 716 | |||
| 679 | assert(run.memory_blocked_steps.items.len == 0); | 717 | assert(run.memory_blocked_steps.items.len == 0); |
| 680 | 718 | ||
| 681 | var test_skip_count: usize = 0; | 719 | var test_skip_count: usize = 0; |
| ... | @@ -724,6 +762,45 @@ fn runStepNames( | ... | @@ -724,6 +762,45 @@ fn runStepNames( |
| 724 | } | 762 | } |
| 725 | } | 763 | } |
| 726 | 764 | ||
| 765 | const ttyconf = run.ttyconf; | ||
| 766 | |||
| 767 | if (fuzz) |mode| blk: { | ||
| 768 | switch (builtin.os.tag) { | ||
| 769 | // Current implementation depends on two things that need to be ported to Windows: | ||
| 770 | // * Memory-mapping to share data between the fuzzer and build runner. | ||
| 771 | // * COFF/PE support added to `std.debug.Info` (it needs a batching API for resolving | ||
| 772 | // many addresses to source locations). | ||
| 773 | .windows => fatal("--fuzz not yet implemented for {s}", .{@tagName(builtin.os.tag)}), | ||
| 774 | else => {}, | ||
| 775 | } | ||
| 776 | if (@bitSizeOf(usize) != 64) { | ||
| 777 | // Current implementation depends on posix.mmap()'s second parameter, `length: usize`, | ||
| 778 | // being compatible with `std.fs.getEndPos() u64`'s return value. This is not the case | ||
| 779 | // on 32-bit platforms. | ||
| 780 | // Affects or affected by issues #5185, #22523, and #22464. | ||
| 781 | fatal("--fuzz not yet implemented on {d}-bit platforms", .{@bitSizeOf(usize)}); | ||
| 782 | } | ||
| 783 | |||
| 784 | switch (mode) { | ||
| 785 | .forever => break :blk, | ||
| 786 | .limit => {}, | ||
| 787 | } | ||
| 788 | |||
| 789 | assert(mode == .limit); | ||
| 790 | var f = std.Build.Fuzz.init( | ||
| 791 | gpa, | ||
| 792 | thread_pool, | ||
| 793 | step_stack.keys(), | ||
| 794 | parent_prog_node, | ||
| 795 | ttyconf, | ||
| 796 | mode, | ||
| 797 | ) catch |err| fatal("failed to start fuzzer: {s}", .{@errorName(err)}); | ||
| 798 | defer f.deinit(); | ||
| 799 | |||
| 800 | f.start(); | ||
| 801 | f.waitAndPrintReport(); | ||
| 802 | } | ||
| 803 | |||
| 727 | // A proper command line application defaults to silently succeeding. | 804 | // A proper command line application defaults to silently succeeding. |
| 728 | // The user may request verbose mode if they have a different preference. | 805 | // The user may request verbose mode if they have a different preference. |
| 729 | const failures_only = switch (run.summary) { | 806 | const failures_only = switch (run.summary) { |
| ... | @@ -737,8 +814,6 @@ fn runStepNames( | ... | @@ -737,8 +814,6 @@ fn runStepNames( |
| 737 | std.Progress.setStatus(.failure); | 814 | std.Progress.setStatus(.failure); |
| 738 | } | 815 | } |
| 739 | 816 | ||
| 740 | const ttyconf = run.ttyconf; | ||
| 741 | |||
| 742 | if (run.summary != .none) { | 817 | if (run.summary != .none) { |
| 743 | const w = std.debug.lockStderrWriter(&stdio_buffer_allocation); | 818 | const w = std.debug.lockStderrWriter(&stdio_buffer_allocation); |
| 744 | defer std.debug.unlockStderrWriter(); | 819 | defer std.debug.unlockStderrWriter(); |
| ... | @@ -1366,7 +1441,10 @@ fn printUsage(b: *std.Build, w: *Writer) !void { | ... | @@ -1366,7 +1441,10 @@ fn printUsage(b: *std.Build, w: *Writer) !void { |
| 1366 | \\ --watch Continuously rebuild when source files are modified | 1441 | \\ --watch Continuously rebuild when source files are modified |
| 1367 | \\ --debounce <ms> Delay before rebuilding after changed file detected | 1442 | \\ --debounce <ms> Delay before rebuilding after changed file detected |
| 1368 | \\ --webui[=ip] Enable the web interface on the given IP address | 1443 | \\ --webui[=ip] Enable the web interface on the given IP address |
| 1369 | \\ --fuzz Continuously search for unit test failures (implies '--webui') | 1444 | \\ --fuzz[=limit] Continuously search for unit test failures with an optional |
| 1445 | \\ limit to the max number of iterations. The argument supports | ||
| 1446 | \\ an optional 'K', 'M', or 'G' suffix (e.g. '10K'). Implies | ||
| 1447 | \\ '--webui' when no limit is specified. | ||
| 1370 | \\ --time-report Force full rebuild and provide detailed information on | 1448 | \\ --time-report Force full rebuild and provide detailed information on |
| 1371 | \\ compilation time of Zig source code (implies '--webui') | 1449 | \\ compilation time of Zig source code (implies '--webui') |
| 1372 | \\ -fincremental Enable incremental compilation | 1450 | \\ -fincremental Enable incremental compilation |
lib/compiler/test_runner.zig+74-5| ... | @@ -2,6 +2,7 @@ | ... | @@ -2,6 +2,7 @@ |
| 2 | const builtin = @import("builtin"); | 2 | const builtin = @import("builtin"); |
| 3 | 3 | ||
| 4 | const std = @import("std"); | 4 | const std = @import("std"); |
| 5 | const fatal = std.process.fatal; | ||
| 5 | const testing = std.testing; | 6 | const testing = std.testing; |
| 6 | const assert = std.debug.assert; | 7 | const assert = std.debug.assert; |
| 7 | const fuzz_abi = std.Build.abi.fuzz; | 8 | const fuzz_abi = std.Build.abi.fuzz; |
| ... | @@ -62,13 +63,13 @@ pub fn main() void { | ... | @@ -62,13 +63,13 @@ pub fn main() void { |
| 62 | } | 63 | } |
| 63 | 64 | ||
| 64 | if (listen) { | 65 | if (listen) { |
| 65 | return mainServer() catch @panic("internal test runner failure"); | 66 | return mainServer(opt_cache_dir) catch @panic("internal test runner failure"); |
| 66 | } else { | 67 | } else { |
| 67 | return mainTerminal(); | 68 | return mainTerminal(); |
| 68 | } | 69 | } |
| 69 | } | 70 | } |
| 70 | 71 | ||
| 71 | fn mainServer() !void { | 72 | fn mainServer(opt_cache_dir: ?[]const u8) !void { |
| 72 | @disableInstrumentation(); | 73 | @disableInstrumentation(); |
| 73 | var stdin_reader = std.fs.File.stdin().readerStreaming(&stdin_buffer); | 74 | var stdin_reader = std.fs.File.stdin().readerStreaming(&stdin_buffer); |
| 74 | var stdout_writer = std.fs.File.stdout().writerStreaming(&stdout_buffer); | 75 | var stdout_writer = std.fs.File.stdout().writerStreaming(&stdout_buffer); |
| ... | @@ -78,9 +79,66 @@ fn mainServer() !void { | ... | @@ -78,9 +79,66 @@ fn mainServer() !void { |
| 78 | .zig_version = builtin.zig_version_string, | 79 | .zig_version = builtin.zig_version_string, |
| 79 | }); | 80 | }); |
| 80 | 81 | ||
| 81 | if (builtin.fuzz) { | 82 | if (builtin.fuzz) blk: { |
| 83 | const cache_dir = opt_cache_dir.?; | ||
| 82 | const coverage_id = fuzz_abi.fuzzer_coverage_id(); | 84 | const coverage_id = fuzz_abi.fuzzer_coverage_id(); |
| 83 | try server.serveU64Message(.coverage_id, coverage_id); | 85 | const coverage_file_path: std.Build.Cache.Path = .{ |
| 86 | .root_dir = .{ | ||
| 87 | .path = cache_dir, | ||
| 88 | .handle = std.fs.cwd().openDir(cache_dir, .{}) catch |err| { | ||
| 89 | if (err == error.FileNotFound) { | ||
| 90 | try server.serveCoverageIdMessage(coverage_id, 0, 0, 0); | ||
| 91 | break :blk; | ||
| 92 | } | ||
| 93 | |||
| 94 | fatal("failed to access cache dir '{s}': {s}", .{ | ||
| 95 | cache_dir, @errorName(err), | ||
| 96 | }); | ||
| 97 | }, | ||
| 98 | }, | ||
| 99 | .sub_path = "v/" ++ std.fmt.hex(coverage_id), | ||
| 100 | }; | ||
| 101 | |||
| 102 | var coverage_file = coverage_file_path.root_dir.handle.openFile(coverage_file_path.sub_path, .{}) catch |err| { | ||
| 103 | if (err == error.FileNotFound) { | ||
| 104 | try server.serveCoverageIdMessage(coverage_id, 0, 0, 0); | ||
| 105 | break :blk; | ||
| 106 | } | ||
| 107 | |||
| 108 | fatal("failed to load coverage file '{f}': {s}", .{ | ||
| 109 | coverage_file_path, @errorName(err), | ||
| 110 | }); | ||
| 111 | }; | ||
| 112 | defer coverage_file.close(); | ||
| 113 | |||
| 114 | var rbuf: [0x1000]u8 = undefined; | ||
| 115 | var r = coverage_file.reader(&rbuf); | ||
| 116 | |||
| 117 | var header: fuzz_abi.SeenPcsHeader = undefined; | ||
| 118 | r.interface.readSliceAll(std.mem.asBytes(&header)) catch |err| { | ||
| 119 | fatal("failed to read from coverage file '{f}': {s}", .{ | ||
| 120 | coverage_file_path, @errorName(err), | ||
| 121 | }); | ||
| 122 | }; | ||
| 123 | |||
| 124 | if (header.pcs_len == 0) { | ||
| 125 | fatal("corrupted coverage file '{f}': pcs_len was zero", .{ | ||
| 126 | coverage_file_path, | ||
| 127 | }); | ||
| 128 | } | ||
| 129 | |||
| 130 | var seen_count: usize = 0; | ||
| 131 | const chunk_count = fuzz_abi.SeenPcsHeader.seenElemsLen(header.pcs_len); | ||
| 132 | for (0..chunk_count) |_| { | ||
| 133 | const seen = r.interface.takeInt(usize, .little) catch |err| { | ||
| 134 | fatal("failed to read from coverage file '{f}': {s}", .{ | ||
| 135 | coverage_file_path, @errorName(err), | ||
| 136 | }); | ||
| 137 | }; | ||
| 138 | seen_count += @popCount(seen); | ||
| 139 | } | ||
| 140 | |||
| 141 | try server.serveCoverageIdMessage(coverage_id, header.n_runs, header.unique_runs, seen_count); | ||
| 84 | } | 142 | } |
| 85 | 143 | ||
| 86 | while (true) { | 144 | while (true) { |
| ... | @@ -158,6 +216,9 @@ fn mainServer() !void { | ... | @@ -158,6 +216,9 @@ fn mainServer() !void { |
| 158 | if (!builtin.fuzz) unreachable; | 216 | if (!builtin.fuzz) unreachable; |
| 159 | 217 | ||
| 160 | const index = try server.receiveBody_u32(); | 218 | const index = try server.receiveBody_u32(); |
| 219 | const mode: fuzz_abi.LimitKind = @enumFromInt(try server.receiveBody_u8()); | ||
| 220 | const amount_or_instance = try server.receiveBody_u64(); | ||
| 221 | |||
| 161 | const test_fn = builtin.test_functions[index]; | 222 | const test_fn = builtin.test_functions[index]; |
| 162 | const entry_addr = @intFromPtr(test_fn.func); | 223 | const entry_addr = @intFromPtr(test_fn.func); |
| 163 | 224 | ||
| ... | @@ -165,6 +226,8 @@ fn mainServer() !void { | ... | @@ -165,6 +226,8 @@ fn mainServer() !void { |
| 165 | defer if (testing.allocator_instance.deinit() == .leak) std.process.exit(1); | 226 | defer if (testing.allocator_instance.deinit() == .leak) std.process.exit(1); |
| 166 | is_fuzz_test = false; | 227 | is_fuzz_test = false; |
| 167 | fuzz_test_index = index; | 228 | fuzz_test_index = index; |
| 229 | fuzz_mode = mode; | ||
| 230 | fuzz_amount_or_instance = amount_or_instance; | ||
| 168 | 231 | ||
| 169 | test_fn.func() catch |err| switch (err) { | 232 | test_fn.func() catch |err| switch (err) { |
| 170 | error.SkipZigTest => return, | 233 | error.SkipZigTest => return, |
| ... | @@ -178,6 +241,8 @@ fn mainServer() !void { | ... | @@ -178,6 +241,8 @@ fn mainServer() !void { |
| 178 | }; | 241 | }; |
| 179 | if (!is_fuzz_test) @panic("missed call to std.testing.fuzz"); | 242 | if (!is_fuzz_test) @panic("missed call to std.testing.fuzz"); |
| 180 | if (log_err_count != 0) @panic("error logs detected"); | 243 | if (log_err_count != 0) @panic("error logs detected"); |
| 244 | assert(mode != .forever); | ||
| 245 | std.process.exit(0); | ||
| 181 | }, | 246 | }, |
| 182 | 247 | ||
| 183 | else => { | 248 | else => { |
| ... | @@ -343,6 +408,8 @@ pub fn mainSimple() anyerror!void { | ... | @@ -343,6 +408,8 @@ pub fn mainSimple() anyerror!void { |
| 343 | 408 | ||
| 344 | var is_fuzz_test: bool = undefined; | 409 | var is_fuzz_test: bool = undefined; |
| 345 | var fuzz_test_index: u32 = undefined; | 410 | var fuzz_test_index: u32 = undefined; |
| 411 | var fuzz_mode: fuzz_abi.LimitKind = undefined; | ||
| 412 | var fuzz_amount_or_instance: u64 = undefined; | ||
| 346 | 413 | ||
| 347 | pub fn fuzz( | 414 | pub fn fuzz( |
| 348 | context: anytype, | 415 | context: anytype, |
| ... | @@ -401,9 +468,11 @@ pub fn fuzz( | ... | @@ -401,9 +468,11 @@ pub fn fuzz( |
| 401 | 468 | ||
| 402 | global.ctx = context; | 469 | global.ctx = context; |
| 403 | fuzz_abi.fuzzer_init_test(&global.test_one, .fromSlice(builtin.test_functions[fuzz_test_index].name)); | 470 | fuzz_abi.fuzzer_init_test(&global.test_one, .fromSlice(builtin.test_functions[fuzz_test_index].name)); |
| 471 | |||
| 404 | for (options.corpus) |elem| | 472 | for (options.corpus) |elem| |
| 405 | fuzz_abi.fuzzer_new_input(.fromSlice(elem)); | 473 | fuzz_abi.fuzzer_new_input(.fromSlice(elem)); |
| 406 | fuzz_abi.fuzzer_main(); | 474 | |
| 475 | fuzz_abi.fuzzer_main(fuzz_mode, fuzz_amount_or_instance); | ||
| 407 | return; | 476 | return; |
| 408 | } | 477 | } |
| 409 | 478 |
lib/fuzzer.zig+4-3| ... | @@ -600,9 +600,10 @@ export fn fuzzer_new_input(bytes: abi.Slice) void { | ... | @@ -600,9 +600,10 @@ export fn fuzzer_new_input(bytes: abi.Slice) void { |
| 600 | } | 600 | } |
| 601 | 601 | ||
| 602 | /// fuzzer_init_test must be called first | 602 | /// fuzzer_init_test must be called first |
| 603 | export fn fuzzer_main() void { | 603 | export fn fuzzer_main(limit_kind: abi.LimitKind, amount: u64) void { |
| 604 | while (true) { | 604 | switch (limit_kind) { |
| 605 | fuzzer.cycle(); | 605 | .forever => while (true) fuzzer.cycle(), |
| 606 | .iterations => for (0..amount -| 1) |_| fuzzer.cycle(), | ||
| 606 | } | 607 | } |
| 607 | } | 608 | } |
| 608 | 609 |
lib/std/Build/Fuzz.zig+154-42| ... | @@ -8,17 +8,22 @@ const Allocator = std.mem.Allocator; | ... | @@ -8,17 +8,22 @@ const Allocator = std.mem.Allocator; |
| 8 | const log = std.log; | 8 | const log = std.log; |
| 9 | const Coverage = std.debug.Coverage; | 9 | const Coverage = std.debug.Coverage; |
| 10 | const abi = Build.abi.fuzz; | 10 | const abi = Build.abi.fuzz; |
| 11 | const tty = std.Io.tty; | ||
| 11 | 12 | ||
| 12 | const Fuzz = @This(); | 13 | const Fuzz = @This(); |
| 13 | const build_runner = @import("root"); | 14 | const build_runner = @import("root"); |
| 14 | 15 | ||
| 15 | ws: *Build.WebServer, | 16 | gpa: Allocator, |
| 17 | mode: Mode, | ||
| 16 | 18 | ||
| 17 | /// Allocated into `ws.gpa`. | 19 | /// Allocated into `gpa`. |
| 18 | run_steps: []const *Step.Run, | 20 | run_steps: []const *Step.Run, |
| 19 | 21 | ||
| 20 | wait_group: std.Thread.WaitGroup, | 22 | wait_group: std.Thread.WaitGroup, |
| 23 | root_prog_node: std.Progress.Node, | ||
| 21 | prog_node: std.Progress.Node, | 24 | prog_node: std.Progress.Node, |
| 25 | thread_pool: *std.Thread.Pool, | ||
| 26 | ttyconf: tty.Config, | ||
| 22 | 27 | ||
| 23 | /// Protects `coverage_files`. | 28 | /// Protects `coverage_files`. |
| 24 | coverage_mutex: std.Thread.Mutex, | 29 | coverage_mutex: std.Thread.Mutex, |
| ... | @@ -28,9 +33,23 @@ queue_mutex: std.Thread.Mutex, | ... | @@ -28,9 +33,23 @@ queue_mutex: std.Thread.Mutex, |
| 28 | queue_cond: std.Thread.Condition, | 33 | queue_cond: std.Thread.Condition, |
| 29 | msg_queue: std.ArrayListUnmanaged(Msg), | 34 | msg_queue: std.ArrayListUnmanaged(Msg), |
| 30 | 35 | ||
| 36 | pub const Mode = union(enum) { | ||
| 37 | forever: struct { ws: *Build.WebServer }, | ||
| 38 | limit: Limited, | ||
| 39 | |||
| 40 | pub const Limited = struct { | ||
| 41 | amount: u64, | ||
| 42 | }; | ||
| 43 | }; | ||
| 44 | |||
| 31 | const Msg = union(enum) { | 45 | const Msg = union(enum) { |
| 32 | coverage: struct { | 46 | coverage: struct { |
| 33 | id: u64, | 47 | id: u64, |
| 48 | cumulative: struct { | ||
| 49 | runs: u64, | ||
| 50 | unique: u64, | ||
| 51 | coverage: u64, | ||
| 52 | }, | ||
| 34 | run: *Step.Run, | 53 | run: *Step.Run, |
| 35 | }, | 54 | }, |
| 36 | entry_point: struct { | 55 | entry_point: struct { |
| ... | @@ -54,23 +73,28 @@ const CoverageMap = struct { | ... | @@ -54,23 +73,28 @@ const CoverageMap = struct { |
| 54 | } | 73 | } |
| 55 | }; | 74 | }; |
| 56 | 75 | ||
| 57 | pub fn init(ws: *Build.WebServer) Allocator.Error!Fuzz { | 76 | pub fn init( |
| 58 | const gpa = ws.gpa; | 77 | gpa: Allocator, |
| 59 | 78 | thread_pool: *std.Thread.Pool, | |
| 79 | all_steps: []const *Build.Step, | ||
| 80 | root_prog_node: std.Progress.Node, | ||
| 81 | ttyconf: tty.Config, | ||
| 82 | mode: Mode, | ||
| 83 | ) Allocator.Error!Fuzz { | ||
| 60 | const run_steps: []const *Step.Run = steps: { | 84 | const run_steps: []const *Step.Run = steps: { |
| 61 | var steps: std.ArrayListUnmanaged(*Step.Run) = .empty; | 85 | var steps: std.ArrayListUnmanaged(*Step.Run) = .empty; |
| 62 | defer steps.deinit(gpa); | 86 | defer steps.deinit(gpa); |
| 63 | const rebuild_node = ws.root_prog_node.start("Rebuilding Unit Tests", 0); | 87 | const rebuild_node = root_prog_node.start("Rebuilding Unit Tests", 0); |
| 64 | defer rebuild_node.end(); | 88 | defer rebuild_node.end(); |
| 65 | var rebuild_wg: std.Thread.WaitGroup = .{}; | 89 | var rebuild_wg: std.Thread.WaitGroup = .{}; |
| 66 | defer rebuild_wg.wait(); | 90 | defer rebuild_wg.wait(); |
| 67 | 91 | ||
| 68 | for (ws.all_steps) |step| { | 92 | for (all_steps) |step| { |
| 69 | const run = step.cast(Step.Run) orelse continue; | 93 | const run = step.cast(Step.Run) orelse continue; |
| 70 | if (run.producer == null) continue; | 94 | if (run.producer == null) continue; |
| 71 | if (run.fuzz_tests.items.len == 0) continue; | 95 | if (run.fuzz_tests.items.len == 0) continue; |
| 72 | try steps.append(gpa, run); | 96 | try steps.append(gpa, run); |
| 73 | ws.thread_pool.spawnWg(&rebuild_wg, rebuildTestsWorkerRun, .{ run, gpa, ws.ttyconf, rebuild_node }); | 97 | thread_pool.spawnWg(&rebuild_wg, rebuildTestsWorkerRun, .{ run, gpa, ttyconf, rebuild_node }); |
| 74 | } | 98 | } |
| 75 | 99 | ||
| 76 | if (steps.items.len == 0) fatal("no fuzz tests found", .{}); | 100 | if (steps.items.len == 0) fatal("no fuzz tests found", .{}); |
| ... | @@ -86,9 +110,13 @@ pub fn init(ws: *Build.WebServer) Allocator.Error!Fuzz { | ... | @@ -86,9 +110,13 @@ pub fn init(ws: *Build.WebServer) Allocator.Error!Fuzz { |
| 86 | } | 110 | } |
| 87 | 111 | ||
| 88 | return .{ | 112 | return .{ |
| 89 | .ws = ws, | 113 | .gpa = gpa, |
| 114 | .mode = mode, | ||
| 90 | .run_steps = run_steps, | 115 | .run_steps = run_steps, |
| 91 | .wait_group = .{}, | 116 | .wait_group = .{}, |
| 117 | .thread_pool = thread_pool, | ||
| 118 | .ttyconf = ttyconf, | ||
| 119 | .root_prog_node = root_prog_node, | ||
| 92 | .prog_node = .none, | 120 | .prog_node = .none, |
| 93 | .coverage_files = .empty, | 121 | .coverage_files = .empty, |
| 94 | .coverage_mutex = .{}, | 122 | .coverage_mutex = .{}, |
| ... | @@ -99,32 +127,31 @@ pub fn init(ws: *Build.WebServer) Allocator.Error!Fuzz { | ... | @@ -99,32 +127,31 @@ pub fn init(ws: *Build.WebServer) Allocator.Error!Fuzz { |
| 99 | } | 127 | } |
| 100 | 128 | ||
| 101 | pub fn start(fuzz: *Fuzz) void { | 129 | pub fn start(fuzz: *Fuzz) void { |
| 102 | const ws = fuzz.ws; | 130 | fuzz.prog_node = fuzz.root_prog_node.start("Fuzzing", fuzz.run_steps.len); |
| 103 | fuzz.prog_node = ws.root_prog_node.start("Fuzzing", fuzz.run_steps.len); | 131 | |
| 104 | 132 | if (fuzz.mode == .forever) { | |
| 105 | // For polling messages and sending updates to subscribers. | 133 | // For polling messages and sending updates to subscribers. |
| 106 | fuzz.wait_group.start(); | 134 | fuzz.wait_group.start(); |
| 107 | _ = std.Thread.spawn(.{}, coverageRun, .{fuzz}) catch |err| { | 135 | _ = std.Thread.spawn(.{}, coverageRun, .{fuzz}) catch |err| { |
| 108 | fuzz.wait_group.finish(); | 136 | fuzz.wait_group.finish(); |
| 109 | fatal("unable to spawn coverage thread: {s}", .{@errorName(err)}); | 137 | fatal("unable to spawn coverage thread: {s}", .{@errorName(err)}); |
| 110 | }; | 138 | }; |
| 139 | } | ||
| 111 | 140 | ||
| 112 | for (fuzz.run_steps) |run| { | 141 | for (fuzz.run_steps) |run| { |
| 113 | for (run.fuzz_tests.items) |unit_test_index| { | 142 | for (run.fuzz_tests.items) |unit_test_index| { |
| 114 | assert(run.rebuilt_executable != null); | 143 | assert(run.rebuilt_executable != null); |
| 115 | ws.thread_pool.spawnWg(&fuzz.wait_group, fuzzWorkerRun, .{ | 144 | fuzz.thread_pool.spawnWg(&fuzz.wait_group, fuzzWorkerRun, .{ |
| 116 | fuzz, run, unit_test_index, | 145 | fuzz, run, unit_test_index, |
| 117 | }); | 146 | }); |
| 118 | } | 147 | } |
| 119 | } | 148 | } |
| 120 | } | 149 | } |
| 150 | |||
| 121 | pub fn deinit(fuzz: *Fuzz) void { | 151 | pub fn deinit(fuzz: *Fuzz) void { |
| 122 | if (true) @panic("TODO: terminate the fuzzer processes"); | 152 | if (!fuzz.wait_group.isDone()) @panic("TODO: terminate the fuzzer processes"); |
| 123 | fuzz.wait_group.wait(); | ||
| 124 | fuzz.prog_node.end(); | 153 | fuzz.prog_node.end(); |
| 125 | 154 | fuzz.gpa.free(fuzz.run_steps); | |
| 126 | const gpa = fuzz.ws.gpa; | ||
| 127 | gpa.free(fuzz.run_steps); | ||
| 128 | } | 155 | } |
| 129 | 156 | ||
| 130 | fn rebuildTestsWorkerRun(run: *Step.Run, gpa: Allocator, ttyconf: std.Io.tty.Config, parent_prog_node: std.Progress.Node) void { | 157 | fn rebuildTestsWorkerRun(run: *Step.Run, gpa: Allocator, ttyconf: std.Io.tty.Config, parent_prog_node: std.Progress.Node) void { |
| ... | @@ -177,7 +204,7 @@ fn fuzzWorkerRun( | ... | @@ -177,7 +204,7 @@ fn fuzzWorkerRun( |
| 177 | var buf: [256]u8 = undefined; | 204 | var buf: [256]u8 = undefined; |
| 178 | const w = std.debug.lockStderrWriter(&buf); | 205 | const w = std.debug.lockStderrWriter(&buf); |
| 179 | defer std.debug.unlockStderrWriter(); | 206 | defer std.debug.unlockStderrWriter(); |
| 180 | build_runner.printErrorMessages(gpa, &run.step, .{ .ttyconf = fuzz.ws.ttyconf }, w, false) catch {}; | 207 | build_runner.printErrorMessages(gpa, &run.step, .{ .ttyconf = fuzz.ttyconf }, w, false) catch {}; |
| 181 | return; | 208 | return; |
| 182 | }, | 209 | }, |
| 183 | else => { | 210 | else => { |
| ... | @@ -190,20 +217,20 @@ fn fuzzWorkerRun( | ... | @@ -190,20 +217,20 @@ fn fuzzWorkerRun( |
| 190 | } | 217 | } |
| 191 | 218 | ||
| 192 | pub fn serveSourcesTar(fuzz: *Fuzz, req: *std.http.Server.Request) !void { | 219 | pub fn serveSourcesTar(fuzz: *Fuzz, req: *std.http.Server.Request) !void { |
| 193 | const gpa = fuzz.ws.gpa; | 220 | assert(fuzz.mode == .forever); |
| 194 | 221 | ||
| 195 | var arena_state: std.heap.ArenaAllocator = .init(gpa); | 222 | var arena_state: std.heap.ArenaAllocator = .init(fuzz.gpa); |
| 196 | defer arena_state.deinit(); | 223 | defer arena_state.deinit(); |
| 197 | const arena = arena_state.allocator(); | 224 | const arena = arena_state.allocator(); |
| 198 | 225 | ||
| 199 | const DedupTable = std.ArrayHashMapUnmanaged(Build.Cache.Path, void, Build.Cache.Path.TableAdapter, false); | 226 | const DedupTable = std.ArrayHashMapUnmanaged(Build.Cache.Path, void, Build.Cache.Path.TableAdapter, false); |
| 200 | var dedup_table: DedupTable = .empty; | 227 | var dedup_table: DedupTable = .empty; |
| 201 | defer dedup_table.deinit(gpa); | 228 | defer dedup_table.deinit(fuzz.gpa); |
| 202 | 229 | ||
| 203 | for (fuzz.run_steps) |run_step| { | 230 | for (fuzz.run_steps) |run_step| { |
| 204 | const compile_inputs = run_step.producer.?.step.inputs.table; | 231 | const compile_inputs = run_step.producer.?.step.inputs.table; |
| 205 | for (compile_inputs.keys(), compile_inputs.values()) |dir_path, *file_list| { | 232 | for (compile_inputs.keys(), compile_inputs.values()) |dir_path, *file_list| { |
| 206 | try dedup_table.ensureUnusedCapacity(gpa, file_list.items.len); | 233 | try dedup_table.ensureUnusedCapacity(fuzz.gpa, file_list.items.len); |
| 207 | for (file_list.items) |sub_path| { | 234 | for (file_list.items) |sub_path| { |
| 208 | if (!std.mem.endsWith(u8, sub_path, ".zig")) continue; | 235 | if (!std.mem.endsWith(u8, sub_path, ".zig")) continue; |
| 209 | const joined_path = try dir_path.join(arena, sub_path); | 236 | const joined_path = try dir_path.join(arena, sub_path); |
| ... | @@ -224,7 +251,7 @@ pub fn serveSourcesTar(fuzz: *Fuzz, req: *std.http.Server.Request) !void { | ... | @@ -224,7 +251,7 @@ pub fn serveSourcesTar(fuzz: *Fuzz, req: *std.http.Server.Request) !void { |
| 224 | } | 251 | } |
| 225 | }; | 252 | }; |
| 226 | std.mem.sortUnstable(Build.Cache.Path, deduped_paths, SortContext{}, SortContext.lessThan); | 253 | std.mem.sortUnstable(Build.Cache.Path, deduped_paths, SortContext{}, SortContext.lessThan); |
| 227 | return fuzz.ws.serveTarFile(req, deduped_paths); | 254 | return fuzz.mode.forever.ws.serveTarFile(req, deduped_paths); |
| 228 | } | 255 | } |
| 229 | 256 | ||
| 230 | pub const Previous = struct { | 257 | pub const Previous = struct { |
| ... | @@ -319,13 +346,13 @@ fn coverageRun(fuzz: *Fuzz) void { | ... | @@ -319,13 +346,13 @@ fn coverageRun(fuzz: *Fuzz) void { |
| 319 | } | 346 | } |
| 320 | } | 347 | } |
| 321 | fn prepareTables(fuzz: *Fuzz, run_step: *Step.Run, coverage_id: u64) error{ OutOfMemory, AlreadyReported }!void { | 348 | fn prepareTables(fuzz: *Fuzz, run_step: *Step.Run, coverage_id: u64) error{ OutOfMemory, AlreadyReported }!void { |
| 322 | const ws = fuzz.ws; | 349 | assert(fuzz.mode == .forever); |
| 323 | const gpa = ws.gpa; | 350 | const ws = fuzz.mode.forever.ws; |
| 324 | 351 | ||
| 325 | fuzz.coverage_mutex.lock(); | 352 | fuzz.coverage_mutex.lock(); |
| 326 | defer fuzz.coverage_mutex.unlock(); | 353 | defer fuzz.coverage_mutex.unlock(); |
| 327 | 354 | ||
| 328 | const gop = try fuzz.coverage_files.getOrPut(gpa, coverage_id); | 355 | const gop = try fuzz.coverage_files.getOrPut(fuzz.gpa, coverage_id); |
| 329 | if (gop.found_existing) { | 356 | if (gop.found_existing) { |
| 330 | // We are fuzzing the same executable with multiple threads. | 357 | // We are fuzzing the same executable with multiple threads. |
| 331 | // Perhaps the same unit test; perhaps a different one. In any | 358 | // Perhaps the same unit test; perhaps a different one. In any |
| ... | @@ -343,16 +370,16 @@ fn prepareTables(fuzz: *Fuzz, run_step: *Step.Run, coverage_id: u64) error{ OutO | ... | @@ -343,16 +370,16 @@ fn prepareTables(fuzz: *Fuzz, run_step: *Step.Run, coverage_id: u64) error{ OutO |
| 343 | .entry_points = .{}, | 370 | .entry_points = .{}, |
| 344 | .start_timestamp = ws.now(), | 371 | .start_timestamp = ws.now(), |
| 345 | }; | 372 | }; |
| 346 | errdefer gop.value_ptr.coverage.deinit(gpa); | 373 | errdefer gop.value_ptr.coverage.deinit(fuzz.gpa); |
| 347 | 374 | ||
| 348 | const rebuilt_exe_path = run_step.rebuilt_executable.?; | 375 | const rebuilt_exe_path = run_step.rebuilt_executable.?; |
| 349 | var debug_info = std.debug.Info.load(gpa, rebuilt_exe_path, &gop.value_ptr.coverage) catch |err| { | 376 | var debug_info = std.debug.Info.load(fuzz.gpa, rebuilt_exe_path, &gop.value_ptr.coverage) catch |err| { |
| 350 | log.err("step '{s}': failed to load debug information for '{f}': {s}", .{ | 377 | log.err("step '{s}': failed to load debug information for '{f}': {s}", .{ |
| 351 | run_step.step.name, rebuilt_exe_path, @errorName(err), | 378 | run_step.step.name, rebuilt_exe_path, @errorName(err), |
| 352 | }); | 379 | }); |
| 353 | return error.AlreadyReported; | 380 | return error.AlreadyReported; |
| 354 | }; | 381 | }; |
| 355 | defer debug_info.deinit(gpa); | 382 | defer debug_info.deinit(fuzz.gpa); |
| 356 | 383 | ||
| 357 | const coverage_file_path: Build.Cache.Path = .{ | 384 | const coverage_file_path: Build.Cache.Path = .{ |
| 358 | .root_dir = run_step.step.owner.cache_root, | 385 | .root_dir = run_step.step.owner.cache_root, |
| ... | @@ -386,14 +413,14 @@ fn prepareTables(fuzz: *Fuzz, run_step: *Step.Run, coverage_id: u64) error{ OutO | ... | @@ -386,14 +413,14 @@ fn prepareTables(fuzz: *Fuzz, run_step: *Step.Run, coverage_id: u64) error{ OutO |
| 386 | 413 | ||
| 387 | const header: *const abi.SeenPcsHeader = @ptrCast(mapped_memory[0..@sizeOf(abi.SeenPcsHeader)]); | 414 | const header: *const abi.SeenPcsHeader = @ptrCast(mapped_memory[0..@sizeOf(abi.SeenPcsHeader)]); |
| 388 | const pcs = header.pcAddrs(); | 415 | const pcs = header.pcAddrs(); |
| 389 | const source_locations = try gpa.alloc(Coverage.SourceLocation, pcs.len); | 416 | const source_locations = try fuzz.gpa.alloc(Coverage.SourceLocation, pcs.len); |
| 390 | errdefer gpa.free(source_locations); | 417 | errdefer fuzz.gpa.free(source_locations); |
| 391 | 418 | ||
| 392 | // Unfortunately the PCs array that LLVM gives us from the 8-bit PC | 419 | // Unfortunately the PCs array that LLVM gives us from the 8-bit PC |
| 393 | // counters feature is not sorted. | 420 | // counters feature is not sorted. |
| 394 | var sorted_pcs: std.MultiArrayList(struct { pc: u64, index: u32, sl: Coverage.SourceLocation }) = .{}; | 421 | var sorted_pcs: std.MultiArrayList(struct { pc: u64, index: u32, sl: Coverage.SourceLocation }) = .{}; |
| 395 | defer sorted_pcs.deinit(gpa); | 422 | defer sorted_pcs.deinit(fuzz.gpa); |
| 396 | try sorted_pcs.resize(gpa, pcs.len); | 423 | try sorted_pcs.resize(fuzz.gpa, pcs.len); |
| 397 | @memcpy(sorted_pcs.items(.pc), pcs); | 424 | @memcpy(sorted_pcs.items(.pc), pcs); |
| 398 | for (sorted_pcs.items(.index), 0..) |*v, i| v.* = @intCast(i); | 425 | for (sorted_pcs.items(.index), 0..) |*v, i| v.* = @intCast(i); |
| 399 | sorted_pcs.sortUnstable(struct { | 426 | sorted_pcs.sortUnstable(struct { |
| ... | @@ -404,7 +431,7 @@ fn prepareTables(fuzz: *Fuzz, run_step: *Step.Run, coverage_id: u64) error{ OutO | ... | @@ -404,7 +431,7 @@ fn prepareTables(fuzz: *Fuzz, run_step: *Step.Run, coverage_id: u64) error{ OutO |
| 404 | } | 431 | } |
| 405 | }{ .addrs = sorted_pcs.items(.pc) }); | 432 | }{ .addrs = sorted_pcs.items(.pc) }); |
| 406 | 433 | ||
| 407 | debug_info.resolveAddresses(gpa, sorted_pcs.items(.pc), sorted_pcs.items(.sl)) catch |err| { | 434 | debug_info.resolveAddresses(fuzz.gpa, sorted_pcs.items(.pc), sorted_pcs.items(.sl)) catch |err| { |
| 408 | log.err("failed to resolve addresses to source locations: {s}", .{@errorName(err)}); | 435 | log.err("failed to resolve addresses to source locations: {s}", .{@errorName(err)}); |
| 409 | return error.AlreadyReported; | 436 | return error.AlreadyReported; |
| 410 | }; | 437 | }; |
| ... | @@ -414,6 +441,7 @@ fn prepareTables(fuzz: *Fuzz, run_step: *Step.Run, coverage_id: u64) error{ OutO | ... | @@ -414,6 +441,7 @@ fn prepareTables(fuzz: *Fuzz, run_step: *Step.Run, coverage_id: u64) error{ OutO |
| 414 | 441 | ||
| 415 | ws.notifyUpdate(); | 442 | ws.notifyUpdate(); |
| 416 | } | 443 | } |
| 444 | |||
| 417 | fn addEntryPoint(fuzz: *Fuzz, coverage_id: u64, addr: u64) error{ AlreadyReported, OutOfMemory }!void { | 445 | fn addEntryPoint(fuzz: *Fuzz, coverage_id: u64, addr: u64) error{ AlreadyReported, OutOfMemory }!void { |
| 418 | fuzz.coverage_mutex.lock(); | 446 | fuzz.coverage_mutex.lock(); |
| 419 | defer fuzz.coverage_mutex.unlock(); | 447 | defer fuzz.coverage_mutex.unlock(); |
| ... | @@ -445,5 +473,89 @@ fn addEntryPoint(fuzz: *Fuzz, coverage_id: u64, addr: u64) error{ AlreadyReporte | ... | @@ -445,5 +473,89 @@ fn addEntryPoint(fuzz: *Fuzz, coverage_id: u64, addr: u64) error{ AlreadyReporte |
| 445 | addr, file_name, sl.line, sl.column, index, pcs[index - 1], pcs[index + 1], | 473 | addr, file_name, sl.line, sl.column, index, pcs[index - 1], pcs[index + 1], |
| 446 | }); | 474 | }); |
| 447 | } | 475 | } |
| 448 | try coverage_map.entry_points.append(fuzz.ws.gpa, @intCast(index)); | 476 | try coverage_map.entry_points.append(fuzz.gpa, @intCast(index)); |
| 477 | } | ||
| 478 | |||
| 479 | pub fn waitAndPrintReport(fuzz: *Fuzz) void { | ||
| 480 | assert(fuzz.mode == .limit); | ||
| 481 | |||
| 482 | fuzz.wait_group.wait(); | ||
| 483 | fuzz.wait_group.reset(); | ||
| 484 | |||
| 485 | std.debug.print("======= FUZZING REPORT =======\n", .{}); | ||
| 486 | for (fuzz.msg_queue.items) |msg| { | ||
| 487 | if (msg != .coverage) continue; | ||
| 488 | |||
| 489 | const cov = msg.coverage; | ||
| 490 | const coverage_file_path: std.Build.Cache.Path = .{ | ||
| 491 | .root_dir = cov.run.step.owner.cache_root, | ||
| 492 | .sub_path = "v/" ++ std.fmt.hex(cov.id), | ||
| 493 | }; | ||
| 494 | var coverage_file = coverage_file_path.root_dir.handle.openFile(coverage_file_path.sub_path, .{}) catch |err| { | ||
| 495 | fatal("step '{s}': failed to load coverage file '{f}': {s}", .{ | ||
| 496 | cov.run.step.name, coverage_file_path, @errorName(err), | ||
| 497 | }); | ||
| 498 | }; | ||
| 499 | defer coverage_file.close(); | ||
| 500 | |||
| 501 | const fuzz_abi = std.Build.abi.fuzz; | ||
| 502 | var rbuf: [0x1000]u8 = undefined; | ||
| 503 | var r = coverage_file.reader(&rbuf); | ||
| 504 | |||
| 505 | var header: fuzz_abi.SeenPcsHeader = undefined; | ||
| 506 | r.interface.readSliceAll(std.mem.asBytes(&header)) catch |err| { | ||
| 507 | fatal("step '{s}': failed to read from coverage file '{f}': {s}", .{ | ||
| 508 | cov.run.step.name, coverage_file_path, @errorName(err), | ||
| 509 | }); | ||
| 510 | }; | ||
| 511 | |||
| 512 | if (header.pcs_len == 0) { | ||
| 513 | fatal("step '{s}': corrupted coverage file '{f}': pcs_len was zero", .{ | ||
| 514 | cov.run.step.name, coverage_file_path, | ||
| 515 | }); | ||
| 516 | } | ||
| 517 | |||
| 518 | var seen_count: usize = 0; | ||
| 519 | const chunk_count = fuzz_abi.SeenPcsHeader.seenElemsLen(header.pcs_len); | ||
| 520 | for (0..chunk_count) |_| { | ||
| 521 | const seen = r.interface.takeInt(usize, .little) catch |err| { | ||
| 522 | fatal("step '{s}': failed to read from coverage file '{f}': {s}", .{ | ||
| 523 | cov.run.step.name, coverage_file_path, @errorName(err), | ||
| 524 | }); | ||
| 525 | }; | ||
| 526 | seen_count += @popCount(seen); | ||
| 527 | } | ||
| 528 | |||
| 529 | const seen_f: f64 = @floatFromInt(seen_count); | ||
| 530 | const total_f: f64 = @floatFromInt(header.pcs_len); | ||
| 531 | const ratio = seen_f / total_f; | ||
| 532 | std.debug.print( | ||
| 533 | \\Step: {s} | ||
| 534 | \\Fuzz test: "{s}" ({x}) | ||
| 535 | \\Runs: {} -> {} | ||
| 536 | \\Unique runs: {} -> {} | ||
| 537 | \\Coverage: {}/{} -> {}/{} ({:.02}%) | ||
| 538 | \\ | ||
| 539 | , .{ | ||
| 540 | cov.run.step.name, | ||
| 541 | cov.run.cached_test_metadata.?.testName(cov.run.fuzz_tests.items[0]), | ||
| 542 | cov.id, | ||
| 543 | cov.cumulative.runs, | ||
| 544 | header.n_runs, | ||
| 545 | cov.cumulative.unique, | ||
| 546 | header.unique_runs, | ||
| 547 | cov.cumulative.coverage, | ||
| 548 | header.pcs_len, | ||
| 549 | seen_count, | ||
| 550 | header.pcs_len, | ||
| 551 | ratio * 100, | ||
| 552 | }); | ||
| 553 | |||
| 554 | std.debug.print("------------------------------\n", .{}); | ||
| 555 | } | ||
| 556 | std.debug.print( | ||
| 557 | \\Values are accumulated across multiple runs when preserving the cache. | ||
| 558 | \\============================== | ||
| 559 | \\ | ||
| 560 | , .{}); | ||
| 449 | } | 561 | } |
lib/std/Build/Step/Run.zig+43-10| ... | @@ -1662,12 +1662,24 @@ fn evalZigTest( | ... | @@ -1662,12 +1662,24 @@ fn evalZigTest( |
| 1662 | // If this is `true`, we avoid ever entering the polling loop below, because the stdin pipe has | 1662 | // If this is `true`, we avoid ever entering the polling loop below, because the stdin pipe has |
| 1663 | // somehow already closed; instead, we go straight to capturing stderr in case it has anything | 1663 | // somehow already closed; instead, we go straight to capturing stderr in case it has anything |
| 1664 | // useful. | 1664 | // useful. |
| 1665 | const first_write_failed = if (fuzz_context) |fuzz| failed: { | 1665 | const first_write_failed = if (fuzz_context) |fctx| failed: { |
| 1666 | sendRunTestMessage(child.stdin.?, .start_fuzzing, fuzz.unit_test_index) catch |err| { | 1666 | switch (fctx.fuzz.mode) { |
| 1667 | try run.step.addError("unable to write stdin: {s}", .{@errorName(err)}); | 1667 | .forever => { |
| 1668 | break :failed true; | 1668 | const instance_id = 0; // will be used by mutiprocess forever fuzzing |
| 1669 | }; | 1669 | sendRunFuzzTestMessage(child.stdin.?, fctx.unit_test_index, .forever, instance_id) catch |err| { |
| 1670 | break :failed false; | 1670 | try run.step.addError("unable to write stdin: {s}", .{@errorName(err)}); |
| 1671 | break :failed true; | ||
| 1672 | }; | ||
| 1673 | break :failed false; | ||
| 1674 | }, | ||
| 1675 | .limit => |limit| { | ||
| 1676 | sendRunFuzzTestMessage(child.stdin.?, fctx.unit_test_index, .iterations, limit.amount) catch |err| { | ||
| 1677 | try run.step.addError("unable to write stdin: {s}", .{@errorName(err)}); | ||
| 1678 | break :failed true; | ||
| 1679 | }; | ||
| 1680 | break :failed false; | ||
| 1681 | }, | ||
| 1682 | } | ||
| 1671 | } else failed: { | 1683 | } else failed: { |
| 1672 | run.fuzz_tests.clearRetainingCapacity(); | 1684 | run.fuzz_tests.clearRetainingCapacity(); |
| 1673 | sendMessage(child.stdin.?, .query_test_metadata) catch |err| { | 1685 | sendMessage(child.stdin.?, .query_test_metadata) catch |err| { |
| ... | @@ -1778,13 +1790,18 @@ fn evalZigTest( | ... | @@ -1778,13 +1790,18 @@ fn evalZigTest( |
| 1778 | }, | 1790 | }, |
| 1779 | .coverage_id => { | 1791 | .coverage_id => { |
| 1780 | const fuzz = fuzz_context.?.fuzz; | 1792 | const fuzz = fuzz_context.?.fuzz; |
| 1781 | const msg_ptr: *align(1) const u64 = @ptrCast(body); | 1793 | const msg_ptr: *align(1) const [4]u64 = @ptrCast(body); |
| 1782 | coverage_id = msg_ptr.*; | 1794 | coverage_id = msg_ptr[0]; |
| 1783 | { | 1795 | { |
| 1784 | fuzz.queue_mutex.lock(); | 1796 | fuzz.queue_mutex.lock(); |
| 1785 | defer fuzz.queue_mutex.unlock(); | 1797 | defer fuzz.queue_mutex.unlock(); |
| 1786 | try fuzz.msg_queue.append(fuzz.ws.gpa, .{ .coverage = .{ | 1798 | try fuzz.msg_queue.append(fuzz.gpa, .{ .coverage = .{ |
| 1787 | .id = coverage_id.?, | 1799 | .id = coverage_id.?, |
| 1800 | .cumulative = .{ | ||
| 1801 | .runs = msg_ptr[1], | ||
| 1802 | .unique = msg_ptr[2], | ||
| 1803 | .coverage = msg_ptr[3], | ||
| 1804 | }, | ||
| 1788 | .run = run, | 1805 | .run = run, |
| 1789 | } }); | 1806 | } }); |
| 1790 | fuzz.queue_cond.signal(); | 1807 | fuzz.queue_cond.signal(); |
| ... | @@ -1797,7 +1814,7 @@ fn evalZigTest( | ... | @@ -1797,7 +1814,7 @@ fn evalZigTest( |
| 1797 | { | 1814 | { |
| 1798 | fuzz.queue_mutex.lock(); | 1815 | fuzz.queue_mutex.lock(); |
| 1799 | defer fuzz.queue_mutex.unlock(); | 1816 | defer fuzz.queue_mutex.unlock(); |
| 1800 | try fuzz.msg_queue.append(fuzz.ws.gpa, .{ .entry_point = .{ | 1817 | try fuzz.msg_queue.append(fuzz.gpa, .{ .entry_point = .{ |
| 1801 | .addr = addr, | 1818 | .addr = addr, |
| 1802 | .coverage_id = coverage_id.?, | 1819 | .coverage_id = coverage_id.?, |
| 1803 | } }); | 1820 | } }); |
| ... | @@ -1900,6 +1917,22 @@ fn sendRunTestMessage(file: std.fs.File, tag: std.zig.Client.Message.Tag, index: | ... | @@ -1900,6 +1917,22 @@ fn sendRunTestMessage(file: std.fs.File, tag: std.zig.Client.Message.Tag, index: |
| 1900 | try file.writeAll(full_msg); | 1917 | try file.writeAll(full_msg); |
| 1901 | } | 1918 | } |
| 1902 | 1919 | ||
| 1920 | fn sendRunFuzzTestMessage( | ||
| 1921 | file: std.fs.File, | ||
| 1922 | index: u32, | ||
| 1923 | kind: std.Build.abi.fuzz.LimitKind, | ||
| 1924 | amount_or_instance: u64, | ||
| 1925 | ) !void { | ||
| 1926 | const header: std.zig.Client.Message.Header = .{ | ||
| 1927 | .tag = .start_fuzzing, | ||
| 1928 | .bytes_len = 4 + 1 + 8, | ||
| 1929 | }; | ||
| 1930 | const full_msg = std.mem.asBytes(&header) ++ std.mem.asBytes(&index) ++ | ||
| 1931 | std.mem.asBytes(&kind) ++ std.mem.asBytes(&amount_or_instance); | ||
| 1932 | |||
| 1933 | try file.writeAll(full_msg); | ||
| 1934 | } | ||
| 1935 | |||
| 1903 | fn evalGeneric(run: *Run, child: *std.process.Child) !StdIoResult { | 1936 | fn evalGeneric(run: *Run, child: *std.process.Child) !StdIoResult { |
| 1904 | const b = run.step.owner; | 1937 | const b = run.step.owner; |
| 1905 | const arena = b.allocator; | 1938 | const arena = b.allocator; |
lib/std/Build/WebServer.zig+9-1| ... | @@ -219,12 +219,20 @@ pub fn finishBuild(ws: *WebServer, opts: struct { | ... | @@ -219,12 +219,20 @@ pub fn finishBuild(ws: *WebServer, opts: struct { |
| 219 | // Affects or affected by issues #5185, #22523, and #22464. | 219 | // Affects or affected by issues #5185, #22523, and #22464. |
| 220 | std.process.fatal("--fuzz not yet implemented on {d}-bit platforms", .{@bitSizeOf(usize)}); | 220 | std.process.fatal("--fuzz not yet implemented on {d}-bit platforms", .{@bitSizeOf(usize)}); |
| 221 | } | 221 | } |
| 222 | |||
| 222 | assert(ws.fuzz == null); | 223 | assert(ws.fuzz == null); |
| 223 | 224 | ||
| 224 | ws.build_status.store(.fuzz_init, .monotonic); | 225 | ws.build_status.store(.fuzz_init, .monotonic); |
| 225 | ws.notifyUpdate(); | 226 | ws.notifyUpdate(); |
| 226 | 227 | ||
| 227 | ws.fuzz = Fuzz.init(ws) catch |err| std.process.fatal("failed to start fuzzer: {s}", .{@errorName(err)}); | 228 | ws.fuzz = Fuzz.init( |
| 229 | ws.gpa, | ||
| 230 | ws.thread_pool, | ||
| 231 | ws.all_steps, | ||
| 232 | ws.root_prog_node, | ||
| 233 | ws.ttyconf, | ||
| 234 | .{ .forever = .{ .ws = ws } }, | ||
| 235 | ) catch |err| std.process.fatal("failed to start fuzzer: {s}", .{@errorName(err)}); | ||
| 228 | ws.fuzz.?.start(); | 236 | ws.fuzz.?.start(); |
| 229 | } | 237 | } |
| 230 | 238 |
lib/std/Build/abi.zig+3-1| ... | @@ -143,7 +143,7 @@ pub const fuzz = struct { | ... | @@ -143,7 +143,7 @@ pub const fuzz = struct { |
| 143 | pub extern fn fuzzer_coverage_id() u64; | 143 | pub extern fn fuzzer_coverage_id() u64; |
| 144 | pub extern fn fuzzer_init_test(test_one: TestOne, unit_test_name: Slice) void; | 144 | pub extern fn fuzzer_init_test(test_one: TestOne, unit_test_name: Slice) void; |
| 145 | pub extern fn fuzzer_new_input(bytes: Slice) void; | 145 | pub extern fn fuzzer_new_input(bytes: Slice) void; |
| 146 | pub extern fn fuzzer_main() void; | 146 | pub extern fn fuzzer_main(limit_kind: LimitKind, amount: u64) void; |
| 147 | 147 | ||
| 148 | pub const Slice = extern struct { | 148 | pub const Slice = extern struct { |
| 149 | ptr: [*]const u8, | 149 | ptr: [*]const u8, |
| ... | @@ -158,6 +158,8 @@ pub const fuzz = struct { | ... | @@ -158,6 +158,8 @@ pub const fuzz = struct { |
| 158 | } | 158 | } |
| 159 | }; | 159 | }; |
| 160 | 160 | ||
| 161 | pub const LimitKind = enum(u8) { forever, iterations }; | ||
| 162 | |||
| 161 | /// libfuzzer uses this and its usize is the one that counts. To match the ABI, | 163 | /// libfuzzer uses this and its usize is the one that counts. To match the ABI, |
| 162 | /// make the ints be the size of the target used with libfuzzer. | 164 | /// make the ints be the size of the target used with libfuzzer. |
| 163 | /// | 165 | /// |
lib/std/zig/Client.zig+10-2| ... | @@ -33,10 +33,18 @@ pub const Message = struct { | ... | @@ -33,10 +33,18 @@ pub const Message = struct { |
| 33 | /// Ask the test runner to run a particular test. | 33 | /// Ask the test runner to run a particular test. |
| 34 | /// The message body is a u32 test index. | 34 | /// The message body is a u32 test index. |
| 35 | run_test, | 35 | run_test, |
| 36 | /// Ask the test runner to start fuzzing a particular test. | 36 | /// Ask the test runner to start fuzzing a particular test forever or for a given amount of time/iterations. |
| 37 | /// The message body is a u32 test index. | 37 | /// The message body is: |
| 38 | /// - a u32 test index. | ||
| 39 | /// - a u8 test limit kind (std.Build.api.fuzz.LimitKind) | ||
| 40 | /// - a u64 value whose meaning depends on FuzzLimitKind (either a limit amount or an instance id) | ||
| 38 | start_fuzzing, | 41 | start_fuzzing, |
| 39 | 42 | ||
| 40 | _, | 43 | _, |
| 41 | }; | 44 | }; |
| 45 | |||
| 46 | comptime { | ||
| 47 | const std = @import("std"); | ||
| 48 | std.debug.assert(@sizeOf(std.Build.abi.fuzz.LimitKind) == 1); | ||
| 49 | } | ||
| 42 | }; | 50 | }; |
lib/std/zig/Server.zig+26-3| ... | @@ -42,9 +42,13 @@ pub const Message = struct { | ... | @@ -42,9 +42,13 @@ pub const Message = struct { |
| 42 | /// The remaining bytes is the file path relative to that prefix. | 42 | /// The remaining bytes is the file path relative to that prefix. |
| 43 | /// The prefixes are hard-coded in Compilation.create (cwd, zig lib dir, local cache dir) | 43 | /// The prefixes are hard-coded in Compilation.create (cwd, zig lib dir, local cache dir) |
| 44 | file_system_inputs, | 44 | file_system_inputs, |
| 45 | /// Body is a u64le that indicates the file path within the cache used | 45 | /// Body is: |
| 46 | /// to store coverage information. The integer is a hash of the PCs | 46 | /// - a u64le that indicates the file path within the cache used |
| 47 | /// stored within that file. | 47 | /// to store coverage information. The integer is a hash of the PCs |
| 48 | /// stored within that file. | ||
| 49 | /// - u64le of total runs accumulated | ||
| 50 | /// - u64le of unique runs accumulated | ||
| 51 | /// - u64le of coverage accumulated | ||
| 48 | coverage_id, | 52 | coverage_id, |
| 49 | /// Body is a u64le that indicates the function pointer virtual memory | 53 | /// Body is a u64le that indicates the function pointer virtual memory |
| 50 | /// address of the fuzz unit test. This is used to provide a starting | 54 | /// address of the fuzz unit test. This is used to provide a starting |
| ... | @@ -141,9 +145,15 @@ pub fn receiveMessage(s: *Server) !InMessage.Header { | ... | @@ -141,9 +145,15 @@ pub fn receiveMessage(s: *Server) !InMessage.Header { |
| 141 | return s.in.takeStruct(InMessage.Header, .little); | 145 | return s.in.takeStruct(InMessage.Header, .little); |
| 142 | } | 146 | } |
| 143 | 147 | ||
| 148 | pub fn receiveBody_u8(s: *Server) !u8 { | ||
| 149 | return s.in.takeInt(u8, .little); | ||
| 150 | } | ||
| 144 | pub fn receiveBody_u32(s: *Server) !u32 { | 151 | pub fn receiveBody_u32(s: *Server) !u32 { |
| 145 | return s.in.takeInt(u32, .little); | 152 | return s.in.takeInt(u32, .little); |
| 146 | } | 153 | } |
| 154 | pub fn receiveBody_u64(s: *Server) !u64 { | ||
| 155 | return s.in.takeInt(u64, .little); | ||
| 156 | } | ||
| 147 | 157 | ||
| 148 | pub fn serveStringMessage(s: *Server, tag: OutMessage.Tag, msg: []const u8) !void { | 158 | pub fn serveStringMessage(s: *Server, tag: OutMessage.Tag, msg: []const u8) !void { |
| 149 | try s.serveMessageHeader(.{ | 159 | try s.serveMessageHeader(.{ |
| ... | @@ -160,6 +170,7 @@ pub fn serveMessageHeader(s: *const Server, header: OutMessage.Header) !void { | ... | @@ -160,6 +170,7 @@ pub fn serveMessageHeader(s: *const Server, header: OutMessage.Header) !void { |
| 160 | } | 170 | } |
| 161 | 171 | ||
| 162 | pub fn serveU64Message(s: *const Server, tag: OutMessage.Tag, int: u64) !void { | 172 | pub fn serveU64Message(s: *const Server, tag: OutMessage.Tag, int: u64) !void { |
| 173 | assert(tag != .coverage_id); | ||
| 163 | try serveMessageHeader(s, .{ | 174 | try serveMessageHeader(s, .{ |
| 164 | .tag = tag, | 175 | .tag = tag, |
| 165 | .bytes_len = @sizeOf(u64), | 176 | .bytes_len = @sizeOf(u64), |
| ... | @@ -168,6 +179,18 @@ pub fn serveU64Message(s: *const Server, tag: OutMessage.Tag, int: u64) !void { | ... | @@ -168,6 +179,18 @@ pub fn serveU64Message(s: *const Server, tag: OutMessage.Tag, int: u64) !void { |
| 168 | try s.out.flush(); | 179 | try s.out.flush(); |
| 169 | } | 180 | } |
| 170 | 181 | ||
| 182 | pub fn serveCoverageIdMessage(s: *const Server, id: u64, runs: u64, unique: u64, cov: u64) !void { | ||
| 183 | try serveMessageHeader(s, .{ | ||
| 184 | .tag = .coverage_id, | ||
| 185 | .bytes_len = @sizeOf(u64) + @sizeOf(u64) + @sizeOf(u64) + @sizeOf(u64), | ||
| 186 | }); | ||
| 187 | try s.out.writeInt(u64, id, .little); | ||
| 188 | try s.out.writeInt(u64, runs, .little); | ||
| 189 | try s.out.writeInt(u64, unique, .little); | ||
| 190 | try s.out.writeInt(u64, cov, .little); | ||
| 191 | try s.out.flush(); | ||
| 192 | } | ||
| 193 | |||
| 171 | pub fn serveEmitDigest( | 194 | pub fn serveEmitDigest( |
| 172 | s: *Server, | 195 | s: *Server, |
| 173 | digest: *const [Cache.bin_digest_len]u8, | 196 | digest: *const [Cache.bin_digest_len]u8, |