authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2025-01-15 18:17:20-08:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2025-01-15 18:17:20-08:00
log10db1b9eda849420b92cc21e2cbc93e0c74740bb
tree66ec854c4e926ef529e49f3bf164747909f08a9d
parenta4b7e9b97daf226801da6142760cff2f2ff955d5

wasm linker: fix explicit exports not affecting object files


1 files changed, 10 insertions(+), 10 deletions(-)

src/link/Wasm.zig+10-10
......@@ -3420,7 +3420,7 @@ pub fn prelink(wasm: *Wasm, prog_node: std.Progress.Node) link.File.FlushError!v
34203420 for (wasm.object_init_funcs.items) |init_func| {
34213421 const func = init_func.function_index.ptr(wasm);
34223422 if (func.object_index.ptr(wasm).is_included) {
3423 try markFunction(wasm, init_func.function_index);
3423 try markFunction(wasm, init_func.function_index, false);
34243424 }
34253425 }
34263426 wasm.functions_end_prelink = @intCast(wasm.functions.entries.len);
......@@ -3484,12 +3484,12 @@ pub fn markFunctionImport(
34843484 try wasm.function_imports.put(gpa, name, .fromObject(func_index, wasm));
34853485 }
34863486 } else {
3487 try markFunction(wasm, import.resolution.unpack(wasm).object_function);
3487 try markFunction(wasm, import.resolution.unpack(wasm).object_function, import.flags.exported);
34883488 }
34893489}
34903490
34913491/// Recursively mark alive everything referenced by the function.
3492fn markFunction(wasm: *Wasm, i: ObjectFunctionIndex) link.File.FlushError!void {
3492fn markFunction(wasm: *Wasm, i: ObjectFunctionIndex, override_export: bool) link.File.FlushError!void {
34933493 const comp = wasm.base.comp;
34943494 const gpa = comp.gpa;
34953495 const gop = try wasm.functions.getOrPut(gpa, .fromObjectFunction(wasm, i));
......@@ -3500,7 +3500,7 @@ fn markFunction(wasm: *Wasm, i: ObjectFunctionIndex) link.File.FlushError!void {
35003500 const function = i.ptr(wasm);
35013501 markObject(wasm, function.object_index);
35023502
3503 if (!is_obj and function.flags.isExported(rdynamic)) {
3503 if (!is_obj and (override_export or function.flags.isExported(rdynamic))) {
35043504 const symbol_name = function.name.unwrap().?;
35053505 if (function.flags.visibility_hidden) {
35063506 try wasm.hidden_function_exports.put(gpa, symbol_name, @enumFromInt(gop.index));
......@@ -3554,11 +3554,11 @@ fn markGlobalImport(
35543554 try wasm.global_imports.put(gpa, name, .fromObject(global_index, wasm));
35553555 }
35563556 } else {
3557 try markGlobal(wasm, import.resolution.unpack(wasm).object_global);
3557 try markGlobal(wasm, import.resolution.unpack(wasm).object_global, import.flags.exported);
35583558 }
35593559}
35603560
3561fn markGlobal(wasm: *Wasm, i: ObjectGlobalIndex) link.File.FlushError!void {
3561fn markGlobal(wasm: *Wasm, i: ObjectGlobalIndex, override_export: bool) link.File.FlushError!void {
35623562 const comp = wasm.base.comp;
35633563 const gpa = comp.gpa;
35643564 const gop = try wasm.globals.getOrPut(gpa, .fromObjectGlobal(wasm, i));
......@@ -3568,7 +3568,7 @@ fn markGlobal(wasm: *Wasm, i: ObjectGlobalIndex) link.File.FlushError!void {
35683568 const is_obj = comp.config.output_mode == .Obj;
35693569 const global = i.ptr(wasm);
35703570
3571 if (!is_obj and global.flags.isExported(rdynamic)) try wasm.global_exports.append(gpa, .{
3571 if (!is_obj and (override_export or global.flags.isExported(rdynamic))) try wasm.global_exports.append(gpa, .{
35723572 .name = global.name.unwrap().?,
35733573 .global_index = @enumFromInt(gop.index),
35743574 });
......@@ -3700,7 +3700,7 @@ fn markRelocations(wasm: *Wasm, relocs: ObjectRelocation.IterableSlice) link.Fil
37003700 .function_index_i32,
37013701 .function_offset_i32,
37023702 .function_offset_i64,
3703 => try markFunction(wasm, pointee.function.chaseWeak(wasm)),
3703 => try markFunction(wasm, pointee.function.chaseWeak(wasm), false),
37043704 .table_index_sleb,
37053705 .table_index_i32,
37063706 .table_index_sleb64,
......@@ -3710,11 +3710,11 @@ fn markRelocations(wasm: *Wasm, relocs: ObjectRelocation.IterableSlice) link.Fil
37103710 => {
37113711 const function = pointee.function;
37123712 try wasm.object_indirect_function_set.put(gpa, function, {});
3713 try markFunction(wasm, function.chaseWeak(wasm));
3713 try markFunction(wasm, function.chaseWeak(wasm), false);
37143714 },
37153715 .global_index_leb,
37163716 .global_index_i32,
3717 => try markGlobal(wasm, pointee.global.chaseWeak(wasm)),
3717 => try markGlobal(wasm, pointee.global.chaseWeak(wasm), false),
37183718 .table_number_leb,
37193719 => try markTable(wasm, pointee.table.chaseWeak(wasm)),
37203720