authorgravatar for emekankurumeh@outlook.comemekoi <emekankurumeh@outlook.com> 2019-12-16 16:14:16-06:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2020-01-07 13:59:16-05:00
log156e43b4633bdcd23913127c6b474ce2de3c4331
tree2bfd9cafe649faebe34be5d783ffadee7b6b9b84
parente81b505960b106a042e4cb890971ba365a5ef180

added -- to pass args to zig build commands


2 files changed, 29 insertions(+), 24 deletions(-)

lib/std/build.zig+2
......@@ -60,6 +60,7 @@ pub const Builder = struct {
6060 override_lib_dir: ?[]const u8,
6161 vcpkg_root: VcpkgRoot,
6262 pkg_config_pkg_list: ?(PkgConfigError![]const PkgConfigPkg) = null,
63 args: ?[][]const u8 = null,
6364
6465 const PkgConfigError = error{
6566 PkgConfigCrashed,
......@@ -166,6 +167,7 @@ pub const Builder = struct {
166167 .override_lib_dir = null,
167168 .install_path = undefined,
168169 .vcpkg_root = VcpkgRoot{ .Unattempted = {} },
170 .args = null,
169171 };
170172 try self.top_level_steps.append(&self.install_tls);
171173 try self.top_level_steps.append(&self.uninstall_tls);
lib/std/special/build_runner.zig+27-24
......@@ -11,32 +11,31 @@ const warn = std.debug.warn;
1111const File = std.fs.File;
1212
1313pub fn main() !void {
14 var arg_it = process.args();
15
1614 // Here we use an ArenaAllocator backed by a DirectAllocator because a build is a short-lived,
1715 // one shot program. We don't need to waste time freeing memory and finding places to squish
1816 // bytes into. So we free everything all at once at the very end.
19
2017 var arena = std.heap.ArenaAllocator.init(std.heap.page_allocator);
2118 defer arena.deinit();
2219
2320 const allocator = &arena.allocator;
21 var args = try process.argsAlloc(allocator);
22 defer process.argsFree(allocator, args);
2423
2524 // skip my own exe name
26 _ = arg_it.skip();
25 var arg_idx: usize = 1;
2726
28 const zig_exe = try unwrapArg(arg_it.next(allocator) orelse {
27 const zig_exe = nextArg(args, &arg_idx) orelse {
2928 warn("Expected first argument to be path to zig compiler\n", .{});
3029 return error.InvalidArgs;
31 });
32 const build_root = try unwrapArg(arg_it.next(allocator) orelse {
30 };
31 const build_root = nextArg(args, &arg_idx) orelse {
3332 warn("Expected second argument to be build root directory path\n", .{});
3433 return error.InvalidArgs;
35 });
36 const cache_root = try unwrapArg(arg_it.next(allocator) orelse {
34 };
35 const cache_root = nextArg(args, &arg_idx) orelse {
3736 warn("Expected third argument to be cache root directory path\n", .{});
3837 return error.InvalidArgs;
39 });
38 };
4039
4140 const builder = try Builder.create(allocator, zig_exe, build_root, cache_root);
4241 defer builder.destroy();
......@@ -46,8 +45,7 @@ pub fn main() !void {
4645 const stderr_stream = &io.getStdErr().outStream().stream;
4746 const stdout_stream = &io.getStdOut().outStream().stream;
4847
49 while (arg_it.next(allocator)) |err_or_arg| {
50 const arg = try unwrapArg(err_or_arg);
48 while (nextArg(args, &arg_idx)) |arg| {
5149 if (mem.startsWith(u8, arg, "-D")) {
5250 const option_contents = arg[2..];
5351 if (option_contents.len == 0) {
......@@ -69,21 +67,21 @@ pub fn main() !void {
6967 } else if (mem.eql(u8, arg, "--help")) {
7068 return usage(builder, false, stdout_stream);
7169 } else if (mem.eql(u8, arg, "--prefix")) {
72 builder.install_prefix = try unwrapArg(arg_it.next(allocator) orelse {
70 builder.install_prefix = nextArg(args, &arg_idx) orelse {
7371 warn("Expected argument after --prefix\n\n", .{});
7472 return usageAndErr(builder, false, stderr_stream);
75 });
73 };
7674 } else if (mem.eql(u8, arg, "--search-prefix")) {
77 const search_prefix = try unwrapArg(arg_it.next(allocator) orelse {
75 const search_prefix = nextArg(args, &arg_idx) orelse {
7876 warn("Expected argument after --search-prefix\n\n", .{});
7977 return usageAndErr(builder, false, stderr_stream);
80 });
78 };
8179 builder.addSearchPrefix(search_prefix);
8280 } else if (mem.eql(u8, arg, "--override-lib-dir")) {
83 builder.override_lib_dir = try unwrapArg(arg_it.next(allocator) orelse {
81 builder.override_lib_dir = nextArg(args, &arg_idx) orelse {
8482 warn("Expected argument after --override-lib-dir\n\n", .{});
8583 return usageAndErr(builder, false, stderr_stream);
86 });
84 };
8785 } else if (mem.eql(u8, arg, "--verbose-tokenize")) {
8886 builder.verbose_tokenize = true;
8987 } else if (mem.eql(u8, arg, "--verbose-ast")) {
......@@ -98,6 +96,9 @@ pub fn main() !void {
9896 builder.verbose_cimport = true;
9997 } else if (mem.eql(u8, arg, "--verbose-cc")) {
10098 builder.verbose_cc = true;
99 } else if (mem.eql(u8, arg, "--")) {
100 builder.args = argsRest(args, arg_idx);
101 break;
101102 } else {
102103 warn("Unrecognized argument: {}\n\n", .{arg});
103104 return usageAndErr(builder, false, stderr_stream);
......@@ -203,11 +204,13 @@ fn usageAndErr(builder: *Builder, already_ran_build: bool, out_stream: var) void
203204 process.exit(1);
204205}
205206
206const UnwrapArgError = error{OutOfMemory};
207fn nextArg(args: [][]const u8, idx: *usize) ?[]const u8 {
208 if (idx.* >= args.len) return null;
209 defer idx.* += 1;
210 return args[idx.*];
211}
207212
208fn unwrapArg(arg: UnwrapArgError![]u8) UnwrapArgError![]u8 {
209 return arg catch |err| {
210 warn("Unable to parse command line: {}\n", .{err});
211 return err;
212 };
213fn argsRest(args: [][]const u8, idx: usize) ?[][]const u8 {
214 if (idx >= args.len) return null;
215 return args[idx..];
213216}