authorgravatar for liljaanton2001@gmail.comantlilja <liljaanton2001@gmail.com> 2023-07-18 01:51:37+02:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2023-09-27 11:24:33-07:00
log15cc008bf8fed09379cca1b51c177a4ebcd7fe72
treed5b41aea84e101059e2d356e4f9ba7ed400a4fe9
parentbcf4a1391331e52e4a06528530316970ded75c74

Replace `@fabs` with `@abs` in behavior tests

2 files changed, 39 insertions(+), 36 deletions(-)

test/behavior/floatop.zig+36-33
......@@ -523,7 +523,7 @@ fn testLog10WithVectors() !void {
523523 try expect(@log10(@as(f32, 0.4)) == result[3]);
524524}
525525
526test "@fabs" {
526test "@abs" {
527527 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
528528 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
529529 if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
......@@ -533,24 +533,24 @@ test "@fabs" {
533533}
534534
535535fn testFabs() !void {
536 try expect(@fabs(@as(f16, -2.5)) == 2.5);
537 try expect(@fabs(@as(f16, 2.5)) == 2.5);
538 try expect(@fabs(@as(f32, -2.5)) == 2.5);
539 try expect(@fabs(@as(f32, 2.5)) == 2.5);
540 try expect(@fabs(@as(f64, -2.5)) == 2.5);
541 try expect(@fabs(@as(f64, 2.5)) == 2.5);
536 try expect(@abs(@as(f16, -2.5)) == 2.5);
537 try expect(@abs(@as(f16, 2.5)) == 2.5);
538 try expect(@abs(@as(f32, -2.5)) == 2.5);
539 try expect(@abs(@as(f32, 2.5)) == 2.5);
540 try expect(@abs(@as(f64, -2.5)) == 2.5);
541 try expect(@abs(@as(f64, 2.5)) == 2.5);
542542
543543 // TODO test f128, and c_longdouble
544544 // https://github.com/ziglang/zig/issues/4026
545545 // {
546546 // var a: f80 = -2.5;
547547 // var b: f80 = 2.5;
548 // try expect(@fabs(a) == 2.5);
549 // try expect(@fabs(b) == 2.5);
548 // try expect(@abs(a) == 2.5);
549 // try expect(@abs(b) == 2.5);
550550 // }
551551}
552552
553test "@fabs with vectors" {
553test "@abs with vectors" {
554554 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
555555 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
556556 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
......@@ -562,14 +562,15 @@ test "@fabs with vectors" {
562562
563563fn testFabsWithVectors() !void {
564564 var v: @Vector(4, f32) = [_]f32{ 1.1, -2.2, 0.3, -0.4 };
565 var result = @fabs(v);
566 try expect(math.approxEqAbs(f32, @fabs(@as(f32, 1.1)), result[0], epsilon));
567 try expect(math.approxEqAbs(f32, @fabs(@as(f32, -2.2)), result[1], epsilon));
568 try expect(math.approxEqAbs(f32, @fabs(@as(f32, 0.3)), result[2], epsilon));
569 try expect(math.approxEqAbs(f32, @fabs(@as(f32, -0.4)), result[3], epsilon));
565 var result = @abs(v);
566 try expect(math.approxEqAbs(f32, @abs(@as(f32, 1.1)), result[0], epsilon));
567 try expect(math.approxEqAbs(f32, @abs(@as(f32, -2.2)), result[1], epsilon));
568 try expect(math.approxEqAbs(f32, @abs(@as(f32, 0.3)), result[2], epsilon));
569 try expect(math.approxEqAbs(f32, @abs(@as(f32, -0.4)), result[3], epsilon));
570570}
571571
572test "another, possibly redundant, @fabs test" {
572test "another, possibly redundant, @abs test" {
573 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
573574 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
574575 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
575576 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
......@@ -587,11 +588,12 @@ test "another, possibly redundant, @fabs test" {
587588
588589 const x = 14.0;
589590 const y = -x;
590 const z = @fabs(y);
591 const z = @abs(y);
591592 try comptime std.testing.expectEqual(x, z);
592593}
593594
594test "@fabs f80" {
595test "@abs f80" {
596 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
595597 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
596598 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
597599 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
......@@ -604,11 +606,12 @@ test "@fabs f80" {
604606
605607fn testFabsLegacy(comptime T: type, x: T) !void {
606608 const y = -x;
607 const z = @fabs(y);
609 const z = @abs(y);
608610 try expect(x == z);
609611}
610612
611test "a third @fabs test, surely there should not be three fabs tests" {
613test "a third @abs test, surely there should not be three fabs tests" {
614 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
612615 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
613616 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
614617 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
......@@ -617,23 +620,23 @@ test "a third @fabs test, surely there should not be three fabs tests" {
617620
618621 inline for ([_]type{ f16, f32, f64, f80, f128, c_longdouble }) |T| {
619622 // normals
620 try expect(@fabs(@as(T, 1.0)) == 1.0);
621 try expect(@fabs(@as(T, -1.0)) == 1.0);
622 try expect(@fabs(math.floatMin(T)) == math.floatMin(T));
623 try expect(@fabs(-math.floatMin(T)) == math.floatMin(T));
624 try expect(@fabs(math.floatMax(T)) == math.floatMax(T));
625 try expect(@fabs(-math.floatMax(T)) == math.floatMax(T));
623 try expect(@abs(@as(T, 1.0)) == 1.0);
624 try expect(@abs(@as(T, -1.0)) == 1.0);
625 try expect(@abs(math.floatMin(T)) == math.floatMin(T));
626 try expect(@abs(-math.floatMin(T)) == math.floatMin(T));
627 try expect(@abs(math.floatMax(T)) == math.floatMax(T));
628 try expect(@abs(-math.floatMax(T)) == math.floatMax(T));
626629
627630 // subnormals
628 try expect(@fabs(@as(T, 0.0)) == 0.0);
629 try expect(@fabs(@as(T, -0.0)) == 0.0);
630 try expect(@fabs(math.floatTrueMin(T)) == math.floatTrueMin(T));
631 try expect(@fabs(-math.floatTrueMin(T)) == math.floatTrueMin(T));
631 try expect(@abs(@as(T, 0.0)) == 0.0);
632 try expect(@abs(@as(T, -0.0)) == 0.0);
633 try expect(@abs(math.floatTrueMin(T)) == math.floatTrueMin(T));
634 try expect(@abs(-math.floatTrueMin(T)) == math.floatTrueMin(T));
632635
633636 // non-finite numbers
634 try expect(math.isPositiveInf(@fabs(math.inf(T))));
635 try expect(math.isPositiveInf(@fabs(-math.inf(T))));
636 try expect(math.isNan(@fabs(math.nan(T))));
637 try expect(math.isPositiveInf(@abs(math.inf(T))));
638 try expect(math.isPositiveInf(@abs(-math.inf(T))));
639 try expect(math.isNan(@abs(math.nan(T))));
637640 }
638641}
639642
test/behavior/math.zig+3-3
......@@ -1391,7 +1391,7 @@ fn frem(comptime T: type) !void {
13911391}
13921392
13931393fn fremOne(comptime T: type, a: T, b: T, c: T, epsilon: T) !void {
1394 try expect(@fabs(@rem(a, b) - c) < epsilon);
1394 try expect(@abs(@rem(a, b) - c) < epsilon);
13951395}
13961396
13971397test "float modulo division using @mod" {
......@@ -1434,7 +1434,7 @@ fn fmod(comptime T: type) !void {
14341434}
14351435
14361436fn fmodOne(comptime T: type, a: T, b: T, c: T, epsilon: T) !void {
1437 try expect(@fabs(@mod(@as(T, a), @as(T, b)) - @as(T, c)) < epsilon);
1437 try expect(@abs(@mod(@as(T, a), @as(T, b)) - @as(T, c)) < epsilon);
14381438}
14391439
14401440test "@round" {
......@@ -1627,7 +1627,7 @@ fn testAbsFloat() !void {
16271627 try testAbsFloatOne(10.05, 10.05);
16281628}
16291629fn testAbsFloatOne(in: f32, out: f32) !void {
1630 try expect(@fabs(@as(f32, in)) == @as(f32, out));
1630 try expect(@abs(@as(f32, in)) == @as(f32, out));
16311631}
16321632
16331633test "mod lazy values" {