authorgravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2024-08-20 18:41:26-04:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2024-08-20 18:41:26-04:00
log16d74809d44d6bb8db1a32923ef8db43d956e24d
tree78344089f8c4cc2bdc07ea74f0a47b8f500d2fcb
parent0a70455095a19a4c18497e6786ca6139c1cc2892
parent55864e98e08c9d44ee2ea6fc1f3a3c2a98042310
signaturebadge-check Signed by PGP key B5690EEEBB952194

Merge pull request #21140 from jacobly0/self-dwarf

Dwarf: inline calls progress

30 files changed, 1236 insertions(+), 698 deletions(-)

src/Air.zig+14-11
......@@ -456,6 +456,8 @@ pub const Inst = struct {
456456 /// Same as `dbg_var_ptr` except the local is a const, not a var, and the
457457 /// operand is the local's value.
458458 dbg_var_val,
459 /// Same as `dbg_var_val` except the local is an inline function argument.
460 dbg_arg_inline,
459461 /// ?T => bool
460462 /// Result type is always bool.
461463 /// Uses the `un_op` field.
......@@ -1022,10 +1024,7 @@ pub const Inst = struct {
10221024 ty: Ref,
10231025 /// Index into `extra` of a null-terminated string representing the parameter name.
10241026 /// This is `.none` if debug info is stripped.
1025 name: enum(u32) {
1026 none = std.math.maxInt(u32),
1027 _,
1028 },
1027 name: NullTerminatedString,
10291028 },
10301029 ty_op: struct {
10311030 ty: Ref,
......@@ -1440,6 +1439,7 @@ pub fn typeOfIndex(air: *const Air, inst: Air.Inst.Index, ip: *const InternPool)
14401439 .dbg_stmt,
14411440 .dbg_var_ptr,
14421441 .dbg_var_val,
1442 .dbg_arg_inline,
14431443 .store,
14441444 .store_safe,
14451445 .fence,
......@@ -1562,14 +1562,16 @@ pub fn value(air: Air, inst: Inst.Ref, pt: Zcu.PerThread) !?Value {
15621562 return air.typeOfIndex(index, &pt.zcu.intern_pool).onePossibleValue(pt);
15631563}
15641564
1565pub fn nullTerminatedString(air: Air, index: usize) [:0]const u8 {
1566 const bytes = std.mem.sliceAsBytes(air.extra[index..]);
1567 var end: usize = 0;
1568 while (bytes[end] != 0) {
1569 end += 1;
1565pub const NullTerminatedString = enum(u32) {
1566 none = std.math.maxInt(u32),
1567 _,
1568
1569 pub fn toSlice(nts: NullTerminatedString, air: Air) [:0]const u8 {
1570 if (nts == .none) return "";
1571 const bytes = std.mem.sliceAsBytes(air.extra[@intFromEnum(nts)..]);
1572 return bytes[0..std.mem.indexOfScalar(u8, bytes, 0).? :0];
15701573 }
1571 return bytes[0..end :0];
1572}
1574};
15731575
15741576/// Returns whether the given instruction must always be lowered, for instance
15751577/// because it can cause side effects. If an instruction does not need to be
......@@ -1596,6 +1598,7 @@ pub fn mustLower(air: Air, inst: Air.Inst.Index, ip: *const InternPool) bool {
15961598 .dbg_inline_block,
15971599 .dbg_var_ptr,
15981600 .dbg_var_val,
1601 .dbg_arg_inline,
15991602 .ret,
16001603 .ret_safe,
16011604 .ret_load,
src/Air/types_resolved.zig+1
......@@ -339,6 +339,7 @@ fn checkBody(air: Air, body: []const Air.Inst.Index, zcu: *Zcu) bool {
339339
340340 .dbg_var_ptr,
341341 .dbg_var_val,
342 .dbg_arg_inline,
342343 => {
343344 if (!checkRef(data.pl_op.operand, zcu)) return false;
344345 },
src/Compilation.zig+20-8
......@@ -2997,14 +2997,26 @@ pub fn saveState(comp: *Compilation) !void {
29972997 addBuf(&bufs, mem.sliceAsBytes(ip.free_dep_entries.items));
29982998
29992999 for (ip.locals, pt_headers.items) |*local, pt_header| {
3000 addBuf(&bufs, mem.sliceAsBytes(local.shared.limbs.view().items(.@"0")[0..pt_header.intern_pool.limbs_len]));
3001 addBuf(&bufs, mem.sliceAsBytes(local.shared.extra.view().items(.@"0")[0..pt_header.intern_pool.extra_len]));
3002 addBuf(&bufs, mem.sliceAsBytes(local.shared.items.view().items(.data)[0..pt_header.intern_pool.items_len]));
3003 addBuf(&bufs, mem.sliceAsBytes(local.shared.items.view().items(.tag)[0..pt_header.intern_pool.items_len]));
3004 addBuf(&bufs, local.shared.strings.view().items(.@"0")[0..pt_header.intern_pool.string_bytes_len]);
3005 addBuf(&bufs, mem.sliceAsBytes(local.shared.tracked_insts.view().items(.@"0")[0..pt_header.intern_pool.tracked_insts_len]));
3006 addBuf(&bufs, mem.sliceAsBytes(local.shared.files.view().items(.bin_digest)[0..pt_header.intern_pool.files_len]));
3007 addBuf(&bufs, mem.sliceAsBytes(local.shared.files.view().items(.root_type)[0..pt_header.intern_pool.files_len]));
3000 if (pt_header.intern_pool.limbs_len > 0) {
3001 addBuf(&bufs, mem.sliceAsBytes(local.shared.limbs.view().items(.@"0")[0..pt_header.intern_pool.limbs_len]));
3002 }
3003 if (pt_header.intern_pool.extra_len > 0) {
3004 addBuf(&bufs, mem.sliceAsBytes(local.shared.extra.view().items(.@"0")[0..pt_header.intern_pool.extra_len]));
3005 }
3006 if (pt_header.intern_pool.items_len > 0) {
3007 addBuf(&bufs, mem.sliceAsBytes(local.shared.items.view().items(.data)[0..pt_header.intern_pool.items_len]));
3008 addBuf(&bufs, mem.sliceAsBytes(local.shared.items.view().items(.tag)[0..pt_header.intern_pool.items_len]));
3009 }
3010 if (pt_header.intern_pool.string_bytes_len > 0) {
3011 addBuf(&bufs, local.shared.strings.view().items(.@"0")[0..pt_header.intern_pool.string_bytes_len]);
3012 }
3013 if (pt_header.intern_pool.tracked_insts_len > 0) {
3014 addBuf(&bufs, mem.sliceAsBytes(local.shared.tracked_insts.view().items(.@"0")[0..pt_header.intern_pool.tracked_insts_len]));
3015 }
3016 if (pt_header.intern_pool.files_len > 0) {
3017 addBuf(&bufs, mem.sliceAsBytes(local.shared.files.view().items(.bin_digest)[0..pt_header.intern_pool.files_len]));
3018 addBuf(&bufs, mem.sliceAsBytes(local.shared.files.view().items(.root_type)[0..pt_header.intern_pool.files_len]));
3019 }
30083020 }
30093021
30103022 //// TODO: compilation errors
src/Liveness.zig+2
......@@ -464,6 +464,7 @@ pub fn categorizeOperand(
464464
465465 .dbg_var_ptr,
466466 .dbg_var_val,
467 .dbg_arg_inline,
467468 => {
468469 const o = air_datas[@intFromEnum(inst)].pl_op.operand;
469470 if (o == operand_ref) return matchOperandSmallIndex(l, inst, 0, .none);
......@@ -1097,6 +1098,7 @@ fn analyzeInst(
10971098
10981099 .dbg_var_ptr,
10991100 .dbg_var_val,
1101 .dbg_arg_inline,
11001102 => {
11011103 const operand = inst_datas[@intFromEnum(inst)].pl_op.operand;
11021104 return analyzeOperands(a, pass, data, inst, .{ operand, .none, .none });
src/Liveness/Verify.zig+1
......@@ -157,6 +157,7 @@ fn verifyBody(self: *Verify, body: []const Air.Inst.Index) Error!void {
157157 },
158158 .dbg_var_ptr,
159159 .dbg_var_val,
160 .dbg_arg_inline,
160161 .wasm_memory_grow,
161162 => {
162163 const pl_op = data[@intFromEnum(inst)].pl_op;
src/Sema.zig+11-10
......@@ -376,7 +376,7 @@ pub const Block = struct {
376376
377377 c_import_buf: ?*std.ArrayList(u8) = null,
378378
379 /// If not `null`, this boolean is set when a `dbg_var_ptr` or `dbg_var_val`
379 /// If not `null`, this boolean is set when a `dbg_var_ptr`, `dbg_var_val`, or `dbg_arg_inline`.
380380 /// instruction is emitted. It signals that the innermost lexically
381381 /// enclosing `block`/`block_inline` should be translated into a real AIR
382382 /// `block` in order for codegen to match lexical scoping for debug vars.
......@@ -6567,7 +6567,7 @@ fn addDbgVar(
65676567 const operand_ty = sema.typeOf(operand);
65686568 const val_ty = switch (air_tag) {
65696569 .dbg_var_ptr => operand_ty.childType(mod),
6570 .dbg_var_val => operand_ty,
6570 .dbg_var_val, .dbg_arg_inline => operand_ty,
65716571 else => unreachable,
65726572 };
65736573 if (try sema.typeRequiresComptime(val_ty)) return;
......@@ -6586,25 +6586,26 @@ fn addDbgVar(
65866586 if (block.need_debug_scope) |ptr| ptr.* = true;
65876587
65886588 // Add the name to the AIR.
6589 const name_extra_index = try sema.appendAirString(name);
6589 const name_nts = try sema.appendAirString(name);
65906590
65916591 _ = try block.addInst(.{
65926592 .tag = air_tag,
65936593 .data = .{ .pl_op = .{
6594 .payload = name_extra_index,
6594 .payload = @intFromEnum(name_nts),
65956595 .operand = operand,
65966596 } },
65976597 });
65986598}
65996599
6600pub fn appendAirString(sema: *Sema, str: []const u8) Allocator.Error!u32 {
6601 const str_extra_index: u32 = @intCast(sema.air_extra.items.len);
6600pub fn appendAirString(sema: *Sema, str: []const u8) Allocator.Error!Air.NullTerminatedString {
6601 if (str.len == 0) return .none;
6602 const nts: Air.NullTerminatedString = @enumFromInt(sema.air_extra.items.len);
66026603 const elements_used = str.len / 4 + 1;
66036604 const elements = try sema.air_extra.addManyAsSlice(sema.gpa, elements_used);
66046605 const buffer = mem.sliceAsBytes(elements);
66056606 @memcpy(buffer[0..str.len], str);
66066607 buffer[str.len] = 0;
6607 return str_extra_index;
6608 return nts;
66086609}
66096610
66106611fn zirDeclRef(sema: *Sema, block: *Block, inst: Zir.Inst.Index) CompileError!Air.Inst.Ref {
......@@ -7748,14 +7749,14 @@ fn analyzeCall(
77487749 const param_name = sema.code.nullTerminatedString(extra.data.name);
77497750 const inst = sema.inst_map.get(param).?;
77507751
7751 try sema.addDbgVar(&child_block, inst, .dbg_var_val, param_name);
7752 try sema.addDbgVar(&child_block, inst, .dbg_arg_inline, param_name);
77527753 },
77537754 .param_anytype, .param_anytype_comptime => {
77547755 const inst_data = sema.code.instructions.items(.data)[@intFromEnum(param)].str_tok;
77557756 const param_name = inst_data.get(sema.code);
77567757 const inst = sema.inst_map.get(param).?;
77577758
7758 try sema.addDbgVar(&child_block, inst, .dbg_var_val, param_name);
7759 try sema.addDbgVar(&child_block, inst, .dbg_arg_inline, param_name);
77597760 },
77607761 else => continue,
77617762 };
......@@ -8266,7 +8267,7 @@ fn instantiateGenericCall(
82668267 .name = if (child_block.ownerModule().strip)
82678268 .none
82688269 else
8269 @enumFromInt(try sema.appendAirString(fn_zir.nullTerminatedString(param_name))),
8270 try sema.appendAirString(fn_zir.nullTerminatedString(param_name)),
82708271 } },
82718272 }));
82728273 try child_block.params.append(sema.arena, .{
src/Zcu/PerThread.zig+15-13
......@@ -1240,11 +1240,11 @@ fn semaCau(pt: Zcu.PerThread, cau_index: InternPool.Cau.Index) !SemaCauResult {
12401240 };
12411241 }
12421242
1243 const nav_already_populated, const queue_linker_work = switch (ip.indexToKey(decl_val.toIntern())) {
1244 .func => |f| .{ f.owner_nav == nav_index, false },
1245 .variable => |v| .{ false, v.owner_nav == nav_index },
1246 .@"extern" => .{ false, false },
1247 else => .{ false, true },
1243 const nav_already_populated, const queue_linker_work, const resolve_type = switch (ip.indexToKey(decl_val.toIntern())) {
1244 .func => |f| .{ f.owner_nav == nav_index, true, false },
1245 .variable => |v| .{ false, v.owner_nav == nav_index, true },
1246 .@"extern" => .{ false, false, false },
1247 else => .{ false, true, true },
12481248 };
12491249
12501250 if (nav_already_populated) {
......@@ -1317,14 +1317,16 @@ fn semaCau(pt: Zcu.PerThread, cau_index: InternPool.Cau.Index) !SemaCauResult {
13171317 queue_codegen: {
13181318 if (!queue_linker_work) break :queue_codegen;
13191319
1320 // Needed for codegen_nav which will call updateDecl and then the
1321 // codegen backend wants full access to the Decl Type.
1322 // We also need this for the `isFnOrHasRuntimeBits` check below.
1323 // TODO: we could make the language more lenient by deferring this work
1324 // to the `codegen_nav` job.
1325 try decl_ty.resolveFully(pt);
1320 if (resolve_type) {
1321 // Needed for codegen_nav which will call updateDecl and then the
1322 // codegen backend wants full access to the Decl Type.
1323 // We also need this for the `isFnOrHasRuntimeBits` check below.
1324 // TODO: we could make the language more lenient by deferring this work
1325 // to the `codegen_nav` job.
1326 try decl_ty.resolveFully(pt);
1327 }
13261328
1327 if (!decl_ty.isFnOrHasRuntimeBits(pt)) {
1329 if (!resolve_type or !decl_ty.hasRuntimeBits(pt)) {
13281330 if (zcu.comp.config.use_llvm) break :queue_codegen;
13291331 if (file.mod.strip) break :queue_codegen;
13301332 }
......@@ -2158,7 +2160,7 @@ fn analyzeFnBody(pt: Zcu.PerThread, func_index: InternPool.Index) Zcu.SemaError!
21582160 .name = if (inner_block.ownerModule().strip)
21592161 .none
21602162 else
2161 @enumFromInt(try sema.appendAirString(sema.code.nullTerminatedString(param_name))),
2163 try sema.appendAirString(sema.code.nullTerminatedString(param_name)),
21622164 } },
21632165 });
21642166 }
src/arch/aarch64/CodeGen.zig+15-16
......@@ -170,7 +170,9 @@ const DbgInfoReloc = struct {
170170
171171 fn genDbgInfo(reloc: DbgInfoReloc, function: Self) !void {
172172 switch (reloc.tag) {
173 .arg => try reloc.genArgDbgInfo(function),
173 .arg,
174 .dbg_arg_inline,
175 => try reloc.genArgDbgInfo(function),
174176
175177 .dbg_var_ptr,
176178 .dbg_var_val,
......@@ -201,7 +203,7 @@ const DbgInfoReloc = struct {
201203 else => unreachable, // not a possible argument
202204
203205 };
204 try dw.genVarDebugInfo(.local_arg, reloc.name, reloc.ty, loc);
206 try dw.genLocalDebugInfo(.local_arg, reloc.name, reloc.ty, loc);
205207 },
206208 .plan9 => {},
207209 .none => {},
......@@ -237,7 +239,7 @@ const DbgInfoReloc = struct {
237239 break :blk .empty;
238240 },
239241 };
240 try dwarf.genVarDebugInfo(.local_var, reloc.name, reloc.ty, loc);
242 try dwarf.genLocalDebugInfo(.local_var, reloc.name, reloc.ty, loc);
241243 },
242244 .plan9 => {},
243245 .none => {},
......@@ -799,6 +801,7 @@ fn genBody(self: *Self, body: []const Air.Inst.Index) InnerError!void {
799801 .dbg_inline_block => try self.airDbgInlineBlock(inst),
800802 .dbg_var_ptr,
801803 .dbg_var_val,
804 .dbg_arg_inline,
802805 => try self.airDbgVar(inst),
803806
804807 .call => try self.airCall(inst, .auto),
......@@ -4220,17 +4223,13 @@ fn airArg(self: *Self, inst: Air.Inst.Index) !void {
42204223
42214224 const ty = self.typeOfIndex(inst);
42224225 const tag = self.air.instructions.items(.tag)[@intFromEnum(inst)];
4223
4224 const name_nts = self.air.instructions.items(.data)[@intFromEnum(inst)].arg.name;
4225 if (name_nts != .none) {
4226 const name = self.air.nullTerminatedString(@intFromEnum(name_nts));
4227 try self.dbg_info_relocs.append(self.gpa, .{
4228 .tag = tag,
4229 .ty = ty,
4230 .name = name,
4231 .mcv = self.args[arg_index],
4232 });
4233 }
4226 const name = self.air.instructions.items(.data)[@intFromEnum(inst)].arg.name;
4227 if (name != .none) try self.dbg_info_relocs.append(self.gpa, .{
4228 .tag = tag,
4229 .ty = ty,
4230 .name = name.toSlice(self.air),
4231 .mcv = self.args[arg_index],
4232 });
42344233
42354234 const result: MCValue = if (self.liveness.isUnused(inst)) .dead else self.args[arg_index];
42364235 return self.finishAir(inst, result, .{ .none, .none, .none });
......@@ -4644,14 +4643,14 @@ fn airDbgVar(self: *Self, inst: Air.Inst.Index) !void {
46444643 const tag = self.air.instructions.items(.tag)[@intFromEnum(inst)];
46454644 const ty = self.typeOf(operand);
46464645 const mcv = try self.resolveInst(operand);
4647 const name = self.air.nullTerminatedString(pl_op.payload);
4646 const name: Air.NullTerminatedString = @enumFromInt(pl_op.payload);
46484647
46494648 log.debug("airDbgVar: %{d}: {}, {}", .{ inst, ty.fmtDebug(), mcv });
46504649
46514650 try self.dbg_info_relocs.append(self.gpa, .{
46524651 .tag = tag,
46534652 .ty = ty,
4654 .name = name,
4653 .name = name.toSlice(self.air),
46554654 .mcv = mcv,
46564655 });
46574656
src/arch/arm/CodeGen.zig+15-15
......@@ -248,7 +248,9 @@ const DbgInfoReloc = struct {
248248
249249 fn genDbgInfo(reloc: DbgInfoReloc, function: Self) !void {
250250 switch (reloc.tag) {
251 .arg => try reloc.genArgDbgInfo(function),
251 .arg,
252 .dbg_arg_inline,
253 => try reloc.genArgDbgInfo(function),
252254
253255 .dbg_var_ptr,
254256 .dbg_var_val,
......@@ -279,7 +281,7 @@ const DbgInfoReloc = struct {
279281 else => unreachable, // not a possible argument
280282 };
281283
282 try dw.genVarDebugInfo(.local_arg, reloc.name, reloc.ty, loc);
284 try dw.genLocalDebugInfo(.local_arg, reloc.name, reloc.ty, loc);
283285 },
284286 .plan9 => {},
285287 .none => {},
......@@ -315,7 +317,7 @@ const DbgInfoReloc = struct {
315317 break :blk .empty;
316318 },
317319 };
318 try dw.genVarDebugInfo(.local_var, reloc.name, reloc.ty, loc);
320 try dw.genLocalDebugInfo(.local_var, reloc.name, reloc.ty, loc);
319321 },
320322 .plan9 => {},
321323 .none => {},
......@@ -786,6 +788,7 @@ fn genBody(self: *Self, body: []const Air.Inst.Index) InnerError!void {
786788 .dbg_inline_block => try self.airDbgInlineBlock(inst),
787789 .dbg_var_ptr,
788790 .dbg_var_val,
791 .dbg_arg_inline,
789792 => try self.airDbgVar(inst),
790793
791794 .call => try self.airCall(inst, .auto),
......@@ -4199,16 +4202,13 @@ fn airArg(self: *Self, inst: Air.Inst.Index) !void {
41994202 const ty = self.typeOfIndex(inst);
42004203 const tag = self.air.instructions.items(.tag)[@intFromEnum(inst)];
42014204
4202 const name_nts = self.air.instructions.items(.data)[@intFromEnum(inst)].arg.name;
4203 if (name_nts != .none) {
4204 const name = self.air.nullTerminatedString(@intFromEnum(name_nts));
4205 try self.dbg_info_relocs.append(self.gpa, .{
4206 .tag = tag,
4207 .ty = ty,
4208 .name = name,
4209 .mcv = self.args[arg_index],
4210 });
4211 }
4205 const name = self.air.instructions.items(.data)[@intFromEnum(inst)].arg.name;
4206 if (name != .none) try self.dbg_info_relocs.append(self.gpa, .{
4207 .tag = tag,
4208 .ty = ty,
4209 .name = name.toSlice(self.air),
4210 .mcv = self.args[arg_index],
4211 });
42124212
42134213 const result: MCValue = if (self.liveness.isUnused(inst)) .dead else self.args[arg_index];
42144214 return self.finishAir(inst, result, .{ .none, .none, .none });
......@@ -4612,14 +4612,14 @@ fn airDbgVar(self: *Self, inst: Air.Inst.Index) !void {
46124612 const tag = self.air.instructions.items(.tag)[@intFromEnum(inst)];
46134613 const ty = self.typeOf(operand);
46144614 const mcv = try self.resolveInst(operand);
4615 const name = self.air.nullTerminatedString(pl_op.payload);
4615 const name: Air.NullTerminatedString = @enumFromInt(pl_op.payload);
46164616
46174617 log.debug("airDbgVar: %{d}: {}, {}", .{ inst, ty.fmtDebug(), mcv });
46184618
46194619 try self.dbg_info_relocs.append(self.gpa, .{
46204620 .tag = tag,
46214621 .ty = ty,
4622 .name = name,
4622 .name = name.toSlice(self.air),
46234623 .mcv = mcv,
46244624 });
46254625
src/arch/riscv64/CodeGen.zig+16-6
......@@ -1644,6 +1644,7 @@ fn genBody(func: *Func, body: []const Air.Inst.Index) InnerError!void {
16441644
16451645 .dbg_var_ptr,
16461646 .dbg_var_val,
1647 .dbg_arg_inline,
16471648 => try func.airDbgVar(inst),
16481649
16491650 .dbg_inline_block => try func.airDbgInlineBlock(inst),
......@@ -4673,11 +4674,15 @@ fn genArgDbgInfo(func: Func, inst: Air.Inst.Index, mcv: MCValue) !void {
46734674 const arg = func.air.instructions.items(.data)[@intFromEnum(inst)].arg;
46744675 const ty = arg.ty.toType();
46754676 if (arg.name == .none) return;
4676 const name = func.air.nullTerminatedString(@intFromEnum(arg.name));
46774677
46784678 switch (func.debug_output) {
46794679 .dwarf => |dw| switch (mcv) {
4680 .register => |reg| try dw.genVarDebugInfo(.local_arg, name, ty, .{ .reg = reg.dwarfNum() }),
4680 .register => |reg| try dw.genLocalDebugInfo(
4681 .local_arg,
4682 arg.name.toSlice(func.air),
4683 ty,
4684 .{ .reg = reg.dwarfNum() },
4685 ),
46814686 .load_frame => {},
46824687 else => {},
46834688 },
......@@ -5179,16 +5184,17 @@ fn airDbgVar(func: *Func, inst: Air.Inst.Index) !void {
51795184 const operand = pl_op.operand;
51805185 const ty = func.typeOf(operand);
51815186 const mcv = try func.resolveInst(operand);
5187 const name: Air.NullTerminatedString = @enumFromInt(pl_op.payload);
51825188
5183 const name = func.air.nullTerminatedString(pl_op.payload);
5184
5185 try func.genVarDbgInfo(ty, mcv, name);
5189 const tag = func.air.instructions.items(.tag)[@intFromEnum(inst)];
5190 try func.genVarDbgInfo(tag, ty, mcv, name.toSlice(func.air));
51865191
51875192 return func.finishAir(inst, .unreach, .{ operand, .none, .none });
51885193}
51895194
51905195fn genVarDbgInfo(
51915196 func: Func,
5197 tag: Air.Inst.Tag,
51925198 ty: Type,
51935199 mcv: MCValue,
51945200 name: []const u8,
......@@ -5205,7 +5211,11 @@ fn genVarDbgInfo(
52055211 break :blk .empty;
52065212 },
52075213 };
5208 try dwarf.genVarDebugInfo(.local_var, name, ty, loc);
5214 try dwarf.genLocalDebugInfo(switch (tag) {
5215 else => unreachable,
5216 .dbg_var_ptr, .dbg_var_val => .local_var,
5217 .dbg_arg_inline => .local_arg,
5218 }, name, ty, loc);
52095219 },
52105220 .plan9 => {},
52115221 .none => {},
src/arch/sparc64/CodeGen.zig+8-5
......@@ -643,6 +643,7 @@ fn genBody(self: *Self, body: []const Air.Inst.Index) InnerError!void {
643643 .dbg_inline_block => try self.airDbgInlineBlock(inst),
644644 .dbg_var_ptr,
645645 .dbg_var_val,
646 .dbg_arg_inline,
646647 => try self.airDbgVar(inst),
647648
648649 .call => try self.airCall(inst, .auto),
......@@ -1662,7 +1663,7 @@ fn airDbgStmt(self: *Self, inst: Air.Inst.Index) !void {
16621663
16631664fn airDbgVar(self: *Self, inst: Air.Inst.Index) !void {
16641665 const pl_op = self.air.instructions.items(.data)[@intFromEnum(inst)].pl_op;
1665 const name = self.air.nullTerminatedString(pl_op.payload);
1666 const name: Air.NullTerminatedString = @enumFromInt(pl_op.payload);
16661667 const operand = pl_op.operand;
16671668 // TODO emit debug info for this variable
16681669 _ = name;
......@@ -3582,13 +3583,15 @@ fn genArgDbgInfo(self: Self, inst: Air.Inst.Index, mcv: MCValue) !void {
35823583 const arg = self.air.instructions.items(.data)[@intFromEnum(inst)].arg;
35833584 const ty = arg.ty.toType();
35843585 if (arg.name == .none) return;
3585 const name = self.air.nullTerminatedString(@intFromEnum(arg.name));
35863586
35873587 switch (self.debug_output) {
35883588 .dwarf => |dw| switch (mcv) {
3589 .register => |reg| try dw.genVarDebugInfo(.local_arg, name, ty, .{
3590 .reg = reg.dwarfNum(),
3591 }),
3589 .register => |reg| try dw.genLocalDebugInfo(
3590 .local_arg,
3591 arg.name.toSlice(self.air),
3592 ty,
3593 .{ .reg = reg.dwarfNum() },
3594 ),
35923595 else => {},
35933596 },
35943597 else => {},
src/arch/wasm/CodeGen.zig+19-13
......@@ -1917,8 +1917,9 @@ fn genInst(func: *CodeGen, inst: Air.Inst.Index) InnerError!void {
19171917
19181918 .dbg_stmt => func.airDbgStmt(inst),
19191919 .dbg_inline_block => func.airDbgInlineBlock(inst),
1920 .dbg_var_ptr => func.airDbgVar(inst, true),
1921 .dbg_var_val => func.airDbgVar(inst, false),
1920 .dbg_var_ptr => func.airDbgVar(inst, .local_var, true),
1921 .dbg_var_val => func.airDbgVar(inst, .local_var, false),
1922 .dbg_arg_inline => func.airDbgVar(inst, .local_arg, false),
19221923
19231924 .call => func.airCall(inst, .auto),
19241925 .call_always_tail => func.airCall(inst, .always_tail),
......@@ -2585,13 +2586,13 @@ fn airArg(func: *CodeGen, inst: Air.Inst.Index) InnerError!void {
25852586
25862587 switch (func.debug_output) {
25872588 .dwarf => |dwarf| {
2588 const name_nts = func.air.instructions.items(.data)[@intFromEnum(inst)].arg.name;
2589 if (name_nts != .none) {
2590 const name = func.air.nullTerminatedString(@intFromEnum(name_nts));
2591 try dwarf.genVarDebugInfo(.local_arg, name, arg_ty, .{
2592 .wasm_ext = .{ .local = arg.local.value },
2593 });
2594 }
2589 const name = func.air.instructions.items(.data)[@intFromEnum(inst)].arg.name;
2590 if (name != .none) try dwarf.genLocalDebugInfo(
2591 .local_arg,
2592 name.toSlice(func.air),
2593 arg_ty,
2594 .{ .wasm_ext = .{ .local = arg.local.value } },
2595 );
25952596 },
25962597 else => {},
25972598 }
......@@ -6454,7 +6455,12 @@ fn airDbgInlineBlock(func: *CodeGen, inst: Air.Inst.Index) InnerError!void {
64546455 try func.lowerBlock(inst, ty_pl.ty.toType(), @ptrCast(func.air.extra[extra.end..][0..extra.data.body_len]));
64556456}
64566457
6457fn airDbgVar(func: *CodeGen, inst: Air.Inst.Index, is_ptr: bool) InnerError!void {
6458fn airDbgVar(
6459 func: *CodeGen,
6460 inst: Air.Inst.Index,
6461 local_tag: link.File.Dwarf.WipNav.LocalTag,
6462 is_ptr: bool,
6463) InnerError!void {
64586464 _ = is_ptr;
64596465 if (func.debug_output != .dwarf) return func.finishAir(inst, .none, &.{});
64606466
......@@ -6464,8 +6470,8 @@ fn airDbgVar(func: *CodeGen, inst: Air.Inst.Index, is_ptr: bool) InnerError!void
64646470
64656471 log.debug("airDbgVar: %{d}: {}, {}", .{ inst, ty.fmtDebug(), operand });
64666472
6467 const name = func.air.nullTerminatedString(pl_op.payload);
6468 log.debug(" var name = ({s})", .{name});
6473 const name: Air.NullTerminatedString = @enumFromInt(pl_op.payload);
6474 log.debug(" var name = ({s})", .{name.toSlice(func.air)});
64696475
64706476 const loc: link.File.Dwarf.Loc = switch (operand) {
64716477 .local => |local| .{ .wasm_ext = .{ .local = local.value } },
......@@ -6474,7 +6480,7 @@ fn airDbgVar(func: *CodeGen, inst: Air.Inst.Index, is_ptr: bool) InnerError!void
64746480 break :blk .empty;
64756481 },
64766482 };
6477 try func.debug_output.dwarf.genVarDebugInfo(.local_var, name, ty, loc);
6483 try func.debug_output.dwarf.genLocalDebugInfo(local_tag, name.toSlice(func.air), ty, loc);
64786484
64796485 return func.finishAir(inst, .none, &.{});
64806486}
src/arch/x86_64/CodeGen.zig+268-238
......@@ -64,8 +64,8 @@ va_info: union {
6464 sysv: struct {
6565 gp_count: u32,
6666 fp_count: u32,
67 overflow_arg_area: FrameAddr,
68 reg_save_area: FrameAddr,
67 overflow_arg_area: bits.FrameAddr,
68 reg_save_area: bits.FrameAddr,
6969 },
7070 win64: struct {},
7171},
......@@ -81,9 +81,6 @@ mir_instructions: std.MultiArrayList(Mir.Inst) = .{},
8181/// MIR extra data
8282mir_extra: std.ArrayListUnmanaged(u32) = .{},
8383
84stack_args: std.ArrayListUnmanaged(StackVar) = .{},
85stack_vars: std.ArrayListUnmanaged(StackVar) = .{},
86
8784/// Byte offset within the source file of the ending curly.
8885end_di_line: u32,
8986end_di_column: u32,
......@@ -113,10 +110,6 @@ air_bookkeeping: @TypeOf(air_bookkeeping_init) = air_bookkeeping_init,
113110
114111const air_bookkeeping_init = if (std.debug.runtime_safety) @as(usize, 0) else {};
115112
116const FrameAddr = struct { index: FrameIndex, off: i32 = 0 };
117const RegisterOffset = struct { reg: Register, off: i32 = 0 };
118const SymbolOffset = struct { sym: u32, off: i32 = 0 };
119
120113const Owner = union(enum) {
121114 nav_index: InternPool.Nav.Index,
122115 lazy_sym: link.File.LazySymbol,
......@@ -174,7 +167,7 @@ pub const MCValue = union(enum) {
174167 /// The value is split across two registers.
175168 register_pair: [2]Register,
176169 /// The value is a constant offset from the value in a register.
177 register_offset: RegisterOffset,
170 register_offset: bits.RegisterOffset,
178171 /// The value is a tuple { wrapped, overflow } where wrapped value is stored in the GP register.
179172 register_overflow: struct { reg: Register, eflags: Condition },
180173 /// The value is in memory at a hard-coded address.
......@@ -182,11 +175,11 @@ pub const MCValue = union(enum) {
182175 memory: u64,
183176 /// The value is in memory at an address not-yet-allocated by the linker.
184177 /// This traditionally corresponds to a relocation emitted in a relocatable object file.
185 load_symbol: SymbolOffset,
178 load_symbol: bits.SymbolOffset,
186179 /// The address of the memory location not-yet-allocated by the linker.
187 lea_symbol: SymbolOffset,
180 lea_symbol: bits.SymbolOffset,
188181 /// The value is in memory at a constant offset from the address in a register.
189 indirect: RegisterOffset,
182 indirect: bits.RegisterOffset,
190183 /// The value is in memory.
191184 /// Payload is a symbol index.
192185 load_direct: u32,
......@@ -207,10 +200,10 @@ pub const MCValue = union(enum) {
207200 lea_tlv: u32,
208201 /// The value stored at an offset from a frame index
209202 /// Payload is a frame address.
210 load_frame: FrameAddr,
203 load_frame: bits.FrameAddr,
211204 /// The address of an offset from a frame index
212205 /// Payload is a frame address.
213 lea_frame: FrameAddr,
206 lea_frame: bits.FrameAddr,
214207 /// Supports integer_per_element abi
215208 elementwise_regs_then_frame: packed struct { regs: u3 = 0, frame_off: i29 = 0, frame_index: FrameIndex },
216209 /// This indicates that we have already allocated a frame index for this instruction,
......@@ -426,10 +419,7 @@ pub const MCValue = union(enum) {
426419 .load_symbol => |sym_off| {
427420 assert(sym_off.off == 0);
428421 return .{
429 .base = .{ .reloc = .{
430 .atom_index = try function.owner.getSymbolIndex(function),
431 .sym_index = sym_off.sym,
432 } },
422 .base = .{ .reloc = sym_off.sym_index },
433423 .mod = .{ .rm = .{
434424 .size = size,
435425 .disp = sym_off.off,
......@@ -456,8 +446,8 @@ pub const MCValue = union(enum) {
456446 .register_overflow => |pl| try writer.print("{s}:{s}", .{
457447 @tagName(pl.eflags), @tagName(pl.reg),
458448 }),
459 .load_symbol => |pl| try writer.print("[{} + 0x{x}]", .{ pl.sym, pl.off }),
460 .lea_symbol => |pl| try writer.print("{} + 0x{x}", .{ pl.sym, pl.off }),
449 .load_symbol => |pl| try writer.print("[{} + 0x{x}]", .{ pl.sym_index, pl.off }),
450 .lea_symbol => |pl| try writer.print("{} + 0x{x}", .{ pl.sym_index, pl.off }),
461451 .indirect => |pl| try writer.print("[{s} + 0x{x}]", .{ @tagName(pl.reg), pl.off }),
462452 .load_direct => |pl| try writer.print("[direct:{d}]", .{pl}),
463453 .lea_direct => |pl| try writer.print("direct:{d}", .{pl}),
......@@ -728,12 +718,6 @@ const InstTracking = struct {
728718 }
729719};
730720
731const StackVar = struct {
732 name: []const u8,
733 type: Type,
734 frame_addr: FrameAddr,
735};
736
737721const FrameAlloc = struct {
738722 abi_size: u31,
739723 spill_pad: u3,
......@@ -839,8 +823,6 @@ pub fn generate(
839823 function.exitlude_jump_relocs.deinit(gpa);
840824 function.mir_instructions.deinit(gpa);
841825 function.mir_extra.deinit(gpa);
842 function.stack_args.deinit(gpa);
843 function.stack_vars.deinit(gpa);
844826 }
845827
846828 wip_mir_log.debug("{}:", .{fmtNav(func.owner_nav, ip)});
......@@ -913,9 +895,6 @@ pub fn generate(
913895 else => |e| return e,
914896 };
915897
916 try function.genStackVarDebugInfo(.local_arg, function.stack_args.items);
917 try function.genStackVarDebugInfo(.local_var, function.stack_vars.items);
918
919898 var mir: Mir = .{
920899 .instructions = function.mir_instructions.toOwnedSlice(),
921900 .extra = try function.mir_extra.toOwnedSlice(gpa),
......@@ -924,6 +903,7 @@ pub fn generate(
924903 defer mir.deinit(gpa);
925904
926905 var emit: Emit = .{
906 .air = function.air,
927907 .lower = .{
928908 .bin_file = bin_file,
929909 .allocator = gpa,
......@@ -934,6 +914,13 @@ pub fn generate(
934914 .link_mode = comp.config.link_mode,
935915 .pic = mod.pic,
936916 },
917 .atom_index = function.owner.getSymbolIndex(&function) catch |err| switch (err) {
918 error.CodegenFail => return Result{ .fail = function.err_msg.? },
919 error.OutOfRegisters => return Result{
920 .fail = try ErrorMsg.create(gpa, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
921 },
922 else => |e| return e,
923 },
937924 .debug_output = debug_output,
938925 .code = code,
939926 .prev_di_pc = 0,
......@@ -1013,14 +1000,15 @@ pub fn generateLazy(
10131000 else => |e| return e,
10141001 };
10151002
1016 var mir = Mir{
1003 var mir: Mir = .{
10171004 .instructions = function.mir_instructions.toOwnedSlice(),
10181005 .extra = try function.mir_extra.toOwnedSlice(gpa),
10191006 .frame_locs = function.frame_locs.toOwnedSlice(),
10201007 };
10211008 defer mir.deinit(gpa);
10221009
1023 var emit = Emit{
1010 var emit: Emit = .{
1011 .air = function.air,
10241012 .lower = .{
10251013 .bin_file = bin_file,
10261014 .allocator = gpa,
......@@ -1031,6 +1019,13 @@ pub fn generateLazy(
10311019 .link_mode = comp.config.link_mode,
10321020 .pic = mod.pic,
10331021 },
1022 .atom_index = function.owner.getSymbolIndex(&function) catch |err| switch (err) {
1023 error.CodegenFail => return Result{ .fail = function.err_msg.? },
1024 error.OutOfRegisters => return Result{
1025 .fail = try ErrorMsg.create(gpa, src_loc, "CodeGen ran out of registers. This is a bug in the Zig compiler.", .{}),
1026 },
1027 else => |e| return e,
1028 },
10341029 .debug_output = debug_output,
10351030 .code = code,
10361031 .prev_di_pc = undefined, // no debug info yet
......@@ -1116,7 +1111,7 @@ fn formatWipMir(
11161111) @TypeOf(writer).Error!void {
11171112 const comp = data.self.bin_file.comp;
11181113 const mod = comp.root_mod;
1119 var lower = Lower{
1114 var lower: Lower = .{
11201115 .bin_file = data.self.bin_file,
11211116 .allocator = data.self.gpa,
11221117 .mir = .{
......@@ -1204,6 +1199,7 @@ fn addExtraAssumeCapacity(self: *Self, extra: anytype) u32 {
12041199 self.mir_extra.appendAssumeCapacity(switch (field.type) {
12051200 u32 => @field(extra, field.name),
12061201 i32, Mir.Memory.Info => @bitCast(@field(extra, field.name)),
1202 bits.FrameIndex => @intFromEnum(@field(extra, field.name)),
12071203 else => @compileError("bad field type: " ++ field.name ++ ": " ++ @typeName(field.type)),
12081204 });
12091205 }
......@@ -1357,6 +1353,124 @@ fn asmPlaceholder(self: *Self) !Mir.Inst.Index {
13571353 });
13581354}
13591355
1356const MirTagAir = enum { dbg_local };
1357
1358fn asmAir(self: *Self, tag: MirTagAir, inst: Air.Inst.Index) !void {
1359 _ = try self.addInst(.{
1360 .tag = .pseudo,
1361 .ops = switch (tag) {
1362 .dbg_local => .pseudo_dbg_local_a,
1363 },
1364 .data = .{ .a = .{ .air_inst = inst } },
1365 });
1366}
1367
1368fn asmAirImmediate(self: *Self, tag: MirTagAir, inst: Air.Inst.Index, imm: Immediate) !void {
1369 switch (imm) {
1370 .signed => |s| _ = try self.addInst(.{
1371 .tag = .pseudo,
1372 .ops = switch (tag) {
1373 .dbg_local => .pseudo_dbg_local_ai_s,
1374 },
1375 .data = .{ .ai = .{
1376 .air_inst = inst,
1377 .i = @bitCast(s),
1378 } },
1379 }),
1380 .unsigned => |u| _ = if (math.cast(u32, u)) |small| try self.addInst(.{
1381 .tag = .pseudo,
1382 .ops = switch (tag) {
1383 .dbg_local => .pseudo_dbg_local_ai_u,
1384 },
1385 .data = .{ .ai = .{
1386 .air_inst = inst,
1387 .i = small,
1388 } },
1389 }) else try self.addInst(.{
1390 .tag = .pseudo,
1391 .ops = switch (tag) {
1392 .dbg_local => .pseudo_dbg_local_ai_64,
1393 },
1394 .data = .{ .ai = .{
1395 .air_inst = inst,
1396 .i = try self.addExtra(Mir.Imm64.encode(u)),
1397 } },
1398 }),
1399 .reloc => |sym_off| _ = if (sym_off.off == 0) try self.addInst(.{
1400 .tag = .pseudo,
1401 .ops = switch (tag) {
1402 .dbg_local => .pseudo_dbg_local_as,
1403 },
1404 .data = .{ .as = .{
1405 .air_inst = inst,
1406 .sym_index = sym_off.sym_index,
1407 } },
1408 }) else try self.addInst(.{
1409 .tag = .pseudo,
1410 .ops = switch (tag) {
1411 .dbg_local => .pseudo_dbg_local_aso,
1412 },
1413 .data = .{ .ax = .{
1414 .air_inst = inst,
1415 .payload = try self.addExtra(sym_off),
1416 } },
1417 }),
1418 }
1419}
1420
1421fn asmAirRegisterImmediate(
1422 self: *Self,
1423 tag: MirTagAir,
1424 inst: Air.Inst.Index,
1425 reg: Register,
1426 imm: Immediate,
1427) !void {
1428 _ = try self.addInst(.{
1429 .tag = .pseudo,
1430 .ops = switch (tag) {
1431 .dbg_local => .pseudo_dbg_local_aro,
1432 },
1433 .data = .{ .rx = .{
1434 .r1 = reg,
1435 .payload = try self.addExtra(Mir.AirOffset{
1436 .air_inst = inst,
1437 .off = imm.signed,
1438 }),
1439 } },
1440 });
1441}
1442
1443fn asmAirFrameAddress(
1444 self: *Self,
1445 tag: MirTagAir,
1446 inst: Air.Inst.Index,
1447 frame_addr: bits.FrameAddr,
1448) !void {
1449 _ = try self.addInst(.{
1450 .tag = .pseudo,
1451 .ops = switch (tag) {
1452 .dbg_local => .pseudo_dbg_local_af,
1453 },
1454 .data = .{ .ax = .{
1455 .air_inst = inst,
1456 .payload = try self.addExtra(frame_addr),
1457 } },
1458 });
1459}
1460
1461fn asmAirMemory(self: *Self, tag: MirTagAir, inst: Air.Inst.Index, m: Memory) !void {
1462 _ = try self.addInst(.{
1463 .tag = .pseudo,
1464 .ops = switch (tag) {
1465 .dbg_local => .pseudo_dbg_local_am,
1466 },
1467 .data = .{ .ax = .{
1468 .air_inst = inst,
1469 .payload = try self.addExtra(Mir.Memory.encode(m)),
1470 } },
1471 });
1472}
1473
13601474fn asmOpOnly(self: *Self, tag: Mir.Inst.FixedTag) !void {
13611475 _ = try self.addInst(.{
13621476 .tag = tag[1],
......@@ -1395,9 +1509,9 @@ fn asmImmediate(self: *Self, tag: Mir.Inst.FixedTag, imm: Immediate) !void {
13951509 .reloc => .rel,
13961510 },
13971511 .data = switch (imm) {
1398 .reloc => |x| reloc: {
1512 .reloc => |sym_off| reloc: {
13991513 assert(tag[0] == ._);
1400 break :reloc .{ .reloc = x };
1514 break :reloc .{ .reloc = sym_off };
14011515 },
14021516 .signed, .unsigned => .{ .i = .{
14031517 .fixes = tag[0],
......@@ -1424,31 +1538,22 @@ fn asmRegisterRegister(self: *Self, tag: Mir.Inst.FixedTag, reg1: Register, reg2
14241538}
14251539
14261540fn asmRegisterImmediate(self: *Self, tag: Mir.Inst.FixedTag, reg: Register, imm: Immediate) !void {
1427 const ops: Mir.Inst.Ops = switch (imm) {
1428 .signed => .ri_s,
1429 .unsigned => |u| if (math.cast(u32, u)) |_| .ri_u else .ri64,
1541 const ops: Mir.Inst.Ops, const i: u32 = switch (imm) {
1542 .signed => |s| .{ .ri_s, @bitCast(s) },
1543 .unsigned => |u| if (math.cast(u32, u)) |small|
1544 .{ .ri_u, small }
1545 else
1546 .{ .ri_64, try self.addExtra(Mir.Imm64.encode(imm.unsigned)) },
14301547 .reloc => unreachable,
14311548 };
14321549 _ = try self.addInst(.{
14331550 .tag = tag[1],
14341551 .ops = ops,
1435 .data = switch (ops) {
1436 .ri_s, .ri_u => .{ .ri = .{
1437 .fixes = tag[0],
1438 .r1 = reg,
1439 .i = switch (imm) {
1440 .signed => |s| @bitCast(s),
1441 .unsigned => |u| @intCast(u),
1442 .reloc => unreachable,
1443 },
1444 } },
1445 .ri64 => .{ .rx = .{
1446 .fixes = tag[0],
1447 .r1 = reg,
1448 .payload = try self.addExtra(Mir.Imm64.encode(imm.unsigned)),
1449 } },
1450 else => unreachable,
1451 },
1552 .data = .{ .ri = .{
1553 .fixes = tag[0],
1554 .r1 = reg,
1555 .i = i,
1556 } },
14521557 });
14531558}
14541559
......@@ -2158,6 +2263,7 @@ fn genBody(self: *Self, body: []const Air.Inst.Index) InnerError!void {
21582263 .dbg_inline_block => try self.airDbgInlineBlock(inst),
21592264 .dbg_var_ptr,
21602265 .dbg_var_val,
2266 .dbg_arg_inline,
21612267 => try self.airDbgVar(inst),
21622268
21632269 .call => try self.airCall(inst, .auto),
......@@ -2485,12 +2591,12 @@ fn computeFrameLayout(self: *Self, cc: std.builtin.CallingConvention) !FrameLayo
24852591 };
24862592}
24872593
2488fn getFrameAddrAlignment(self: *Self, frame_addr: FrameAddr) Alignment {
2594fn getFrameAddrAlignment(self: *Self, frame_addr: bits.FrameAddr) Alignment {
24892595 const alloc_align = self.frame_allocs.get(@intFromEnum(frame_addr.index)).abi_align;
24902596 return @enumFromInt(@min(@intFromEnum(alloc_align), @ctz(frame_addr.off)));
24912597}
24922598
2493fn getFrameAddrSize(self: *Self, frame_addr: FrameAddr) u32 {
2599fn getFrameAddrSize(self: *Self, frame_addr: bits.FrameAddr) u32 {
24942600 return self.frame_allocs.get(@intFromEnum(frame_addr.index)).abi_size - @as(u31, @intCast(frame_addr.off));
24952601}
24962602
......@@ -11951,87 +12057,65 @@ fn airArg(self: *Self, inst: Air.Inst.Index) !void {
1195112057fn airDbgArg(self: *Self, inst: Air.Inst.Index) !void {
1195212058 defer self.finishAirBookkeeping();
1195312059 if (self.debug_output == .none) return;
11954 const name_nts = self.air.instructions.items(.data)[@intFromEnum(inst)].arg.name;
11955 const name = self.air.nullTerminatedString(@intFromEnum(name_nts));
11956 if (name.len > 0) {
11957 const arg_ty = self.typeOfIndex(inst);
11958 const arg_mcv = self.getResolvedInstValue(inst).short;
11959 try self.genVarDebugInfo(.local_arg, .dbg_var_val, name, arg_ty, arg_mcv);
11960 }
12060 const name = self.air.instructions.items(.data)[@intFromEnum(inst)].arg.name;
12061 if (name != .none) try self.genLocalDebugInfo(inst, self.getResolvedInstValue(inst).short);
1196112062 if (self.liveness.isUnused(inst)) try self.processDeath(inst);
1196212063}
1196312064
11964fn genVarDebugInfo(
12065fn genLocalDebugInfo(
1196512066 self: *Self,
11966 var_tag: link.File.Dwarf.WipNav.VarTag,
11967 tag: Air.Inst.Tag,
11968 name: []const u8,
11969 ty: Type,
12067 inst: Air.Inst.Index,
1197012068 mcv: MCValue,
1197112069) !void {
11972 const stack_vars = switch (var_tag) {
11973 .local_arg => &self.stack_args,
11974 .local_var => &self.stack_vars,
11975 };
11976 switch (self.debug_output) {
11977 .dwarf => |dwarf| switch (tag) {
11978 else => unreachable,
11979 .dbg_var_ptr => {
11980 const var_ty = ty.childType(self.pt.zcu);
11981 switch (mcv) {
11982 else => {
11983 log.info("dbg_var_ptr({s}({}))", .{ @tagName(mcv), mcv });
11984 unreachable;
11985 },
11986 .unreach, .dead, .elementwise_regs_then_frame, .reserved_frame, .air_ref => unreachable,
11987 .lea_frame => |frame_addr| try stack_vars.append(self.gpa, .{
11988 .name = name,
11989 .type = var_ty,
11990 .frame_addr = frame_addr,
11991 }),
11992 .lea_symbol => |sym_off| try dwarf.genVarDebugInfo(var_tag, name, var_ty, .{ .plus = .{
11993 &.{ .addr = .{ .sym = sym_off.sym } },
11994 &.{ .consts = sym_off.off },
11995 } }),
11996 }
11997 },
11998 .dbg_var_val => switch (mcv) {
11999 .none => try dwarf.genVarDebugInfo(var_tag, name, ty, .empty),
12070 if (self.debug_output == .none) return;
12071 switch (self.air.instructions.items(.tag)[@intFromEnum(inst)]) {
12072 else => unreachable,
12073 .arg, .dbg_arg_inline, .dbg_var_val => |tag| {
12074 switch (mcv) {
12075 .none => try self.asmAir(.dbg_local, inst),
1200012076 .unreach, .dead, .elementwise_regs_then_frame, .reserved_frame, .air_ref => unreachable,
12001 .immediate => |immediate| try dwarf.genVarDebugInfo(var_tag, name, ty, .{ .stack_value = &.{
12002 .constu = immediate,
12003 } }),
12077 .immediate => |imm| try self.asmAirImmediate(.dbg_local, inst, Immediate.u(imm)),
12078 .lea_frame => |frame_addr| try self.asmAirFrameAddress(.dbg_local, inst, frame_addr),
12079 .lea_symbol => |sym_off| try self.asmAirImmediate(.dbg_local, inst, Immediate.rel(sym_off)),
1200412080 else => {
12081 const ty = switch (tag) {
12082 else => unreachable,
12083 .arg => self.typeOfIndex(inst),
12084 .dbg_arg_inline, .dbg_var_val => self.typeOf(
12085 self.air.instructions.items(.data)[@intFromEnum(inst)].pl_op.operand,
12086 ),
12087 };
1200512088 const frame_index = try self.allocFrameIndex(FrameAlloc.initSpill(ty, self.pt));
1200612089 try self.genSetMem(.{ .frame = frame_index }, 0, ty, mcv, .{});
12007 try stack_vars.append(self.gpa, .{
12008 .name = name,
12009 .type = ty,
12010 .frame_addr = .{ .index = frame_index },
12090 try self.asmAirMemory(.dbg_local, inst, .{
12091 .base = .{ .frame = frame_index },
12092 .mod = .{ .rm = .{ .size = .qword } },
1201112093 });
1201212094 },
12013 },
12095 }
1201412096 },
12015 .plan9 => {},
12016 .none => {},
12017 }
12018}
12019
12020fn genStackVarDebugInfo(
12021 self: Self,
12022 var_tag: link.File.Dwarf.WipNav.VarTag,
12023 stack_vars: []const StackVar,
12024) !void {
12025 switch (self.debug_output) {
12026 .dwarf => |dwarf| for (stack_vars) |stack_var| {
12027 const frame_loc = self.frame_locs.get(@intFromEnum(stack_var.frame_addr.index));
12028 try dwarf.genVarDebugInfo(var_tag, stack_var.name, stack_var.type, .{ .plus = .{
12029 &.{ .breg = frame_loc.base.dwarfNum() },
12030 &.{ .consts = @as(i33, frame_loc.disp) + stack_var.frame_addr.off },
12031 } });
12097 .dbg_var_ptr => switch (mcv) {
12098 else => unreachable,
12099 .unreach, .dead, .elementwise_regs_then_frame, .reserved_frame, .air_ref => unreachable,
12100 .lea_frame => |frame_addr| try self.asmAirMemory(.dbg_local, inst, .{
12101 .base = .{ .frame = frame_addr.index },
12102 .mod = .{ .rm = .{
12103 .size = .qword,
12104 .disp = frame_addr.off,
12105 } },
12106 }),
12107 .lea_symbol => |sym_off| try self.asmAirMemory(.dbg_local, inst, .{
12108 .base = .{ .reloc = sym_off.sym_index },
12109 .mod = .{ .rm = .{
12110 .size = .qword,
12111 .disp = sym_off.off,
12112 } },
12113 }),
12114 .lea_direct, .lea_got, .lea_tlv => |sym_index| try self.asmAirMemory(.dbg_local, inst, .{
12115 .base = .{ .reloc = sym_index },
12116 .mod = .{ .rm = .{ .size = .qword } },
12117 }),
1203212118 },
12033 .plan9 => {},
12034 .none => {},
1203512119 }
1203612120}
1203712121
......@@ -12351,10 +12435,7 @@ fn genCall(self: *Self, info: union(enum) {
1235112435 if (self.bin_file.cast(.elf)) |elf_file| {
1235212436 const zo = elf_file.zigObjectPtr().?;
1235312437 const sym_index = try zo.getOrCreateMetadataForNav(elf_file, func.owner_nav);
12354 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{
12355 .atom_index = try self.owner.getSymbolIndex(self),
12356 .sym_index = sym_index,
12357 }));
12438 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{ .sym_index = sym_index }));
1235812439 } else if (self.bin_file.cast(.coff)) |coff_file| {
1235912440 const atom = try coff_file.getOrCreateAtomForNav(func.owner_nav);
1236012441 const sym_index = coff_file.getAtom(atom).getSymbolIndex().?;
......@@ -12364,10 +12445,7 @@ fn genCall(self: *Self, info: union(enum) {
1236412445 const zo = macho_file.getZigObject().?;
1236512446 const sym_index = try zo.getOrCreateMetadataForNav(macho_file, func.owner_nav);
1236612447 const sym = zo.symbols.items[sym_index];
12367 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{
12368 .atom_index = try self.owner.getSymbolIndex(self),
12369 .sym_index = sym.nlist_idx,
12370 }));
12448 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{ .sym_index = sym.nlist_idx }));
1237112449 } else if (self.bin_file.cast(.plan9)) |p9| {
1237212450 const atom_index = try p9.seeNav(pt, func.owner_nav);
1237312451 const atom = p9.getAtom(atom_index);
......@@ -12385,19 +12463,13 @@ fn genCall(self: *Self, info: union(enum) {
1238512463 @"extern".name.toSlice(ip),
1238612464 @"extern".lib_name.toSlice(ip),
1238712465 );
12388 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{
12389 .atom_index = try self.owner.getSymbolIndex(self),
12390 .sym_index = target_sym_index,
12391 }));
12466 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{ .sym_index = target_sym_index }));
1239212467 } else if (self.bin_file.cast(.macho)) |macho_file| {
1239312468 const target_sym_index = try macho_file.getGlobalSymbol(
1239412469 @"extern".name.toSlice(ip),
1239512470 @"extern".lib_name.toSlice(ip),
1239612471 );
12397 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{
12398 .atom_index = try self.owner.getSymbolIndex(self),
12399 .sym_index = target_sym_index,
12400 }));
12472 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{ .sym_index = target_sym_index }));
1240112473 } else try self.genExternSymbolRef(
1240212474 .call,
1240312475 @"extern".lib_name.toSlice(ip),
......@@ -12412,16 +12484,10 @@ fn genCall(self: *Self, info: union(enum) {
1241212484 },
1241312485 .lib => |lib| if (self.bin_file.cast(.elf)) |elf_file| {
1241412486 const target_sym_index = try elf_file.getGlobalSymbol(lib.callee, lib.lib);
12415 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{
12416 .atom_index = try self.owner.getSymbolIndex(self),
12417 .sym_index = target_sym_index,
12418 }));
12487 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{ .sym_index = target_sym_index }));
1241912488 } else if (self.bin_file.cast(.macho)) |macho_file| {
1242012489 const target_sym_index = try macho_file.getGlobalSymbol(lib.callee, lib.lib);
12421 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{
12422 .atom_index = try self.owner.getSymbolIndex(self),
12423 .sym_index = target_sym_index,
12424 }));
12490 try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{ .sym_index = target_sym_index }));
1242512491 } else try self.genExternSymbolRef(.call, lib.lib, lib.callee),
1242612492 }
1242712493 return call_info.return_value.short;
......@@ -13060,29 +13126,21 @@ fn airDbgInlineBlock(self: *Self, inst: Air.Inst.Index) !void {
1306013126 self.inline_func = extra.data.func;
1306113127 _ = try self.addInst(.{
1306213128 .tag = .pseudo,
13063 .ops = .pseudo_dbg_inline_func,
13129 .ops = .pseudo_dbg_enter_inline_func,
1306413130 .data = .{ .func = extra.data.func },
1306513131 });
1306613132 try self.lowerBlock(inst, @ptrCast(self.air.extra[extra.end..][0..extra.data.body_len]));
1306713133 _ = try self.addInst(.{
1306813134 .tag = .pseudo,
13069 .ops = .pseudo_dbg_inline_func,
13135 .ops = .pseudo_dbg_leave_inline_func,
1307013136 .data = .{ .func = old_inline_func },
1307113137 });
1307213138}
1307313139
1307413140fn airDbgVar(self: *Self, inst: Air.Inst.Index) !void {
1307513141 const pl_op = self.air.instructions.items(.data)[@intFromEnum(inst)].pl_op;
13076 const operand = pl_op.operand;
13077 const ty = self.typeOf(operand);
13078 const mcv = try self.resolveInst(operand);
13079
13080 const name = self.air.nullTerminatedString(pl_op.payload);
13081
13082 const tag = self.air.instructions.items(.tag)[@intFromEnum(inst)];
13083 try self.genVarDebugInfo(.local_var, tag, name, ty, mcv);
13084
13085 return self.finishAir(inst, .unreach, .{ operand, .none, .none });
13142 try self.genLocalDebugInfo(inst, try self.resolveInst(pl_op.operand));
13143 return self.finishAir(inst, .unreach, .{ pl_op.operand, .none, .none });
1308613144}
1308713145
1308813146fn genCondBrMir(self: *Self, ty: Type, mcv: MCValue) !Mir.Inst.Index {
......@@ -14970,10 +15028,7 @@ fn genSetReg(
1497015028 .general_purpose => {
1497115029 assert(sym_off.off == 0);
1497215030 try self.asmRegisterMemory(.{ ._, .mov }, registerAlias(dst_reg, abi_size), .{
14973 .base = .{ .reloc = .{
14974 .atom_index = try self.owner.getSymbolIndex(self),
14975 .sym_index = sym_off.sym,
14976 } },
15031 .base = .{ .reloc = sym_off.sym_index },
1497715032 .mod = .{ .rm = .{
1497815033 .size = self.memSize(ty),
1497915034 .disp = sym_off.off,
......@@ -14991,10 +15046,7 @@ fn genSetReg(
1499115046 .ops = .direct_reloc,
1499215047 .data = .{ .rx = .{
1499315048 .r1 = registerAlias(dst_reg, abi_size),
14994 .payload = try self.addExtra(bits.Symbol{
14995 .atom_index = try self.owner.getSymbolIndex(self),
14996 .sym_index = sym_index,
14997 }),
15049 .payload = try self.addExtra(bits.SymbolOffset{ .sym_index = sym_index }),
1499815050 } },
1499915051 });
1500015052 return;
......@@ -15019,52 +15071,38 @@ fn genSetReg(
1501915071 },
1502015072 );
1502115073 },
15022 .lea_symbol => |sym_index| {
15023 const atom_index = try self.owner.getSymbolIndex(self);
15024 switch (self.bin_file.tag) {
15025 .elf, .macho => {
15026 try self.asmRegisterMemory(
15027 .{ ._, .lea },
15028 dst_reg.to64(),
15029 .{
15030 .base = .{ .reloc = .{
15031 .atom_index = atom_index,
15032 .sym_index = sym_index.sym,
15033 } },
15034 .mod = .{ .rm = .{
15035 .size = .qword,
15036 .disp = sym_index.off,
15037 } },
15038 },
15039 );
15040 },
15041 else => return self.fail("TODO emit symbol sequence on {s}", .{
15042 @tagName(self.bin_file.tag),
15043 }),
15044 }
15045 },
15046 .lea_direct, .lea_got => |sym_index| {
15047 const atom_index = try self.owner.getSymbolIndex(self);
15048 _ = try self.addInst(.{
15049 .tag = switch (src_mcv) {
15050 .lea_direct => .lea,
15051 .lea_got => .mov,
15052 else => unreachable,
15053 },
15054 .ops = switch (src_mcv) {
15055 .lea_direct => .direct_reloc,
15056 .lea_got => .got_reloc,
15057 else => unreachable,
15074 .lea_symbol => |sym_off| switch (self.bin_file.tag) {
15075 .elf, .macho => try self.asmRegisterMemory(
15076 .{ ._, .lea },
15077 dst_reg.to64(),
15078 .{
15079 .base = .{ .reloc = sym_off.sym_index },
15080 .mod = .{ .rm = .{
15081 .size = .qword,
15082 .disp = sym_off.off,
15083 } },
1505815084 },
15059 .data = .{ .rx = .{
15060 .r1 = dst_reg.to64(),
15061 .payload = try self.addExtra(bits.Symbol{
15062 .atom_index = atom_index,
15063 .sym_index = sym_index,
15064 }),
15065 } },
15066 });
15085 ),
15086 else => return self.fail("TODO emit symbol sequence on {s}", .{
15087 @tagName(self.bin_file.tag),
15088 }),
1506715089 },
15090 .lea_direct, .lea_got => |sym_index| _ = try self.addInst(.{
15091 .tag = switch (src_mcv) {
15092 .lea_direct => .lea,
15093 .lea_got => .mov,
15094 else => unreachable,
15095 },
15096 .ops = switch (src_mcv) {
15097 .lea_direct => .direct_reloc,
15098 .lea_got => .got_reloc,
15099 else => unreachable,
15100 },
15101 .data = .{ .rx = .{
15102 .r1 = dst_reg.to64(),
15103 .payload = try self.addExtra(bits.SymbolOffset{ .sym_index = sym_index }),
15104 } },
15105 }),
1506815106 .lea_tlv => unreachable, // TODO: remove this
1506915107 .air_ref => |src_ref| try self.genSetReg(dst_reg, ty, try self.resolveInst(src_ref), opts),
1507015108 }
......@@ -15085,7 +15123,7 @@ fn genSetMem(
1508515123 .none => .{ .immediate = @bitCast(@as(i64, disp)) },
1508615124 .reg => |base_reg| .{ .register_offset = .{ .reg = base_reg, .off = disp } },
1508715125 .frame => |base_frame_index| .{ .lea_frame = .{ .index = base_frame_index, .off = disp } },
15088 .reloc => |base_symbol| .{ .lea_symbol = .{ .sym = base_symbol.sym_index, .off = disp } },
15126 .reloc => |sym_index| .{ .lea_symbol = .{ .sym_index = sym_index, .off = disp } },
1508915127 };
1509015128 switch (src_mcv) {
1509115129 .none,
......@@ -15328,7 +15366,6 @@ fn genExternSymbolRef(
1532815366 lib: ?[]const u8,
1532915367 callee: []const u8,
1533015368) InnerError!void {
15331 const atom_index = try self.owner.getSymbolIndex(self);
1533215369 if (self.bin_file.cast(.coff)) |coff_file| {
1533315370 const global_index = try coff_file.getGlobalSymbol(callee, lib);
1533415371 _ = try self.addInst(.{
......@@ -15336,8 +15373,7 @@ fn genExternSymbolRef(
1533615373 .ops = .import_reloc,
1533715374 .data = .{ .rx = .{
1533815375 .r1 = .rax,
15339 .payload = try self.addExtra(bits.Symbol{
15340 .atom_index = atom_index,
15376 .payload = try self.addExtra(bits.SymbolOffset{
1534115377 .sym_index = link.File.Coff.global_symbol_bit | global_index,
1534215378 }),
1534315379 } },
......@@ -15364,10 +15400,10 @@ fn genLazySymbolRef(
1536415400 if (self.mod.pic) {
1536515401 switch (tag) {
1536615402 .lea, .call => try self.genSetReg(reg, Type.usize, .{
15367 .lea_symbol = .{ .sym = sym_index },
15403 .lea_symbol = .{ .sym_index = sym_index },
1536815404 }, .{}),
1536915405 .mov => try self.genSetReg(reg, Type.usize, .{
15370 .load_symbol = .{ .sym = sym_index },
15406 .load_symbol = .{ .sym_index = sym_index },
1537115407 }, .{}),
1537215408 else => unreachable,
1537315409 }
......@@ -15376,19 +15412,13 @@ fn genLazySymbolRef(
1537615412 .call => try self.asmRegister(.{ ._, .call }, reg),
1537715413 else => unreachable,
1537815414 }
15379 } else {
15380 const reloc = bits.Symbol{
15381 .atom_index = try self.owner.getSymbolIndex(self),
15382 .sym_index = sym_index,
15383 };
15384 switch (tag) {
15385 .lea, .mov => try self.asmRegisterMemory(.{ ._, tag }, reg.to64(), .{
15386 .base = .{ .reloc = reloc },
15387 .mod = .{ .rm = .{ .size = .qword } },
15388 }),
15389 .call => try self.asmImmediate(.{ ._, .call }, Immediate.rel(reloc)),
15390 else => unreachable,
15391 }
15415 } else switch (tag) {
15416 .lea, .mov => try self.asmRegisterMemory(.{ ._, tag }, reg.to64(), .{
15417 .base = .{ .reloc = sym_index },
15418 .mod = .{ .rm = .{ .size = .qword } },
15419 }),
15420 .call => try self.asmImmediate(.{ ._, .call }, Immediate.rel(.{ .sym_index = sym_index })),
15421 else => unreachable,
1539215422 }
1539315423 } else if (self.bin_file.cast(.plan9)) |p9_file| {
1539415424 const atom_index = p9_file.getOrCreateAtomForLazySymbol(pt, lazy_sym) catch |err|
......@@ -15438,10 +15468,10 @@ fn genLazySymbolRef(
1543815468 const sym = zo.symbols.items[sym_index];
1543915469 switch (tag) {
1544015470 .lea, .call => try self.genSetReg(reg, Type.usize, .{
15441 .lea_symbol = .{ .sym = sym.nlist_idx },
15471 .lea_symbol = .{ .sym_index = sym.nlist_idx },
1544215472 }, .{}),
1544315473 .mov => try self.genSetReg(reg, Type.usize, .{
15444 .load_symbol = .{ .sym = sym.nlist_idx },
15474 .load_symbol = .{ .sym_index = sym.nlist_idx },
1544515475 }, .{}),
1544615476 else => unreachable,
1544715477 }
......@@ -18786,7 +18816,7 @@ fn resolveInst(self: *Self, ref: Air.Inst.Ref) InnerError!MCValue {
1878618816 .{ .frame = frame_index },
1878718817 0,
1878818818 Type.usize,
18789 .{ .lea_symbol = .{ .sym = tlv_sym } },
18819 .{ .lea_symbol = .{ .sym_index = tlv_sym } },
1879018820 .{},
1879118821 );
1879218822 break :init .{ .load_frame = .{ .index = frame_index } };
......@@ -18842,8 +18872,8 @@ fn genTypedValue(self: *Self, val: Value) InnerError!MCValue {
1884218872 .undef => .undef,
1884318873 .immediate => |imm| .{ .immediate = imm },
1884418874 .memory => |addr| .{ .memory = addr },
18845 .load_symbol => |sym_index| .{ .load_symbol = .{ .sym = sym_index } },
18846 .lea_symbol => |sym_index| .{ .lea_symbol = .{ .sym = sym_index } },
18875 .load_symbol => |sym_index| .{ .load_symbol = .{ .sym_index = sym_index } },
18876 .lea_symbol => |sym_index| .{ .lea_symbol = .{ .sym_index = sym_index } },
1884718877 .load_direct => |sym_index| .{ .load_direct = sym_index },
1884818878 .lea_direct => |sym_index| .{ .lea_direct = sym_index },
1884918879 .load_got => |sym_index| .{ .lea_got = sym_index },
src/arch/x86_64/Emit.zig+195-52
......@@ -1,6 +1,8 @@
11//! This file contains the functionality for emitting x86_64 MIR as machine code
22
3air: Air,
34lower: Lower,
5atom_index: u32,
46debug_output: DebugInfoOutput,
57code: *std.ArrayList(u8),
68
......@@ -36,83 +38,84 @@ pub fn emitMir(emit: *Emit) Error!void {
3638 }) switch (lowered_relocs[0].target) {
3739 .inst => |target| try emit.relocs.append(emit.lower.allocator, .{
3840 .source = start_offset,
41 .source_offset = end_offset - 4,
3942 .target = target,
40 .offset = end_offset - 4,
43 .target_offset = lowered_relocs[0].off,
4144 .length = @intCast(end_offset - start_offset),
4245 }),
43 .linker_extern_fn => |symbol| if (emit.lower.bin_file.cast(.elf)) |elf_file| {
46 .linker_extern_fn => |sym_index| if (emit.lower.bin_file.cast(.elf)) |elf_file| {
4447 // Add relocation to the decl.
4548 const zo = elf_file.zigObjectPtr().?;
46 const atom_ptr = zo.symbol(symbol.atom_index).atom(elf_file).?;
49 const atom_ptr = zo.symbol(emit.atom_index).atom(elf_file).?;
4750 const r_type = @intFromEnum(std.elf.R_X86_64.PLT32);
4851 try atom_ptr.addReloc(elf_file, .{
4952 .r_offset = end_offset - 4,
50 .r_info = (@as(u64, @intCast(symbol.sym_index)) << 32) | r_type,
51 .r_addend = -4,
53 .r_info = (@as(u64, @intCast(sym_index)) << 32) | r_type,
54 .r_addend = lowered_relocs[0].off - 4,
5255 });
5356 } else if (emit.lower.bin_file.cast(.macho)) |macho_file| {
5457 // Add relocation to the decl.
5558 const zo = macho_file.getZigObject().?;
56 const atom = zo.symbols.items[symbol.atom_index].getAtom(macho_file).?;
59 const atom = zo.symbols.items[emit.atom_index].getAtom(macho_file).?;
5760 try atom.addReloc(macho_file, .{
5861 .tag = .@"extern",
5962 .offset = end_offset - 4,
60 .target = symbol.sym_index,
61 .addend = 0,
63 .target = sym_index,
64 .addend = lowered_relocs[0].off,
6265 .type = .branch,
6366 .meta = .{
6467 .pcrel = true,
6568 .has_subtractor = false,
6669 .length = 2,
67 .symbolnum = @intCast(symbol.sym_index),
70 .symbolnum = @intCast(sym_index),
6871 },
6972 });
7073 } else if (emit.lower.bin_file.cast(.coff)) |coff_file| {
7174 // Add relocation to the decl.
7275 const atom_index = coff_file.getAtomIndexForSymbol(
73 .{ .sym_index = symbol.atom_index, .file = null },
76 .{ .sym_index = emit.atom_index, .file = null },
7477 ).?;
75 const target = if (link.File.Coff.global_symbol_bit & symbol.sym_index != 0)
76 coff_file.getGlobalByIndex(link.File.Coff.global_symbol_mask & symbol.sym_index)
78 const target = if (link.File.Coff.global_symbol_bit & sym_index != 0)
79 coff_file.getGlobalByIndex(link.File.Coff.global_symbol_mask & sym_index)
7780 else
78 link.File.Coff.SymbolWithLoc{ .sym_index = symbol.sym_index, .file = null };
81 link.File.Coff.SymbolWithLoc{ .sym_index = sym_index, .file = null };
7982 try link.File.Coff.Atom.addRelocation(coff_file, atom_index, .{
8083 .type = .direct,
8184 .target = target,
8285 .offset = end_offset - 4,
83 .addend = 0,
86 .addend = @intCast(lowered_relocs[0].off),
8487 .pcrel = true,
8588 .length = 2,
8689 });
8790 } else return emit.fail("TODO implement extern reloc for {s}", .{
8891 @tagName(emit.lower.bin_file.tag),
8992 }),
90 .linker_tlsld => |data| {
93 .linker_tlsld => |sym_index| {
9194 const elf_file = emit.lower.bin_file.cast(.elf).?;
9295 const zo = elf_file.zigObjectPtr().?;
93 const atom = zo.symbol(data.atom_index).atom(elf_file).?;
96 const atom = zo.symbol(emit.atom_index).atom(elf_file).?;
9497 const r_type = @intFromEnum(std.elf.R_X86_64.TLSLD);
9598 try atom.addReloc(elf_file, .{
9699 .r_offset = end_offset - 4,
97 .r_info = (@as(u64, @intCast(data.sym_index)) << 32) | r_type,
98 .r_addend = -4,
100 .r_info = (@as(u64, @intCast(sym_index)) << 32) | r_type,
101 .r_addend = lowered_relocs[0].off - 4,
99102 });
100103 },
101 .linker_dtpoff => |data| {
104 .linker_dtpoff => |sym_index| {
102105 const elf_file = emit.lower.bin_file.cast(.elf).?;
103106 const zo = elf_file.zigObjectPtr().?;
104 const atom = zo.symbol(data.atom_index).atom(elf_file).?;
107 const atom = zo.symbol(emit.atom_index).atom(elf_file).?;
105108 const r_type = @intFromEnum(std.elf.R_X86_64.DTPOFF32);
106109 try atom.addReloc(elf_file, .{
107110 .r_offset = end_offset - 4,
108 .r_info = (@as(u64, @intCast(data.sym_index)) << 32) | r_type,
109 .r_addend = 0,
111 .r_info = (@as(u64, @intCast(sym_index)) << 32) | r_type,
112 .r_addend = lowered_relocs[0].off,
110113 });
111114 },
112 .linker_reloc => |data| if (emit.lower.bin_file.cast(.elf)) |elf_file| {
115 .linker_reloc => |sym_index| if (emit.lower.bin_file.cast(.elf)) |elf_file| {
113116 const zo = elf_file.zigObjectPtr().?;
114 const atom = zo.symbol(data.atom_index).atom(elf_file).?;
115 const sym = zo.symbol(data.sym_index);
117 const atom = zo.symbol(emit.atom_index).atom(elf_file).?;
118 const sym = zo.symbol(sym_index);
116119 if (emit.lower.pic) {
117120 const r_type: u32 = if (sym.flags.is_extern_ptr)
118121 @intFromEnum(std.elf.R_X86_64.GOTPCREL)
......@@ -120,8 +123,8 @@ pub fn emitMir(emit: *Emit) Error!void {
120123 @intFromEnum(std.elf.R_X86_64.PC32);
121124 try atom.addReloc(elf_file, .{
122125 .r_offset = end_offset - 4,
123 .r_info = (@as(u64, @intCast(data.sym_index)) << 32) | r_type,
124 .r_addend = -4,
126 .r_info = (@as(u64, @intCast(sym_index)) << 32) | r_type,
127 .r_addend = lowered_relocs[0].off - 4,
125128 });
126129 } else {
127130 const r_type: u32 = if (sym.flags.is_tls)
......@@ -130,14 +133,14 @@ pub fn emitMir(emit: *Emit) Error!void {
130133 @intFromEnum(std.elf.R_X86_64.@"32");
131134 try atom.addReloc(elf_file, .{
132135 .r_offset = end_offset - 4,
133 .r_info = (@as(u64, @intCast(data.sym_index)) << 32) | r_type,
134 .r_addend = 0,
136 .r_info = (@as(u64, @intCast(sym_index)) << 32) | r_type,
137 .r_addend = lowered_relocs[0].off,
135138 });
136139 }
137140 } else if (emit.lower.bin_file.cast(.macho)) |macho_file| {
138141 const zo = macho_file.getZigObject().?;
139 const atom = zo.symbols.items[data.atom_index].getAtom(macho_file).?;
140 const sym = &zo.symbols.items[data.sym_index];
142 const atom = zo.symbols.items[emit.atom_index].getAtom(macho_file).?;
143 const sym = &zo.symbols.items[sym_index];
141144 const @"type": link.File.MachO.Relocation.Type = if (sym.flags.is_extern_ptr)
142145 .got_load
143146 else if (sym.flags.tlv)
......@@ -147,33 +150,33 @@ pub fn emitMir(emit: *Emit) Error!void {
147150 try atom.addReloc(macho_file, .{
148151 .tag = .@"extern",
149152 .offset = @intCast(end_offset - 4),
150 .target = data.sym_index,
151 .addend = 0,
153 .target = sym_index,
154 .addend = lowered_relocs[0].off,
152155 .type = @"type",
153156 .meta = .{
154157 .pcrel = true,
155158 .has_subtractor = false,
156159 .length = 2,
157 .symbolnum = @intCast(data.sym_index),
160 .symbolnum = @intCast(sym_index),
158161 },
159162 });
160163 } else unreachable,
161164 .linker_got,
162165 .linker_direct,
163166 .linker_import,
164 => |symbol| if (emit.lower.bin_file.cast(.elf)) |_| {
167 => |sym_index| if (emit.lower.bin_file.cast(.elf)) |_| {
165168 unreachable;
166169 } else if (emit.lower.bin_file.cast(.macho)) |_| {
167170 unreachable;
168171 } else if (emit.lower.bin_file.cast(.coff)) |coff_file| {
169172 const atom_index = coff_file.getAtomIndexForSymbol(.{
170 .sym_index = symbol.atom_index,
173 .sym_index = emit.atom_index,
171174 .file = null,
172175 }).?;
173 const target = if (link.File.Coff.global_symbol_bit & symbol.sym_index != 0)
174 coff_file.getGlobalByIndex(link.File.Coff.global_symbol_mask & symbol.sym_index)
176 const target = if (link.File.Coff.global_symbol_bit & sym_index != 0)
177 coff_file.getGlobalByIndex(link.File.Coff.global_symbol_mask & sym_index)
175178 else
176 link.File.Coff.SymbolWithLoc{ .sym_index = symbol.sym_index, .file = null };
179 link.File.Coff.SymbolWithLoc{ .sym_index = sym_index, .file = null };
177180 try link.File.Coff.Atom.addRelocation(coff_file, atom_index, .{
178181 .type = switch (lowered_relocs[0].target) {
179182 .linker_got => .got,
......@@ -183,16 +186,15 @@ pub fn emitMir(emit: *Emit) Error!void {
183186 },
184187 .target = target,
185188 .offset = @intCast(end_offset - 4),
186 .addend = 0,
189 .addend = @intCast(lowered_relocs[0].off),
187190 .pcrel = true,
188191 .length = 2,
189192 });
190193 } else if (emit.lower.bin_file.cast(.plan9)) |p9_file| {
191 const atom_index = symbol.atom_index;
192 try p9_file.addReloc(atom_index, .{ // TODO we may need to add a .type field to the relocs if they are .linker_got instead of just .linker_direct
193 .target = symbol.sym_index, // we set sym_index to just be the atom index
194 try p9_file.addReloc(emit.atom_index, .{ // TODO we may need to add a .type field to the relocs if they are .linker_got instead of just .linker_direct
195 .target = sym_index, // we set sym_index to just be the atom index
194196 .offset = @intCast(end_offset - 4),
195 .addend = 0,
197 .addend = @intCast(lowered_relocs[0].off),
196198 .type = .pcrel,
197199 });
198200 } else return emit.fail("TODO implement linker reloc for {s}", .{
......@@ -232,13 +234,151 @@ pub fn emitMir(emit: *Emit) Error!void {
232234 .none => {},
233235 }
234236 },
235 .pseudo_dbg_inline_func => {
237 .pseudo_dbg_enter_inline_func => {
236238 switch (emit.debug_output) {
237239 .dwarf => |dw| {
238 log.debug("mirDbgInline (line={d}, col={d})", .{
240 log.debug("mirDbgEnterInline (line={d}, col={d})", .{
239241 emit.prev_di_line, emit.prev_di_column,
240242 });
241 try dw.setInlineFunc(mir_inst.data.func);
243 try dw.enterInlineFunc(mir_inst.data.func, emit.code.items.len, emit.prev_di_line, emit.prev_di_column);
244 },
245 .plan9 => {},
246 .none => {},
247 }
248 },
249 .pseudo_dbg_leave_inline_func => {
250 switch (emit.debug_output) {
251 .dwarf => |dw| {
252 log.debug("mirDbgLeaveInline (line={d}, col={d})", .{
253 emit.prev_di_line, emit.prev_di_column,
254 });
255 try dw.leaveInlineFunc(mir_inst.data.func, emit.code.items.len);
256 },
257 .plan9 => {},
258 .none => {},
259 }
260 },
261 .pseudo_dbg_local_a,
262 .pseudo_dbg_local_ai_s,
263 .pseudo_dbg_local_ai_u,
264 .pseudo_dbg_local_ai_64,
265 .pseudo_dbg_local_as,
266 .pseudo_dbg_local_aso,
267 .pseudo_dbg_local_aro,
268 .pseudo_dbg_local_af,
269 .pseudo_dbg_local_am,
270 => {
271 switch (emit.debug_output) {
272 .dwarf => |dw| {
273 var loc_buf: [2]link.File.Dwarf.Loc = undefined;
274 const air_inst_index, const loc: link.File.Dwarf.Loc = switch (mir_inst.ops) {
275 else => unreachable,
276 .pseudo_dbg_local_a => .{ mir_inst.data.a.air_inst, .empty },
277 .pseudo_dbg_local_ai_s,
278 .pseudo_dbg_local_ai_u,
279 .pseudo_dbg_local_ai_64,
280 => .{ mir_inst.data.ai.air_inst, .{ .stack_value = stack_value: {
281 loc_buf[0] = switch (emit.lower.imm(mir_inst.ops, mir_inst.data.ai.i)) {
282 .signed => |s| .{ .consts = s },
283 .unsigned => |u| .{ .constu = u },
284 };
285 break :stack_value &loc_buf[0];
286 } } },
287 .pseudo_dbg_local_as => .{ mir_inst.data.as.air_inst, .{ .addr = .{
288 .sym = mir_inst.data.as.sym_index,
289 } } },
290 .pseudo_dbg_local_aso => loc: {
291 const sym_off = emit.lower.mir.extraData(
292 bits.SymbolOffset,
293 mir_inst.data.ax.payload,
294 ).data;
295 break :loc .{ mir_inst.data.ax.air_inst, .{ .plus = .{
296 sym: {
297 loc_buf[0] = .{ .addr = .{ .sym = sym_off.sym_index } };
298 break :sym &loc_buf[0];
299 },
300 off: {
301 loc_buf[1] = .{ .consts = sym_off.off };
302 break :off &loc_buf[1];
303 },
304 } } };
305 },
306 .pseudo_dbg_local_aro => loc: {
307 const air_off = emit.lower.mir.extraData(
308 Mir.AirOffset,
309 mir_inst.data.rx.payload,
310 ).data;
311 break :loc .{ air_off.air_inst, .{ .plus = .{
312 reg: {
313 loc_buf[0] = .{ .breg = mir_inst.data.rx.r1.dwarfNum() };
314 break :reg &loc_buf[0];
315 },
316 off: {
317 loc_buf[1] = .{ .consts = air_off.off };
318 break :off &loc_buf[1];
319 },
320 } } };
321 },
322 .pseudo_dbg_local_af => loc: {
323 const reg_off = emit.lower.mir.resolveFrameAddr(emit.lower.mir.extraData(
324 bits.FrameAddr,
325 mir_inst.data.ax.payload,
326 ).data);
327 break :loc .{ mir_inst.data.ax.air_inst, .{ .plus = .{
328 reg: {
329 loc_buf[0] = .{ .breg = reg_off.reg.dwarfNum() };
330 break :reg &loc_buf[0];
331 },
332 off: {
333 loc_buf[1] = .{ .consts = reg_off.off };
334 break :off &loc_buf[1];
335 },
336 } } };
337 },
338 .pseudo_dbg_local_am => loc: {
339 const mem = emit.lower.mem(mir_inst.data.ax.payload);
340 break :loc .{ mir_inst.data.ax.air_inst, .{ .plus = .{
341 base: {
342 loc_buf[0] = switch (mem.base()) {
343 .none => .{ .constu = 0 },
344 .reg => |reg| .{ .breg = reg.dwarfNum() },
345 .frame => unreachable,
346 .reloc => |sym_index| .{ .addr = .{ .sym = sym_index } },
347 };
348 break :base &loc_buf[0];
349 },
350 disp: {
351 loc_buf[1] = switch (mem.disp()) {
352 .signed => |s| .{ .consts = s },
353 .unsigned => |u| .{ .constu = u },
354 };
355 break :disp &loc_buf[1];
356 },
357 } } };
358 },
359 };
360 const ip = &emit.lower.bin_file.comp.module.?.intern_pool;
361 const air_inst = emit.air.instructions.get(@intFromEnum(air_inst_index));
362 const name: Air.NullTerminatedString = switch (air_inst.tag) {
363 else => unreachable,
364 .arg => air_inst.data.arg.name,
365 .dbg_var_ptr, .dbg_var_val, .dbg_arg_inline => @enumFromInt(air_inst.data.pl_op.payload),
366 };
367 try dw.genLocalDebugInfo(
368 switch (air_inst.tag) {
369 else => unreachable,
370 .arg, .dbg_arg_inline => .local_arg,
371 .dbg_var_ptr, .dbg_var_val => .local_var,
372 },
373 name.toSlice(emit.air),
374 switch (air_inst.tag) {
375 else => unreachable,
376 .arg => emit.air.typeOfIndex(air_inst_index, ip),
377 .dbg_var_ptr => emit.air.typeOf(air_inst.data.pl_op.operand, ip).childTypeIp(ip),
378 .dbg_var_val, .dbg_arg_inline => emit.air.typeOf(air_inst.data.pl_op.operand, ip),
379 },
380 loc,
381 );
242382 },
243383 .plan9 => {},
244384 .none => {},
......@@ -268,10 +408,12 @@ fn fail(emit: *Emit, comptime format: []const u8, args: anytype) Error {
268408const Reloc = struct {
269409 /// Offset of the instruction.
270410 source: usize,
411 /// Offset of the relocation within the instruction.
412 source_offset: u32,
271413 /// Target of the relocation.
272414 target: Mir.Inst.Index,
273 /// Offset of the relocation within the instruction.
274 offset: u32,
415 /// Offset from the target instruction.
416 target_offset: i32,
275417 /// Length of the instruction.
276418 length: u5,
277419};
......@@ -284,8 +426,8 @@ fn fixupRelocs(emit: *Emit) Error!void {
284426 for (emit.relocs.items) |reloc| {
285427 const target = emit.code_offset_mapping.get(reloc.target) orelse
286428 return emit.fail("JMP/CALL relocation target not found!", .{});
287 const disp = @as(i64, @intCast(target)) - @as(i64, @intCast(reloc.source + reloc.length));
288 mem.writeInt(i32, emit.code.items[reloc.offset..][0..4], @intCast(disp), .little);
429 const disp = @as(i64, @intCast(target)) - @as(i64, @intCast(reloc.source + reloc.length)) + reloc.target_offset;
430 std.mem.writeInt(i32, emit.code.items[reloc.source_offset..][0..4], @intCast(disp), .little);
289431 }
290432}
291433
......@@ -338,11 +480,12 @@ fn dbgAdvancePCAndLine(emit: *Emit, line: u32, column: u32) Error!void {
338480 }
339481}
340482
483const bits = @import("bits.zig");
341484const link = @import("../../link.zig");
342485const log = std.log.scoped(.emit);
343const mem = std.mem;
344486const std = @import("std");
345487
488const Air = @import("../../Air.zig");
346489const DebugInfoOutput = @import("../../codegen.zig").DebugInfoOutput;
347490const Emit = @This();
348491const Lower = @import("Lower.zig");
src/arch/x86_64/Lower.zig+60-52
......@@ -4,10 +4,10 @@ bin_file: *link.File,
44output_mode: std.builtin.OutputMode,
55link_mode: std.builtin.LinkMode,
66pic: bool,
7allocator: Allocator,
7allocator: std.mem.Allocator,
88mir: Mir,
99cc: std.builtin.CallingConvention,
10err_msg: ?*ErrorMsg = null,
10err_msg: ?*Zcu.ErrorMsg = null,
1111src_loc: Zcu.LazySrcLoc,
1212result_insts_len: u8 = undefined,
1313result_relocs_len: u8 = undefined,
......@@ -52,16 +52,17 @@ pub const Error = error{
5252pub const Reloc = struct {
5353 lowered_inst_index: u8,
5454 target: Target,
55 off: i32,
5556
5657 const Target = union(enum) {
5758 inst: Mir.Inst.Index,
58 linker_reloc: bits.Symbol,
59 linker_tlsld: bits.Symbol,
60 linker_dtpoff: bits.Symbol,
61 linker_extern_fn: bits.Symbol,
62 linker_got: bits.Symbol,
63 linker_direct: bits.Symbol,
64 linker_import: bits.Symbol,
59 linker_reloc: u32,
60 linker_tlsld: u32,
61 linker_dtpoff: u32,
62 linker_extern_fn: u32,
63 linker_got: u32,
64 linker_direct: u32,
65 linker_import: u32,
6566 };
6667};
6768
......@@ -173,19 +174,19 @@ pub fn lowerMir(lower: *Lower, index: Mir.Inst.Index) Error!struct {
173174 .pseudo_j_z_and_np_inst => {
174175 assert(inst.data.inst.fixes == ._);
175176 try lower.emit(.none, .jnz, &.{
176 .{ .imm = lower.reloc(.{ .inst = index + 1 }) },
177 .{ .imm = lower.reloc(.{ .inst = index + 1 }, 0) },
177178 });
178179 try lower.emit(.none, .jnp, &.{
179 .{ .imm = lower.reloc(.{ .inst = inst.data.inst.inst }) },
180 .{ .imm = lower.reloc(.{ .inst = inst.data.inst.inst }, 0) },
180181 });
181182 },
182183 .pseudo_j_nz_or_p_inst => {
183184 assert(inst.data.inst.fixes == ._);
184185 try lower.emit(.none, .jnz, &.{
185 .{ .imm = lower.reloc(.{ .inst = inst.data.inst.inst }) },
186 .{ .imm = lower.reloc(.{ .inst = inst.data.inst.inst }, 0) },
186187 });
187188 try lower.emit(.none, .jp, &.{
188 .{ .imm = lower.reloc(.{ .inst = inst.data.inst.inst }) },
189 .{ .imm = lower.reloc(.{ .inst = inst.data.inst.inst }, 0) },
189190 });
190191 },
191192
......@@ -195,7 +196,7 @@ pub fn lowerMir(lower: *Lower, index: Mir.Inst.Index) Error!struct {
195196 .{ .imm = Immediate.s(@bitCast(inst.data.ri.i)) },
196197 });
197198 try lower.emit(.none, .jz, &.{
198 .{ .imm = lower.reloc(.{ .inst = index + 1 }) },
199 .{ .imm = lower.reloc(.{ .inst = index + 1 }, 0) },
199200 });
200201 try lower.emit(.none, .lea, &.{
201202 .{ .reg = inst.data.ri.r1 },
......@@ -211,7 +212,7 @@ pub fn lowerMir(lower: *Lower, index: Mir.Inst.Index) Error!struct {
211212 .{ .reg = inst.data.ri.r1.to32() },
212213 });
213214 try lower.emit(.none, .jmp, &.{
214 .{ .imm = lower.reloc(.{ .inst = index }) },
215 .{ .imm = lower.reloc(.{ .inst = index }, 0) },
215216 });
216217 assert(lower.result_insts_len == pseudo_probe_align_insts);
217218 },
......@@ -257,7 +258,7 @@ pub fn lowerMir(lower: *Lower, index: Mir.Inst.Index) Error!struct {
257258 .{ .imm = Immediate.s(page_size) },
258259 });
259260 try lower.emit(.none, .jae, &.{
260 .{ .imm = lower.reloc(.{ .inst = index }) },
261 .{ .imm = lower.reloc(.{ .inst = index }, 0) },
261262 });
262263 assert(lower.result_insts_len == pseudo_probe_adjust_loop_insts);
263264 },
......@@ -267,7 +268,17 @@ pub fn lowerMir(lower: *Lower, index: Mir.Inst.Index) Error!struct {
267268 .pseudo_dbg_prologue_end_none,
268269 .pseudo_dbg_line_line_column,
269270 .pseudo_dbg_epilogue_begin_none,
270 .pseudo_dbg_inline_func,
271 .pseudo_dbg_enter_inline_func,
272 .pseudo_dbg_leave_inline_func,
273 .pseudo_dbg_local_a,
274 .pseudo_dbg_local_ai_s,
275 .pseudo_dbg_local_ai_u,
276 .pseudo_dbg_local_ai_64,
277 .pseudo_dbg_local_as,
278 .pseudo_dbg_local_aso,
279 .pseudo_dbg_local_aro,
280 .pseudo_dbg_local_af,
281 .pseudo_dbg_local_am,
271282 .pseudo_dead_none,
272283 => {},
273284 else => unreachable,
......@@ -283,17 +294,18 @@ pub fn lowerMir(lower: *Lower, index: Mir.Inst.Index) Error!struct {
283294pub fn fail(lower: *Lower, comptime format: []const u8, args: anytype) Error {
284295 @setCold(true);
285296 assert(lower.err_msg == null);
286 lower.err_msg = try ErrorMsg.create(lower.allocator, lower.src_loc, format, args);
297 lower.err_msg = try Zcu.ErrorMsg.create(lower.allocator, lower.src_loc, format, args);
287298 return error.LowerFail;
288299}
289300
290fn imm(lower: Lower, ops: Mir.Inst.Ops, i: u32) Immediate {
301pub fn imm(lower: Lower, ops: Mir.Inst.Ops, i: u32) Immediate {
291302 return switch (ops) {
292303 .rri_s,
293304 .ri_s,
294305 .i_s,
295306 .mi_s,
296307 .rmi_s,
308 .pseudo_dbg_local_ai_s,
297309 => Immediate.s(@bitCast(i)),
298310
299311 .rrri,
......@@ -306,22 +318,26 @@ fn imm(lower: Lower, ops: Mir.Inst.Ops, i: u32) Immediate {
306318 .mri,
307319 .rrm,
308320 .rrmi,
321 .pseudo_dbg_local_ai_u,
309322 => Immediate.u(i),
310323
311 .ri64 => Immediate.u(lower.mir.extraData(Mir.Imm64, i).data.decode()),
324 .ri_64,
325 .pseudo_dbg_local_ai_64,
326 => Immediate.u(lower.mir.extraData(Mir.Imm64, i).data.decode()),
312327
313328 else => unreachable,
314329 };
315330}
316331
317fn mem(lower: Lower, payload: u32) Memory {
332pub fn mem(lower: Lower, payload: u32) Memory {
318333 return lower.mir.resolveFrameLoc(lower.mir.extraData(Mir.Memory, payload).data).decode();
319334}
320335
321fn reloc(lower: *Lower, target: Reloc.Target) Immediate {
336fn reloc(lower: *Lower, target: Reloc.Target, off: i32) Immediate {
322337 lower.result_relocs[lower.result_relocs_len] = .{
323338 .lowered_inst_index = lower.result_insts_len,
324339 .target = target,
340 .off = off,
325341 };
326342 lower.result_relocs_len += 1;
327343 return Immediate.s(0);
......@@ -337,37 +353,36 @@ fn emit(lower: *Lower, prefix: Prefix, mnemonic: Mnemonic, ops: []const Operand)
337353 else => op,
338354 .mem => |mem_op| switch (mem_op.base()) {
339355 else => op,
340 .reloc => |sym| op: {
356 .reloc => |sym_index| op: {
341357 assert(prefix == .none);
342358 assert(mem_op.sib.disp == 0);
343359 assert(mem_op.sib.scale_index.scale == 0);
344360
345361 if (lower.bin_file.cast(.elf)) |elf_file| {
346362 const zo = elf_file.zigObjectPtr().?;
347 const elf_sym = zo.symbol(sym.sym_index);
363 const elf_sym = zo.symbol(sym_index);
348364
349365 if (elf_sym.flags.is_tls) {
350366 // TODO handle extern TLS vars, i.e., emit GD model
351367 if (lower.pic) {
352368 // Here, we currently assume local dynamic TLS vars, and so
353369 // we emit LD model.
354 _ = lower.reloc(.{ .linker_tlsld = sym });
370 _ = lower.reloc(.{ .linker_tlsld = sym_index }, 0);
355371 lower.result_insts[lower.result_insts_len] =
356372 try Instruction.new(.none, .lea, &[_]Operand{
357373 .{ .reg = .rdi },
358374 .{ .mem = Memory.rip(mem_op.sib.ptr_size, 0) },
359375 });
360376 lower.result_insts_len += 1;
361 _ = lower.reloc(.{ .linker_extern_fn = .{
362 .atom_index = sym.atom_index,
363 .sym_index = try elf_file.getGlobalSymbol("__tls_get_addr", null),
364 } });
377 _ = lower.reloc(.{
378 .linker_extern_fn = try elf_file.getGlobalSymbol("__tls_get_addr", null),
379 }, 0);
365380 lower.result_insts[lower.result_insts_len] =
366381 try Instruction.new(.none, .call, &[_]Operand{
367382 .{ .imm = Immediate.s(0) },
368383 });
369384 lower.result_insts_len += 1;
370 _ = lower.reloc(.{ .linker_dtpoff = sym });
385 _ = lower.reloc(.{ .linker_dtpoff = sym_index }, 0);
371386 emit_mnemonic = .lea;
372387 break :op .{ .mem = Memory.sib(mem_op.sib.ptr_size, .{
373388 .base = .{ .reg = .rax },
......@@ -381,7 +396,7 @@ fn emit(lower: *Lower, prefix: Prefix, mnemonic: Mnemonic, ops: []const Operand)
381396 .{ .mem = Memory.sib(.qword, .{ .base = .{ .reg = .fs } }) },
382397 });
383398 lower.result_insts_len += 1;
384 _ = lower.reloc(.{ .linker_reloc = sym });
399 _ = lower.reloc(.{ .linker_reloc = sym_index }, 0);
385400 emit_mnemonic = .lea;
386401 break :op .{ .mem = Memory.sib(mem_op.sib.ptr_size, .{
387402 .base = .{ .reg = .rax },
......@@ -390,7 +405,7 @@ fn emit(lower: *Lower, prefix: Prefix, mnemonic: Mnemonic, ops: []const Operand)
390405 }
391406 }
392407
393 _ = lower.reloc(.{ .linker_reloc = sym });
408 _ = lower.reloc(.{ .linker_reloc = sym_index }, 0);
394409 if (lower.pic) switch (mnemonic) {
395410 .lea => {
396411 if (elf_sym.flags.is_extern_ptr) emit_mnemonic = .mov;
......@@ -427,10 +442,10 @@ fn emit(lower: *Lower, prefix: Prefix, mnemonic: Mnemonic, ops: []const Operand)
427442 }
428443 } else if (lower.bin_file.cast(.macho)) |macho_file| {
429444 const zo = macho_file.getZigObject().?;
430 const macho_sym = zo.symbols.items[sym.sym_index];
445 const macho_sym = zo.symbols.items[sym_index];
431446
432447 if (macho_sym.flags.tlv) {
433 _ = lower.reloc(.{ .linker_reloc = sym });
448 _ = lower.reloc(.{ .linker_reloc = sym_index }, 0);
434449 lower.result_insts[lower.result_insts_len] =
435450 try Instruction.new(.none, .mov, &[_]Operand{
436451 .{ .reg = .rdi },
......@@ -446,7 +461,7 @@ fn emit(lower: *Lower, prefix: Prefix, mnemonic: Mnemonic, ops: []const Operand)
446461 break :op .{ .reg = .rax };
447462 }
448463
449 _ = lower.reloc(.{ .linker_reloc = sym });
464 _ = lower.reloc(.{ .linker_reloc = sym_index }, 0);
450465 break :op switch (mnemonic) {
451466 .lea => {
452467 if (macho_sym.flags.is_extern_ptr) emit_mnemonic = .mov;
......@@ -490,8 +505,8 @@ fn generic(lower: *Lower, inst: Mir.Inst) Error!void {
490505 .rrrr => inst.data.rrrr.fixes,
491506 .rrri => inst.data.rrri.fixes,
492507 .rri_s, .rri_u => inst.data.rri.fixes,
493 .ri_s, .ri_u => inst.data.ri.fixes,
494 .ri64, .rm, .rmi_s, .mr => inst.data.rx.fixes,
508 .ri_s, .ri_u, .ri_64 => inst.data.ri.fixes,
509 .rm, .rmi_s, .mr => inst.data.rx.fixes,
495510 .mrr, .rrm, .rmr => inst.data.rrx.fixes,
496511 .rmi, .mri => inst.data.rix.fixes,
497512 .rrmr => inst.data.rrrx.fixes,
......@@ -525,7 +540,7 @@ fn generic(lower: *Lower, inst: Mir.Inst) Error!void {
525540 }, switch (inst.ops) {
526541 .none => &.{},
527542 .inst => &.{
528 .{ .imm = lower.reloc(.{ .inst = inst.data.inst.inst }) },
543 .{ .imm = lower.reloc(.{ .inst = inst.data.inst.inst }, 0) },
529544 },
530545 .i_s, .i_u => &.{
531546 .{ .imm = lower.imm(inst.ops, inst.data.i.i) },
......@@ -554,14 +569,10 @@ fn generic(lower: *Lower, inst: Mir.Inst) Error!void {
554569 .{ .reg = inst.data.rrri.r3 },
555570 .{ .imm = lower.imm(inst.ops, inst.data.rrri.i) },
556571 },
557 .ri_s, .ri_u => &.{
572 .ri_s, .ri_u, .ri_64 => &.{
558573 .{ .reg = inst.data.ri.r1 },
559574 .{ .imm = lower.imm(inst.ops, inst.data.ri.i) },
560575 },
561 .ri64 => &.{
562 .{ .reg = inst.data.rx.r1 },
563 .{ .imm = lower.imm(inst.ops, inst.data.rx.payload) },
564 },
565576 .rri_s, .rri_u => &.{
566577 .{ .reg = inst.data.rri.r1 },
567578 .{ .reg = inst.data.rri.r2 },
......@@ -631,17 +642,17 @@ fn generic(lower: *Lower, inst: Mir.Inst) Error!void {
631642 .{ .imm = lower.imm(inst.ops, inst.data.rrix.i) },
632643 },
633644 .extern_fn_reloc, .rel => &.{
634 .{ .imm = lower.reloc(.{ .linker_extern_fn = inst.data.reloc }) },
645 .{ .imm = lower.reloc(.{ .linker_extern_fn = inst.data.reloc.sym_index }, inst.data.reloc.off) },
635646 },
636647 .got_reloc, .direct_reloc, .import_reloc => ops: {
637648 const reg = inst.data.rx.r1;
638 const extra = lower.mir.extraData(bits.Symbol, inst.data.rx.payload).data;
649 const extra = lower.mir.extraData(bits.SymbolOffset, inst.data.rx.payload).data;
639650 _ = lower.reloc(switch (inst.ops) {
640 .got_reloc => .{ .linker_got = extra },
641 .direct_reloc => .{ .linker_direct = extra },
642 .import_reloc => .{ .linker_import = extra },
651 .got_reloc => .{ .linker_got = extra.sym_index },
652 .direct_reloc => .{ .linker_direct = extra.sym_index },
653 .import_reloc => .{ .linker_import = extra.sym_index },
643654 else => unreachable,
644 });
655 }, extra.off);
645656 break :ops &.{
646657 .{ .reg = reg },
647658 .{ .mem = Memory.rip(Memory.PtrSize.fromBitSize(reg.bitSize()), 0) },
......@@ -670,9 +681,6 @@ const encoder = @import("encoder.zig");
670681const link = @import("../../link.zig");
671682const std = @import("std");
672683
673const Air = @import("../../Air.zig");
674const Allocator = std.mem.Allocator;
675const ErrorMsg = Zcu.ErrorMsg;
676684const Immediate = Instruction.Immediate;
677685const Instruction = encoder.Instruction;
678686const Lower = @This();
src/arch/x86_64/Mir.zig+74-20
......@@ -760,8 +760,8 @@ pub const Inst = struct {
760760 /// Uses `ri` payload.
761761 ri_u,
762762 /// Register, 64-bit unsigned immediate operands.
763 /// Uses `rx` payload with payload type `Imm64`.
764 ri64,
763 /// Uses `ri` payload with `i` index of extra data of type `Imm64`.
764 ri_64,
765765 /// Immediate (sign-extended) operand.
766766 /// Uses `imm` payload.
767767 i_s,
......@@ -796,7 +796,7 @@ pub const Inst = struct {
796796 /// Uses `rrix` payload with extra data of type `Memory`.
797797 rrmi,
798798 /// Single memory operand.
799 /// Uses `x` with extra data of type `Memory`.
799 /// Uses `x` payload with extra data of type `Memory`.
800800 m,
801801 /// Memory, immediate (sign-extend) operands.
802802 /// Uses `x` payload with extra data of type `Imm32` followed by `Memory`.
......@@ -820,16 +820,16 @@ pub const Inst = struct {
820820 /// Uses `reloc` payload.
821821 extern_fn_reloc,
822822 /// Linker relocation - GOT indirection.
823 /// Uses `rx` payload with extra data of type `bits.Symbol`.
823 /// Uses `rx` payload with extra data of type `bits.SymbolOffset`.
824824 got_reloc,
825825 /// Linker relocation - direct reference.
826 /// Uses `rx` payload with extra data of type `bits.Symbol`.
826 /// Uses `rx` payload with extra data of type `bits.SymbolOffset`.
827827 direct_reloc,
828828 /// Linker relocation - imports table indirection (binding).
829 /// Uses `rx` payload with extra data of type `bits.Symbol`.
829 /// Uses `rx` payload with extra data of type `bits.SymbolOffset`.
830830 import_reloc,
831831 /// Linker relocation - threadlocal variable via GOT indirection.
832 /// Uses `rx` payload with extra data of type `bits.Symbol`.
832 /// Uses `rx` payload with extra data of type `bits.SymbolOffset`.
833833 tlv_reloc,
834834
835835 // Pseudo instructions:
......@@ -868,16 +868,16 @@ pub const Inst = struct {
868868 pseudo_j_nz_or_p_inst,
869869
870870 /// Probe alignment
871 /// Uses `ri` payload
871 /// Uses `ri` payload.
872872 pseudo_probe_align_ri_s,
873873 /// Probe adjust unrolled
874 /// Uses `ri` payload
874 /// Uses `ri` payload.
875875 pseudo_probe_adjust_unrolled_ri_s,
876876 /// Probe adjust setup
877 /// Uses `rri` payload
877 /// Uses `rri` payload.
878878 pseudo_probe_adjust_setup_rri_s,
879879 /// Probe adjust loop
880 /// Uses `rr` payload
880 /// Uses `rr` payload.
881881 pseudo_probe_adjust_loop_rr,
882882 /// Push registers
883883 /// Uses `reg_list` payload.
......@@ -893,8 +893,37 @@ pub const Inst = struct {
893893 pseudo_dbg_line_line_column,
894894 /// Start of epilogue
895895 pseudo_dbg_epilogue_begin_none,
896 /// Start or end of inline function
897 pseudo_dbg_inline_func,
896 /// Start of inline function
897 pseudo_dbg_enter_inline_func,
898 /// End of inline function
899 pseudo_dbg_leave_inline_func,
900 /// Local argument or variable.
901 /// Uses `a` payload.
902 pseudo_dbg_local_a,
903 /// Local argument or variable.
904 /// Uses `ai` payload.
905 pseudo_dbg_local_ai_s,
906 /// Local argument or variable.
907 /// Uses `ai` payload.
908 pseudo_dbg_local_ai_u,
909 /// Local argument or variable.
910 /// Uses `ai` payload with extra data of type `Imm64`.
911 pseudo_dbg_local_ai_64,
912 /// Local argument or variable.
913 /// Uses `as` payload.
914 pseudo_dbg_local_as,
915 /// Local argument or variable.
916 /// Uses `ax` payload with extra data of type `bits.SymbolOffset`.
917 pseudo_dbg_local_aso,
918 /// Local argument or variable.
919 /// Uses `rx` payload with extra data of type `AirOffset`.
920 pseudo_dbg_local_aro,
921 /// Local argument or variable.
922 /// Uses `ax` payload with extra data of type `bits.FrameAddr`.
923 pseudo_dbg_local_af,
924 /// Local argument or variable.
925 /// Uses `ax` payload with extra data of type `Memory`.
926 pseudo_dbg_local_am,
898927
899928 /// Tombstone
900929 /// Emitter should skip this instruction.
......@@ -997,10 +1026,28 @@ pub const Inst = struct {
9971026 fixes: Fixes = ._,
9981027 payload: u32,
9991028 },
1029 ix: struct {
1030 payload: u32,
1031 },
1032 a: struct {
1033 air_inst: Air.Inst.Index,
1034 },
1035 ai: struct {
1036 air_inst: Air.Inst.Index,
1037 i: u32,
1038 },
1039 as: struct {
1040 air_inst: Air.Inst.Index,
1041 sym_index: u32,
1042 },
1043 ax: struct {
1044 air_inst: Air.Inst.Index,
1045 payload: u32,
1046 },
10001047 /// Relocation for the linker where:
1001 /// * `atom_index` is the index of the source
10021048 /// * `sym_index` is the index of the target
1003 reloc: bits.Symbol,
1049 /// * `off` is the offset from the target
1050 reloc: bits.SymbolOffset,
10041051 /// Debug line and column position
10051052 line_column: struct {
10061053 line: u32,
......@@ -1020,6 +1067,8 @@ pub const Inst = struct {
10201067 }
10211068};
10221069
1070pub const AirOffset = struct { air_inst: Air.Inst.Index, off: i32 };
1071
10231072/// Used in conjunction with payload to transfer a list of used registers in a compact manner.
10241073pub const RegisterList = struct {
10251074 bitset: BitSet = BitSet.initEmpty(),
......@@ -1118,15 +1167,13 @@ pub const Memory = struct {
11181167 .none => undefined,
11191168 .reg => |reg| @intFromEnum(reg),
11201169 .frame => |frame_index| @intFromEnum(frame_index),
1121 .reloc => |symbol| symbol.sym_index,
1170 .reloc => |sym_index| sym_index,
11221171 },
11231172 .off = switch (mem.mod) {
11241173 .rm => |rm| @bitCast(rm.disp),
11251174 .off => |off| @truncate(off),
11261175 },
1127 .extra = if (mem.base == .reloc)
1128 mem.base.reloc.atom_index
1129 else if (mem.mod == .off)
1176 .extra = if (mem.mod == .off)
11301177 @intCast(mem.mod.off >> 32)
11311178 else
11321179 undefined,
......@@ -1146,7 +1193,7 @@ pub const Memory = struct {
11461193 .none => .none,
11471194 .reg => .{ .reg = @enumFromInt(mem.base) },
11481195 .frame => .{ .frame = @enumFromInt(mem.base) },
1149 .reloc => .{ .reloc = .{ .atom_index = mem.extra, .sym_index = mem.base } },
1196 .reloc => .{ .reloc = mem.base },
11501197 },
11511198 .scale_index = switch (mem.info.index) {
11521199 .none => null,
......@@ -1186,6 +1233,7 @@ pub fn extraData(mir: Mir, comptime T: type, index: u32) struct { data: T, end:
11861233 @field(result, field.name) = switch (field.type) {
11871234 u32 => mir.extra[i],
11881235 i32, Memory.Info => @bitCast(mir.extra[i]),
1236 bits.FrameIndex, Air.Inst.Index => @enumFromInt(mir.extra[i]),
11891237 else => @compileError("bad field type: " ++ field.name ++ ": " ++ @typeName(field.type)),
11901238 };
11911239 i += 1;
......@@ -1201,6 +1249,11 @@ pub const FrameLoc = struct {
12011249 disp: i32,
12021250};
12031251
1252pub fn resolveFrameAddr(mir: Mir, frame_addr: bits.FrameAddr) bits.RegisterOffset {
1253 const frame_loc = mir.frame_locs.get(@intFromEnum(frame_addr.index));
1254 return .{ .reg = frame_loc.base, .off = frame_loc.disp + frame_addr.off };
1255}
1256
12041257pub fn resolveFrameLoc(mir: Mir, mem: Memory) Memory {
12051258 return switch (mem.info.base) {
12061259 .none, .reg, .reloc => mem,
......@@ -1225,6 +1278,7 @@ const builtin = @import("builtin");
12251278const encoder = @import("encoder.zig");
12261279const std = @import("std");
12271280
1281const Air = @import("../../Air.zig");
12281282const IntegerBitSet = std.bit_set.IntegerBitSet;
12291283const InternPool = @import("../../InternPool.zig");
12301284const Mir = @This();
src/arch/x86_64/bits.zig+12-27
......@@ -447,26 +447,11 @@ pub const FrameIndex = enum(u32) {
447447 }
448448};
449449
450/// A linker symbol not yet allocated in VM.
451pub const Symbol = struct {
452 /// Index of the containing atom.
453 atom_index: u32,
454 /// Index into the linker's symbol table.
455 sym_index: u32,
450pub const FrameAddr = struct { index: FrameIndex, off: i32 = 0 };
456451
457 pub fn format(
458 sym: Symbol,
459 comptime fmt: []const u8,
460 options: std.fmt.FormatOptions,
461 writer: anytype,
462 ) @TypeOf(writer).Error!void {
463 try writer.writeAll("Symbol(");
464 try std.fmt.formatType(sym.atom_index, fmt, options, writer, 0);
465 try writer.writeAll(", ");
466 try std.fmt.formatType(sym.sym_index, fmt, options, writer, 0);
467 try writer.writeByte(')');
468 }
469};
452pub const RegisterOffset = struct { reg: Register, off: i32 = 0 };
453
454pub const SymbolOffset = struct { sym_index: u32, off: i32 = 0 };
470455
471456pub const Memory = struct {
472457 base: Base,
......@@ -476,7 +461,7 @@ pub const Memory = struct {
476461 none,
477462 reg: Register,
478463 frame: FrameIndex,
479 reloc: Symbol,
464 reloc: u32,
480465
481466 pub const Tag = @typeInfo(Base).Union.tag_type.?;
482467
......@@ -568,7 +553,7 @@ pub const Memory = struct {
568553pub const Immediate = union(enum) {
569554 signed: i32,
570555 unsigned: u64,
571 reloc: Symbol,
556 reloc: SymbolOffset,
572557
573558 pub fn u(x: u64) Immediate {
574559 return .{ .unsigned = x };
......@@ -578,19 +563,19 @@ pub const Immediate = union(enum) {
578563 return .{ .signed = x };
579564 }
580565
581 pub fn rel(symbol: Symbol) Immediate {
582 return .{ .reloc = symbol };
566 pub fn rel(sym_off: SymbolOffset) Immediate {
567 return .{ .reloc = sym_off };
583568 }
584569
585570 pub fn format(
586571 imm: Immediate,
587 comptime fmt: []const u8,
588 options: std.fmt.FormatOptions,
572 comptime _: []const u8,
573 _: std.fmt.FormatOptions,
589574 writer: anytype,
590575 ) @TypeOf(writer).Error!void {
591576 switch (imm) {
592 .reloc => |x| try std.fmt.formatType(x, fmt, options, writer, 0),
593 inline else => |x| try writer.print("{d}", .{x}),
577 inline else => |int| try writer.print("{d}", .{int}),
578 .reloc => |sym_off| try writer.print("Symbol({[sym_index]d}) + {[off]d}", sym_off),
594579 }
595580 }
596581};
src/arch/x86_64/encoder.zig+15-12
......@@ -128,8 +128,8 @@ pub const Instruction = struct {
128128 } };
129129 }
130130
131 pub fn rip(ptr_size: PtrSize, disp: i32) Memory {
132 return .{ .rip = .{ .ptr_size = ptr_size, .disp = disp } };
131 pub fn rip(ptr_size: PtrSize, displacement: i32) Memory {
132 return .{ .rip = .{ .ptr_size = ptr_size, .disp = displacement } };
133133 }
134134
135135 pub fn isSegmentRegister(mem: Memory) bool {
......@@ -158,6 +158,14 @@ pub const Instruction = struct {
158158 };
159159 }
160160
161 pub fn disp(mem: Memory) Immediate {
162 return switch (mem) {
163 .sib => |s| Immediate.s(s.disp),
164 .rip => |r| Immediate.s(r.disp),
165 .moffs => |m| Immediate.u(m.offset),
166 };
167 }
168
161169 pub fn bitSize(mem: Memory) u64 {
162170 return switch (mem) {
163171 .rip => |r| r.ptr_size.bitSize(),
......@@ -258,17 +266,12 @@ pub const Instruction = struct {
258266
259267 try writer.writeByte('[');
260268
261 var any = false;
269 var any = true;
262270 switch (sib.base) {
263 .none => {},
264 .reg => |reg| {
265 try writer.print("{s}", .{@tagName(reg)});
266 any = true;
267 },
268 inline .frame, .reloc => |payload| {
269 try writer.print("{}", .{payload});
270 any = true;
271 },
271 .none => any = false,
272 .reg => |reg| try writer.print("{s}", .{@tagName(reg)}),
273 .frame => |frame_index| try writer.print("{}", .{frame_index}),
274 .reloc => |sym_index| try writer.print("Symbol({d})", .{sym_index}),
272275 }
273276 if (mem.scaleIndex()) |si| {
274277 if (any) try writer.writeAll(" + ");
src/codegen/c.zig+4-3
......@@ -3293,7 +3293,7 @@ fn genBodyInner(f: *Function, body: []const Air.Inst.Index) error{ AnalysisFail,
32933293
32943294 .dbg_stmt => try airDbgStmt(f, inst),
32953295 .dbg_inline_block => try airDbgInlineBlock(f, inst),
3296 .dbg_var_ptr, .dbg_var_val => try airDbgVar(f, inst),
3296 .dbg_var_ptr, .dbg_var_val, .dbg_arg_inline => try airDbgVar(f, inst),
32973297
32983298 .call => try airCall(f, inst, .auto),
32993299 .call_always_tail => .none,
......@@ -4590,14 +4590,15 @@ fn airDbgInlineBlock(f: *Function, inst: Air.Inst.Index) !CValue {
45904590fn airDbgVar(f: *Function, inst: Air.Inst.Index) !CValue {
45914591 const pt = f.object.dg.pt;
45924592 const zcu = pt.zcu;
4593 const tag = f.air.instructions.items(.tag)[@intFromEnum(inst)];
45934594 const pl_op = f.air.instructions.items(.data)[@intFromEnum(inst)].pl_op;
4594 const name = f.air.nullTerminatedString(pl_op.payload);
4595 const name: Air.NullTerminatedString = @enumFromInt(pl_op.payload);
45954596 const operand_is_undef = if (try f.air.value(pl_op.operand, pt)) |v| v.isUndefDeep(zcu) else false;
45964597 if (!operand_is_undef) _ = try f.resolveInst(pl_op.operand);
45974598
45984599 try reap(f, inst, &.{pl_op.operand});
45994600 const writer = f.object.writer();
4600 try writer.print("/* var:{s} */\n", .{name});
4601 try writer.print("/* {s}:{s} */\n", .{ @tagName(tag), name.toSlice(f.air) });
46014602 return .none;
46024603}
46034604
src/codegen/llvm.zig+24-10
......@@ -1665,6 +1665,7 @@ pub const Object = struct {
16651665 .ret_ptr = ret_ptr,
16661666 .args = args.items,
16671667 .arg_index = 0,
1668 .arg_inline_index = 0,
16681669 .func_inst_table = .{},
16691670 .blocks = .{},
16701671 .sync_scope = if (owner_mod.single_threaded) .singlethread else .system,
......@@ -4769,7 +4770,8 @@ pub const FuncGen = struct {
47694770 /// it omits 0-bit types. If the function uses sret as the first parameter,
47704771 /// this slice does not include it.
47714772 args: []const Builder.Value,
4772 arg_index: usize,
4773 arg_index: u32,
4774 arg_inline_index: u32,
47734775
47744776 err_ret_trace: Builder.Value = .none,
47754777
......@@ -5082,7 +5084,8 @@ pub const FuncGen = struct {
50825084 .dbg_stmt => try self.airDbgStmt(inst),
50835085 .dbg_inline_block => try self.airDbgInlineBlock(inst),
50845086 .dbg_var_ptr => try self.airDbgVarPtr(inst),
5085 .dbg_var_val => try self.airDbgVarVal(inst),
5087 .dbg_var_val => try self.airDbgVarVal(inst, false),
5088 .dbg_arg_inline => try self.airDbgVarVal(inst, true),
50865089
50875090 .c_va_arg => try self.airCVaArg(inst),
50885091 .c_va_copy => try self.airCVaCopy(inst),
......@@ -6677,6 +6680,7 @@ pub const FuncGen = struct {
66776680 fn airDbgInlineBlock(self: *FuncGen, inst: Air.Inst.Index) !Builder.Value {
66786681 const ty_pl = self.air.instructions.items(.data)[@intFromEnum(inst)].ty_pl;
66796682 const extra = self.air.extraData(Air.DbgInlineBlock, ty_pl.payload);
6683 self.arg_inline_index = 0;
66806684 return self.lowerBlock(inst, extra.data.func, @ptrCast(self.air.extra[extra.end..][0..extra.data.body_len]));
66816685 }
66826686
......@@ -6685,11 +6689,11 @@ pub const FuncGen = struct {
66856689 const mod = o.pt.zcu;
66866690 const pl_op = self.air.instructions.items(.data)[@intFromEnum(inst)].pl_op;
66876691 const operand = try self.resolveInst(pl_op.operand);
6688 const name = self.air.nullTerminatedString(pl_op.payload);
6692 const name: Air.NullTerminatedString = @enumFromInt(pl_op.payload);
66896693 const ptr_ty = self.typeOf(pl_op.operand);
66906694
66916695 const debug_local_var = try o.builder.debugLocalVar(
6692 try o.builder.metadataString(name),
6696 try o.builder.metadataString(name.toSlice(self.air)),
66936697 self.file,
66946698 self.scope,
66956699 self.prev_dbg_line,
......@@ -6712,15 +6716,25 @@ pub const FuncGen = struct {
67126716 return .none;
67136717 }
67146718
6715 fn airDbgVarVal(self: *FuncGen, inst: Air.Inst.Index) !Builder.Value {
6719 fn airDbgVarVal(self: *FuncGen, inst: Air.Inst.Index, is_arg: bool) !Builder.Value {
67166720 const o = self.ng.object;
67176721 const pl_op = self.air.instructions.items(.data)[@intFromEnum(inst)].pl_op;
67186722 const operand = try self.resolveInst(pl_op.operand);
67196723 const operand_ty = self.typeOf(pl_op.operand);
6720 const name = self.air.nullTerminatedString(pl_op.payload);
6724 const name: Air.NullTerminatedString = @enumFromInt(pl_op.payload);
67216725
6722 const debug_local_var = try o.builder.debugLocalVar(
6723 try o.builder.metadataString(name),
6726 const debug_local_var = if (is_arg) try o.builder.debugParameter(
6727 try o.builder.metadataString(name.toSlice(self.air)),
6728 self.file,
6729 self.scope,
6730 self.prev_dbg_line,
6731 try o.lowerDebugType(operand_ty),
6732 arg_no: {
6733 self.arg_inline_index += 1;
6734 break :arg_no self.arg_inline_index;
6735 },
6736 ) else try o.builder.debugLocalVar(
6737 try o.builder.metadataString(name.toSlice(self.air)),
67246738 self.file,
67256739 self.scope,
67266740 self.prev_dbg_line,
......@@ -8835,12 +8849,12 @@ pub const FuncGen = struct {
88358849 const lbrace_col = func.lbrace_column + 1;
88368850
88378851 const debug_parameter = try o.builder.debugParameter(
8838 try o.builder.metadataString(self.air.nullTerminatedString(@intFromEnum(name))),
8852 try o.builder.metadataString(name.toSlice(self.air)),
88398853 self.file,
88408854 self.scope,
88418855 lbrace_line,
88428856 try o.lowerDebugType(inst_ty),
8843 @intCast(self.arg_index),
8857 self.arg_index,
88448858 );
88458859
88468860 const old_location = self.wip.debug_location;
src/codegen/spirv.zig+2-2
......@@ -6366,8 +6366,8 @@ const NavGen = struct {
63666366 fn airDbgVar(self: *NavGen, inst: Air.Inst.Index) !void {
63676367 const pl_op = self.air.instructions.items(.data)[@intFromEnum(inst)].pl_op;
63686368 const target_id = try self.resolve(pl_op.operand);
6369 const name = self.air.nullTerminatedString(pl_op.payload);
6370 try self.spv.debugName(target_id, name);
6369 const name: Air.NullTerminatedString = @enumFromInt(pl_op.payload);
6370 try self.spv.debugName(target_id, name.toSlice(self.air));
63716371 }
63726372
63736373 fn airAssembly(self: *NavGen, inst: Air.Inst.Index) !?IdRef {
src/link/C.zig+11-1
......@@ -317,8 +317,18 @@ pub fn updateNav(self: *C, pt: Zcu.PerThread, nav_index: InternPool.Nav.Index) !
317317 defer tracy.end();
318318
319319 const gpa = self.base.comp.gpa;
320
321320 const zcu = pt.zcu;
321 const ip = &zcu.intern_pool;
322
323 const nav = ip.getNav(nav_index);
324 const nav_init = switch (ip.indexToKey(nav.status.resolved.val)) {
325 .func => return,
326 .@"extern" => .none,
327 .variable => |variable| variable.init,
328 else => nav.status.resolved.val,
329 };
330 if (nav_init != .none and !Value.fromInterned(nav_init).typeOf(zcu).hasRuntimeBits(pt)) return;
331
322332 const gop = try self.navs.getOrPut(gpa, nav_index);
323333 errdefer _ = self.navs.pop();
324334 if (!gop.found_existing) gop.value_ptr.* = .{};
src/link/Coff.zig+2-1
......@@ -1207,6 +1207,7 @@ pub fn updateNav(
12071207
12081208 const nav_val = zcu.navValue(nav_index);
12091209 const nav_init = switch (ip.indexToKey(nav_val.toIntern())) {
1210 .func => return,
12101211 .variable => |variable| Value.fromInterned(variable.init),
12111212 .@"extern" => |@"extern"| {
12121213 if (ip.isFunctionType(@"extern".ty)) return;
......@@ -1220,7 +1221,7 @@ pub fn updateNav(
12201221 else => nav_val,
12211222 };
12221223
1223 if (nav_init.typeOf(zcu).isFnOrHasRuntimeBits(pt)) {
1224 if (nav_init.typeOf(zcu).hasRuntimeBits(pt)) {
12241225 const atom_index = try self.getOrCreateAtomForNav(nav_index);
12251226 Atom.freeRelocations(self, atom_index);
12261227 const atom = self.getAtom(atom_index);
src/link/Dwarf.zig+339-150
......@@ -21,8 +21,9 @@ pub const UpdateError =
2121 std.fs.File.OpenError ||
2222 std.fs.File.SetEndPosError ||
2323 std.fs.File.CopyRangeError ||
24 std.fs.File.PReadError ||
2425 std.fs.File.PWriteError ||
25 error{ Overflow, Underflow, UnexpectedEndOfFile };
26 error{ EndOfStream, Overflow, Underflow, UnexpectedEndOfFile };
2627
2728pub const FlushError =
2829 UpdateError ||
......@@ -253,10 +254,8 @@ const Section = struct {
253254 .trailer_len = trailer_len,
254255 .len = header_len + trailer_len,
255256 .entries = .{},
256 .cross_entry_relocs = .{},
257257 .cross_unit_relocs = .{},
258258 .cross_section_relocs = .{},
259 .external_relocs = .{},
260259 };
261260 if (sec.last.unwrap()) |last_unit| {
262261 const last_unit_ptr = sec.getUnit(last_unit);
......@@ -358,10 +357,8 @@ const Unit = struct {
358357 /// data length in bytes
359358 len: u32,
360359 entries: std.ArrayListUnmanaged(Entry),
361 cross_entry_relocs: std.ArrayListUnmanaged(CrossEntryReloc),
362360 cross_unit_relocs: std.ArrayListUnmanaged(CrossUnitReloc),
363361 cross_section_relocs: std.ArrayListUnmanaged(CrossSectionReloc),
364 external_relocs: std.ArrayListUnmanaged(ExternalReloc),
365362
366363 const Index = enum(u32) {
367364 main,
......@@ -381,12 +378,16 @@ const Unit = struct {
381378 }
382379 };
383380
381 fn clear(unit: *Unit) void {
382 unit.cross_unit_relocs.clearRetainingCapacity();
383 unit.cross_section_relocs.clearRetainingCapacity();
384 }
385
384386 fn deinit(unit: *Unit, gpa: std.mem.Allocator) void {
387 for (unit.entries.items) |*entry| entry.deinit(gpa);
385388 unit.entries.deinit(gpa);
386 unit.cross_entry_relocs.deinit(gpa);
387389 unit.cross_unit_relocs.deinit(gpa);
388390 unit.cross_section_relocs.deinit(gpa);
389 unit.external_relocs.deinit(gpa);
390391 unit.* = undefined;
391392 }
392393
......@@ -398,6 +399,10 @@ const Unit = struct {
398399 .next = .none,
399400 .off = 0,
400401 .len = 0,
402 .cross_entry_relocs = .{},
403 .cross_unit_relocs = .{},
404 .cross_section_relocs = .{},
405 .external_relocs = .{},
401406 };
402407 if (unit.last.unwrap()) |last_entry| {
403408 const last_entry_ptr = unit.getEntry(last_entry);
......@@ -451,6 +456,14 @@ const Unit = struct {
451456 unit_ptr.len = len;
452457 }
453458
459 fn trim(unit: *Unit) void {
460 const len = unit.getEntry(unit.first.unwrap() orelse return).off;
461 if (len == 0) return;
462 for (unit.entries.items) |*entry| entry.off -= len;
463 unit.off += len;
464 unit.len -= len;
465 }
466
454467 fn move(unit: *Unit, sec: *Section, dwarf: *Dwarf, new_off: u32) UpdateError!void {
455468 if (unit.off == new_off) return;
456469 if (try dwarf.getFile().?.copyRangeAll(
......@@ -463,6 +476,7 @@ const Unit = struct {
463476 }
464477
465478 fn resizeHeader(unit: *Unit, sec: *Section, dwarf: *Dwarf, len: u32) UpdateError!void {
479 unit.trim();
466480 if (unit.header_len == len) return;
467481 const available_len = if (unit.prev.unwrap()) |prev_unit| prev_excess: {
468482 const prev_unit_ptr = sec.getUnit(prev_unit);
......@@ -535,23 +549,11 @@ const Unit = struct {
535549 }
536550
537551 fn resolveRelocs(unit: *Unit, sec: *Section, dwarf: *Dwarf) RelocError!void {
538 for (unit.cross_entry_relocs.items) |reloc| {
539 try dwarf.resolveReloc(
540 sec.off + unit.off + (if (reloc.source_entry.unwrap()) |source_entry|
541 unit.header_len + unit.getEntry(source_entry).off
542 else
543 0) + reloc.source_off,
544 unit.off + unit.header_len + unit.getEntry(reloc.target_entry).assertNonEmpty(unit, sec, dwarf).off + reloc.target_off,
545 dwarf.sectionOffsetBytes(),
546 );
547 }
552 const unit_off = sec.off + unit.off;
548553 for (unit.cross_unit_relocs.items) |reloc| {
549554 const target_unit = sec.getUnit(reloc.target_unit);
550555 try dwarf.resolveReloc(
551 sec.off + unit.off + (if (reloc.source_entry.unwrap()) |source_entry|
552 unit.header_len + unit.getEntry(source_entry).off
553 else
554 0) + reloc.source_off,
556 unit_off + reloc.source_off,
555557 target_unit.off + (if (reloc.target_entry.unwrap()) |target_entry|
556558 target_unit.header_len + target_unit.getEntry(target_entry).assertNonEmpty(unit, sec, dwarf).off
557559 else
......@@ -565,10 +567,7 @@ const Unit = struct {
565567 };
566568 const target_unit = target_sec.getUnit(reloc.target_unit);
567569 try dwarf.resolveReloc(
568 sec.off + unit.off + (if (reloc.source_entry.unwrap()) |source_entry|
569 unit.header_len + unit.getEntry(source_entry).off
570 else
571 0) + reloc.source_off,
570 unit_off + reloc.source_off,
572571 target_unit.off + (if (reloc.target_entry.unwrap()) |target_entry|
573572 target_unit.header_len + target_unit.getEntry(target_entry).assertNonEmpty(unit, sec, dwarf).off
574573 else
......@@ -576,57 +575,8 @@ const Unit = struct {
576575 dwarf.sectionOffsetBytes(),
577576 );
578577 }
579 if (dwarf.bin_file.cast(.elf)) |elf_file| {
580 const zo = elf_file.zigObjectPtr().?;
581 for (unit.external_relocs.items) |reloc| {
582 const symbol = zo.symbol(reloc.target_sym);
583 try dwarf.resolveReloc(
584 sec.off + unit.off + unit.header_len + unit.getEntry(reloc.source_entry).off + reloc.source_off,
585 @bitCast(symbol.address(.{}, elf_file) + @as(i64, @intCast(reloc.target_off)) -
586 if (symbol.flags.is_tls) elf_file.dtpAddress() else 0),
587 @intFromEnum(dwarf.address_size),
588 );
589 }
590 } else if (dwarf.bin_file.cast(.macho)) |macho_file| {
591 const zo = macho_file.getZigObject().?;
592 for (unit.external_relocs.items) |reloc| {
593 const ref = zo.getSymbolRef(reloc.target_sym, macho_file);
594 try dwarf.resolveReloc(
595 sec.off + unit.off + unit.header_len + unit.getEntry(reloc.source_entry).off + reloc.source_off,
596 ref.getSymbol(macho_file).?.getAddress(.{}, macho_file),
597 @intFromEnum(dwarf.address_size),
598 );
599 }
600 }
578 for (unit.entries.items) |*entry| try entry.resolveRelocs(unit, sec, dwarf);
601579 }
602
603 const CrossEntryReloc = struct {
604 source_entry: Entry.Index.Optional = .none,
605 source_off: u32 = 0,
606 target_entry: Entry.Index,
607 target_off: u32 = 0,
608 };
609 const CrossUnitReloc = struct {
610 source_entry: Entry.Index.Optional = .none,
611 source_off: u32 = 0,
612 target_unit: Unit.Index,
613 target_entry: Entry.Index.Optional = .none,
614 target_off: u32 = 0,
615 };
616 const CrossSectionReloc = struct {
617 source_entry: Entry.Index.Optional = .none,
618 source_off: u32 = 0,
619 target_sec: Section.Index,
620 target_unit: Unit.Index,
621 target_entry: Entry.Index.Optional = .none,
622 target_off: u32 = 0,
623 };
624 const ExternalReloc = struct {
625 source_entry: Entry.Index,
626 source_off: u32 = 0,
627 target_sym: u32,
628 target_off: u64 = 0,
629 };
630580};
631581
632582/// An indivisible entry within a `Unit` containing section-specific data.
......@@ -637,6 +587,25 @@ const Entry = struct {
637587 off: u32,
638588 /// data length in bytes
639589 len: u32,
590 cross_entry_relocs: std.ArrayListUnmanaged(CrossEntryReloc),
591 cross_unit_relocs: std.ArrayListUnmanaged(CrossUnitReloc),
592 cross_section_relocs: std.ArrayListUnmanaged(CrossSectionReloc),
593 external_relocs: std.ArrayListUnmanaged(ExternalReloc),
594
595 fn clear(entry: *Entry) void {
596 entry.cross_entry_relocs.clearRetainingCapacity();
597 entry.cross_unit_relocs.clearRetainingCapacity();
598 entry.cross_section_relocs.clearRetainingCapacity();
599 entry.external_relocs.clearRetainingCapacity();
600 }
601
602 fn deinit(entry: *Entry, gpa: std.mem.Allocator) void {
603 entry.cross_entry_relocs.deinit(gpa);
604 entry.cross_unit_relocs.deinit(gpa);
605 entry.cross_section_relocs.deinit(gpa);
606 entry.external_relocs.deinit(gpa);
607 entry.* = undefined;
608 }
640609
641610 const Index = enum(u32) {
642611 _,
......@@ -803,6 +772,88 @@ const Entry = struct {
803772 }
804773 @panic("missing dwarf relocation target");
805774 }
775
776 fn resolveRelocs(entry: *Entry, unit: *Unit, sec: *Section, dwarf: *Dwarf) RelocError!void {
777 const entry_off = sec.off + unit.off + unit.header_len + entry.off;
778 for (entry.cross_entry_relocs.items) |reloc| {
779 try dwarf.resolveReloc(
780 entry_off + reloc.source_off,
781 unit.off + unit.header_len + unit.getEntry(reloc.target_entry).assertNonEmpty(unit, sec, dwarf).off + reloc.target_off,
782 dwarf.sectionOffsetBytes(),
783 );
784 }
785 for (entry.cross_unit_relocs.items) |reloc| {
786 const target_unit = sec.getUnit(reloc.target_unit);
787 try dwarf.resolveReloc(
788 entry_off + reloc.source_off,
789 target_unit.off + (if (reloc.target_entry.unwrap()) |target_entry|
790 target_unit.header_len + target_unit.getEntry(target_entry).assertNonEmpty(unit, sec, dwarf).off
791 else
792 0) + reloc.target_off,
793 dwarf.sectionOffsetBytes(),
794 );
795 }
796 for (entry.cross_section_relocs.items) |reloc| {
797 const target_sec = switch (reloc.target_sec) {
798 inline else => |target_sec| &@field(dwarf, @tagName(target_sec)).section,
799 };
800 const target_unit = target_sec.getUnit(reloc.target_unit);
801 try dwarf.resolveReloc(
802 entry_off + reloc.source_off,
803 target_unit.off + (if (reloc.target_entry.unwrap()) |target_entry|
804 target_unit.header_len + target_unit.getEntry(target_entry).assertNonEmpty(unit, sec, dwarf).off
805 else
806 0) + reloc.target_off,
807 dwarf.sectionOffsetBytes(),
808 );
809 }
810 if (dwarf.bin_file.cast(.elf)) |elf_file| {
811 const zo = elf_file.zigObjectPtr().?;
812 for (entry.external_relocs.items) |reloc| {
813 const symbol = zo.symbol(reloc.target_sym);
814 try dwarf.resolveReloc(
815 entry_off + reloc.source_off,
816 @bitCast(symbol.address(.{}, elf_file) + @as(i64, @intCast(reloc.target_off)) -
817 if (symbol.flags.is_tls) elf_file.dtpAddress() else 0),
818 @intFromEnum(dwarf.address_size),
819 );
820 }
821 } else if (dwarf.bin_file.cast(.macho)) |macho_file| {
822 const zo = macho_file.getZigObject().?;
823 for (entry.external_relocs.items) |reloc| {
824 const ref = zo.getSymbolRef(reloc.target_sym, macho_file);
825 try dwarf.resolveReloc(
826 entry_off + reloc.source_off,
827 ref.getSymbol(macho_file).?.getAddress(.{}, macho_file),
828 @intFromEnum(dwarf.address_size),
829 );
830 }
831 }
832 }
833};
834
835const CrossEntryReloc = struct {
836 source_off: u32 = 0,
837 target_entry: Entry.Index,
838 target_off: u32 = 0,
839};
840const CrossUnitReloc = struct {
841 source_off: u32 = 0,
842 target_unit: Unit.Index,
843 target_entry: Entry.Index.Optional = .none,
844 target_off: u32 = 0,
845};
846const CrossSectionReloc = struct {
847 source_off: u32 = 0,
848 target_sec: Section.Index,
849 target_unit: Unit.Index,
850 target_entry: Entry.Index.Optional = .none,
851 target_off: u32 = 0,
852};
853const ExternalReloc = struct {
854 source_off: u32 = 0,
855 target_sym: u32,
856 target_off: u64 = 0,
806857};
807858
808859pub const Loc = union(enum) {
......@@ -986,7 +1037,9 @@ pub const WipNav = struct {
9861037 entry: Entry.Index,
9871038 any_children: bool,
9881039 func: InternPool.Index,
1040 func_sym_index: u32,
9891041 func_high_reloc: u32,
1042 inlined_funcs_high_reloc: std.ArrayListUnmanaged(u32),
9901043 debug_info: std.ArrayListUnmanaged(u8),
9911044 debug_line: std.ArrayListUnmanaged(u8),
9921045 debug_loclists: std.ArrayListUnmanaged(u8),
......@@ -994,6 +1047,7 @@ pub const WipNav = struct {
9941047
9951048 pub fn deinit(wip_nav: *WipNav) void {
9961049 const gpa = wip_nav.dwarf.gpa;
1050 if (wip_nav.func != .none) wip_nav.inlined_funcs_high_reloc.deinit(gpa);
9971051 wip_nav.debug_info.deinit(gpa);
9981052 wip_nav.debug_line.deinit(gpa);
9991053 wip_nav.debug_loclists.deinit(gpa);
......@@ -1004,10 +1058,10 @@ pub const WipNav = struct {
10041058 return wip_nav.debug_info.writer(wip_nav.dwarf.gpa);
10051059 }
10061060
1007 pub const VarTag = enum { local_arg, local_var };
1008 pub fn genVarDebugInfo(
1061 pub const LocalTag = enum { local_arg, local_var };
1062 pub fn genLocalDebugInfo(
10091063 wip_nav: *WipNav,
1010 tag: VarTag,
1064 tag: LocalTag,
10111065 name: []const u8,
10121066 ty: Type,
10131067 loc: Loc,
......@@ -1078,7 +1132,43 @@ pub const WipNav = struct {
10781132 try dlw.writeByte(DW.LNS.set_epilogue_begin);
10791133 }
10801134
1135 pub fn enterInlineFunc(wip_nav: *WipNav, func: InternPool.Index, code_off: u64, line: u32, column: u32) UpdateError!void {
1136 const dwarf = wip_nav.dwarf;
1137 const zcu = wip_nav.pt.zcu;
1138 const diw = wip_nav.debug_info.writer(dwarf.gpa);
1139 try wip_nav.inlined_funcs_high_reloc.ensureUnusedCapacity(dwarf.gpa, 1);
1140
1141 try uleb128(diw, @intFromEnum(AbbrevCode.inlined_func));
1142 try wip_nav.refNav(zcu.funcInfo(func).owner_nav);
1143 try uleb128(diw, zcu.navSrcLine(zcu.funcInfo(wip_nav.func).owner_nav) + line + 1);
1144 try uleb128(diw, column + 1);
1145 const external_relocs = &dwarf.debug_info.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).external_relocs;
1146 try external_relocs.ensureUnusedCapacity(dwarf.gpa, 2);
1147 external_relocs.appendAssumeCapacity(.{
1148 .source_off = @intCast(wip_nav.debug_info.items.len),
1149 .target_sym = wip_nav.func_sym_index,
1150 .target_off = code_off,
1151 });
1152 try diw.writeByteNTimes(0, @intFromEnum(dwarf.address_size));
1153 wip_nav.inlined_funcs_high_reloc.appendAssumeCapacity(@intCast(external_relocs.items.len));
1154 external_relocs.appendAssumeCapacity(.{
1155 .source_off = @intCast(wip_nav.debug_info.items.len),
1156 .target_sym = wip_nav.func_sym_index,
1157 .target_off = undefined,
1158 });
1159 try diw.writeByteNTimes(0, @intFromEnum(dwarf.address_size));
1160 try wip_nav.setInlineFunc(func);
1161 }
1162
1163 pub fn leaveInlineFunc(wip_nav: *WipNav, func: InternPool.Index, code_off: u64) UpdateError!void {
1164 const external_relocs = &wip_nav.dwarf.debug_info.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).external_relocs;
1165 external_relocs.items[wip_nav.inlined_funcs_high_reloc.pop()].target_off = code_off;
1166 try uleb128(wip_nav.debug_info.writer(wip_nav.dwarf.gpa), @intFromEnum(AbbrevCode.null));
1167 try wip_nav.setInlineFunc(func);
1168 }
1169
10811170 pub fn setInlineFunc(wip_nav: *WipNav, func: InternPool.Index) UpdateError!void {
1171 wip_nav.any_children = true;
10821172 const zcu = wip_nav.pt.zcu;
10831173 const dwarf = wip_nav.dwarf;
10841174 if (wip_nav.func == func) return;
......@@ -1096,8 +1186,7 @@ pub const WipNav = struct {
10961186 try dlw.writeByte(DW.LNS.extended_op);
10971187 try uleb128(dlw, 1 + dwarf.sectionOffsetBytes());
10981188 try dlw.writeByte(DW.LNE.ZIG_set_decl);
1099 try dwarf.debug_line.section.getUnit(wip_nav.unit).cross_section_relocs.append(dwarf.gpa, .{
1100 .source_entry = wip_nav.entry.toOptional(),
1189 try dwarf.debug_line.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).cross_section_relocs.append(dwarf.gpa, .{
11011190 .source_off = @intCast(wip_nav.debug_line.items.len),
11021191 .target_sec = .debug_info,
11031192 .target_unit = new_unit,
......@@ -1133,9 +1222,9 @@ pub const WipNav = struct {
11331222 fn infoSectionOffset(wip_nav: *WipNav, sec: Section.Index, unit: Unit.Index, entry: Entry.Index, off: u32) UpdateError!void {
11341223 const dwarf = wip_nav.dwarf;
11351224 const gpa = dwarf.gpa;
1225 const entry_ptr = dwarf.debug_info.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry);
11361226 if (sec != .debug_info) {
1137 try dwarf.debug_info.section.getUnit(wip_nav.unit).cross_section_relocs.append(gpa, .{
1138 .source_entry = wip_nav.entry.toOptional(),
1227 try entry_ptr.cross_section_relocs.append(gpa, .{
11391228 .source_off = @intCast(wip_nav.debug_info.items.len),
11401229 .target_sec = sec,
11411230 .target_unit = unit,
......@@ -1143,16 +1232,14 @@ pub const WipNav = struct {
11431232 .target_off = off,
11441233 });
11451234 } else if (unit != wip_nav.unit) {
1146 try dwarf.debug_info.section.getUnit(wip_nav.unit).cross_unit_relocs.append(gpa, .{
1147 .source_entry = wip_nav.entry.toOptional(),
1235 try entry_ptr.cross_unit_relocs.append(gpa, .{
11481236 .source_off = @intCast(wip_nav.debug_info.items.len),
11491237 .target_unit = unit,
11501238 .target_entry = entry.toOptional(),
11511239 .target_off = off,
11521240 });
11531241 } else {
1154 try dwarf.debug_info.section.getUnit(wip_nav.unit).cross_entry_relocs.append(gpa, .{
1155 .source_entry = wip_nav.entry.toOptional(),
1242 try entry_ptr.cross_entry_relocs.append(gpa, .{
11561243 .source_off = @intCast(wip_nav.debug_info.items.len),
11571244 .target_entry = entry,
11581245 .target_off = off,
......@@ -1167,8 +1254,7 @@ pub const WipNav = struct {
11671254
11681255 fn addrSym(wip_nav: *WipNav, sym_index: u32) UpdateError!void {
11691256 const dwarf = wip_nav.dwarf;
1170 try dwarf.debug_info.section.getUnit(wip_nav.unit).external_relocs.append(dwarf.gpa, .{
1171 .source_entry = wip_nav.entry,
1257 try dwarf.debug_info.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).external_relocs.append(dwarf.gpa, .{
11721258 .source_off = @intCast(wip_nav.debug_info.items.len),
11731259 .target_sym = sym_index,
11741260 });
......@@ -1217,12 +1303,20 @@ pub const WipNav = struct {
12171303 try wip_nav.infoSectionOffset(.debug_info, unit, entry, 0);
12181304 }
12191305
1306 fn refNav(wip_nav: *WipNav, nav_index: InternPool.Nav.Index) UpdateError!void {
1307 const zcu = wip_nav.pt.zcu;
1308 const ip = &zcu.intern_pool;
1309 const unit = try wip_nav.dwarf.getUnit(zcu.fileByIndex(ip.getNav(nav_index).srcInst(ip).resolveFile(ip)).mod);
1310 const nav_gop = try wip_nav.dwarf.navs.getOrPut(wip_nav.dwarf.gpa, nav_index);
1311 if (!nav_gop.found_existing) nav_gop.value_ptr.* = try wip_nav.dwarf.addCommonEntry(unit);
1312 try wip_nav.infoSectionOffset(.debug_info, unit, nav_gop.value_ptr.*, 0);
1313 }
1314
12201315 fn refForward(wip_nav: *WipNav) std.mem.Allocator.Error!u32 {
12211316 const dwarf = wip_nav.dwarf;
1222 const cross_entry_relocs = &dwarf.debug_info.section.getUnit(wip_nav.unit).cross_entry_relocs;
1317 const cross_entry_relocs = &dwarf.debug_info.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).cross_entry_relocs;
12231318 const reloc_index: u32 = @intCast(cross_entry_relocs.items.len);
12241319 try cross_entry_relocs.append(dwarf.gpa, .{
1225 .source_entry = wip_nav.entry.toOptional(),
12261320 .source_off = @intCast(wip_nav.debug_info.items.len),
12271321 .target_entry = undefined,
12281322 .target_off = undefined,
......@@ -1232,7 +1326,7 @@ pub const WipNav = struct {
12321326 }
12331327
12341328 fn finishForward(wip_nav: *WipNav, reloc_index: u32) void {
1235 const reloc = &wip_nav.dwarf.debug_info.section.getUnit(wip_nav.unit).cross_entry_relocs.items[reloc_index];
1329 const reloc = &wip_nav.dwarf.debug_info.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).cross_entry_relocs.items[reloc_index];
12361330 reloc.target_entry = wip_nav.entry;
12371331 reloc.target_off = @intCast(wip_nav.debug_info.items.len);
12381332 }
......@@ -1545,7 +1639,15 @@ pub fn initWipNav(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPool.Nav.In
15451639 const unit = try dwarf.getUnit(file.mod);
15461640 const nav_gop = try dwarf.navs.getOrPut(dwarf.gpa, nav_index);
15471641 errdefer _ = dwarf.navs.pop();
1548 if (!nav_gop.found_existing) nav_gop.value_ptr.* = try dwarf.addCommonEntry(unit);
1642 if (nav_gop.found_existing) {
1643 for ([_]*Section{
1644 &dwarf.debug_aranges.section,
1645 &dwarf.debug_info.section,
1646 &dwarf.debug_line.section,
1647 &dwarf.debug_loclists.section,
1648 &dwarf.debug_rnglists.section,
1649 }) |sec| sec.getUnit(unit).getEntry(nav_gop.value_ptr.*).clear();
1650 } else nav_gop.value_ptr.* = try dwarf.addCommonEntry(unit);
15491651 const nav_val = zcu.navValue(nav_index);
15501652 var wip_nav: WipNav = .{
15511653 .dwarf = dwarf,
......@@ -1554,7 +1656,9 @@ pub fn initWipNav(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPool.Nav.In
15541656 .entry = nav_gop.value_ptr.*,
15551657 .any_children = false,
15561658 .func = .none,
1659 .func_sym_index = undefined,
15571660 .func_high_reloc = undefined,
1661 .inlined_funcs_high_reloc = undefined,
15581662 .debug_info = .{},
15591663 .debug_line = .{},
15601664 .debug_loclists = .{},
......@@ -1608,16 +1712,7 @@ pub fn initWipNav(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPool.Nav.In
16081712 try wip_nav.exprloc(.{ .addr = .{ .sym = sym_index } });
16091713 try uleb128(diw, nav.status.resolved.alignment.toByteUnits() orelse
16101714 ty.abiAlignment(pt).toByteUnits().?);
1611 const func_unit = InternPool.AnalUnit.wrap(.{ .func = nav_val.toIntern() });
1612 try diw.writeByte(@intFromBool(for (if (zcu.single_exports.get(func_unit)) |export_index|
1613 zcu.all_exports.items[export_index..][0..1]
1614 else if (zcu.multi_exports.get(func_unit)) |export_range|
1615 zcu.all_exports.items[export_range.index..][0..export_range.len]
1616 else
1617 &.{}) |@"export"|
1618 {
1619 if (@"export".exported == .nav and @"export".exported.nav == nav_index) break true;
1620 } else false));
1715 try diw.writeByte(@intFromBool(false));
16211716 wip_nav.finishForward(ty_reloc_index);
16221717 try uleb128(diw, @intFromEnum(AbbrevCode.is_const));
16231718 try wip_nav.refType(ty);
......@@ -1668,16 +1763,7 @@ pub fn initWipNav(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPool.Nav.In
16681763 try wip_nav.exprloc(if (variable.is_threadlocal) .{ .form_tls_address = &addr } else addr);
16691764 try uleb128(diw, nav.status.resolved.alignment.toByteUnits() orelse
16701765 ty.abiAlignment(pt).toByteUnits().?);
1671 const func_unit = InternPool.AnalUnit.wrap(.{ .func = nav_val.toIntern() });
1672 try diw.writeByte(@intFromBool(for (if (zcu.single_exports.get(func_unit)) |export_index|
1673 zcu.all_exports.items[export_index..][0..1]
1674 else if (zcu.multi_exports.get(func_unit)) |export_range|
1675 zcu.all_exports.items[export_range.index..][0..export_range.len]
1676 else
1677 &.{}) |@"export"|
1678 {
1679 if (@"export".exported == .nav and @"export".exported.nav == nav_index) break true;
1680 } else false));
1766 try diw.writeByte(@intFromBool(false));
16811767 },
16821768 .func => |func| {
16831769 assert(file.zir_loaded);
......@@ -1712,6 +1798,8 @@ pub fn initWipNav(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPool.Nav.In
17121798
17131799 const func_type = ip.indexToKey(func.ty).func_type;
17141800 wip_nav.func = nav_val.toIntern();
1801 wip_nav.func_sym_index = sym_index;
1802 wip_nav.inlined_funcs_high_reloc = .{};
17151803
17161804 const diw = wip_nav.debug_info.writer(dwarf.gpa);
17171805 try uleb128(diw, @intFromEnum(AbbrevCode.decl_func));
......@@ -1723,32 +1811,23 @@ pub fn initWipNav(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPool.Nav.In
17231811 try wip_nav.strp(nav.name.toSlice(ip));
17241812 try wip_nav.strp(nav.fqn.toSlice(ip));
17251813 try wip_nav.refType(Type.fromInterned(func_type.return_type));
1726 const external_relocs = &dwarf.debug_info.section.getUnit(unit).external_relocs;
1727 try external_relocs.append(dwarf.gpa, .{
1728 .source_entry = wip_nav.entry,
1814 const external_relocs = &dwarf.debug_info.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).external_relocs;
1815 try external_relocs.ensureUnusedCapacity(dwarf.gpa, 2);
1816 external_relocs.appendAssumeCapacity(.{
17291817 .source_off = @intCast(wip_nav.debug_info.items.len),
17301818 .target_sym = sym_index,
17311819 });
17321820 try diw.writeByteNTimes(0, @intFromEnum(dwarf.address_size));
17331821 wip_nav.func_high_reloc = @intCast(external_relocs.items.len);
1734 try external_relocs.append(dwarf.gpa, .{
1735 .source_entry = wip_nav.entry,
1822 external_relocs.appendAssumeCapacity(.{
17361823 .source_off = @intCast(wip_nav.debug_info.items.len),
17371824 .target_sym = sym_index,
1825 .target_off = undefined,
17381826 });
17391827 try diw.writeByteNTimes(0, @intFromEnum(dwarf.address_size));
17401828 try uleb128(diw, nav.status.resolved.alignment.toByteUnits() orelse
17411829 target_info.defaultFunctionAlignment(file.mod.resolved_target.result).toByteUnits().?);
1742 const func_unit = InternPool.AnalUnit.wrap(.{ .func = nav_val.toIntern() });
1743 try diw.writeByte(@intFromBool(for (if (zcu.single_exports.get(func_unit)) |export_index|
1744 zcu.all_exports.items[export_index..][0..1]
1745 else if (zcu.multi_exports.get(func_unit)) |export_range|
1746 zcu.all_exports.items[export_range.index..][0..export_range.len]
1747 else
1748 &.{}) |@"export"|
1749 {
1750 if (@"export".exported == .nav and @"export".exported.nav == nav_index) break true;
1751 } else false));
1830 try diw.writeByte(@intFromBool(false));
17521831 try diw.writeByte(@intFromBool(func_type.return_type == .noreturn_type));
17531832
17541833 const dlw = wip_nav.debug_line.writer(dwarf.gpa);
......@@ -1756,8 +1835,7 @@ pub fn initWipNav(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPool.Nav.In
17561835 if (dwarf.incremental()) {
17571836 try uleb128(dlw, 1 + dwarf.sectionOffsetBytes());
17581837 try dlw.writeByte(DW.LNE.ZIG_set_decl);
1759 try dwarf.debug_line.section.getUnit(wip_nav.unit).cross_section_relocs.append(dwarf.gpa, .{
1760 .source_entry = wip_nav.entry.toOptional(),
1838 try dwarf.debug_line.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).cross_section_relocs.append(dwarf.gpa, .{
17611839 .source_off = @intCast(wip_nav.debug_line.items.len),
17621840 .target_sec = .debug_info,
17631841 .target_unit = wip_nav.unit,
......@@ -1772,8 +1850,7 @@ pub fn initWipNav(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPool.Nav.In
17721850 } else {
17731851 try uleb128(dlw, 1 + @intFromEnum(dwarf.address_size));
17741852 try dlw.writeByte(DW.LNE.set_address);
1775 try dwarf.debug_line.section.getUnit(wip_nav.unit).external_relocs.append(dwarf.gpa, .{
1776 .source_entry = wip_nav.entry,
1853 try dwarf.debug_line.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).external_relocs.append(dwarf.gpa, .{
17771854 .source_off = @intCast(wip_nav.debug_line.items.len),
17781855 .target_sym = sym_index,
17791856 });
......@@ -1806,7 +1883,8 @@ pub fn finishWipNav(
18061883 log.debug("finishWipNav({})", .{nav.fqn.fmt(ip)});
18071884
18081885 if (wip_nav.func != .none) {
1809 dwarf.debug_info.section.getUnit(wip_nav.unit).external_relocs.items[wip_nav.func_high_reloc].target_off = sym.size;
1886 const external_relocs = &dwarf.debug_info.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).external_relocs;
1887 external_relocs.items[wip_nav.func_high_reloc].target_off = sym.size;
18101888 if (wip_nav.any_children) {
18111889 const diw = wip_nav.debug_info.writer(dwarf.gpa);
18121890 try uleb128(diw, @intFromEnum(AbbrevCode.null));
......@@ -1817,8 +1895,7 @@ pub fn finishWipNav(
18171895 );
18181896
18191897 var aranges_entry = [1]u8{0} ** (8 + 8);
1820 try dwarf.debug_aranges.section.getUnit(wip_nav.unit).external_relocs.append(dwarf.gpa, .{
1821 .source_entry = wip_nav.entry,
1898 try dwarf.debug_aranges.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).external_relocs.append(dwarf.gpa, .{
18221899 .target_sym = sym.index,
18231900 });
18241901 dwarf.writeInt(aranges_entry[0..@intFromEnum(dwarf.address_size)], 0);
......@@ -1832,14 +1909,12 @@ pub fn finishWipNav(
18321909 aranges_entry[0 .. @intFromEnum(dwarf.address_size) * 2],
18331910 );
18341911
1835 try dwarf.debug_rnglists.section.getUnit(wip_nav.unit).external_relocs.appendSlice(dwarf.gpa, &.{
1912 try dwarf.debug_rnglists.section.getUnit(wip_nav.unit).getEntry(wip_nav.entry).external_relocs.appendSlice(dwarf.gpa, &.{
18361913 .{
1837 .source_entry = wip_nav.entry,
18381914 .source_off = 1,
18391915 .target_sym = sym.index,
18401916 },
18411917 .{
1842 .source_entry = wip_nav.entry,
18431918 .source_off = 1 + @intFromEnum(dwarf.address_size),
18441919 .target_sym = sym.index,
18451920 .target_off = sym.size,
......@@ -1891,7 +1966,9 @@ pub fn updateComptimeNav(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPool
18911966 .entry = undefined,
18921967 .any_children = false,
18931968 .func = .none,
1969 .func_sym_index = undefined,
18941970 .func_high_reloc = undefined,
1971 .inlined_funcs_high_reloc = undefined,
18951972 .debug_info = .{},
18961973 .debug_line = .{},
18971974 .debug_loclists = .{},
......@@ -1902,6 +1979,62 @@ pub fn updateComptimeNav(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPool
19021979 const nav_gop = try dwarf.navs.getOrPut(dwarf.gpa, nav_index);
19031980 errdefer _ = dwarf.navs.pop();
19041981 switch (ip.indexToKey(nav_val.toIntern())) {
1982 .func => |func| {
1983 if (nav_gop.found_existing) {
1984 const unit_ptr = dwarf.debug_info.section.getUnit(unit);
1985 const entry_ptr = unit_ptr.getEntry(nav_gop.value_ptr.*);
1986 if (entry_ptr.len >= AbbrevCode.decl_bytes) {
1987 var abbrev_code_buf: [AbbrevCode.decl_bytes]u8 = undefined;
1988 if (try dwarf.getFile().?.preadAll(
1989 &abbrev_code_buf,
1990 dwarf.debug_info.section.off + unit_ptr.off + unit_ptr.header_len + entry_ptr.off,
1991 ) != abbrev_code_buf.len) return error.InputOutput;
1992 var abbrev_code_fbs = std.io.fixedBufferStream(&abbrev_code_buf);
1993 const abbrev_code: AbbrevCode = @enumFromInt(
1994 try std.leb.readUleb128(@typeInfo(AbbrevCode).Enum.tag_type, abbrev_code_fbs.reader()),
1995 );
1996 switch (abbrev_code) {
1997 else => unreachable,
1998 .decl_func, .decl_func_empty => return,
1999 .decl_func_generic, .decl_func_generic_empty => {},
2000 }
2001 }
2002 entry_ptr.clear();
2003 } else nav_gop.value_ptr.* = try dwarf.addCommonEntry(unit);
2004 wip_nav.entry = nav_gop.value_ptr.*;
2005
2006 const parent_type, const accessibility: u8 = if (nav.analysis_owner.unwrap()) |cau| parent: {
2007 const parent_namespace_ptr = ip.namespacePtr(ip.getCau(cau).namespace);
2008 break :parent .{
2009 parent_namespace_ptr.owner_type,
2010 if (parent_namespace_ptr.pub_decls.containsContext(nav_index, .{ .zcu = zcu }))
2011 DW.ACCESS.public
2012 else if (parent_namespace_ptr.priv_decls.containsContext(nav_index, .{ .zcu = zcu }))
2013 DW.ACCESS.private
2014 else
2015 unreachable,
2016 };
2017 } else .{ zcu.fileRootType(inst_info.file), DW.ACCESS.private };
2018
2019 const func_type = ip.indexToKey(func.ty).func_type;
2020 const diw = wip_nav.debug_info.writer(dwarf.gpa);
2021 try uleb128(diw, @intFromEnum(@as(AbbrevCode, if (func_type.param_types.len > 0 or func_type.is_var_args) .decl_func_generic else .decl_func_generic_empty)));
2022 try wip_nav.refType(Type.fromInterned(parent_type));
2023 assert(wip_nav.debug_info.items.len == DebugInfo.declEntryLineOff(dwarf));
2024 try diw.writeInt(u32, @intCast(loc.line + 1), dwarf.endian);
2025 try uleb128(diw, loc.column + 1);
2026 try diw.writeByte(accessibility);
2027 try wip_nav.strp(nav.name.toSlice(ip));
2028 try wip_nav.refType(Type.fromInterned(func_type.return_type));
2029 if (func_type.param_types.len > 0 or func_type.is_var_args) {
2030 for (0..func_type.param_types.len) |param_index| {
2031 try uleb128(diw, @intFromEnum(AbbrevCode.func_type_param));
2032 try wip_nav.refType(Type.fromInterned(func_type.param_types.get(ip)[param_index]));
2033 }
2034 if (func_type.is_var_args) try uleb128(diw, @intFromEnum(AbbrevCode.is_var_args));
2035 try uleb128(diw, @intFromEnum(AbbrevCode.null));
2036 }
2037 },
19052038 .struct_type => done: {
19062039 const loaded_struct = ip.loadStructType(nav_val.toIntern());
19072040
......@@ -2304,7 +2437,9 @@ fn updateType(
23042437 .entry = dwarf.types.get(type_index).?,
23052438 .any_children = false,
23062439 .func = .none,
2440 .func_sym_index = undefined,
23072441 .func_high_reloc = undefined,
2442 .inlined_funcs_high_reloc = undefined,
23082443 .debug_info = .{},
23092444 .debug_line = .{},
23102445 .debug_loclists = .{},
......@@ -2467,13 +2602,25 @@ fn updateType(
24672602 .error_union_type => |error_union_type| {
24682603 const error_union_error_set_type = Type.fromInterned(error_union_type.error_set_type);
24692604 const error_union_payload_type = Type.fromInterned(error_union_type.payload_type);
2470 const error_union_error_set_offset = codegen.errUnionErrorOffset(error_union_payload_type, pt);
2471 const error_union_payload_offset = codegen.errUnionPayloadOffset(error_union_payload_type, pt);
2605 const error_union_error_set_offset, const error_union_payload_offset = switch (error_union_type.payload_type) {
2606 .generic_poison_type => .{ 0, 0 },
2607 else => .{
2608 codegen.errUnionErrorOffset(error_union_payload_type, pt),
2609 codegen.errUnionPayloadOffset(error_union_payload_type, pt),
2610 },
2611 };
24722612
24732613 try uleb128(diw, @intFromEnum(AbbrevCode.union_type));
24742614 try wip_nav.strp(name);
2475 try uleb128(diw, ty.abiSize(pt));
2476 try uleb128(diw, ty.abiAlignment(pt).toByteUnits().?);
2615 if (error_union_type.error_set_type != .generic_poison_type and
2616 error_union_type.payload_type != .generic_poison_type)
2617 {
2618 try uleb128(diw, ty.abiSize(pt));
2619 try uleb128(diw, ty.abiAlignment(pt).toByteUnits().?);
2620 } else {
2621 try uleb128(diw, 0);
2622 try uleb128(diw, 1);
2623 }
24772624 {
24782625 try uleb128(diw, @intFromEnum(AbbrevCode.tagged_union));
24792626 try wip_nav.infoSectionOffset(
......@@ -2655,10 +2802,16 @@ fn updateType(
26552802 }
26562803 if (error_set_type.names.len > 0) try uleb128(diw, @intFromEnum(AbbrevCode.null));
26572804 },
2658 .inferred_error_set_type => |func| {
2659 try uleb128(diw, @intFromEnum(AbbrevCode.inferred_error_set_type));
2660 try wip_nav.strp(name);
2661 try wip_nav.refType(Type.fromInterned(ip.funcIesResolvedUnordered(func)));
2805 .inferred_error_set_type => |func| switch (ip.funcIesResolvedUnordered(func)) {
2806 .none => {
2807 try uleb128(diw, @intFromEnum(AbbrevCode.void_type));
2808 try wip_nav.strp(name);
2809 },
2810 else => |ies| {
2811 try uleb128(diw, @intFromEnum(AbbrevCode.inferred_error_set_type));
2812 try wip_nav.strp(name);
2813 try wip_nav.refType(Type.fromInterned(ies));
2814 },
26622815 },
26632816
26642817 // values, not types
......@@ -2705,7 +2858,9 @@ pub fn updateContainerType(dwarf: *Dwarf, pt: Zcu.PerThread, type_index: InternP
27052858 .entry = type_gop.value_ptr.*,
27062859 .any_children = false,
27072860 .func = .none,
2861 .func_sym_index = undefined,
27082862 .func_high_reloc = undefined,
2863 .inlined_funcs_high_reloc = undefined,
27092864 .debug_info = .{},
27102865 .debug_line = .{},
27112866 .debug_loclists = .{},
......@@ -2766,7 +2921,9 @@ pub fn updateContainerType(dwarf: *Dwarf, pt: Zcu.PerThread, type_index: InternP
27662921 .entry = type_gop.value_ptr.*,
27672922 .any_children = false,
27682923 .func = .none,
2924 .func_sym_index = undefined,
27692925 .func_high_reloc = undefined,
2926 .inlined_funcs_high_reloc = undefined,
27702927 .debug_info = .{},
27712928 .debug_line = .{},
27722929 .debug_loclists = .{},
......@@ -2940,7 +3097,9 @@ pub fn flushModule(dwarf: *Dwarf, pt: Zcu.PerThread) FlushError!void {
29403097 .entry = entry,
29413098 .any_children = false,
29423099 .func = .none,
3100 .func_sym_index = undefined,
29433101 .func_high_reloc = undefined,
3102 .inlined_funcs_high_reloc = undefined,
29443103 .debug_info = .{},
29453104 .debug_line = .{},
29463105 .debug_loclists = .{},
......@@ -2998,7 +3157,8 @@ pub fn flushModule(dwarf: *Dwarf, pt: Zcu.PerThread) FlushError!void {
29983157 if (dwarf.debug_aranges.section.dirty) {
29993158 for (dwarf.debug_aranges.section.units.items, 0..) |*unit_ptr, unit_index| {
30003159 const unit: Unit.Index = @enumFromInt(unit_index);
3001 try unit_ptr.cross_section_relocs.ensureUnusedCapacity(dwarf.gpa, 1);
3160 unit_ptr.clear();
3161 try unit_ptr.cross_section_relocs.ensureTotalCapacity(dwarf.gpa, 1);
30023162 header.clearRetainingCapacity();
30033163 try header.ensureTotalCapacity(unit_ptr.header_len);
30043164 const unit_len = (if (unit_ptr.next.unwrap()) |next_unit|
......@@ -3029,8 +3189,9 @@ pub fn flushModule(dwarf: *Dwarf, pt: Zcu.PerThread) FlushError!void {
30293189 if (dwarf.debug_info.section.dirty) {
30303190 for (dwarf.mods.keys(), dwarf.mods.values(), dwarf.debug_info.section.units.items, 0..) |mod, mod_info, *unit_ptr, unit_index| {
30313191 const unit: Unit.Index = @enumFromInt(unit_index);
3032 try unit_ptr.cross_unit_relocs.ensureUnusedCapacity(dwarf.gpa, 1);
3033 try unit_ptr.cross_section_relocs.ensureUnusedCapacity(dwarf.gpa, 7);
3192 unit_ptr.clear();
3193 try unit_ptr.cross_unit_relocs.ensureTotalCapacity(dwarf.gpa, 1);
3194 try unit_ptr.cross_section_relocs.ensureTotalCapacity(dwarf.gpa, 7);
30343195 header.clearRetainingCapacity();
30353196 try header.ensureTotalCapacity(unit_ptr.header_len);
30363197 const unit_len = (if (unit_ptr.next.unwrap()) |next_unit|
......@@ -3121,7 +3282,8 @@ pub fn flushModule(dwarf: *Dwarf, pt: Zcu.PerThread) FlushError!void {
31213282 for (dwarf.mods.values(), dwarf.debug_line.section.units.items) |mod_info, *unit|
31223283 try unit.resizeHeader(&dwarf.debug_line.section, dwarf, DebugLine.headerBytes(dwarf, @intCast(mod_info.dirs.count()), @intCast(mod_info.files.count())));
31233284 for (dwarf.mods.values(), dwarf.debug_line.section.units.items) |mod_info, *unit| {
3124 try unit.cross_section_relocs.ensureUnusedCapacity(dwarf.gpa, 2 * (1 + mod_info.files.count()));
3285 unit.clear();
3286 try unit.cross_section_relocs.ensureTotalCapacity(dwarf.gpa, 2 * (1 + mod_info.files.count()));
31253287 header.clearRetainingCapacity();
31263288 try header.ensureTotalCapacity(unit.header_len);
31273289 const unit_len = (if (unit.next.unwrap()) |next_unit|
......@@ -3310,6 +3472,8 @@ const AbbrevCode = enum(u8) {
33103472 decl_var,
33113473 decl_func,
33123474 decl_func_empty,
3475 decl_func_generic,
3476 decl_func_generic_empty,
33133477 // the rest are unrestricted
33143478 compile_unit,
33153479 module,
......@@ -3344,10 +3508,11 @@ const AbbrevCode = enum(u8) {
33443508 struct_type,
33453509 packed_struct_type,
33463510 union_type,
3511 inlined_func,
33473512 local_arg,
33483513 local_var,
33493514
3350 const decl_bytes = uleb128Bytes(@intFromEnum(AbbrevCode.decl_func_empty));
3515 const decl_bytes = uleb128Bytes(@intFromEnum(AbbrevCode.decl_func_generic_empty));
33513516
33523517 const Attr = struct {
33533518 DeclValEnum(DW.AT),
......@@ -3451,6 +3616,19 @@ const AbbrevCode = enum(u8) {
34513616 .{ .noreturn, .flag },
34523617 },
34533618 },
3619 .decl_func_generic = .{
3620 .tag = .subprogram,
3621 .children = true,
3622 .attrs = decl_abbrev_common_attrs ++ .{
3623 .{ .type, .ref_addr },
3624 },
3625 },
3626 .decl_func_generic_empty = .{
3627 .tag = .subprogram,
3628 .attrs = decl_abbrev_common_attrs ++ .{
3629 .{ .type, .ref_addr },
3630 },
3631 },
34543632 .compile_unit = .{
34553633 .tag = .compile_unit,
34563634 .children = true,
......@@ -3706,6 +3884,17 @@ const AbbrevCode = enum(u8) {
37063884 .{ .alignment, .udata },
37073885 },
37083886 },
3887 .inlined_func = .{
3888 .tag = .inlined_subroutine,
3889 .children = true,
3890 .attrs = &.{
3891 .{ .abstract_origin, .ref_addr },
3892 .{ .call_line, .udata },
3893 .{ .call_column, .udata },
3894 .{ .low_pc, .addr },
3895 .{ .high_pc, .addr },
3896 },
3897 },
37093898 .local_arg = .{
37103899 .tag = .formal_parameter,
37113900 .attrs = &.{
src/link/Elf/ZigObject.zig+6-6
......@@ -1122,9 +1122,9 @@ pub fn updateNav(
11221122
11231123 log.debug("updateNav {}({d})", .{ nav.fqn.fmt(ip), nav_index });
11241124
1125 const nav_val = zcu.navValue(nav_index);
1126 const nav_init = switch (ip.indexToKey(nav_val.toIntern())) {
1127 .variable => |variable| Value.fromInterned(variable.init),
1125 const nav_init = switch (ip.indexToKey(nav.status.resolved.val)) {
1126 .func => .none,
1127 .variable => |variable| variable.init,
11281128 .@"extern" => |@"extern"| {
11291129 if (ip.isFunctionType(@"extern".ty)) return;
11301130 const sym_index = try self.getGlobalSymbol(
......@@ -1135,10 +1135,10 @@ pub fn updateNav(
11351135 self.symbol(sym_index).flags.is_extern_ptr = true;
11361136 return;
11371137 },
1138 else => nav_val,
1138 else => nav.status.resolved.val,
11391139 };
11401140
1141 if (nav_init.typeOf(zcu).isFnOrHasRuntimeBits(pt)) {
1141 if (nav_init != .none and Value.fromInterned(nav_init).typeOf(zcu).hasRuntimeBits(pt)) {
11421142 const sym_index = try self.getOrCreateMetadataForNav(elf_file, nav_index);
11431143 self.symbol(sym_index).atom(elf_file).?.freeRelocs(elf_file);
11441144
......@@ -1153,7 +1153,7 @@ pub fn updateNav(
11531153 &elf_file.base,
11541154 pt,
11551155 zcu.navSrcLoc(nav_index),
1156 nav_init,
1156 Value.fromInterned(nav_init),
11571157 &code_buffer,
11581158 if (debug_wip_nav) |*wip_nav| .{ .dwarf = wip_nav } else .none,
11591159 .{ .parent_atom_index = sym_index },
src/link/MachO/ZigObject.zig+7-6
......@@ -869,10 +869,11 @@ pub fn updateNav(
869869
870870 const zcu = pt.zcu;
871871 const ip = &zcu.intern_pool;
872 const nav = ip.getNav(nav_index);
872873
873 const nav_val = zcu.navValue(nav_index);
874 const nav_init = switch (ip.indexToKey(nav_val.toIntern())) {
875 .variable => |variable| Value.fromInterned(variable.init),
874 const nav_init = switch (ip.indexToKey(nav.status.resolved.val)) {
875 .func => .none,
876 .variable => |variable| variable.init,
876877 .@"extern" => |@"extern"| {
877878 if (ip.isFunctionType(@"extern".ty)) return;
878879 // Extern variable gets a __got entry only
......@@ -883,10 +884,10 @@ pub fn updateNav(
883884 sym.flags.is_extern_ptr = true;
884885 return;
885886 },
886 else => nav_val,
887 else => nav.status.resolved.val,
887888 };
888889
889 if (nav_init.typeOf(zcu).isFnOrHasRuntimeBits(pt)) {
890 if (nav_init != .none and Value.fromInterned(nav_init).typeOf(zcu).hasRuntimeBits(pt)) {
890891 const sym_index = try self.getOrCreateMetadataForNav(macho_file, nav_index);
891892 self.symbols.items[sym_index].getAtom(macho_file).?.freeRelocs(macho_file);
892893
......@@ -900,7 +901,7 @@ pub fn updateNav(
900901 &macho_file.base,
901902 pt,
902903 zcu.navSrcLoc(nav_index),
903 nav_init,
904 Value.fromInterned(nav_init),
904905 &code_buffer,
905906 if (debug_wip_nav) |*wip_nav| .{ .dwarf = wip_nav } else .none,
906907 .{ .parent_atom_index = sym_index },
src/link/Plan9.zig+2-1
......@@ -448,6 +448,7 @@ pub fn updateNav(self: *Plan9, pt: Zcu.PerThread, nav_index: InternPool.Nav.Inde
448448 const nav = ip.getNav(nav_index);
449449 const nav_val = zcu.navValue(nav_index);
450450 const nav_init = switch (ip.indexToKey(nav_val.toIntern())) {
451 .func => return,
451452 .variable => |variable| Value.fromInterned(variable.init),
452453 .@"extern" => {
453454 log.debug("found extern decl: {}", .{nav.name.fmt(ip)});
......@@ -456,7 +457,7 @@ pub fn updateNav(self: *Plan9, pt: Zcu.PerThread, nav_index: InternPool.Nav.Inde
456457 else => nav_val,
457458 };
458459
459 if (nav_init.typeOf(zcu).isFnOrHasRuntimeBits(pt)) {
460 if (nav_init.typeOf(zcu).hasRuntimeBits(pt)) {
460461 const atom_idx = try self.seeNav(pt, nav_index);
461462
462463 var code_buffer = std.ArrayList(u8).init(gpa);
src/link/Wasm/ZigObject.zig+1-1
......@@ -259,7 +259,7 @@ pub fn updateNav(
259259 else => .{ false, .none, nav_val },
260260 };
261261
262 if (nav_init.typeOf(zcu).isFnOrHasRuntimeBits(pt)) {
262 if (nav_init.typeOf(zcu).hasRuntimeBits(pt)) {
263263 const gpa = wasm_file.base.comp.gpa;
264264 const atom_index = try zig_object.getOrCreateAtomForNav(wasm_file, pt, nav_index);
265265 const atom = wasm_file.getAtomPtr(atom_index);
src/print_air.zig+4-6
......@@ -283,6 +283,7 @@ const Writer = struct {
283283
284284 .dbg_var_ptr,
285285 .dbg_var_val,
286 .dbg_arg_inline,
286287 => try w.writeDbgVar(s, inst),
287288
288289 .struct_field_ptr => try w.writeStructField(s, inst),
......@@ -358,10 +359,7 @@ const Writer = struct {
358359 try w.writeType(s, arg.ty.toType());
359360 switch (arg.name) {
360361 .none => {},
361 _ => {
362 const name = w.air.nullTerminatedString(@intFromEnum(arg.name));
363 try s.print(", \"{}\"", .{std.zig.fmtEscapes(name)});
364 },
362 _ => try s.print(", \"{}\"", .{std.zig.fmtEscapes(arg.name.toSlice(w.air))}),
365363 }
366364 }
367365
......@@ -686,8 +684,8 @@ const Writer = struct {
686684 fn writeDbgVar(w: *Writer, s: anytype, inst: Air.Inst.Index) @TypeOf(s).Error!void {
687685 const pl_op = w.air.instructions.items(.data)[@intFromEnum(inst)].pl_op;
688686 try w.writeOperand(s, inst, 0, pl_op.operand);
689 const name = w.air.nullTerminatedString(pl_op.payload);
690 try s.print(", \"{}\"", .{std.zig.fmtEscapes(name)});
687 const name: Air.NullTerminatedString = @enumFromInt(pl_op.payload);
688 try s.print(", \"{}\"", .{std.zig.fmtEscapes(name.toSlice(w.air))});
691689 }
692690
693691 fn writeCall(w: *Writer, s: anytype, inst: Air.Inst.Index) @TypeOf(s).Error!void {
test/src/Debugger.zig+73-13
......@@ -587,7 +587,7 @@ pub fn addTestsForTarget(db: *Debugger, target: Target) void {
587587 },
588588 );
589589 db.addLldbTest(
590 "cross_module_call",
590 "inline_call",
591591 target,
592592 &.{
593593 .{
......@@ -595,8 +595,18 @@ pub fn addTestsForTarget(db: *Debugger, target: Target) void {
595595 .source =
596596 \\const module = @import("module");
597597 \\pub fn main() void {
598 \\ module.foo(123);
599 \\ module.bar(456);
598 \\ fa(12);
599 \\ fb(34);
600 \\ module.fc(56);
601 \\ module.fd(78);
602 \\}
603 \\fn fa(pa: u32) void {
604 \\ const la = ~pa;
605 \\ _ = la;
606 \\}
607 \\inline fn fb(pb: u32) void {
608 \\ const lb = ~pb;
609 \\ _ = lb;
600610 \\}
601611 \\
602612 ,
......@@ -605,34 +615,84 @@ pub fn addTestsForTarget(db: *Debugger, target: Target) void {
605615 .import = "module",
606616 .path = "module.zig",
607617 .source =
608 \\pub fn foo(x: u32) void {
609 \\ _ = x;
618 \\pub fn fc(pc: u32) void {
619 \\ const lc = ~pc;
620 \\ _ = lc;
610621 \\}
611 \\pub inline fn bar(y: u32) void {
612 \\ _ = y;
622 \\pub inline fn fd(pd: u32) void {
623 \\ const ld = ~pd;
624 \\ _ = ld;
613625 \\}
614626 \\
615627 ,
616628 },
617629 },
618 \\breakpoint set --file module.zig --source-pattern-regexp '_ = x;'
630 \\settings set frame-format 'frame #${frame.index}:{ ${module.file.basename}{\`${function.name-with-args}{${frame.no-debug}${function.pc-offset}}}}{ at ${line.file.basename}:${line.number}{:${line.column}}}{${function.is-optimized} [opt]}{${frame.is-artificial} [artificial]}\n'
631 \\
632 \\breakpoint set --file main.zig --source-pattern-regexp '_ = la;'
619633 \\process launch
620 \\source info
634 \\frame variable pa la
635 \\thread backtrace --count 2
621636 \\breakpoint delete --force 1
622637 \\
623 \\breakpoint set --file module.zig --line 5
638 \\breakpoint set --file main.zig --source-pattern-regexp '_ = lb;'
624639 \\process continue
625 \\source info
640 \\frame variable pb lb
641 \\thread backtrace --count 2
626642 \\breakpoint delete --force 2
643 \\
644 \\breakpoint set --file module.zig --source-pattern-regexp '_ = lc;'
645 \\process continue
646 \\frame variable pc lc
647 \\thread backtrace --count 2
648 \\breakpoint delete --force 3
649 \\
650 \\breakpoint set --file module.zig --line 7
651 \\process continue
652 \\frame variable pd ld
653 \\thread backtrace --count 2
654 \\breakpoint delete --force 4
627655 ,
628656 &.{
629 \\/module.zig:2:5
657 \\(lldb) frame variable pa la
658 \\(u32) pa = 12
659 \\(u32) la = 4294967283
660 \\(lldb) thread backtrace --count 2
661 \\* thread #1, name = 'inline_call', stop reason = breakpoint 1.1
662 \\ * frame #0: inline_call`main.fa(pa=12) at main.zig:10:5
663 \\ frame #1: inline_call`main.main at main.zig:3:7
630664 \\(lldb) breakpoint delete --force 1
631665 \\1 breakpoints deleted; 0 breakpoint locations disabled.
632666 ,
633 \\/module.zig:5:5
667 \\(lldb) frame variable pb lb
668 \\(u32) pb = 34
669 \\(u32) lb = 4294967261
670 \\(lldb) thread backtrace --count 2
671 \\* thread #1, name = 'inline_call', stop reason = breakpoint 2.1
672 \\ * frame #0: inline_call`main.main [inlined] fb(pb=34) at main.zig:14:5
673 \\ frame #1: inline_call`main.main at main.zig:4:7
634674 \\(lldb) breakpoint delete --force 2
635675 \\1 breakpoints deleted; 0 breakpoint locations disabled.
676 ,
677 \\(lldb) frame variable pc lc
678 \\(u32) pc = 56
679 \\(u32) lc = 4294967239
680 \\(lldb) thread backtrace --count 2
681 \\* thread #1, name = 'inline_call', stop reason = breakpoint 3.1
682 \\ * frame #0: inline_call`module.fc(pc=56) at module.zig:3:5
683 \\ frame #1: inline_call`main.main at main.zig:5:14
684 \\(lldb) breakpoint delete --force 3
685 \\1 breakpoints deleted; 0 breakpoint locations disabled.
686 ,
687 \\(lldb) frame variable pd ld
688 \\(u32) pd = 78
689 \\(u32) ld = 4294967217
690 \\(lldb) thread backtrace --count 2
691 \\* thread #1, name = 'inline_call', stop reason = breakpoint 4.1
692 \\ * frame #0: inline_call`main.main [inlined] fd(pd=78) at module.zig:7:5
693 \\ frame #1: inline_call`main.main at main.zig:6:14
694 \\(lldb) breakpoint delete --force 4
695 \\1 breakpoints deleted; 0 breakpoint locations disabled.
636696 },
637697 );
638698}