| author |  Dominic <4678790+dweiller@users.noreply.github.com> 2023-12-30 14:37:35+11:00 |
| committer | Dominic <4678790+dweiller@users.noreply.github.com> 2023-12-31 15:36:58+11:00 |
| log | 17485110589c953aa39de75a9fb75ac415e4f9cd |
| tree | ddfd5113567a2a0896e3b80d7b3fdce24345ffd1 |
| parent | 4129996211edd30b25c23454520fd78b2a70394b |
sema: add compile error for OOB by-length slice of array
3 files changed, 64 insertions(+), 0 deletions(-)
src- test
- cases
- compile_errors
src/Sema.zig+24
| ... | @@ -32160,6 +32160,30 @@ fn analyzeSlice( | ... | @@ -32160,6 +32160,30 @@ fn analyzeSlice( |
| 32160 | if (!end_is_len) { | 32160 | if (!end_is_len) { |
| 32161 | const end = if (by_length) end: { | 32161 | const end = if (by_length) end: { |
| 32162 | const len = try sema.coerce(block, Type.usize, uncasted_end_opt, end_src); | 32162 | const len = try sema.coerce(block, Type.usize, uncasted_end_opt, end_src); |
| 32163 | if (try sema.resolveValue(len)) |slice_len_val| { | ||
| 32164 | const len_s_val = try mod.intValue( | ||
| 32165 | Type.usize, | ||
| 32166 | array_ty.arrayLenIncludingSentinel(mod), | ||
| 32167 | ); | ||
| 32168 | if (!(try sema.compareScalar(slice_len_val, .lte, len_s_val, Type.usize))) { | ||
| 32169 | const sentinel_label: []const u8 = if (array_ty.sentinel(mod) != null) | ||
| 32170 | " +1 (sentinel)" | ||
| 32171 | else | ||
| 32172 | ""; | ||
| 32173 | |||
| 32174 | return sema.fail( | ||
| 32175 | block, | ||
| 32176 | end_src, | ||
| 32177 | "length {} out of bounds for array of length {}{s}", | ||
| 32178 | .{ | ||
| 32179 | slice_len_val.fmtValue(Type.usize, mod), | ||
| 32180 | len_val.fmtValue(Type.usize, mod), | ||
| 32181 | sentinel_label, | ||
| 32182 | }, | ||
| 32183 | ); | ||
| 32184 | } | ||
| 32185 | } | ||
| 32186 | // check len is less than array size if comptime known | ||
| 32163 | const uncasted_end = try sema.analyzeArithmetic(block, .add, start, len, src, start_src, end_src, false); | 32187 | const uncasted_end = try sema.analyzeArithmetic(block, .add, start, len, src, start_src, end_src, false); |
| 32164 | break :end try sema.coerce(block, Type.usize, uncasted_end, end_src); | 32188 | break :end try sema.coerce(block, Type.usize, uncasted_end, end_src); |
| 32165 | } else try sema.coerce(block, Type.usize, uncasted_end_opt, end_src); | 32189 | } else try sema.coerce(block, Type.usize, uncasted_end_opt, end_src); |
test/cases/compile_errors/slice_of_array_by-length_oversized.zig created+19
| ... | @@ -0,0 +1,19 @@ | ||
| 1 | export fn entry1() void { | ||
| 2 | var buf: [5]u8 = undefined; | ||
| 3 | var a: u32 = 6; | ||
| 4 | _ = &a; | ||
| 5 | _ = buf[a..][0..10]; | ||
| 6 | } | ||
| 7 | |||
| 8 | export fn entry2() void { | ||
| 9 | var buf: [5]u8 = undefined; | ||
| 10 | const a: u32 = 6; | ||
| 11 | _ = buf[a..][0..10]; | ||
| 12 | } | ||
| 13 | |||
| 14 | // error | ||
| 15 | // backend=stage2 | ||
| 16 | // target=native | ||
| 17 | // | ||
| 18 | // :5:21: error: length 10 out of bounds for array of length 5 | ||
| 19 | // :11:21: error: length 10 out of bounds for array of length 5 | ||
test/cases/safety/array slice by-length oversized.zig created+21
| ... | @@ -0,0 +1,21 @@ | ||
| 1 | const std = @import("std"); | ||
| 2 | |||
| 3 | pub fn panic(message: []const u8, stack_trace: ?*std.builtin.StackTrace, _: ?usize) noreturn { | ||
| 4 | _ = stack_trace; | ||
| 5 | if (std.mem.eql(u8, message, "index out of bounds: index 12, len 5")) { | ||
| 6 | std.process.exit(0); | ||
| 7 | } | ||
| 8 | std.process.exit(1); | ||
| 9 | } | ||
| 10 | |||
| 11 | pub fn main() !void { | ||
| 12 | var buf: [5]u8 = undefined; | ||
| 13 | var a: u32 = 6; | ||
| 14 | _ = &a; | ||
| 15 | _ = buf[a..][0..a]; | ||
| 16 | return error.TestFailed; | ||
| 17 | } | ||
| 18 | |||
| 19 | // run | ||
| 20 | // backend=llvm | ||
| 21 | // target=native | ||