Commit 25d4c5df706bb8ca6e7882f80d6f8209b9ad31f8 | zig

author	ominitay <37453713+ominitay@users.noreply.github.com> 2022-03-28 12:10:36+01:00
committer	GitHub <noreply@github.com> 2022-03-28 14:10:36+03:00
log	25d4c5df706bb8ca6e7882f80d6f8209b9ad31f8
tree	102a1619668a9734115f8dd74c17adc70c8c6d46
parent	460e7a24451c9bf37a8c1e5e6a4554173416b149
signature	Signed by PGP key 4AEE18F83AFDEB23

std.mem.zeroInit: Fix behaviour with empty initialiser

1 files changed, 36 insertions(+), 14 deletions(-)

lib
- std
  - mem.zig

lib/std/mem.zig+36-14

 @@ -432,6 +432,13 @@ pub fn zeroInit(comptime T: type, init: anytype) T {
                 .Struct => |init_info| {
                     var value = std.mem.zeroes(T);
+                    inline for (struct_info.fields) |field| {
+                        if (field.default_value) |default_value_ptr| {
+                            const default_value = @ptrCast(*const field.field_type, default_value_ptr).*;
+                            @field(value, field.name) = default_value;
+                        }
+                    }
                     if (init_info.is_tuple) {
                         inline for (init_info.fields) |field, i| {
                             @field(value, struct_info.fields[i].name) = @field(init, field.name);
 @@ -443,21 +450,14 @@ pub fn zeroInit(comptime T: type, init: anytype) T {
                         if (!@hasField(T, field.name)) {
                             @compileError("Encountered an initializer for `" ++ field.name ++ "`, but it is not a field of " ++ @typeName(T));
                         }
-                    }
-                    inline for (struct_info.fields) |field| {
+                        switch (@typeInfo(field.field_type)) {
-                        if (@hasField(Init, field.name)) {
+                            .Struct => {
-                            switch (@typeInfo(field.field_type)) {
+                                @field(value, field.name) = zeroInit(field.field_type, @field(init, field.name));
-                                .Struct => {
+                            },
-                                    @field(value, field.name) = zeroInit(field.field_type, @field(init, field.name));
+                            else => {
-                                },
+                                @field(value, field.name) = @field(init, field.name);
-                                else => {
+                            },
-                                    @field(value, field.name) = @field(init, field.name);
-                                },
-                            }
-                        } else if (field.default_value) |default_value_ptr| {
-                            const default_value = @ptrCast(*const field.field_type, default_value_ptr).*;
-                            @field(value, field.name) = default_value;
                         }
                     }
 @@ -515,6 +515,28 @@ test "zeroInit" {
         .b = 0,
         .a = 0,
     }, c);
+    const Foo = struct {
+        foo: u8 = 69,
+        bar: u8,
+    };
+    const f = zeroInit(Foo, .{});
+    try testing.expectEqual(Foo{
+        .foo = 69,
+        .bar = 0,
+    }, f);
+    const Bar = struct {
+        foo: u32 = 666,
+        bar: u32 = 420,
+    };
+    const b = zeroInit(Bar, .{69});
+    try testing.expectEqual(Bar{
+        .foo = 69,
+        .bar = 420,
+    }, b);
 }
 /// Compares two slices of numbers lexicographically. O(n).