authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2022-10-27 10:02:12+02:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2022-10-30 10:12:25+01:00
log27bcd4ec79cd9e680c30cf3f8cd2d48f5030da30
treedfc8627792c4fd531c1a98de03cbe83e1f1bed10
parent5339cac2ef69d81913444ae50c7b060e97e80709

macho: do not unnecessarily dupe sym names in resolver

1 files changed, 1 insertions(+), 2 deletions(-)

src/link/MachO/zld.zig+1-2
...@@ -966,10 +966,9 @@ pub const Zld = struct {...@@ -966,10 +966,9 @@ pub const Zld = struct {
966966
967 const global_index = resolver.table.get(sym_name) orelse {967 const global_index = resolver.table.get(sym_name) orelse {
968 const gpa = self.gpa;968 const gpa = self.gpa;
969 const name = try resolver.arena.dupe(u8, sym_name);
970 const global_index = @intCast(u32, self.globals.items.len);969 const global_index = @intCast(u32, self.globals.items.len);
971 try self.globals.append(gpa, sym_loc);970 try self.globals.append(gpa, sym_loc);
972 try resolver.table.putNoClobber(name, global_index);971 try resolver.table.putNoClobber(sym_name, global_index);
973 if (sym.undf() and !sym.tentative()) {972 if (sym.undf() and !sym.tentative()) {
974 try resolver.unresolved.putNoClobber(global_index, {});973 try resolver.unresolved.putNoClobber(global_index, {});
975 }974 }