authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2022-06-01 16:45:28-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2022-06-01 16:45:28-07:00
log288e89b606b46328a5ab358b2eef2c5dc277bc8f
treece898990af2eec71a7d515cc317b7e7b096d76b5
parenta4cdb49a58f62776b73ad873b25243e65ac29266

Sema: fix compiler crash with comptime arithmetic involving `@ptrToInt`


3 files changed, 47 insertions(+), 21 deletions(-)

src/Sema.zig+39-13
......@@ -1540,6 +1540,24 @@ fn resolveMaybeUndefVal(
15401540 }
15411541}
15421542
1543/// Value Tag `variable` results in `null`.
1544/// Value Tag `undef` results in the Value.
1545/// Value Tag `generic_poison` causes `error.GenericPoison` to be returned.
1546/// Value Tag `decl_ref` and `decl_ref_mut` or any nested such value results in `null`.
1547fn resolveMaybeUndefValIntable(
1548 sema: *Sema,
1549 block: *Block,
1550 src: LazySrcLoc,
1551 inst: Air.Inst.Ref,
1552) CompileError!?Value {
1553 const val = (try sema.resolveMaybeUndefValAllowVariables(block, src, inst)) orelse return null;
1554 switch (val.tag()) {
1555 .variable, .decl_ref, .decl_ref_mut => return null,
1556 .generic_poison => return error.GenericPoison,
1557 else => return val,
1558 }
1559}
1560
15431561/// Returns all Value tags including `variable` and `undef`.
15441562fn resolveMaybeUndefValAllowVariables(
15451563 sema: *Sema,
......@@ -9302,19 +9320,27 @@ fn zirBitwise(
93029320 return sema.fail(block, src, "invalid operands to binary bitwise expression: '{s}' and '{s}'", .{ @tagName(lhs_ty.zigTypeTag()), @tagName(rhs_ty.zigTypeTag()) });
93039321 }
93049322
9305 if (try sema.resolveMaybeUndefVal(block, lhs_src, casted_lhs)) |lhs_val| {
9306 if (try sema.resolveMaybeUndefVal(block, rhs_src, casted_rhs)) |rhs_val| {
9307 const result_val = switch (air_tag) {
9308 .bit_and => try lhs_val.bitwiseAnd(rhs_val, resolved_type, sema.arena, target),
9309 .bit_or => try lhs_val.bitwiseOr(rhs_val, resolved_type, sema.arena, target),
9310 .xor => try lhs_val.bitwiseXor(rhs_val, resolved_type, sema.arena, target),
9311 else => unreachable,
9312 };
9313 return sema.addConstant(resolved_type, result_val);
9323 const runtime_src = runtime: {
9324 // TODO: ask the linker what kind of relocations are available, and
9325 // in some cases emit a Value that means "this decl's address AND'd with this operand".
9326 if (try sema.resolveMaybeUndefValIntable(block, lhs_src, casted_lhs)) |lhs_val| {
9327 if (try sema.resolveMaybeUndefValIntable(block, rhs_src, casted_rhs)) |rhs_val| {
9328 const result_val = switch (air_tag) {
9329 .bit_and => try lhs_val.bitwiseAnd(rhs_val, resolved_type, sema.arena, target),
9330 .bit_or => try lhs_val.bitwiseOr(rhs_val, resolved_type, sema.arena, target),
9331 .xor => try lhs_val.bitwiseXor(rhs_val, resolved_type, sema.arena, target),
9332 else => unreachable,
9333 };
9334 return sema.addConstant(resolved_type, result_val);
9335 } else {
9336 break :runtime rhs_src;
9337 }
9338 } else {
9339 break :runtime lhs_src;
93149340 }
9315 }
9341 };
93169342
9317 try sema.requireRuntimeBlock(block, src);
9343 try sema.requireRuntimeBlock(block, runtime_src);
93189344 return block.addBinOp(air_tag, casted_lhs, casted_rhs);
93199345}
93209346
......@@ -10163,8 +10189,8 @@ fn analyzeArithmetic(
1016310189
1016410190 const mod = sema.mod;
1016510191 const target = mod.getTarget();
10166 const maybe_lhs_val = try sema.resolveMaybeUndefVal(block, lhs_src, casted_lhs);
10167 const maybe_rhs_val = try sema.resolveMaybeUndefVal(block, rhs_src, casted_rhs);
10192 const maybe_lhs_val = try sema.resolveMaybeUndefValIntable(block, lhs_src, casted_lhs);
10193 const maybe_rhs_val = try sema.resolveMaybeUndefValIntable(block, rhs_src, casted_rhs);
1016810194 const rs: struct { src: LazySrcLoc, air_tag: Air.Inst.Tag } = rs: {
1016910195 switch (zir_tag) {
1017010196 .add => {
test/behavior/align.zig+4-7
......@@ -502,12 +502,9 @@ test "align(@alignOf(T)) T does not force resolution of T" {
502502
503503test "align(N) on functions" {
504504 if (builtin.zig_backend == .stage1) return error.SkipZigTest;
505
506 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
507 if (builtin.zig_backend == .stage2_llvm) return error.SkipZigTest;
508 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest;
509 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
510 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
505 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
506 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
507 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
511508
512509 // function alignment is a compile error on wasm32/wasm64
513510 if (native_arch == .wasm32 or native_arch == .wasm64) return error.SkipZigTest;
......@@ -531,5 +528,5 @@ test "comptime alloc alignment" {
531528
532529 comptime var bytes2 align(256) = [_]u8{0};
533530 var bytes2_addr = @ptrToInt(&bytes2);
534 try std.testing.expect(bytes2_addr & 0xff == 0);
531 try expect(bytes2_addr & 0xff == 0);
535532}
test/behavior/bugs/1741.zig+4-1
......@@ -2,7 +2,10 @@ const std = @import("std");
22const builtin = @import("builtin");
33
44test "fixed" {
5 if (builtin.zig_backend != .stage1) return error.SkipZigTest;
5 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
6 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
7 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
8
69 const x: f32 align(128) = 12.34;
710 try std.testing.expect(@ptrToInt(&x) % 128 == 0);
811}