Commit 28feeaf77818c801bac4f7959ace39af5bdc40a5 | zig

author	Andrew Kelley <andrew@ziglang.org> 2026-09-14 18:48:12-07:00
committer	Andrew Kelley <andrew@ziglang.org> 2026-09-16 13:12:47-07:00
log	28feeaf77818c801bac4f7959ace39af5bdc40a5
tree	051fdda941e95d2a0a5478412a0cf7f222716fff
parent	7911f377441a1717ac1ab82933af826926b29ff7

link: pass request_handle=true to addInputPath

when passing already open handle, this is now required when the caller
wants the cache system to keep the file handle open.

2 files changed, 10 insertions(+), 5 deletions(-)

lib
- std
  - Build
    Cache.zig
src
- link.zig

lib/std/Build/Cache.zig+2

 @@ -650,8 +650,10 @@ pub const Manifest = struct {
     };
     pub const AddInputPathOptions = struct {
+        /// If provided, will be closed when `check` is called, unless `request_handle` is also set.
         handle: PathHandle = .{ .file = null },
         stat: ?Stat = null,
+        /// If set, file handle will remain open after `check` is called.
         request_handle: bool = false,
         /// Can request file or directory contents depending on `handle`.
         request_contents: bool = false,

src/link.zig+8-5

 @@ -1500,11 +1500,11 @@ pub fn doPrelinkTask(comp: *Compilation, task: PrelinkTask) void {
                 base.loadInput(input) catch |err| switch (err) {
                     error.AlreadyReported => return, // error reported via diags
                     else => |e| switch (input) {
-                        .dso => |dso| diags.addParseError(dso.path, "failed to parse shared library: {s}", .{@errorName(e)}),
+                        .dso => |dso| diags.addParseError(dso.path, "failed to parse shared library: {t}", .{e}),
-                        .object => |obj| diags.addParseError(obj.path, "failed to parse object: {s}", .{@errorName(e)}),
+                        .object => |obj| diags.addParseError(obj.path, "failed to parse object: {t}", .{e}),
-                        .archive => |obj| diags.addParseError(obj.path, "failed to parse archive: {s}", .{@errorName(e)}),
+                        .archive => |obj| diags.addParseError(obj.path, "failed to parse archive: {t}", .{e}),
-                        .res => |res| diags.addParseError(res.path, "failed to parse Windows resource: {s}", .{@errorName(e)}),
+                        .res => |res| diags.addParseError(res.path, "failed to parse Windows resource: {t}", .{e}),
-                        .dso_exact => diags.addError("failed to handle dso_exact: {s}", .{@errorName(e)}),
+                        .dso_exact => diags.addError("failed to handle dso_exact: {t}", .{e}),
                     },
                 };
                 prog_node.completeOne();
 @@ -1927,6 +1927,7 @@ pub fn hashInputs(man: *Cache.Manifest, link_inputs: []const Input) !void {
             .object, .archive => |obj| {
                 _ = try man.addInputPath(obj.path, .{
                     .handle = .{ .file = obj.file },
+                    .request_handle = true,
                 });
                 man.hash.add(obj.must_link);
                 man.hash.add(obj.hidden);
 @@ -1934,11 +1935,13 @@ pub fn hashInputs(man: *Cache.Manifest, link_inputs: []const Input) !void {
             .res => |res| {
                 _ = try man.addInputPath(res.path, .{
                     .handle = .{ .file = res.file },
+                    .request_handle = true,
                 });
             },
             .dso => |dso| {
                 _ = try man.addInputPath(dso.path, .{
                     .handle = .{ .file = dso.file },
+                    .request_handle = true,
                 });
                 man.hash.add(dso.needed);
                 man.hash.add(dso.weak);