authorgravatar for twostepted@gmail.comTravis Staloch <twostepted@gmail.com> 2025-07-14 16:35:23-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2025-07-15 08:49:54+02:00
log294db62d926ef82f2beb86e7e5ddf8d69092864a
tree3d47be43b54702dbee00bb90ff247f027748b8a2
parent4f5fa959aa80ce39828b8bf45098029ce818fda2

memory safety fix for Io.Writer.Allocating.toOwnedSlice*()

don't forget to save the list. this allows a `testing.checkAllAllocationFailures()` test to pass in one of my projects which newly failed since #24329 was merged.

1 files changed, 2 insertions(+), 0 deletions(-)

lib/std/Io/Writer.zig+2
...@@ -2446,12 +2446,14 @@ pub const Allocating = struct {...@@ -2446,12 +2446,14 @@ pub const Allocating = struct {
24462446
2447 pub fn toOwnedSlice(a: *Allocating) error{OutOfMemory}![]u8 {2447 pub fn toOwnedSlice(a: *Allocating) error{OutOfMemory}![]u8 {
2448 var list = a.toArrayList();2448 var list = a.toArrayList();
2449 defer a.setArrayList(list);
2449 return list.toOwnedSlice(a.allocator);2450 return list.toOwnedSlice(a.allocator);
2450 }2451 }
24512452
2452 pub fn toOwnedSliceSentinel(a: *Allocating, comptime sentinel: u8) error{OutOfMemory}![:sentinel]u8 {2453 pub fn toOwnedSliceSentinel(a: *Allocating, comptime sentinel: u8) error{OutOfMemory}![:sentinel]u8 {
2453 const gpa = a.allocator;2454 const gpa = a.allocator;
2454 var list = toArrayList(a);2455 var list = toArrayList(a);
2456 defer a.setArrayList(list);
2455 return list.toOwnedSliceSentinel(gpa, sentinel);2457 return list.toOwnedSliceSentinel(gpa, sentinel);
2456 }2458 }
24572459