Commit 32c89531b1475ce8e3b8efdf7a07745da7bc854a | zig

author	Andrew Kelley <andrew@ziglang.org> 2019-10-24 16:23:33-04:00
committer	Andrew Kelley <andrew@ziglang.org> 2019-10-24 16:23:33-04:00
log	32c89531b1475ce8e3b8efdf7a07745da7bc854a
tree	848ea8ac81eabbe6293eacdfc16210b1d6973a99
parent	345042ecbc7fb645fd17b69df4e57ffefa5be5a5
signature	Commit is signed but in an unrecognized format.

in array literals.

Fixes #3524

2 files changed, 17 insertions(+), 1 deletions(-)

src/ir.cpp+4-1

 @@ -17590,7 +17590,10 @@ static IrInstruction *ir_analyze_instruction_elem_ptr(IrAnalyze *ira, IrInstruct
                             false);
                     array_ptr_val->data.x_struct.fields[slice_ptr_index].data.x_ptr.mut = ConstPtrMutInfer;
                 } else {
-                    zig_unreachable();
+                    ir_add_error(ira, elem_ptr_instruction->init_array_type,
+                        buf_sprintf("expected array type or [_], found '%s'",
+                            buf_ptr(&array_type->name)));
+                    return ira->codegen->invalid_instruction;
                 }
             }

test/compile_errors.zig+13

...	@@ -2,6 +2,19 @@ const tests = @import("tests.zig");	...	@@ -2,6 +2,19 @@ const tests = @import("tests.zig");
2	const builtin = @import("builtin");	2	const builtin = @import("builtin");
3		3
4	pub fn addCases(cases: *tests.CompileErrorContext) void {	4	pub fn addCases(cases: *tests.CompileErrorContext) void {
		5	cases.add(
		6	"using an unknown len ptr type instead of array",
		7	\\const resolutions = [][]const u8{
		8	\\ c"[320 240 ]",
		9	\\ null,
		10	\\};
		11	\\comptime {
		12	\\ _ = resolutions;
		13	\\}
		14	,
		15	"tmp.zig:1:21: error: expected array type or [_], found '[][]const u8'",
		16	);
		17
5	cases.add(	18	cases.add(
6	"comparison with error union and error value",	19	"comparison with error union and error value",
7	\\export fn entry() void {	20	\\export fn entry() void {