authorgravatar for alex@alexrp.comAlex Rønne Petersen <alex@alexrp.com> 2025-05-06 01:52:47+02:00
committergravatar for alex@alexrp.comAlex Rønne Petersen <alex@alexrp.com> 2025-05-06 01:52:47+02:00
log35f30558ad2836b83859d8ba64a593a0603d4e0e
treedf204d0928ab8378e295a46acf5de3a1fb51c2e9
parenta14352b0b24b295e1857f306de5877680dd80d2b
signaturebadge-check Signed by SSH key SHA256:7B/LJ7bpR1eX8aCXSr4mtd5M45VMPKcx9zY8e95b5QM

std.Build: Rename --glibc-runtimes to --libc-runtimes and enable it for musl.


4 files changed, 45 insertions(+), 30 deletions(-)

lib/compiler/build_runner.zig+7-5
......@@ -241,8 +241,9 @@ pub fn main() !void {
241241 // but it is handled by the parent process. The build runner
242242 // only sees this flag.
243243 graph.system_package_mode = true;
244 } else if (mem.eql(u8, arg, "--glibc-runtimes")) {
245 builder.glibc_runtimes_dir = nextArgOrFatal(args, &arg_idx);
244 } else if (mem.eql(u8, arg, "--libc-runtimes") or mem.eql(u8, arg, "--glibc-runtimes")) {
245 // --glibc-runtimes was the old name of the flag; kept for compatibility for now.
246 builder.libc_runtimes_dir = nextArgOrFatal(args, &arg_idx);
246247 } else if (mem.eql(u8, arg, "--verbose-link")) {
247248 builder.verbose_link = true;
248249 } else if (mem.eql(u8, arg, "--verbose-air")) {
......@@ -1279,9 +1280,10 @@ fn usage(b: *std.Build, out_stream: anytype) !void {
12791280 \\ -fqemu, -fno-qemu Integration with system-installed QEMU to execute
12801281 \\ foreign-architecture programs on Linux hosts
12811282 \\ (default: no)
1282 \\ --glibc-runtimes [path] Enhances QEMU integration by providing glibc built
1283 \\ for multiple foreign architectures, allowing
1284 \\ execution of non-native programs that link with glibc.
1283 \\ --libc-runtimes [path] Enhances QEMU integration by providing dynamic libc
1284 \\ (e.g. glibc or musl) built for multiple foreign
1285 \\ architectures, allowing execution of non-native
1286 \\ programs that link with libc.
12851287 \\ -frosetta, -fno-rosetta Rely on Rosetta to execute x86_64 programs on
12861288 \\ ARM64 macOS hosts. (default: no)
12871289 \\ -fwasmtime, -fno-wasmtime Integration with system-installed wasmtime to
lib/std/Build.zig+3-2
......@@ -79,7 +79,8 @@ enable_wine: bool = false,
7979/// this will be the directory $glibc-build-dir/install/glibcs
8080/// Given the example of the aarch64 target, this is the directory
8181/// that contains the path `aarch64-linux-gnu/lib/ld-linux-aarch64.so.1`.
82glibc_runtimes_dir: ?[]const u8 = null,
82/// Also works for dynamic musl.
83libc_runtimes_dir: ?[]const u8 = null,
8384
8485dep_prefix: []const u8 = "",
8586
......@@ -390,7 +391,7 @@ fn createChildOnly(
390391 .enable_rosetta = parent.enable_rosetta,
391392 .enable_wasmtime = parent.enable_wasmtime,
392393 .enable_wine = parent.enable_wine,
393 .glibc_runtimes_dir = parent.glibc_runtimes_dir,
394 .libc_runtimes_dir = parent.libc_runtimes_dir,
394395 .dep_prefix = parent.fmt("{s}{s}.", .{ parent.dep_prefix, dep_name }),
395396 .modules = .init(allocator),
396397 .named_writefiles = .init(allocator),
lib/std/Build/Step/Run.zig+21-23
......@@ -1026,11 +1026,11 @@ fn runCommand(
10261026 }
10271027
10281028 const root_target = exe.rootModuleTarget();
1029 const need_cross_glibc = root_target.isGnuLibC() and
1030 exe.is_linking_libc;
1029 const need_cross_libc = exe.is_linking_libc and
1030 (root_target.isGnuLibC() or (root_target.isMuslLibC() and exe.linkage == .dynamic));
10311031 const other_target = exe.root_module.resolved_target.?.result;
10321032 switch (std.zig.system.getExternalExecutor(b.graph.host.result, &other_target, .{
1033 .qemu_fixes_dl = need_cross_glibc and b.glibc_runtimes_dir != null,
1033 .qemu_fixes_dl = need_cross_libc and b.libc_runtimes_dir != null,
10341034 .link_libc = exe.is_linking_libc,
10351035 })) {
10361036 .native, .rosetta => {
......@@ -1047,31 +1047,29 @@ fn runCommand(
10471047 },
10481048 .qemu => |bin_name| {
10491049 if (b.enable_qemu) {
1050 const glibc_dir_arg = if (need_cross_glibc)
1051 b.glibc_runtimes_dir orelse
1052 return failForeign(run, "--glibc-runtimes", argv[0], exe)
1053 else
1054 null;
1055
10561050 try interp_argv.append(bin_name);
10571051
1058 if (glibc_dir_arg) |dir| {
1059 try interp_argv.append("-L");
1060 try interp_argv.append(b.pathJoin(&.{
1061 dir,
1062 try std.zig.target.glibcRuntimeTriple(
1063 b.allocator,
1064 root_target.cpu.arch,
1065 root_target.os.tag,
1066 root_target.abi,
1067 ),
1068 }));
1052 if (need_cross_libc) {
1053 if (b.libc_runtimes_dir) |dir| {
1054 try interp_argv.append("-L");
1055 try interp_argv.append(b.pathJoin(&.{
1056 dir,
1057 try if (root_target.isGnuLibC()) std.zig.target.glibcRuntimeTriple(
1058 b.allocator,
1059 root_target.cpu.arch,
1060 root_target.os.tag,
1061 root_target.abi,
1062 ) else if (root_target.isMuslLibC()) std.zig.target.muslRuntimeTriple(
1063 b.allocator,
1064 root_target.cpu.arch,
1065 root_target.abi,
1066 ) else unreachable,
1067 }));
1068 } else return failForeign(run, "--libc-runtimes", argv[0], exe);
10691069 }
10701070
10711071 try interp_argv.appendSlice(argv);
1072 } else {
1073 return failForeign(run, "-fqemu", argv[0], exe);
1074 }
1072 } else return failForeign(run, "-fqemu", argv[0], exe);
10751073 },
10761074 .darling => |bin_name| {
10771075 if (b.enable_darling) {
lib/std/zig/target.zig+14
......@@ -131,6 +131,20 @@ pub fn glibcRuntimeTriple(
131131 };
132132}
133133
134/// Returns the subdirectory triple to be used to find the correct musl for the given `arch` and
135/// `abi` in an installation directory.
136///
137/// `abi` must be a musl ABI, i.e. `.isMusl()`.
138pub fn muslRuntimeTriple(
139 allocator: Allocator,
140 arch: std.Target.Cpu.Arch,
141 abi: std.Target.Abi,
142) Allocator.Error![]const u8 {
143 assert(abi.isMusl());
144
145 return std.Target.linuxTripleSimple(allocator, arch, .linux, abi);
146}
147
134148pub fn osArchName(target: std.Target) [:0]const u8 {
135149 return switch (target.os.tag) {
136150 .linux => switch (target.cpu.arch) {