authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2020-09-08 01:30:56-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2020-09-09 09:28:05-07:00
log35f334ae0fe0f7eef7f8610103e860527df37f42
tree42e6fad6a505d605205af7d1cf83eed107184ead
parent4056bb92e6d6ca3d2ab8f49b4ac83c01fb25bd11

organize some TODO comments

2 files changed, 3 insertions(+), 7 deletions(-)

src-self-hosted/Module.zig+2
......@@ -1048,6 +1048,8 @@ pub fn init(gpa: *Allocator, options: InitOptions) !Module {
10481048
10491049 // We put everything into the cache hash except for the root source file, because we want to
10501050 // find the same binary and incrementally update it even if the file contents changed.
1051 // TODO Look into storing this information in memory rather than on disk and solving
1052 // serialization/deserialization of *all* incremental compilation state in a more generic way.
10511053 const cache_dir = if (options.root_pkg) |root_pkg| root_pkg.root_src_dir else std.fs.cwd();
10521054 var cache = try std.cache_hash.CacheHash.init(gpa, cache_dir, "zig-cache");
10531055 errdefer cache.release();
src-self-hosted/main.zig+1-7
......@@ -960,13 +960,7 @@ pub fn buildOutputType(
960960 .yes_default_path => try std.fmt.allocPrint(arena, "{}.h", .{root_name}),
961961 };
962962
963 // TODO Remove this, we'll have this error emitted lazily only if the features would end
964 // up actually getting used.
965 //if (!build_options.have_llvm) {
966 // if ((use_llvm orelse false) or (use_lld orelse false) or (use_clang orelse false))
967 // fatal("-fLLVM, -fLLD, and -fClang unavailable: compiler not built with LLVM extensions enabled", .{});
968 //}
969
963 // TODO look into implementing compiler_id at build time so we don't have to compute it at runtime.
970964 const compiler_id = try introspect.resolveCompilerId(gpa);
971965
972966 var module = Module.init(gpa, .{