authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2026-01-30 08:16:39+01:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2026-01-30 08:16:39+01:00
log380ea6fb5eea659200d496540efea1fa4e39dcaf
treee3ed4a881b0871d675c6a531d7f4d1feba107205
parent377bb8f23744001562cda4e15ab1f041bc3c6686
parented93f0d70f5b3f954a4f52e37cab80383ca61413

Merge pull request 'Compilation: make libzigc share zcu if possible' (#31037) from GasInfinity/zig:libc-share-zcu into master

Reviewed-on: https://codeberg.org/ziglang/zig/pulls/31037

4 files changed, 69 insertions(+), 16 deletions(-)

lib/c/common.zig+4-8
......@@ -1,18 +1,14 @@
11const builtin = @import("builtin");
22const std = @import("std");
33
4pub const linkage: std.builtin.GlobalLinkage = if (builtin.is_test)
5 .internal
6else
7 .strong;
4/// It is incorrect to make this conditional on `builtin.is_test`, because it is possible that
5/// libzigc is being linked into a different test compilation, as opposed to being tested itself.
6pub const linkage: std.builtin.GlobalLinkage = .strong;
87
98/// Determines the symbol's visibility to other objects.
109/// For WebAssembly this allows the symbol to be resolved to other modules, but will not
1110/// export it to the host runtime.
12pub const visibility: std.builtin.SymbolVisibility = if (linkage != .internal)
13 .hidden
14else
15 .default;
11pub const visibility: std.builtin.SymbolVisibility = .hidden;
1612
1713/// Given a low-level syscall return value, sets errno and returns `-1`, or on
1814/// success returns the result.
src/Compilation.zig+58-7
......@@ -80,6 +80,7 @@ sysroot: ?[]const u8,
8080root_name: [:0]const u8,
8181compiler_rt_strat: RtStrat,
8282ubsan_rt_strat: RtStrat,
83zigc_strat: RtStrat,
8384/// Resolved into known paths, any GNU ld scripts already resolved.
8485link_inputs: []const link.Input,
8586/// Needed only for passing -F args to clang.
......@@ -2101,6 +2102,47 @@ pub fn create(gpa: Allocator, arena: Allocator, io: Io, diag: *CreateDiagnostic,
21012102 try options.root_mod.deps.putNoClobber(arena, "ubsan_rt", ubsan_rt_mod);
21022103 }
21032104
2105 // Like with ubsan_rt we want to go through the `_ = @import("zigc")`
2106 // approach if possible since it uses even more of the standard library
2107 // and can thus reduce further unnecesary bloat.
2108 const zigc_strat: RtStrat = s: {
2109 if (options.skip_linker_dependencies) break :s .none;
2110 if (target.ofmt == .c) break :s .none;
2111 if (!link_libc or !is_exe_or_dyn_lib) break :s .none;
2112 if (!target_util.wantsZigC(target, options.config.link_mode)) break :s .none;
2113 if (have_zcu) break :s .zcu;
2114 break :s .lib;
2115 };
2116
2117 if (zigc_strat == .zcu) {
2118 const zigc_mod = Package.Module.create(arena, .{
2119 .paths = .{
2120 .root = .zig_lib_root,
2121 .root_src_path = "c.zig",
2122 },
2123 .fully_qualified_name = "zigc",
2124 .cc_argv = &.{},
2125 .inherited = .{},
2126 .global = options.config,
2127 .parent = options.root_mod,
2128 }) catch |err| switch (err) {
2129 error.OutOfMemory => |e| return e,
2130 // None of these are possible because the configuration matches the root module
2131 // which already passed these checks.
2132 error.ValgrindUnsupportedOnTarget => unreachable,
2133 error.TargetRequiresSingleThreaded => unreachable,
2134 error.BackendRequiresSingleThreaded => unreachable,
2135 error.TargetRequiresPic => unreachable,
2136 error.PieRequiresPic => unreachable,
2137 error.DynamicLinkingRequiresPic => unreachable,
2138 error.TargetHasNoRedZone => unreachable,
2139 error.StackCheckUnsupportedByTarget => unreachable,
2140 error.StackProtectorUnsupportedByTarget => unreachable,
2141 error.StackProtectorUnavailableWithoutLibC => unreachable,
2142 };
2143 try options.root_mod.deps.putNoClobber(arena, "zigc", zigc_mod);
2144 }
2145
21042146 if (options.verbose_llvm_cpu_features) {
21052147 if (options.root_mod.resolved_target.llvm_cpu_features) |cf| {
21062148 const stderr = try io.lockStderr(&.{}, null);
......@@ -2296,6 +2338,7 @@ pub fn create(gpa: Allocator, arena: Allocator, io: Io, diag: *CreateDiagnostic,
22962338 .libc_installation = libc_dirs.libc_installation,
22972339 .compiler_rt_strat = compiler_rt_strat,
22982340 .ubsan_rt_strat = ubsan_rt_strat,
2341 .zigc_strat = zigc_strat,
22992342 .link_inputs = options.link_inputs,
23002343 .framework_dirs = options.framework_dirs,
23012344 .llvm_opt_bisect_limit = options.llvm_opt_bisect_limit,
......@@ -2651,13 +2694,6 @@ pub fn create(gpa: Allocator, arena: Allocator, io: Io, diag: *CreateDiagnostic,
26512694 } else {
26522695 return diag.fail(.cross_libc_unavailable);
26532696 }
2654
2655 if ((target.isMuslLibC() and comp.config.link_mode == .static) or
2656 target.isWasiLibC() or
2657 target.isMinGW())
2658 {
2659 comp.queued_jobs.zigc_lib = true;
2660 }
26612697 }
26622698
26632699 // Generate Windows import libs.
......@@ -2711,6 +2747,15 @@ pub fn create(gpa: Allocator, arena: Allocator, io: Io, diag: *CreateDiagnostic,
27112747 .dyn_lib => unreachable, // hack for compiler_rt only
27122748 }
27132749
2750 switch (comp.zigc_strat) {
2751 .none, .zcu => {},
2752 .lib => {
2753 log.debug("queuing a job to build libzigc", .{});
2754 comp.queued_jobs.zigc_lib = true;
2755 },
2756 .obj, .dyn_lib => unreachable, // only available as a static library or inside an existing ZCU
2757 }
2758
27142759 if (is_exe_or_dyn_lib and comp.config.any_fuzz) {
27152760 log.debug("queuing a job to build libfuzzer", .{});
27162761 comp.queued_jobs.fuzzer_lib = true;
......@@ -3100,6 +3145,11 @@ pub fn update(comp: *Compilation, main_progress_node: std.Progress.Node) UpdateE
31003145 zcu.analysis_roots_buffer[zcu.analysis_roots_len] = ubsan_rt_mod;
31013146 zcu.analysis_roots_len += 1;
31023147 }
3148
3149 if (zcu.root_mod.deps.get("zigc")) |zigc_mod| {
3150 zcu.analysis_roots_buffer[zcu.analysis_roots_len] = zigc_mod;
3151 zcu.analysis_roots_len += 1;
3152 }
31033153 }
31043154
31053155 // The linker progress node is set up here instead of in `performAllTheWork`, because
......@@ -3531,6 +3581,7 @@ fn addNonIncrementalStuffToCacheManifest(
35313581 man.hash.add(comp.skip_linker_dependencies);
35323582 man.hash.add(comp.compiler_rt_strat);
35333583 man.hash.add(comp.ubsan_rt_strat);
3584 man.hash.add(comp.zigc_strat);
35343585 man.hash.add(comp.rc_includes);
35353586 man.hash.addListOfBytes(comp.force_undefined_symbols.keys());
35363587 man.hash.addListOfBytes(comp.framework_dirs);
src/Zcu.zig+1-1
......@@ -269,7 +269,7 @@ nav_val_analysis_queued: std.AutoArrayHashMapUnmanaged(InternPool.Nav.Index, voi
269269
270270/// These are the modules which we initially queue for analysis in `Compilation.update`.
271271/// `resolveReferences` will use these as the root of its reachability traversal.
272analysis_roots_buffer: [4]*Package.Module,
272analysis_roots_buffer: [5]*Package.Module,
273273analysis_roots_len: usize = 0,
274274/// This is the cached result of `Zcu.resolveReferences`. It is computed on-demand, and
275275/// reset to `null` when any semantic analysis occurs (since this invalidates the data).
src/target.zig+6
......@@ -423,6 +423,12 @@ pub fn canBuildLibUbsanRt(target: *const std.Target) enum { no, yes, llvm_only,
423423 };
424424}
425425
426/// Whether libzigc can fill-in the gaps of an existing libc
427/// or *is* the libc of the target.
428pub fn wantsZigC(target: *const std.Target, link_mode: std.builtin.LinkMode) bool {
429 return (target.isMuslLibC() and link_mode == .static) or target.isWasiLibC() or target.isMinGW();
430}
431
426432pub fn hasRedZone(target: *const std.Target) bool {
427433 return switch (target.cpu.arch) {
428434 .aarch64,