authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2024-05-23 18:45:04-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2024-05-27 20:56:48-07:00
log3a768bd6ce9e891ad258b32fb2dd0ed912ef9e9b
tree522b5e592a3a6fa35f5dade357c578334f0b02e4
parentdf46f5af690889508ebcb07b46c8579acaad06a2

std.Progress: save a copy of IPC data

so that the previous message can be used when the pipe is empty. prevents flickering

1 files changed, 80 insertions(+), 10 deletions(-)

lib/std/Progress.zig+80-10
......@@ -472,6 +472,7 @@ const Serialized = struct {
472472
473473fn serialize() Serialized {
474474 var serialized_len: usize = 0;
475 var any_ipc = false;
475476
476477 // Iterate all of the nodes and construct a serializable copy of the state that can be examined
477478 // without atomics.
......@@ -486,6 +487,8 @@ fn serialize() Serialized {
486487 dest_storage.completed_count = @atomicLoad(u32, &storage_ptr.completed_count, .monotonic);
487488 dest_storage.estimated_total_count = @atomicLoad(u32, &storage_ptr.estimated_total_count, .monotonic);
488489
490 any_ipc = any_ipc or dest_storage.getIpcFd() != null;
491
489492 const end_parent = @atomicLoad(Node.Parent, parent_ptr, .seq_cst);
490493 if (begin_parent == end_parent) {
491494 serialized_node_parents_buffer[serialized_len] = begin_parent;
......@@ -508,6 +511,32 @@ fn serialize() Serialized {
508511 }
509512
510513 // Find nodes which correspond to child processes.
514 if (any_ipc)
515 serialized_len = serializeIpc(serialized_len);
516
517 return .{
518 .parents = serialized_node_parents_buffer[0..serialized_len],
519 .storage = serialized_node_storage_buffer[0..serialized_len],
520 };
521}
522
523var parents_copy: [default_node_storage_buffer_len]Node.Parent = undefined;
524var storage_copy: [default_node_storage_buffer_len]Node.Storage = undefined;
525
526const SavedMetadata = extern struct {
527 start_index: u16,
528 nodes_len: u16,
529 main_index: u16,
530 flags: Flags,
531
532 const Flags = enum(u16) {
533 saved = std.math.maxInt(u16),
534 _,
535 };
536};
537
538fn serializeIpc(start_serialized_len: usize) usize {
539 var serialized_len = start_serialized_len;
511540 var pipe_buf: [4096]u8 align(4) = undefined;
512541
513542 for (
......@@ -532,24 +561,23 @@ fn serialize() Serialized {
532561 // Ignore all but the last message on the pipe.
533562 var input: []align(2) u8 = pipe_buf[0..bytes_read];
534563 if (input.len == 0) {
535 main_storage.completed_count = 0;
536 main_storage.estimated_total_count = 0;
564 serialized_len = useSavedIpcData(serialized_len, main_storage, main_index);
537565 continue;
538566 }
539567
540568 const storage, const parents = while (true) {
541569 if (input.len < 4) {
542570 std.log.warn("short read: {d} out of 4 header bytes", .{input.len});
543 main_storage.completed_count = 0;
544 main_storage.estimated_total_count = 0;
571 // TODO keep track of the short read to trash odd bytes with the next read
572 serialized_len = useSavedIpcData(serialized_len, main_storage, main_index);
545573 continue;
546574 }
547575 const subtree_len = std.mem.readInt(u32, input[0..4], .little);
548576 const expected_bytes = 4 + subtree_len * (@sizeOf(Node.Storage) + @sizeOf(Node.Parent));
549577 if (input.len < expected_bytes) {
550578 std.log.warn("short read: {d} out of {d} ({d} nodes)", .{ input.len, expected_bytes, subtree_len });
551 main_storage.completed_count = 0;
552 main_storage.estimated_total_count = 0;
579 // TODO keep track of the short read to trash odd bytes with the next read
580 serialized_len = useSavedIpcData(serialized_len, main_storage, main_index);
553581 continue;
554582 }
555583 if (input.len > expected_bytes) {
......@@ -564,6 +592,14 @@ fn serialize() Serialized {
564592 };
565593 };
566594
595 // Remember in case the pipe is empty on next update.
596 @as(*SavedMetadata, @ptrCast(&main_storage.name)).* = .{
597 .start_index = @intCast(serialized_len),
598 .nodes_len = @intCast(parents.len),
599 .main_index = @intCast(main_index),
600 .flags = .saved,
601 };
602
567603 // Mount the root here.
568604 main_storage.* = storage[0];
569605
......@@ -580,6 +616,7 @@ fn serialize() Serialized {
580616 // Root node is being mounted here.
581617 @as(Node.Parent, @enumFromInt(0)) => @enumFromInt(main_index),
582618 // Other nodes mounted at the end.
619 // TODO check for bad data pointing outside the expected range
583620 _ => |off| @enumFromInt(serialized_len + @intFromEnum(off) - 1),
584621 };
585622 }
......@@ -587,10 +624,43 @@ fn serialize() Serialized {
587624 serialized_len += storage.len - 1;
588625 }
589626
590 return .{
591 .parents = serialized_node_parents_buffer[0..serialized_len],
592 .storage = serialized_node_storage_buffer[0..serialized_len],
593 };
627 // Save a copy in case any pipes are empty on the next update.
628 @memcpy(parents_copy[0..serialized_len], serialized_node_parents_buffer[0..serialized_len]);
629 @memcpy(storage_copy[0..serialized_len], serialized_node_storage_buffer[0..serialized_len]);
630
631 return serialized_len;
632}
633
634fn useSavedIpcData(start_serialized_len: usize, main_storage: *Node.Storage, main_index: usize) usize {
635 const saved_metadata: *SavedMetadata = @ptrCast(&main_storage.name);
636 if (saved_metadata.flags != .saved) {
637 main_storage.completed_count = 0;
638 main_storage.estimated_total_count = 0;
639 return start_serialized_len;
640 }
641
642 const start_index = saved_metadata.start_index;
643 const nodes_len = saved_metadata.nodes_len;
644 const old_main_index = saved_metadata.main_index;
645
646 const parents = parents_copy[start_index..][0 .. nodes_len - 1];
647 const storage = storage_copy[start_index..][0 .. nodes_len - 1];
648
649 main_storage.* = storage_copy[old_main_index];
650
651 @memcpy(serialized_node_storage_buffer[start_serialized_len..][0..storage.len], storage);
652
653 for (serialized_node_parents_buffer[start_serialized_len..][0..parents.len], parents) |*dest, p| {
654 dest.* = switch (p) {
655 .none, .unused => .none,
656 _ => |prev| @enumFromInt(if (@intFromEnum(prev) == old_main_index)
657 main_index
658 else
659 @intFromEnum(prev) - start_index + start_serialized_len),
660 };
661 }
662
663 return start_serialized_len + storage.len;
594664}
595665
596666fn computeRedraw() []u8 {