authorgravatar for joachim.schmidt557@outlook.comJoachim Schmidt <joachim.schmidt557@outlook.com> 2022-03-17 09:40:41+01:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2022-03-17 09:40:41+01:00
log3c3826bf93f7cbd88ecc30b43afac12cde313ffa
tree617ffc8f30d7750aad90ddbafcf2e33580a2a02d
parent87779cfd93fdcb525f386d693a099e4188a3fc44
parentdcc1de12b097db4971b85cfc0b4e18fec2c8b2c4
signaturebadge-question-mark Signed by PGP key 4AEE18F83AFDEB23

Merge pull request #11192 from joachimschmidt557/stage2-arm

stage2 ARM: misc improvements

23 files changed, 189 insertions(+), 143 deletions(-)

src/arch/arm/CodeGen.zig+180-102
......@@ -530,13 +530,13 @@ fn genBody(self: *Self, body: []const Air.Inst.Index) InnerError!void {
530530 switch (air_tags[inst]) {
531531 // zig fmt: off
532532 .add, .ptr_add => try self.airBinOp(inst),
533 .addwrap => try self.airAddWrap(inst),
533 .addwrap => try self.airBinOp(inst),
534534 .add_sat => try self.airAddSat(inst),
535535 .sub, .ptr_sub => try self.airBinOp(inst),
536 .subwrap => try self.airSubWrap(inst),
536 .subwrap => try self.airBinOp(inst),
537537 .sub_sat => try self.airSubSat(inst),
538538 .mul => try self.airBinOp(inst),
539 .mulwrap => try self.airMulWrap(inst),
539 .mulwrap => try self.airBinOp(inst),
540540 .mul_sat => try self.airMulSat(inst),
541541 .rem => try self.airRem(inst),
542542 .mod => try self.airMod(inst),
......@@ -939,63 +939,85 @@ fn airIntCast(self: *Self, inst: Air.Inst.Index) !void {
939939 // return self.finishAir(inst, result, .{ ty_op.operand, .none, .none });
940940}
941941
942fn airTrunc(self: *Self, inst: Air.Inst.Index) !void {
943 const ty_op = self.air.instructions.items(.data)[inst].ty_op;
944 if (self.liveness.isUnused(inst))
945 return self.finishAir(inst, .dead, .{ ty_op.operand, .none, .none });
942fn truncRegister(
943 self: *Self,
944 operand_reg: Register,
945 dest_reg: Register,
946 int_signedness: std.builtin.Signedness,
947 int_bits: u16,
948) !void {
949 // TODO check if sxtb/uxtb/sxth/uxth are more efficient
950 _ = try self.addInst(.{
951 .tag = switch (int_signedness) {
952 .signed => .sbfx,
953 .unsigned => .ubfx,
954 },
955 .data = .{ .rr_lsb_width = .{
956 .rd = dest_reg,
957 .rn = operand_reg,
958 .lsb = 0,
959 .width = @intCast(u6, int_bits),
960 } },
961 });
962}
946963
947 const operand_ty = self.air.typeOf(ty_op.operand);
948 const operand = try self.resolveInst(ty_op.operand);
964fn trunc(
965 self: *Self,
966 maybe_inst: ?Air.Inst.Index,
967 operand: MCValue,
968 operand_ty: Type,
969 dest_ty: Type,
970) !MCValue {
949971 const info_a = operand_ty.intInfo(self.target.*);
950 const info_b = self.air.typeOfIndex(inst).intInfo(self.target.*);
951
952 const result: MCValue = blk: {
953 if (info_b.bits <= 32) {
954 const operand_reg = switch (operand) {
955 .register => |r| r,
956 else => operand_reg: {
957 if (info_a.bits <= 32) {
958 break :operand_reg try self.copyToTmpRegister(operand_ty, operand);
959 } else {
960 return self.fail("TODO load least significant word into register", .{});
961 }
962 },
963 };
964 self.register_manager.freezeRegs(&.{operand_reg});
965 defer self.register_manager.unfreezeRegs(&.{operand_reg});
966
967 const dest_reg = dest_reg: {
968 if (operand == .register and self.reuseOperand(inst, ty_op.operand, 0, operand)) {
969 break :dest_reg operand_reg;
972 const info_b = dest_ty.intInfo(self.target.*);
973
974 if (info_b.bits <= 32) {
975 const operand_reg = switch (operand) {
976 .register => |r| r,
977 else => operand_reg: {
978 if (info_a.bits <= 32) {
979 break :operand_reg try self.copyToTmpRegister(operand_ty, operand);
980 } else {
981 return self.fail("TODO load least significant word into register", .{});
970982 }
983 },
984 };
985 self.register_manager.freezeRegs(&.{operand_reg});
986 defer self.register_manager.unfreezeRegs(&.{operand_reg});
971987
972 break :dest_reg try self.register_manager.allocReg(null);
973 };
988 const dest_reg = if (maybe_inst) |inst| blk: {
989 const ty_op = self.air.instructions.items(.data)[inst].ty_op;
974990
975 switch (info_b.bits) {
976 32 => {
977 try self.genSetReg(operand_ty, dest_reg, .{ .register = operand_reg });
978 break :blk MCValue{ .register = dest_reg };
979 },
980 else => {
981 _ = try self.addInst(.{
982 .tag = switch (info_b.signedness) {
983 .signed => .sbfx,
984 .unsigned => .ubfx,
985 },
986 .data = .{ .rr_lsb_width = .{
987 .rd = dest_reg,
988 .rn = operand_reg,
989 .lsb = 0,
990 .width = @intCast(u6, info_b.bits),
991 } },
992 });
993 break :blk MCValue{ .register = dest_reg };
994 },
991 if (operand == .register and self.reuseOperand(inst, ty_op.operand, 0, operand)) {
992 break :blk operand_reg;
993 } else {
994 break :blk try self.register_manager.allocReg(inst);
995995 }
996 } else {
997 return self.fail("TODO: truncate to ints > 32 bits", .{});
996 } else try self.register_manager.allocReg(null);
997
998 switch (info_b.bits) {
999 32 => {
1000 try self.genSetReg(operand_ty, dest_reg, .{ .register = operand_reg });
1001 return MCValue{ .register = dest_reg };
1002 },
1003 else => {
1004 try self.truncRegister(operand_reg, dest_reg, info_b.signedness, info_b.bits);
1005 return MCValue{ .register = dest_reg };
1006 },
9981007 }
1008 } else {
1009 return self.fail("TODO: truncate to ints > 32 bits", .{});
1010 }
1011}
1012
1013fn airTrunc(self: *Self, inst: Air.Inst.Index) !void {
1014 const ty_op = self.air.instructions.items(.data)[inst].ty_op;
1015 const operand = try self.resolveInst(ty_op.operand);
1016 const operand_ty = self.air.typeOf(ty_op.operand);
1017 const dest_ty = self.air.typeOfIndex(inst);
1018
1019 const result: MCValue = if (self.liveness.isUnused(inst)) .dead else blk: {
1020 break :blk try self.trunc(inst, operand, operand_ty, dest_ty);
9991021 };
10001022
10011023 return self.finishAir(inst, result, .{ ty_op.operand, .none, .none });
......@@ -1099,6 +1121,10 @@ fn airNot(self: *Self, inst: Air.Inst.Index) !void {
10991121 } },
11001122 });
11011123
1124 if (int_info.bits < 32) {
1125 try self.truncRegister(dest_reg, dest_reg, int_info.signedness, int_info.bits);
1126 }
1127
11021128 break :result MCValue{ .register = dest_reg };
11031129 } else {
11041130 return self.fail("TODO ARM not on integers > u32/i32", .{});
......@@ -1957,8 +1983,8 @@ fn binOpRegister(
19571983 if (!rhs_is_register) try self.genSetReg(rhs_ty, rhs_reg, rhs);
19581984
19591985 const mir_tag: Mir.Inst.Tag = switch (tag) {
1960 .add, .ptr_add => .add,
1961 .sub, .ptr_sub => .sub,
1986 .add => .add,
1987 .sub => .sub,
19621988 .cmp_eq => .cmp,
19631989 .mul => .mul,
19641990 .bit_and,
......@@ -1967,12 +1993,8 @@ fn binOpRegister(
19671993 .bit_or,
19681994 .bool_or,
19691995 => .orr,
1970 .shl,
1971 .shl_exact,
1972 => .lsl,
1973 .shr,
1974 .shr_exact,
1975 => switch (lhs_ty.intInfo(self.target.*).signedness) {
1996 .shl_exact => .lsl,
1997 .shr_exact => switch (lhs_ty.intInfo(self.target.*).signedness) {
19761998 .signed => Mir.Inst.Tag.asr,
19771999 .unsigned => Mir.Inst.Tag.lsr,
19782000 },
......@@ -1988,16 +2010,12 @@ fn binOpRegister(
19882010 .bit_or,
19892011 .bool_or,
19902012 .xor,
1991 .ptr_add,
1992 .ptr_sub,
19932013 => .{ .rr_op = .{
19942014 .rd = dest_reg,
19952015 .rn = lhs_reg,
19962016 .op = Instruction.Operand.reg(rhs_reg, Instruction.Operand.Shift.none),
19972017 } },
1998 .shl,
19992018 .shl_exact,
2000 .shr,
20012019 .shr_exact,
20022020 => .{ .rr_shift = .{
20032021 .rd = dest_reg,
......@@ -2094,12 +2112,8 @@ fn binOpImmediate(
20942112 .bit_or,
20952113 .bool_or,
20962114 => .orr,
2097 .shl,
2098 .shl_exact,
2099 => .lsl,
2100 .shr,
2101 .shr_exact,
2102 => switch (lhs_ty.intInfo(self.target.*).signedness) {
2115 .shl_exact => .lsl,
2116 .shr_exact => switch (lhs_ty.intInfo(self.target.*).signedness) {
21032117 .signed => Mir.Inst.Tag.asr,
21042118 .unsigned => Mir.Inst.Tag.lsr,
21052119 },
......@@ -2120,9 +2134,7 @@ fn binOpImmediate(
21202134 .rn = lhs_reg,
21212135 .op = Instruction.Operand.fromU32(rhs.immediate).?,
21222136 } },
2123 .shl,
21242137 .shl_exact,
2125 .shr,
21262138 .shr_exact,
21272139 => .{ .rr_shift = .{
21282140 .rd = dest_reg,
......@@ -2225,6 +2237,39 @@ fn binOp(
22252237 else => unreachable,
22262238 }
22272239 },
2240 .addwrap,
2241 .subwrap,
2242 .mulwrap,
2243 => {
2244 const base_tag: Air.Inst.Tag = switch (tag) {
2245 .addwrap => .add,
2246 .subwrap => .sub,
2247 .mulwrap => .mul,
2248 else => unreachable,
2249 };
2250
2251 // Generate an add/sub/mul
2252 const result = try self.binOp(base_tag, maybe_inst, lhs, rhs, lhs_ty, rhs_ty);
2253
2254 // Truncate if necessary
2255 switch (lhs_ty.zigTypeTag()) {
2256 .Vector => return self.fail("TODO ARM binary operations on vectors", .{}),
2257 .Int => {
2258 const int_info = lhs_ty.intInfo(self.target.*);
2259 if (int_info.bits <= 32) {
2260 const result_reg = result.register;
2261
2262 if (int_info.bits < 32) {
2263 try self.truncRegister(result_reg, result_reg, int_info.signedness, int_info.bits);
2264 return result;
2265 } else return result;
2266 } else {
2267 return self.fail("TODO ARM binary operations on integers > u32/i32", .{});
2268 }
2269 },
2270 else => unreachable,
2271 }
2272 },
22282273 .bit_and,
22292274 .bit_or,
22302275 .xor,
......@@ -2253,8 +2298,8 @@ fn binOp(
22532298 else => unreachable,
22542299 }
22552300 },
2256 .shl,
2257 .shr,
2301 .shl_exact,
2302 .shr_exact,
22582303 => {
22592304 switch (lhs_ty.zigTypeTag()) {
22602305 .Vector => return self.fail("TODO ARM binary operations on vectors", .{}),
......@@ -2275,6 +2320,41 @@ fn binOp(
22752320 else => unreachable,
22762321 }
22772322 },
2323 .shl,
2324 .shr,
2325 => {
2326 const base_tag: Air.Inst.Tag = switch (tag) {
2327 .shl => .shl_exact,
2328 .shr => .shr_exact,
2329 else => unreachable,
2330 };
2331
2332 // Generate a shl_exact/shr_exact
2333 const result = try self.binOp(base_tag, maybe_inst, lhs, rhs, lhs_ty, rhs_ty);
2334
2335 // Truncate if necessary
2336 switch (tag) {
2337 .shr => return result,
2338 .shl => switch (lhs_ty.zigTypeTag()) {
2339 .Vector => return self.fail("TODO ARM binary operations on vectors", .{}),
2340 .Int => {
2341 const int_info = lhs_ty.intInfo(self.target.*);
2342 if (int_info.bits <= 32) {
2343 const result_reg = result.register;
2344
2345 if (int_info.bits < 32) {
2346 try self.truncRegister(result_reg, result_reg, int_info.signedness, int_info.bits);
2347 return result;
2348 } else return result;
2349 } else {
2350 return self.fail("TODO ARM binary operations on integers > u32/i32", .{});
2351 }
2352 },
2353 else => unreachable,
2354 },
2355 else => unreachable,
2356 }
2357 },
22782358 .bool_and,
22792359 .bool_or,
22802360 => {
......@@ -2308,7 +2388,13 @@ fn binOp(
23082388 const elem_size = @intCast(u32, elem_ty.abiSize(self.target.*));
23092389
23102390 if (elem_size == 1) {
2311 return try self.binOpRegister(tag, maybe_inst, lhs, rhs, lhs_ty, rhs_ty);
2391 const base_tag: Air.Inst.Tag = switch (tag) {
2392 .ptr_add => .add,
2393 .ptr_sub => .sub,
2394 else => unreachable,
2395 };
2396
2397 return try self.binOpRegister(base_tag, maybe_inst, lhs, rhs, lhs_ty, rhs_ty);
23122398 } else {
23132399 // convert the offset into a byte offset by
23142400 // multiplying it with elem_size
......@@ -2876,35 +2962,19 @@ fn airCondBr(self: *Self, inst: Air.Inst.Index) !void {
28762962 const condition = Condition.fromCompareOperatorUnsigned(cmp_op);
28772963 break :blk condition.negate();
28782964 },
2879 .register => |reg| blk: {
2880 try self.spillCompareFlagsIfOccupied();
2881
2882 // cmp reg, 1
2883 // bne ...
2884 _ = try self.addInst(.{
2885 .tag = .cmp,
2886 .cond = .al,
2887 .data = .{ .rr_op = .{
2888 .rd = .r0,
2889 .rn = reg,
2890 .op = Instruction.Operand.imm(1, 0),
2891 } },
2892 });
2965 else => blk: {
2966 const reg = switch (cond) {
2967 .register => |r| r,
2968 else => try self.copyToTmpRegister(Type.bool, cond),
2969 };
28932970
2894 break :blk .ne;
2895 },
2896 .stack_offset,
2897 .memory,
2898 .stack_argument_offset,
2899 => blk: {
29002971 try self.spillCompareFlagsIfOccupied();
29012972
2902 const reg = try self.copyToTmpRegister(Type.initTag(.bool), cond);
2903
29042973 // cmp reg, 1
29052974 // bne ...
29062975 _ = try self.addInst(.{
29072976 .tag = .cmp,
2977 .cond = .al,
29082978 .data = .{ .rr_op = .{
29092979 .rd = .r0,
29102980 .rn = reg,
......@@ -2914,7 +2984,6 @@ fn airCondBr(self: *Self, inst: Air.Inst.Index) !void {
29142984
29152985 break :blk .ne;
29162986 },
2917 else => return self.fail("TODO implement condbr {} when condition is {s}", .{ self.target.cpu.arch, @tagName(cond) }),
29182987 };
29192988
29202989 break :reloc try self.addInst(.{
......@@ -3603,9 +3672,18 @@ fn genSetStack(self: *Self, ty: Type, stack_offset: u32, mcv: MCValue) InnerErro
36033672 try self.genSetReg(ptr_ty, src_reg, .{ .ptr_stack_offset = off });
36043673 },
36053674 .memory => |addr| try self.genSetReg(ptr_ty, src_reg, .{ .immediate = @intCast(u32, addr) }),
3606 .embedded_in_code,
3607 .stack_argument_offset,
3608 => return self.fail("TODO genSetStack with src={}", .{mcv}),
3675 .stack_argument_offset => |unadjusted_off| {
3676 const adj_off = unadjusted_off + abi_size;
3677
3678 _ = try self.addInst(.{
3679 .tag = .ldr_ptr_stack_argument,
3680 .data = .{ .r_stack_offset = .{
3681 .rt = src_reg,
3682 .stack_offset = adj_off,
3683 } },
3684 });
3685 },
3686 .embedded_in_code => return self.fail("TODO genSetStack with src={}", .{mcv}),
36093687 else => unreachable,
36103688 }
36113689
src/arch/arm/Emit.zig+7
......@@ -112,6 +112,7 @@ pub fn emitMir(
112112 .str => try emit.mirLoadStore(inst),
113113 .strb => try emit.mirLoadStore(inst),
114114
115 .ldr_ptr_stack_argument => try emit.mirLoadStackArgument(inst),
115116 .ldr_stack_argument => try emit.mirLoadStackArgument(inst),
116117 .ldrb_stack_argument => try emit.mirLoadStackArgument(inst),
117118 .ldrh_stack_argument => try emit.mirLoadStackArgument(inst),
......@@ -597,6 +598,12 @@ fn mirLoadStackArgument(emit: *Emit, inst: Mir.Inst.Index) !void {
597598
598599 const raw_offset = emit.prologue_stack_space - r_stack_offset.stack_offset;
599600 switch (tag) {
601 .ldr_ptr_stack_argument => {
602 const operand = Instruction.Operand.fromU32(raw_offset) orelse
603 return emit.fail("TODO mirLoadStack larger offsets", .{});
604
605 try emit.writeInstruction(Instruction.add(cond, r_stack_offset.rt, .fp, operand));
606 },
600607 .ldr_stack_argument,
601608 .ldrb_stack_argument,
602609 => {
src/arch/arm/Mir.zig+2
......@@ -54,6 +54,8 @@ pub const Inst = struct {
5454 eor,
5555 /// Load Register
5656 ldr,
57 /// Pseudo-instruction: Load pointer to stack argument offset
58 ldr_ptr_stack_argument,
5759 /// Load Register
5860 ldr_stack_argument,
5961 /// Load Register Byte
test/behavior/array.zig-1
......@@ -202,7 +202,6 @@ fn doSomeMangling(array: *[4]u8) void {
202202
203203test "implicit cast zero sized array ptr to slice" {
204204 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
205 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
206205
207206 {
208207 var b = "".*;
test/behavior/bitcast.zig-1
......@@ -269,7 +269,6 @@ test "bitcast passed as tuple element" {
269269
270270test "triple level result location with bitcast sandwich passed as tuple element" {
271271 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest;
272 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
273272
274273 const S = struct {
275274 fn foo(args: anytype) !void {
test/behavior/bugs/11181.zig-2
......@@ -2,7 +2,6 @@ const builtin = @import("builtin");
22
33test "const inferred array of slices" {
44 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
5 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
65 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
76
87 const T = struct { v: bool };
......@@ -17,7 +16,6 @@ test "const inferred array of slices" {
1716
1817test "var inferred array of slices" {
1918 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
20 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
2119 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
2220
2321 const T = struct { v: bool };
test/behavior/bugs/1421.zig-1
......@@ -9,7 +9,6 @@ const S = struct {
99};
1010
1111test "functions with return type required to be comptime are generic" {
12 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
1312 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
1413 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
1514 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest;
test/behavior/bugs/2692.zig-1
......@@ -6,7 +6,6 @@ fn foo(a: []u8) void {
66
77test "address of 0 length array" {
88 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest;
9 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
109 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
1110
1211 var pt: [0]u8 = undefined;
test/behavior/bugs/5474.zig-4
......@@ -49,15 +49,11 @@ fn constant() !void {
4949}
5050
5151test "pointer-to-array constness for zero-size elements, var" {
52 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
53
5452 try mutable();
5553 comptime try mutable();
5654}
5755
5856test "pointer-to-array constness for zero-size elements, const" {
59 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
60
6157 try constant();
6258 comptime try constant();
6359}
test/behavior/bugs/828.zig-1
......@@ -30,7 +30,6 @@ fn constCount(comptime cb: *const CountBy, comptime unused: u32) void {
3030}
3131
3232test "comptime struct return should not return the same instance" {
33 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
3433 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
3534
3635 //the first parameter must be passed by reference to trigger the bug
test/behavior/cast.zig-4
......@@ -1080,7 +1080,6 @@ test "compile time int to ptr of function" {
10801080
10811081 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
10821082 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
1083 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
10841083 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
10851084 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
10861085
......@@ -1129,7 +1128,6 @@ fn returnNullLitFromOptionalTypeErrorRef() anyerror!?*A {
11291128test "peer type resolution: [0]u8 and []const u8" {
11301129 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
11311130 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
1132 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
11331131
11341132 try expect(peerTypeEmptyArrayAndSlice(true, "hi").len == 0);
11351133 try expect(peerTypeEmptyArrayAndSlice(false, "hi").len == 1);
......@@ -1278,8 +1276,6 @@ test "assignment to optional pointer result loc" {
12781276}
12791277
12801278test "cast between *[N]void and []void" {
1281 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
1282
12831279 var a: [4]void = undefined;
12841280 var b: []void = &a;
12851281 try expect(b.len == 4);
test/behavior/fn.zig-1
......@@ -389,7 +389,6 @@ test "ability to give comptime types and non comptime types to same parameter" {
389389test "function with inferred error set but returning no error" {
390390 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
391391 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
392 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
393392
394393 const S = struct {
395394 fn foo() !void {}
test/behavior/math.zig-8
......@@ -367,7 +367,6 @@ test "binary not" {
367367 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
368368 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
369369 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
370 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
371370
372371 try expect(comptime x: {
373372 break :x ~@as(u16, 0b1010101010101010) == 0b0101010101010101;
......@@ -488,7 +487,6 @@ fn mod(comptime T: type, a: T, b: T) T {
488487test "unsigned wrapping" {
489488 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
490489 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
491 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
492490
493491 try testUnsignedWrappingEval(maxInt(u32));
494492 comptime try testUnsignedWrappingEval(maxInt(u32));
......@@ -503,7 +501,6 @@ fn testUnsignedWrappingEval(x: u32) !void {
503501test "signed wrapping" {
504502 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
505503 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
506 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
507504
508505 try testSignedWrappingEval(maxInt(i32));
509506 comptime try testSignedWrappingEval(maxInt(i32));
......@@ -518,7 +515,6 @@ fn testSignedWrappingEval(x: i32) !void {
518515test "signed negation wrapping" {
519516 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
520517 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
521 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
522518
523519 try testSignedNegationWrappingEval(minInt(i16));
524520 comptime try testSignedNegationWrappingEval(minInt(i16));
......@@ -532,7 +528,6 @@ fn testSignedNegationWrappingEval(x: i16) !void {
532528test "unsigned negation wrapping" {
533529 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
534530 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
535 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
536531
537532 try testUnsignedNegationWrappingEval(1);
538533 comptime try testUnsignedNegationWrappingEval(1);
......@@ -868,7 +863,6 @@ test "quad hex float literal parsing accurate" {
868863
869864test "truncating shift left" {
870865 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
871 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
872866 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
873867
874868 try testShlTrunc(maxInt(u16));
......@@ -881,7 +875,6 @@ fn testShlTrunc(x: u16) !void {
881875
882876test "exact shift left" {
883877 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
884 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
885878 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
886879
887880 try testShlExact(0b00110101);
......@@ -894,7 +887,6 @@ fn testShlExact(x: u8) !void {
894887
895888test "exact shift right" {
896889 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
897 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
898890 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
899891
900892 try testShrExact(0b10110100);
test/behavior/optional.zig-1
......@@ -26,7 +26,6 @@ pub const EmptyStruct = struct {};
2626
2727test "optional pointer to size zero struct" {
2828 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
29 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
3029
3130 var e = EmptyStruct{};
3231 var o: ?*EmptyStruct = &e;
test/behavior/ptrcast.zig-1
......@@ -59,7 +59,6 @@ fn testReinterpretStructWrappedBytesAsInteger() !void {
5959}
6060
6161test "reinterpret bytes of an array into an extern struct" {
62 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
6362 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
6463 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
6564
test/behavior/sizeof_and_typeof.zig-1
......@@ -186,7 +186,6 @@ test "@sizeOf(T) == 0 doesn't force resolving struct size" {
186186}
187187
188188test "@TypeOf() has no runtime side effects" {
189 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
190189 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
191190 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest;
192191 const S = struct {
test/behavior/slice.zig-2
......@@ -70,7 +70,6 @@ test "comptime slice of undefined pointer of length 0" {
7070test "implicitly cast array of size 0 to slice" {
7171 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
7272 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
73 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
7473
7574 var msg = [_]u8{};
7675 try assertLenIsZero(&msg);
......@@ -206,7 +205,6 @@ const y = x[0x100..];
206205test "compile time slice of pointer to hard coded address" {
207206 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
208207 if (builtin.zig_backend == .stage1) return error.SkipZigTest;
209 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
210208 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
211209 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest;
212210
test/behavior/struct.zig-2
......@@ -926,7 +926,6 @@ test "anonymous struct literal syntax" {
926926
927927test "fully anonymous struct" {
928928 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
929 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
930929
931930 const S = struct {
932931 fn doTheTest() !void {
......@@ -951,7 +950,6 @@ test "fully anonymous struct" {
951950
952951test "fully anonymous list literal" {
953952 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
954 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
955953
956954 const S = struct {
957955 fn doTheTest() !void {
test/behavior/struct_contains_null_ptr_itself.zig-1
......@@ -3,7 +3,6 @@ const expect = std.testing.expect;
33const builtin = @import("builtin");
44
55test "struct contains null pointer which contains original struct" {
6 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
76 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
87 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
98 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest;
test/behavior/type.zig-2
......@@ -468,7 +468,6 @@ test "Type.Union from Type.Enum" {
468468 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
469469 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
470470 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
471 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
472471 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
473472
474473 const Tag = @Type(.{
......@@ -500,7 +499,6 @@ test "Type.Union from regular enum" {
500499 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
501500 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
502501 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
503 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
504502 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
505503
506504 const E = enum { working_as_expected };
test/behavior/type_info.zig-1
......@@ -385,7 +385,6 @@ extern fn foo(a: usize, b: bool, ...) callconv(.C) usize;
385385extern fn fooAligned(a: usize, b: bool, ...) align(4) callconv(.C) usize;
386386
387387test "type info: generic function types" {
388 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
389388 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
390389 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest;
391390
test/behavior/var_args.zig-5
......@@ -14,7 +14,6 @@ fn add(args: anytype) i32 {
1414
1515test "add arbitrary args" {
1616 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
17 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
1817
1918 try expect(add(.{ @as(i32, 1), @as(i32, 2), @as(i32, 3), @as(i32, 4) }) == 10);
2019 try expect(add(.{@as(i32, 1234)}) == 1234);
......@@ -27,14 +26,12 @@ fn readFirstVarArg(args: anytype) void {
2726
2827test "send void arg to var args" {
2928 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
30 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
3129
3230 readFirstVarArg(.{{}});
3331}
3432
3533test "pass args directly" {
3634 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
37 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
3835 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
3936
4037 try expect(addSomeStuff(.{ @as(i32, 1), @as(i32, 2), @as(i32, 3), @as(i32, 4) }) == 10);
......@@ -89,7 +86,6 @@ fn foo2(args: anytype) bool {
8986
9087test "array of var args functions" {
9188 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
92 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
9389
9490 try expect(foos[0](.{}));
9591 try expect(!foos[1](.{}));
......@@ -97,7 +93,6 @@ test "array of var args functions" {
9793
9894test "pass zero length array to var args param" {
9995 if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
100 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
10196
10297 doNothingWithFirstArg(.{""});
10398}
test/behavior/void.zig-1
......@@ -19,7 +19,6 @@ test "compare void with void compile time known" {
1919}
2020
2121test "iterate over a void slice" {
22 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
2322 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
2423
2524 var j: usize = 0;