authorgravatar for alichraghi@proton.meAli Chraghi <alichraghi@proton.me> 2024-02-19 17:08:39+03:30
committergravatar for alichraghi@proton.meAli Chraghi <alichraghi@proton.me> 2024-04-06 09:01:46+03:30
log436f53f55d3191bfa56418d98130d763fa5a6b22
treef9434f4e9bd566660997405d085a61ab505fc94b
parent97850149386a8ec54ffce285973d3e7010cefa00

spirv: implement `@mulWithOverflow`

6 files changed, 63 insertions(+), 12 deletions(-)

src/codegen/spirv.zig+59-2
......@@ -2315,6 +2315,7 @@ const DeclGen = struct {
23152315 .sub, .sub_wrap, .sub_optimized => try self.airArithOp(inst, .OpFSub, .OpISub, .OpISub),
23162316 .mul, .mul_wrap, .mul_optimized => try self.airArithOp(inst, .OpFMul, .OpIMul, .OpIMul),
23172317
2318
23182319 .abs => try self.airAbs(inst),
23192320 .floor => try self.airFloor(inst),
23202321
......@@ -2330,6 +2331,7 @@ const DeclGen = struct {
23302331
23312332 .add_with_overflow => try self.airAddSubOverflow(inst, .OpIAdd, .OpULessThan, .OpSLessThan),
23322333 .sub_with_overflow => try self.airAddSubOverflow(inst, .OpISub, .OpUGreaterThan, .OpSGreaterThan),
2334 .mul_with_overflow => try self.airMulOverflow(inst),
23332335 .shl_with_overflow => try self.airShlOverflow(inst),
23342336
23352337 .mul_add => try self.airMulAdd(inst),
......@@ -2733,8 +2735,8 @@ const DeclGen = struct {
27332735 else => unreachable,
27342736 };
27352737 const set_id = switch (target.os.tag) {
2736 .opencl => try self.spv.importInstructionSet("OpenCL.std"),
2737 .vulkan => try self.spv.importInstructionSet("GLSL.std.450"),
2738 .opencl => try self.spv.importInstructionSet(.@"OpenCL.std"),
2739 .vulkan => try self.spv.importInstructionSet(.@"GLSL.std.450"),
27382740 else => unreachable,
27392741 };
27402742
......@@ -2998,6 +3000,61 @@ const DeclGen = struct {
29983000 );
29993001 }
30003002
3003 fn airMulOverflow(self: *DeclGen, inst: Air.Inst.Index) !?IdRef {
3004 const ty_pl = self.air.instructions.items(.data)[@intFromEnum(inst)].ty_pl;
3005 const extra = self.air.extraData(Air.Bin, ty_pl.payload).data;
3006 const lhs = try self.resolve(extra.lhs);
3007 const rhs = try self.resolve(extra.rhs);
3008
3009 const result_ty = self.typeOfIndex(inst);
3010 const operand_ty = self.typeOf(extra.lhs);
3011 const ov_ty = result_ty.structFieldType(1, self.module);
3012
3013 const info = self.arithmeticTypeInfo(operand_ty);
3014 switch (info.class) {
3015 .composite_integer => return self.todo("overflow ops for composite integers", .{}),
3016 .strange_integer, .integer => {},
3017 .float, .bool => unreachable,
3018 }
3019
3020 var wip_result = try self.elementWise(operand_ty, true);
3021 defer wip_result.deinit();
3022 var wip_ov = try self.elementWise(ov_ty, true);
3023 defer wip_ov.deinit();
3024
3025 const zero_id = try self.constInt(wip_result.ty_ref, 0);
3026 const zero_ov_id = try self.constInt(wip_ov.ty_ref, 0);
3027 const one_ov_id = try self.constInt(wip_ov.ty_ref, 1);
3028
3029 for (wip_result.results, wip_ov.results, 0..) |*result_id, *ov_id, i| {
3030 const lhs_elem_id = try wip_result.elementAt(operand_ty, lhs, i);
3031 const rhs_elem_id = try wip_result.elementAt(operand_ty, rhs, i);
3032
3033 result_id.* = try self.arithOp(wip_result.ty, lhs_elem_id, rhs_elem_id, .OpFMul, .OpIMul, .OpIMul);
3034
3035 // (a != 0) and (x / a != b)
3036 const not_zero_id = try self.cmp(.neq, Type.bool, wip_result.ty, lhs_elem_id, zero_id);
3037 const res_rhs_id = try self.arithOp(wip_result.ty, result_id.*, lhs_elem_id, .OpFDiv, .OpSDiv, .OpUDiv);
3038 const res_rhs_not_rhs_id = try self.cmp(.neq, Type.bool, wip_result.ty, res_rhs_id, rhs_elem_id);
3039 const cond_id = try self.binOpSimple(Type.bool, not_zero_id, res_rhs_not_rhs_id, .OpLogicalAnd);
3040
3041 ov_id.* = self.spv.allocId();
3042 try self.func.body.emit(self.spv.gpa, .OpSelect, .{
3043 .id_result_type = wip_ov.ty_id,
3044 .id_result = ov_id.*,
3045 .condition = cond_id,
3046 .object_1 = one_ov_id,
3047 .object_2 = zero_ov_id,
3048 });
3049 }
3050
3051 return try self.constructStruct(
3052 result_ty,
3053 &.{ operand_ty, ov_ty },
3054 &.{ try wip_result.finalize(), try wip_ov.finalize() },
3055 );
3056 }
3057
30013058 fn airShlOverflow(self: *DeclGen, inst: Air.Inst.Index) !?IdRef {
30023059 const mod = self.module;
30033060 const ty_pl = self.air.instructions.items(.data)[@intFromEnum(inst)].ty_pl;
src/codegen/spirv/Assembler.zig+4-1
......@@ -263,7 +263,10 @@ fn processInstruction(self: *Assembler) !void {
263263 .OpExtInstImport => blk: {
264264 const set_name_offset = self.inst.operands.items[1].string;
265265 const set_name = std.mem.sliceTo(self.inst.string_bytes.items[set_name_offset..], 0);
266 break :blk .{ .value = try self.spv.importInstructionSet(set_name) };
266 const set_tag = std.meta.stringToEnum(spec.InstructionSet, set_name) orelse {
267 return self.fail(set_name_offset, "unknown instruction set: {s}", .{set_name});
268 };
269 break :blk .{ .value = try self.spv.importInstructionSet(set_tag) };
267270 },
268271 else => switch (self.inst.opcode.class()) {
269272 .TypeDeclaration => try self.processTypeInstruction(),
test/behavior/for.zig-1
......@@ -226,7 +226,6 @@ test "else continue outer for" {
226226
227227test "for loop with else branch" {
228228 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
229 if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;
230229
231230 {
232231 var x = [_]u32{ 1, 2 };
test/behavior/hasdecl.zig-4
......@@ -12,8 +12,6 @@ const Bar = struct {
1212};
1313
1414test "@hasDecl" {
15 if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;
16
1715 try expect(@hasDecl(Foo, "public_thing"));
1816 try expect(!@hasDecl(Foo, "private_thing"));
1917 try expect(!@hasDecl(Foo, "no_thing"));
......@@ -24,8 +22,6 @@ test "@hasDecl" {
2422}
2523
2624test "@hasDecl using a sliced string literal" {
27 if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;
28
2925 try expect(@hasDecl(@This(), "std") == true);
3026 try expect(@hasDecl(@This(), "std"[0..0]) == false);
3127 try expect(@hasDecl(@This(), "std"[0..1]) == false);
test/behavior/math.zig-3
......@@ -788,7 +788,6 @@ test "small int addition" {
788788test "basic @mulWithOverflow" {
789789 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
790790 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
791 if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;
792791
793792 {
794793 var a: u8 = 86;
......@@ -821,7 +820,6 @@ test "basic @mulWithOverflow" {
821820test "extensive @mulWithOverflow" {
822821 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
823822 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
824 if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;
825823
826824 {
827825 var a: u5 = 3;
......@@ -998,7 +996,6 @@ test "@mulWithOverflow bitsize > 32" {
998996 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
999997 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
1000998 if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
1001 if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;
1002999
10031000 {
10041001 var a: u62 = 3;
test/behavior/vector.zig-1
......@@ -1136,7 +1136,6 @@ test "@mulWithOverflow" {
11361136 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
11371137 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
11381138 if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
1139 if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;
11401139
11411140 const S = struct {
11421141 fn doTheTest() !void {